)]}'
{".zuul.yaml":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"13ffb0ba214219a70e22c10599dc31a0edf87de7","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        dns_zone_info"},{"line_number":64,"context_line":"        floating_ip_info"},{"line_number":65,"context_line":"        group"},{"line_number":66,"context_line":"        identity_user_info"},{"line_number":67,"context_line":"        image"},{"line_number":68,"context_line":"        keypair"},{"line_number":69,"context_line":"        keystone_domain"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"a2a32970_e245d6a4","line":66,"updated":"2022-05-02 10:14:45.000000000","message":"Zuul CI wont run this ci role because it is ignoring the updated tox_extra_args. What is going on here?","commit_id":"43b1d6a112681be994bcf1c6f3dff5b16163a193"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"34d51b06e3abd76e1bec4f24e29a5c20a9b2b0bf","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        dns_zone_info"},{"line_number":64,"context_line":"        floating_ip_info"},{"line_number":65,"context_line":"        group"},{"line_number":66,"context_line":"        identity_user_info"},{"line_number":67,"context_line":"        image"},{"line_number":68,"context_line":"        keypair"},{"line_number":69,"context_line":"        keystone_domain"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"aa64da19_d2b044aa","line":66,"in_reply_to":"a2a32970_e245d6a4","updated":"2022-05-04 19:02:01.000000000","message":"Fixed ci config, lets see if it works now.","commit_id":"43b1d6a112681be994bcf1c6f3dff5b16163a193"}],"/COMMIT_MSG":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"bce81d5fa16b438f082ebbf5a9978c9531e1ca5c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafael Castillo \u003crcastill@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-09 09:18:16 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use proxy layer in identity_user_info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I99e98a529ce74ff2ca77a67d09f188228e6a0e37"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"13cc6cda_2cc86b51","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2022-02-09 20:59:50.000000000","message":"Great, can you please add tests for this module here? https://github.com/openstack/ansible-collections-openstack/blob/master/ci/roles/user/tasks/main.yml\n\njust list users with and without filters and check that you get what\u0027s configured, something simple","commit_id":"ce53d312b90a76ab6f477ee828646cf6c54e0833"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"d0d3a1d5b94eb5f5035d9958ab20334c3539cebb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafael Castillo \u003crcastill@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-09 09:18:16 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use proxy layer in identity_user_info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I99e98a529ce74ff2ca77a67d09f188228e6a0e37"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1b81f0c2_0b113688","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"in_reply_to":"13cc6cda_2cc86b51","updated":"2022-04-13 17:25:08.000000000","message":"Done","commit_id":"ce53d312b90a76ab6f477ee828646cf6c54e0833"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"1b2e03c6571ba136e305ded9cd1a2dbc7378b70c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e0342c31_6fcdb4b6","updated":"2022-02-09 20:55:25.000000000","message":"recheck stack failure not related","commit_id":"ce53d312b90a76ab6f477ee828646cf6c54e0833"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d67c84f54d5dce694f7a8dbac6471aa1f251377b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"94c23ff1_54854571","updated":"2022-02-13 10:51:29.000000000","message":"Can you please make a dummy patch on top of this one with tests enabled only for user tasks? See for example: https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828290 or https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828294","commit_id":"108920da36268fc28a46a810d94bf9c03fca7701"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"36c2cf0a784481673d9654dc09be92d575ceb968","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b5abf067_17797a88","in_reply_to":"94c23ff1_54854571","updated":"2022-02-16 01:06:07.000000000","message":"Added in https://review.opendev.org/c/openstack/ansible-collections-openstack/+/829427\n\nNot sure if it will pass as the user playbook relies on a few more modules that I haven\u0027t gotten to updating.","commit_id":"108920da36268fc28a46a810d94bf9c03fca7701"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"2188f230f5a1118015048d86efa3865626e56d0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c4f937a8_f90a00ce","updated":"2022-04-13 13:58:13.000000000","message":"Should we add the additional ci tests in ci/roles/user_info/tasks/main.yml instead of the user folder?","commit_id":"c0707674d29a6dcc9c94f2c8f8d21d0a5f83df5a"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"aae3cc31379ae869e23fc7222d96cd76fb4e85ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"0dd1dd84_e2790b90","updated":"2022-04-12 20:10:02.000000000","message":"Thanks for the update 😊 Added a couple of remarks. If this patch is still WIP, then please mark it as such 😉\n\nWhile debugging the return values, I found and patched this one:\nhttps://review.opendev.org/c/openstack/ansible-collections-openstack/+/837617\n\nDepend on this one please or just wait till it has been merged and rebase ^^","commit_id":"c0707674d29a6dcc9c94f2c8f8d21d0a5f83df5a"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"cc80bb9fb7cce9b7ab829bca4b4adfa67c79989e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"596e0e40_de82ab85","updated":"2022-04-07 16:47:51.000000000","message":"recheck","commit_id":"c0707674d29a6dcc9c94f2c8f8d21d0a5f83df5a"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"d0d3a1d5b94eb5f5035d9958ab20334c3539cebb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"2b2070fc_717dfffb","in_reply_to":"c4f937a8_f90a00ce","updated":"2022-04-13 17:25:08.000000000","message":"This is a good idea, I\u0027ve added the new role to test user_info specifically.","commit_id":"c0707674d29a6dcc9c94f2c8f8d21d0a5f83df5a"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"649134226a1a64194e81f8f363eb0576fde1431c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"b44c5d9c_23f828dd","updated":"2022-04-27 08:06:48.000000000","message":"Thank you! Only some minor things, then its ready for being merged 😊","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"48a6ec248067cbe14013cc23aa684eff1e427232","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"f0409d0c_a5a3a023","updated":"2022-04-28 13:51:30.000000000","message":"Please rebase and add tag to tox_extra_args in .zuul.yaml, so that your tests are actually run.","commit_id":"304b67dd542daa5bb60e6c9894d0801b3c772590"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c83b1025dc94fe85a001789b1982eede4f734dbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"59376e3c_83f53262","updated":"2022-04-28 09:50:35.000000000","message":"Will merge once CI is fixed, e.g. this one has been merged and we can actually run your tests https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839374","commit_id":"304b67dd542daa5bb60e6c9894d0801b3c772590"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ec03964fc21e7a44d0837fa340fb862a918db5a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"dd6062a5_8cab302d","updated":"2022-05-02 07:50:01.000000000","message":"Fixed role name, let\u0027s see if Zuul is okay now ^^","commit_id":"43b1d6a112681be994bcf1c6f3dff5b16163a193"}],"ci/roles/user/tasks/main.yml":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"314f3dc04dc660a1d9160a459c36f5a57b2ddf70","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    that:"},{"line_number":36,"context_line":"      - userinfo.openstack_users[0].name \u003d\u003d updateduser.user.name"},{"line_number":37,"context_line":"      - userinfo.openstack_users[0].id \u003d\u003d updateduser.user.id"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Delete user"},{"line_number":40,"context_line":"  openstack.cloud.identity_user:"},{"line_number":41,"context_line":"     cloud: \"{{ cloud }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"f7e926c9_58267528","line":38,"updated":"2022-04-04 14:06:46.000000000","message":"Please add asserts on returned keys, so that we know that our return value doc is in sync with the actually returned values.","commit_id":"92def112fb82335e0954d31c3139b572b6cb05a0"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"a3a85a4977ea48e457d1110d3a10db5c0709f396","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    that:"},{"line_number":36,"context_line":"      - userinfo.openstack_users[0].name \u003d\u003d updateduser.user.name"},{"line_number":37,"context_line":"      - userinfo.openstack_users[0].id \u003d\u003d updateduser.user.id"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Delete user"},{"line_number":40,"context_line":"  openstack.cloud.identity_user:"},{"line_number":41,"context_line":"     cloud: \"{{ cloud }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7ddea9a3_093f9fe4","line":38,"in_reply_to":"f7e926c9_58267528","updated":"2022-04-07 16:46:55.000000000","message":"Done","commit_id":"92def112fb82335e0954d31c3139b572b6cb05a0"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"aae3cc31379ae869e23fc7222d96cd76fb4e85ec","unresolved":true,"context_lines":[{"line_number":39,"context_line":"- name: Ensure user has fields"},{"line_number":40,"context_line":"  assert:"},{"line_number":41,"context_line":"    that: item in user[\u0027user\u0027]"},{"line_number":42,"context_line":"  with_items:"},{"line_number":43,"context_line":"    - default_project_id"},{"line_number":44,"context_line":"    - comain_id"},{"line_number":45,"context_line":"    - email"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"d8a51f12_caf29583","line":42,"updated":"2022-04-12 20:10:02.000000000","message":"\"The loop keyword is equivalent to with_list, and is the best choice for simple loops.\"\nhttps://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html\n\nOr use our functional style as shown in our migration doc ;)","commit_id":"c0707674d29a6dcc9c94f2c8f8d21d0a5f83df5a"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"d0d3a1d5b94eb5f5035d9958ab20334c3539cebb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"- name: Ensure user has fields"},{"line_number":40,"context_line":"  assert:"},{"line_number":41,"context_line":"    that: item in user[\u0027user\u0027]"},{"line_number":42,"context_line":"  with_items:"},{"line_number":43,"context_line":"    - default_project_id"},{"line_number":44,"context_line":"    - comain_id"},{"line_number":45,"context_line":"    - email"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9f1d71aa_c949ba50","line":42,"in_reply_to":"d8a51f12_caf29583","updated":"2022-04-13 17:25:08.000000000","message":"Done","commit_id":"c0707674d29a6dcc9c94f2c8f8d21d0a5f83df5a"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"aae3cc31379ae869e23fc7222d96cd76fb4e85ec","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    that: item in user[\u0027user\u0027]"},{"line_number":42,"context_line":"  with_items:"},{"line_number":43,"context_line":"    - default_project_id"},{"line_number":44,"context_line":"    - comain_id"},{"line_number":45,"context_line":"    - email"},{"line_number":46,"context_line":"    - id"},{"line_number":47,"context_line":"    - name"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"6bb566a4_0085e33b","line":44,"updated":"2022-04-12 20:10:02.000000000","message":"i doubt it...","commit_id":"c0707674d29a6dcc9c94f2c8f8d21d0a5f83df5a"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"d0d3a1d5b94eb5f5035d9958ab20334c3539cebb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    that: item in user[\u0027user\u0027]"},{"line_number":42,"context_line":"  with_items:"},{"line_number":43,"context_line":"    - default_project_id"},{"line_number":44,"context_line":"    - comain_id"},{"line_number":45,"context_line":"    - email"},{"line_number":46,"context_line":"    - id"},{"line_number":47,"context_line":"    - name"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5650612f_3cd86c60","line":44,"in_reply_to":"6bb566a4_0085e33b","updated":"2022-04-13 17:25:08.000000000","message":"Done","commit_id":"c0707674d29a6dcc9c94f2c8f8d21d0a5f83df5a"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"aae3cc31379ae869e23fc7222d96cd76fb4e85ec","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    - comain_id"},{"line_number":45,"context_line":"    - email"},{"line_number":46,"context_line":"    - id"},{"line_number":47,"context_line":"    - name"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Delete user"},{"line_number":50,"context_line":"  openstack.cloud.identity_user:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"ac81a571_c4e37ea5","line":47,"updated":"2022-04-12 20:10:02.000000000","message":"this is not the complete list of attributes that will be returned. please update assertion and return value docs.","commit_id":"c0707674d29a6dcc9c94f2c8f8d21d0a5f83df5a"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"649134226a1a64194e81f8f363eb0576fde1431c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    - comain_id"},{"line_number":45,"context_line":"    - email"},{"line_number":46,"context_line":"    - id"},{"line_number":47,"context_line":"    - name"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Delete user"},{"line_number":50,"context_line":"  openstack.cloud.identity_user:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"daadafcc_d7ec687b","line":47,"in_reply_to":"ac81a571_c4e37ea5","updated":"2022-04-27 08:06:48.000000000","message":"Done","commit_id":"c0707674d29a6dcc9c94f2c8f8d21d0a5f83df5a"}],"ci/roles/user_info/tasks/main.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"ce3a52b0eba35ed6b3e37dd902b5ed6017390883","unresolved":true,"context_lines":[{"line_number":4,"context_line":"     state: absent"},{"line_number":5,"context_line":"     name: ansible_user"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- block:"},{"line_number":8,"context_line":"  - name: Get unexistent user"},{"line_number":9,"context_line":"    openstack.cloud.identity_user_info:"},{"line_number":10,"context_line":"      cloud: \"{{ cloud }}\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"d7b8c03a_e54f8a45","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":8},"updated":"2022-04-27 07:48:04.000000000","message":"what is the reason behind using \"block\"s here? Just curious","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"f76e04cfb1514034b726d9a70d85180389dee3b1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"     state: absent"},{"line_number":5,"context_line":"     name: ansible_user"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- block:"},{"line_number":8,"context_line":"  - name: Get unexistent user"},{"line_number":9,"context_line":"    openstack.cloud.identity_user_info:"},{"line_number":10,"context_line":"      cloud: \"{{ cloud }}\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"f375d198_0793a40d","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":8},"in_reply_to":"d7b8c03a_e54f8a45","updated":"2022-04-27 14:25:14.000000000","message":"I\u0027m trying to use blocks to logically group \"test cases\" if that makes sense.","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c83b1025dc94fe85a001789b1982eede4f734dbe","unresolved":true,"context_lines":[{"line_number":4,"context_line":"     state: absent"},{"line_number":5,"context_line":"     name: ansible_user"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- block:"},{"line_number":8,"context_line":"  - name: Get unexistent user"},{"line_number":9,"context_line":"    openstack.cloud.identity_user_info:"},{"line_number":10,"context_line":"      cloud: \"{{ cloud }}\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"30db9e48_d8a48926","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":8},"in_reply_to":"f375d198_0793a40d","updated":"2022-04-28 09:50:35.000000000","message":"You could use comments or whatever to break down the file into separate identifyable sections. But actually i like the blocks approach because the additional indentation makes it easy to spot start and end of sections.","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"649134226a1a64194e81f8f363eb0576fde1431c","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    assert:"},{"line_number":48,"context_line":"      that: item in userinfo.openstack_users[0]"},{"line_number":49,"context_line":"    loop: \"{{ os_expected_user_info_fields }}\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Get all users"},{"line_number":52,"context_line":"  openstack.cloud.identity_user_info:"},{"line_number":53,"context_line":"    cloud: \"{{ cloud }}\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"46f46ebf_9c9184d4","line":50,"updated":"2022-04-27 08:06:48.000000000","message":"Please remove users once tests are done. This makes it easier to rerun tests locally.","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"f76e04cfb1514034b726d9a70d85180389dee3b1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    assert:"},{"line_number":48,"context_line":"      that: item in userinfo.openstack_users[0]"},{"line_number":49,"context_line":"    loop: \"{{ os_expected_user_info_fields }}\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Get all users"},{"line_number":52,"context_line":"  openstack.cloud.identity_user_info:"},{"line_number":53,"context_line":"    cloud: \"{{ cloud }}\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"cfb81ae4_4670367d","line":50,"in_reply_to":"46f46ebf_9c9184d4","updated":"2022-04-27 14:25:14.000000000","message":"Done","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"649134226a1a64194e81f8f363eb0576fde1431c","unresolved":true,"context_lines":[{"line_number":52,"context_line":"  openstack.cloud.identity_user_info:"},{"line_number":53,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":54,"context_line":"  register: userinfo"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"c84a6fdd_4408d048","line":55,"updated":"2022-04-27 08:06:48.000000000","message":"Did you want to do something here?","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c83b1025dc94fe85a001789b1982eede4f734dbe","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  openstack.cloud.identity_user_info:"},{"line_number":53,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":54,"context_line":"  register: userinfo"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"2de3d74b_f0dda737","line":55,"in_reply_to":"c84a6fdd_4408d048","updated":"2022-04-28 09:50:35.000000000","message":"Done","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"}],"plugins/modules/identity_user_info.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d0d333da4f6d9c7f96e619cb7f0a3a6dd476e767","unresolved":true,"context_lines":[{"line_number":130,"context_line":"        if domain:"},{"line_number":131,"context_line":"            dom_obj \u003d self.conn.identity.find_domain(domain)"},{"line_number":132,"context_line":"            if dom_obj is None:"},{"line_number":133,"context_line":"                self.fail_json(msg\u003d\u0027Domain name or ID does not exist\u0027)"},{"line_number":134,"context_line":"            domain \u003d dom_obj.id"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        if \u0027enabled\u0027 in filters:"}],"source_content_type":"text/x-python","patch_set":2,"id":"58a06785_801af369","line":133,"range":{"start_line":133,"start_character":53,"end_line":133,"end_character":54},"updated":"2022-02-09 14:09:13.000000000","message":"worth to print \"domain\" in this case","commit_id":"6d8240ef2fe9fd6397dd8823afd80a8df05f3deb"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"f5f252c1f3b3b2c1d6bac0b623060a7949214f69","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        if domain:"},{"line_number":131,"context_line":"            dom_obj \u003d self.conn.identity.find_domain(domain)"},{"line_number":132,"context_line":"            if dom_obj is None:"},{"line_number":133,"context_line":"                self.fail_json(msg\u003d\u0027Domain name or ID does not exist\u0027)"},{"line_number":134,"context_line":"            domain \u003d dom_obj.id"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        if \u0027enabled\u0027 in filters:"}],"source_content_type":"text/x-python","patch_set":2,"id":"a4b042c4_0d147637","line":133,"range":{"start_line":133,"start_character":53,"end_line":133,"end_character":54},"in_reply_to":"58a06785_801af369","updated":"2022-02-09 14:36:55.000000000","message":"Done","commit_id":"6d8240ef2fe9fd6397dd8823afd80a8df05f3deb"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d0d333da4f6d9c7f96e619cb7f0a3a6dd476e767","unresolved":true,"context_lines":[{"line_number":137,"context_line":"            filters[\u0027is_enabled\u0027] \u003d filters[\u0027enabled\u0027]"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        users \u003d self.conn.identity.users(name\u003dname, domain_id\u003ddomain, **filters)"},{"line_number":140,"context_line":"        users \u003d [user.to_dict if has_attr(user, \u0027to_dict\u0027), else user for user in users]"},{"line_number":141,"context_line":"        self.exit_json(changed\u003dFalse, openstack_users\u003dusers)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"888a94c1_00468b27","line":140,"range":{"start_line":140,"start_character":58,"end_line":140,"end_character":60},"updated":"2022-02-09 14:09:13.000000000","message":"no need comma","commit_id":"6d8240ef2fe9fd6397dd8823afd80a8df05f3deb"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"f5f252c1f3b3b2c1d6bac0b623060a7949214f69","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            filters[\u0027is_enabled\u0027] \u003d filters[\u0027enabled\u0027]"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        users \u003d self.conn.identity.users(name\u003dname, domain_id\u003ddomain, **filters)"},{"line_number":140,"context_line":"        users \u003d [user.to_dict if has_attr(user, \u0027to_dict\u0027), else user for user in users]"},{"line_number":141,"context_line":"        self.exit_json(changed\u003dFalse, openstack_users\u003dusers)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dc865a0d_d2c6a61b","line":140,"range":{"start_line":140,"start_character":58,"end_line":140,"end_character":60},"in_reply_to":"888a94c1_00468b27","updated":"2022-02-09 14:36:55.000000000","message":"Done","commit_id":"6d8240ef2fe9fd6397dd8823afd80a8df05f3deb"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"bce81d5fa16b438f082ebbf5a9978c9531e1ca5c","unresolved":true,"context_lines":[{"line_number":135,"context_line":"            domain \u003d dom_obj.id"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if \u0027enabled\u0027 in filters:"},{"line_number":138,"context_line":"            filters[\u0027is_enabled\u0027] \u003d filters[\u0027enabled\u0027]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":141,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"}],"source_content_type":"text/x-python","patch_set":5,"id":"6229c147_aa992413","line":138,"range":{"start_line":138,"start_character":13,"end_line":138,"end_character":54},"updated":"2022-02-09 20:59:50.000000000","message":"nice, I think in this case we need to remove \u0027enabled\u0027 from filters?\nlike: filters[\u0027is_enabled\u0027] \u003d filters.pop(\u0027enabled\u0027)\nso it\u0027s not passed together with is_enabled to query","commit_id":"ce53d312b90a76ab6f477ee828646cf6c54e0833"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"67c5b9f8629ea101fdd5c9b1cc981819cedcc2e0","unresolved":true,"context_lines":[{"line_number":135,"context_line":"            domain \u003d dom_obj.id"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if \u0027enabled\u0027 in filters:"},{"line_number":138,"context_line":"            filters[\u0027is_enabled\u0027] \u003d filters[\u0027enabled\u0027]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":141,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bbe93389_b1afe2c3","line":138,"range":{"start_line":138,"start_character":13,"end_line":138,"end_character":54},"in_reply_to":"6229c147_aa992413","updated":"2022-02-09 21:44:29.000000000","message":"I can do that. Wasn\u0027t sure if I needed to get rid of it.","commit_id":"ce53d312b90a76ab6f477ee828646cf6c54e0833"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"460774f4ae3dc07641a763ce07e1cc8b3c0d88e2","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            domain \u003d dom_obj.id"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if \u0027enabled\u0027 in filters:"},{"line_number":138,"context_line":"            filters[\u0027is_enabled\u0027] \u003d filters[\u0027enabled\u0027]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":141,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7d4c823e_b92d18df","line":138,"range":{"start_line":138,"start_character":13,"end_line":138,"end_character":54},"in_reply_to":"bbe93389_b1afe2c3","updated":"2022-02-10 14:49:31.000000000","message":"Done","commit_id":"ce53d312b90a76ab6f477ee828646cf6c54e0833"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"56e835d9c1a5d6739682f7784a8c7b3281797c04","unresolved":true,"context_lines":[{"line_number":134,"context_line":"                    msg\u003d\"Domain name or ID \u0027{0}\u0027 does not exist\".format(domain))"},{"line_number":135,"context_line":"            domain \u003d dom_obj.id"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if \u0027enabled\u0027 in filters:"},{"line_number":138,"context_line":"            filters[\u0027is_enabled\u0027] \u003d filters[\u0027enabled\u0027]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        users \u003d self.conn.identity.users("}],"source_content_type":"text/x-python","patch_set":6,"id":"d5273bf6_5261d861","line":137,"range":{"start_line":137,"start_character":24,"end_line":137,"end_character":32},"updated":"2022-02-10 00:48:22.000000000","message":"it\u0027s None if not set","commit_id":"536579292307b66a63bdd06715e6c58dc4c5f842"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"460774f4ae3dc07641a763ce07e1cc8b3c0d88e2","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                    msg\u003d\"Domain name or ID \u0027{0}\u0027 does not exist\".format(domain))"},{"line_number":135,"context_line":"            domain \u003d dom_obj.id"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if \u0027enabled\u0027 in filters:"},{"line_number":138,"context_line":"            filters[\u0027is_enabled\u0027] \u003d filters[\u0027enabled\u0027]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        users \u003d self.conn.identity.users("}],"source_content_type":"text/x-python","patch_set":6,"id":"8ad376e1_92a68770","line":137,"range":{"start_line":137,"start_character":24,"end_line":137,"end_character":32},"in_reply_to":"d5273bf6_5261d861","updated":"2022-02-10 14:49:31.000000000","message":"Done","commit_id":"536579292307b66a63bdd06715e6c58dc4c5f842"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"bba24188de5dcc0afc1cedfd75e18c58b217f908","unresolved":true,"context_lines":[{"line_number":24,"context_line":"     description:"},{"line_number":25,"context_line":"        - A dictionary of meta data to use for further filtering.  Elements of"},{"line_number":26,"context_line":"          this dictionary may be additional dictionaries."},{"line_number":27,"context_line":"     type: dict"},{"line_number":28,"context_line":"requirements:"},{"line_number":29,"context_line":"    - \"python \u003e\u003d 3.6\""},{"line_number":30,"context_line":"    - \"openstacksdk\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5b02e852_d514feb0","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":15},"updated":"2022-02-10 17:30:08.000000000","message":"just put here\n\ndefault: {}","commit_id":"15aeb1a43d6dbca3823ad95b481c699866966d73"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"51a0f8688a5304a997d8ed83169abedb7a0c9318","unresolved":false,"context_lines":[{"line_number":24,"context_line":"     description:"},{"line_number":25,"context_line":"        - A dictionary of meta data to use for further filtering.  Elements of"},{"line_number":26,"context_line":"          this dictionary may be additional dictionaries."},{"line_number":27,"context_line":"     type: dict"},{"line_number":28,"context_line":"requirements:"},{"line_number":29,"context_line":"    - \"python \u003e\u003d 3.6\""},{"line_number":30,"context_line":"    - \"openstacksdk\""}],"source_content_type":"text/x-python","patch_set":8,"id":"55b3581c_81885fbb","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":15},"in_reply_to":"5b02e852_d514feb0","updated":"2022-02-11 02:18:00.000000000","message":"Done","commit_id":"15aeb1a43d6dbca3823ad95b481c699866966d73"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"bba24188de5dcc0afc1cedfd75e18c58b217f908","unresolved":true,"context_lines":[{"line_number":135,"context_line":"            domain \u003d dom_obj.id"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if \u0027enabled\u0027 in filters:"},{"line_number":138,"context_line":"            filters[\u0027is_enabled\u0027] \u003d filters[\u0027enabled\u0027]"},{"line_number":139,"context_line":"            filters.pop(\u0027enabled\u0027)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":142,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"}],"source_content_type":"text/x-python","patch_set":8,"id":"c4334eb6_d61aca0c","line":139,"range":{"start_line":138,"start_character":34,"end_line":139,"end_character":34},"updated":"2022-02-10 17:30:08.000000000","message":"it can be one line:\n  filters[\u0027is_enabled\u0027] \u003d filters.pop(\u0027enabled\u0027)","commit_id":"15aeb1a43d6dbca3823ad95b481c699866966d73"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"51a0f8688a5304a997d8ed83169abedb7a0c9318","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            domain \u003d dom_obj.id"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if \u0027enabled\u0027 in filters:"},{"line_number":138,"context_line":"            filters[\u0027is_enabled\u0027] \u003d filters[\u0027enabled\u0027]"},{"line_number":139,"context_line":"            filters.pop(\u0027enabled\u0027)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":142,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"}],"source_content_type":"text/x-python","patch_set":8,"id":"abcbb5e2_8c8fa670","line":139,"range":{"start_line":138,"start_character":34,"end_line":139,"end_character":34},"in_reply_to":"c4334eb6_d61aca0c","updated":"2022-02-11 02:18:00.000000000","message":"Done","commit_id":"15aeb1a43d6dbca3823ad95b481c699866966d73"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"56e89f8db720462f8128cdae4214fa58fa99e95a","unresolved":true,"context_lines":[{"line_number":126,"context_line":"    def run(self):"},{"line_number":127,"context_line":"        name \u003d self.params[\u0027name\u0027]"},{"line_number":128,"context_line":"        domain \u003d self.params[\u0027domain\u0027]"},{"line_number":129,"context_line":"        filters \u003d self.params.get(\u0027filters\u0027, {})"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if domain:"},{"line_number":132,"context_line":"            dom_obj \u003d self.conn.identity.find_domain(domain)"}],"source_content_type":"text/x-python","patch_set":9,"id":"a9057e91_ba789cab","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":18},"updated":"2022-02-10 18:15:02.000000000","message":"now when you have defaults, you can have just\n  filters \u003d self.params[\u0027filters\u0027]","commit_id":"c594276fd7f63605022f52e3f97c048b831b21c0"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"51a0f8688a5304a997d8ed83169abedb7a0c9318","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def run(self):"},{"line_number":127,"context_line":"        name \u003d self.params[\u0027name\u0027]"},{"line_number":128,"context_line":"        domain \u003d self.params[\u0027domain\u0027]"},{"line_number":129,"context_line":"        filters \u003d self.params.get(\u0027filters\u0027, {})"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if domain:"},{"line_number":132,"context_line":"            dom_obj \u003d self.conn.identity.find_domain(domain)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fd315f26_8a0eb2d6","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":18},"in_reply_to":"a9057e91_ba789cab","updated":"2022-02-11 02:18:00.000000000","message":"Done","commit_id":"c594276fd7f63605022f52e3f97c048b831b21c0"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2d418f351abda20c3f97a06c87a8778f7bc07245","unresolved":true,"context_lines":[{"line_number":136,"context_line":"            domain \u003d dom_obj.id"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if \u0027enabled\u0027 in filters:"},{"line_number":139,"context_line":"            filters[\u0027is_enabled\u0027] \u003d filters.pop(\u0027enabled\u0027)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":142,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"}],"source_content_type":"text/x-python","patch_set":15,"id":"d09f2735_7522d393","line":139,"range":{"start_line":139,"start_character":12,"end_line":139,"end_character":58},"updated":"2022-03-08 10:26:37.000000000","message":"is it the only difference between old and new?","commit_id":"b5fe90a54416bba80cdb0e7d7132e0c3e2984774"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"649134226a1a64194e81f8f363eb0576fde1431c","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            domain \u003d dom_obj.id"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if \u0027enabled\u0027 in filters:"},{"line_number":139,"context_line":"            filters[\u0027is_enabled\u0027] \u003d filters.pop(\u0027enabled\u0027)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":142,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"}],"source_content_type":"text/x-python","patch_set":15,"id":"e10eb440_fd981df0","line":139,"range":{"start_line":139,"start_character":12,"end_line":139,"end_character":58},"in_reply_to":"d09f2735_7522d393","updated":"2022-04-27 08:06:48.000000000","message":"Done","commit_id":"b5fe90a54416bba80cdb0e7d7132e0c3e2984774"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"314f3dc04dc660a1d9160a459c36f5a57b2ddf70","unresolved":true,"context_lines":[{"line_number":136,"context_line":"            domain \u003d dom_obj.id"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if \u0027enabled\u0027 in filters:"},{"line_number":139,"context_line":"            filters[\u0027is_enabled\u0027] \u003d filters.pop(\u0027enabled\u0027)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":142,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5c80ce82_c2de6050","line":139,"updated":"2022-04-04 14:06:46.000000000","message":"In my experiments, both \u0027enabled\u0027 and \u0027is_enabled\u0027 work with OpenStack SDK 0.36.5 and later when passed to self.conn.identity.users(). So why drop it?","commit_id":"92def112fb82335e0954d31c3139b572b6cb05a0"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"a3a85a4977ea48e457d1110d3a10db5c0709f396","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            domain \u003d dom_obj.id"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if \u0027enabled\u0027 in filters:"},{"line_number":139,"context_line":"            filters[\u0027is_enabled\u0027] \u003d filters.pop(\u0027enabled\u0027)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":142,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"}],"source_content_type":"text/x-python","patch_set":16,"id":"016aa466_6d5957f8","line":139,"in_reply_to":"5c80ce82_c2de6050","updated":"2022-04-07 16:46:55.000000000","message":"You\u0027re correct, I dropped the conditional. Not sure why I was under the wrong impression here.","commit_id":"92def112fb82335e0954d31c3139b572b6cb05a0"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"aae3cc31379ae869e23fc7222d96cd76fb4e85ec","unresolved":true,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":139,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"},{"line_number":140,"context_line":"        users \u003d [user.to_dict() for user in users]"},{"line_number":141,"context_line":"        self.exit_json(changed\u003dFalse, openstack_users\u003dusers)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1e46ab8d_aa5867a3","line":140,"updated":"2022-04-12 20:10:02.000000000","message":"computed\u003dFalse","commit_id":"c0707674d29a6dcc9c94f2c8f8d21d0a5f83df5a"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"d0d3a1d5b94eb5f5035d9958ab20334c3539cebb","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":139,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"},{"line_number":140,"context_line":"        users \u003d [user.to_dict() for user in users]"},{"line_number":141,"context_line":"        self.exit_json(changed\u003dFalse, openstack_users\u003dusers)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"72deb9e8_539b31bd","line":140,"in_reply_to":"1e46ab8d_aa5867a3","updated":"2022-04-13 17:25:08.000000000","message":"Done","commit_id":"c0707674d29a6dcc9c94f2c8f8d21d0a5f83df5a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"ce3a52b0eba35ed6b3e37dd902b5ed6017390883","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":76,"context_line":"openstack_users:"},{"line_number":77,"context_line":"    description: has all the OpenStack information about users"},{"line_number":78,"context_line":"    returned: always, but can be null"},{"line_number":79,"context_line":"    type: list"}],"source_content_type":"text/x-python","patch_set":26,"id":"7883b322_35202345","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":15},"updated":"2022-04-27 07:48:04.000000000","message":"let\u0027s use just \"users\"?","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c83b1025dc94fe85a001789b1982eede4f734dbe","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":76,"context_line":"openstack_users:"},{"line_number":77,"context_line":"    description: has all the OpenStack information about users"},{"line_number":78,"context_line":"    returned: always, but can be null"},{"line_number":79,"context_line":"    type: list"}],"source_content_type":"text/x-python","patch_set":26,"id":"2101cce3_1adfe8fe","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":15},"in_reply_to":"25fe691b_00bfd526","updated":"2022-04-28 09:50:35.000000000","message":"As you know I do worry a lot about backward compatibility. But in this case it is fine and actually good to break it. Why? Because the results returned from the SDK have changed (e.g. enabled \u003d\u003e is_enabled). With renaming from openstack_users to users, existing code will more likely break and thus it will be easier for our users to see that something has changed.","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"f76e04cfb1514034b726d9a70d85180389dee3b1","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":76,"context_line":"openstack_users:"},{"line_number":77,"context_line":"    description: has all the OpenStack information about users"},{"line_number":78,"context_line":"    returned: always, but can be null"},{"line_number":79,"context_line":"    type: list"}],"source_content_type":"text/x-python","patch_set":26,"id":"25fe691b_00bfd526","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":15},"in_reply_to":"7883b322_35202345","updated":"2022-04-27 14:25:14.000000000","message":"I\u0027d love to, but I\u0027m concerned about breaking compatibility too much. I also left it for consistency\u0027s sake, most of these info modules return a openstack_$RESOURCE list already.","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"649134226a1a64194e81f8f363eb0576fde1431c","unresolved":true,"context_lines":[{"line_number":75,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":76,"context_line":"openstack_users:"},{"line_number":77,"context_line":"    description: has all the OpenStack information about users"},{"line_number":78,"context_line":"    returned: always, but can be null"},{"line_number":79,"context_line":"    type: list"},{"line_number":80,"context_line":"    elements: dict"},{"line_number":81,"context_line":"    contains:"}],"source_content_type":"text/x-python","patch_set":26,"id":"a12f8a74_7572b240","line":78,"updated":"2022-04-27 08:06:48.000000000","message":"can be empty, cannot be null.","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"f76e04cfb1514034b726d9a70d85180389dee3b1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":76,"context_line":"openstack_users:"},{"line_number":77,"context_line":"    description: has all the OpenStack information about users"},{"line_number":78,"context_line":"    returned: always, but can be null"},{"line_number":79,"context_line":"    type: list"},{"line_number":80,"context_line":"    elements: dict"},{"line_number":81,"context_line":"    contains:"}],"source_content_type":"text/x-python","patch_set":26,"id":"22d524d1_aa1d180e","line":78,"in_reply_to":"a12f8a74_7572b240","updated":"2022-04-27 14:25:14.000000000","message":"Done","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"649134226a1a64194e81f8f363eb0576fde1431c","unresolved":true,"context_lines":[{"line_number":154,"context_line":"            domain \u003d dom_obj.id"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":157,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"},{"line_number":158,"context_line":"        users \u003d [user.to_dict(computed\u003dFalse) for user in users]"},{"line_number":159,"context_line":"        self.exit_json(changed\u003dFalse, openstack_users\u003dusers)"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"17693622_6cc406a3","line":157,"updated":"2022-04-27 08:06:48.000000000","message":"Please do pass domain_id to users only if it has a value. Atm if domain is not specified by the user, then domain will be None and thus the OpenStack SDK will be called with http://***/identity/v3/users?domain_id\u003dNone instead of http://***/identity/v3/users.\n\nOne way to solve it would be to replace\n\n  domain \u003d dom_obj.id\n\nwith\n\n  filters[\"domain_id\"] \u003d dom_obj.id\n\nor something like that.","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"f76e04cfb1514034b726d9a70d85180389dee3b1","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            domain \u003d dom_obj.id"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":157,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"},{"line_number":158,"context_line":"        users \u003d [user.to_dict(computed\u003dFalse) for user in users]"},{"line_number":159,"context_line":"        self.exit_json(changed\u003dFalse, openstack_users\u003dusers)"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"81cd7a90_ee6797a1","line":157,"in_reply_to":"17693622_6cc406a3","updated":"2022-04-27 14:25:14.000000000","message":"Done","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"ce3a52b0eba35ed6b3e37dd902b5ed6017390883","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":157,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"},{"line_number":158,"context_line":"        users \u003d [user.to_dict(computed\u003dFalse) for user in users]"},{"line_number":159,"context_line":"        self.exit_json(changed\u003dFalse, openstack_users\u003dusers)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":26,"id":"aed76b92_aa63b9f7","line":159,"range":{"start_line":159,"start_character":38,"end_line":159,"end_character":53},"updated":"2022-04-27 07:48:04.000000000","message":"ditto","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c83b1025dc94fe85a001789b1982eede4f734dbe","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        users \u003d self.conn.identity.users("},{"line_number":157,"context_line":"            name\u003dname, domain_id\u003ddomain, **filters)"},{"line_number":158,"context_line":"        users \u003d [user.to_dict(computed\u003dFalse) for user in users]"},{"line_number":159,"context_line":"        self.exit_json(changed\u003dFalse, openstack_users\u003dusers)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":26,"id":"456340ec_936c024b","line":159,"range":{"start_line":159,"start_character":38,"end_line":159,"end_character":53},"in_reply_to":"aed76b92_aa63b9f7","updated":"2022-04-28 09:50:35.000000000","message":"Done","commit_id":"5ee4f6526b8f97ffb4bd66dd99a1a425948565a9"}]}