)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"789641c1534187d1d74814c34542b6c97c487598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b872eb70_bd72b8d3","updated":"2022-04-19 12:03:19.000000000","message":"Thanks for the patch ☺️\n\nUnfortunately, \u0027description\u0027 in create_security_group_rule() is only supported on master branch [1] of OpenStack SDK but not in OpenStack Yoga or earlier [2]. But not all is lost! \n\nOur call to self.conn.create_security_group_rule() [3] can be replaced with self.conn.network.create_security_group_rule() [4] without too much effort. Here [5] is what has to be added to (or rather changed in) our module. The \u0027else\u0027 part is not necessary because this Nova API returns 404 since OpenStack Newton anyway [6] and we support (and test) OpenStack Train and newer only.\n\n[1] https://github.com/openstack/openstacksdk/blob/master/openstack/cloud/_security_group.py#L234\n[2] https://github.com/openstack/openstacksdk/blob/stable/yoga/openstack/cloud/_security_group.py#L234\n[3] https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/plugins/modules/security_group_rule.py#L352\n[4] https://github.com/openstack/openstacksdk/blob/stable/yoga/openstack/network/v2/_proxy.py#L3677\n[5] https://github.com/openstack/openstacksdk/blob/6b2f555ade95aee14746a570a5b2eebdc56077c8/openstack/cloud/_security_group.py#L306\n[6] https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#microversion","commit_id":"b9756e005f7e84a9bdf276471f89cd3bcee772d5"},{"author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"change_message_id":"d4a7e1e651a74e003c5fb5ea440fbecff659a637","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5ba185a1_6464b5bd","updated":"2022-04-19 15:39:20.000000000","message":"Hi\nYes, I added the description to the openstacksdk myself. Now using the .network function instead with a test for None description.\nThanks","commit_id":"4756b56cde95cf19e54d7674b060f91be877c440"},{"author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"change_message_id":"964a4d1e128fbd17805f47933b869cae51865d5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f3450a6b_4d9422f9","updated":"2022-04-19 17:42:51.000000000","message":"recent rstcheck requires python 3.7[1], ansible 2.9 does not specify a version for rstcheck, therefor the test fails on ubuntu with python3.6. \n\n[1] https://pypi.org/project/rstcheck/3.5.0/#id1","commit_id":"4756b56cde95cf19e54d7674b060f91be877c440"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"37cdfdb68d43c358c78f92aaae092de364c8d2df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5a0f962e_5f537237","in_reply_to":"f3450a6b_4d9422f9","updated":"2022-04-19 19:37:17.000000000","message":"Let\u0027s wait for this PR to be fixed and merged into 2.9 😊\n\nhttps://github.com/ansible/ansible/pull/77568","commit_id":"4756b56cde95cf19e54d7674b060f91be877c440"},{"author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"change_message_id":"b0c3571efdeb779c3e555f708ac187bdf3f3be42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aa0cbe64_a54661e7","updated":"2022-04-19 20:12:09.000000000","message":"Oh I missed your port range point in your first comments, lets do a new check when the PR to ansible 2.9 is merged. \nThanks","commit_id":"1af66c954bfda9672b36334e17e7b51a7df10ff6"},{"author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"change_message_id":"92ef3f1bff7dd463c2b6b17924aae9e41eb0d07c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c9b86ef6_fd81ebb4","updated":"2022-04-20 08:05:18.000000000","message":"recheck","commit_id":"1af66c954bfda9672b36334e17e7b51a7df10ff6"}],"plugins/modules/security_group_rule.py":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"789641c1534187d1d74814c34542b6c97c487598","unresolved":true,"context_lines":[{"line_number":355,"context_line":"                kwargs \u003d {}"},{"line_number":356,"context_line":"                if project_id:"},{"line_number":357,"context_line":"                    kwargs[\u0027project_id\u0027] \u003d project_id"},{"line_number":358,"context_line":"                kwargs[\"description\"] \u003d self.params[\u0027description\u0027]"},{"line_number":359,"context_line":"                rule \u003d self.conn.create_security_group_rule("},{"line_number":360,"context_line":"                    secgroup[\u0027id\u0027],"},{"line_number":361,"context_line":"                    port_range_min\u003dself.params[\u0027port_range_min\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"2343c87d_f1a29d5e","line":358,"updated":"2022-04-19 12:03:19.000000000","message":"Please add something like \"if self.params[\u0027description\u0027] is not None:\"\n\nRef.: https://github.com/openstack/openstacksdk/blob/6b2f555ade95aee14746a570a5b2eebdc56077c8/openstack/cloud/_security_group.py#L324","commit_id":"b9756e005f7e84a9bdf276471f89cd3bcee772d5"},{"author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"change_message_id":"d4a7e1e651a74e003c5fb5ea440fbecff659a637","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                kwargs \u003d {}"},{"line_number":356,"context_line":"                if project_id:"},{"line_number":357,"context_line":"                    kwargs[\u0027project_id\u0027] \u003d project_id"},{"line_number":358,"context_line":"                kwargs[\"description\"] \u003d self.params[\u0027description\u0027]"},{"line_number":359,"context_line":"                rule \u003d self.conn.create_security_group_rule("},{"line_number":360,"context_line":"                    secgroup[\u0027id\u0027],"},{"line_number":361,"context_line":"                    port_range_min\u003dself.params[\u0027port_range_min\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fd46f22e_57138e35","line":358,"in_reply_to":"2343c87d_f1a29d5e","updated":"2022-04-19 15:39:20.000000000","message":"Done","commit_id":"b9756e005f7e84a9bdf276471f89cd3bcee772d5"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"37cdfdb68d43c358c78f92aaae092de364c8d2df","unresolved":true,"context_lines":[{"line_number":359,"context_line":"                    kwargs[\"description\"] \u003d self.params[\u0027description\u0027]"},{"line_number":360,"context_line":"                rule \u003d self.conn.network.create_security_group_rule("},{"line_number":361,"context_line":"                    security_group_id\u003dsecgroup[\u0027id\u0027],"},{"line_number":362,"context_line":"                    port_range_min\u003dself.params[\u0027port_range_min\u0027],"},{"line_number":363,"context_line":"                    port_range_max\u003dself.params[\u0027port_range_max\u0027],"},{"line_number":364,"context_line":"                    protocol\u003dself.params[\u0027protocol\u0027],"},{"line_number":365,"context_line":"                    remote_ip_prefix\u003dself.params[\u0027remote_ip_prefix\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"b6960a85_bcc8b374","line":362,"updated":"2022-04-19 19:37:17.000000000","message":"Please add these checks for port_range_min/max to not break backward compatibility:\n\nhttps://github.com/openstack/openstacksdk/blob/stable/train/openstack/cloud/_security_group.py#L302","commit_id":"4756b56cde95cf19e54d7674b060f91be877c440"},{"author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"change_message_id":"b0c3571efdeb779c3e555f708ac187bdf3f3be42","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                    kwargs[\"description\"] \u003d self.params[\u0027description\u0027]"},{"line_number":360,"context_line":"                rule \u003d self.conn.network.create_security_group_rule("},{"line_number":361,"context_line":"                    security_group_id\u003dsecgroup[\u0027id\u0027],"},{"line_number":362,"context_line":"                    port_range_min\u003dself.params[\u0027port_range_min\u0027],"},{"line_number":363,"context_line":"                    port_range_max\u003dself.params[\u0027port_range_max\u0027],"},{"line_number":364,"context_line":"                    protocol\u003dself.params[\u0027protocol\u0027],"},{"line_number":365,"context_line":"                    remote_ip_prefix\u003dself.params[\u0027remote_ip_prefix\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1dd9f670_9feec8e2","line":362,"in_reply_to":"b6960a85_bcc8b374","updated":"2022-04-19 20:12:09.000000000","message":"Done","commit_id":"4756b56cde95cf19e54d7674b060f91be877c440"}]}