)]}'
{".zuul.yaml":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8fb48b42883508ab8470bd6e77263a14cb0fa7ed","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        dns_zone_info"},{"line_number":64,"context_line":"        floating_ip_info"},{"line_number":65,"context_line":"        group"},{"line_number":66,"context_line":"        identity_role_info"},{"line_number":67,"context_line":"        image"},{"line_number":68,"context_line":"        keypair"},{"line_number":69,"context_line":"        keystone_domain"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"a67a20e7_e677e2e6","line":66,"updated":"2022-05-02 10:15:34.000000000","message":"Zuul CI wont run this ci role because it is ignoring the updated tox_extra_args. What is going on here?","commit_id":"89f71ce8b270f96bc1f4f4aebd455a2cbb6881a7"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"933e18b5dfbb34034faf2f824059309f096a077e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        dns_zone_info"},{"line_number":64,"context_line":"        floating_ip_info"},{"line_number":65,"context_line":"        group"},{"line_number":66,"context_line":"        identity_role_info"},{"line_number":67,"context_line":"        image"},{"line_number":68,"context_line":"        keypair"},{"line_number":69,"context_line":"        keystone_domain"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"043a8dcd_f5b8374a","line":66,"in_reply_to":"a67a20e7_e677e2e6","updated":"2022-05-09 09:08:55.000000000","message":"Done","commit_id":"89f71ce8b270f96bc1f4f4aebd455a2cbb6881a7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8b7820fa55db8f39275b82a796674364eade62e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2c9559e7_182808dc","updated":"2022-04-27 09:07:24.000000000","message":"Great, thank you very much! Awesome tests 👍","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"c58eebad2b40774ebdfc6cd4942170560ce7aa3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cee1dc6f_3a804f0c","in_reply_to":"2c9559e7_182808dc","updated":"2022-04-27 15:18:45.000000000","message":"Thanks for the review!","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"2c838c0cf221765c50af4757c35dfb2dd244cb34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"668d8ce7_b22b5e75","updated":"2022-04-28 09:19:59.000000000","message":"Nice one! Will merge once our CI has been fixed, e.g. this one has been merged\nhttps://review.opendev.org/c/openstack/ansible-collections-openstack/+/839374","commit_id":"d44e1173fdf3c4450df70c041ee5bfa4c262c4f1"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"80a6a0a874b377ec3a607f1799d6217e831a1a15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5a50c137_8dc8cf5b","updated":"2022-04-28 13:52:09.000000000","message":"Please rebase and add tag to tox_extra_args in .zuul.yaml, so that your tests are actually run.","commit_id":"d44e1173fdf3c4450df70c041ee5bfa4c262c4f1"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"a1f9c20a80e734b2814f1c0fe688886126e66f21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"92b1cb73_e6f52892","updated":"2022-05-02 07:41:27.000000000","message":"Latest patchset fixed attribute names (openstack_roles \u003d\u003e roles) in keystone_role as well. Let\u0027s see if CI passes this time..","commit_id":"89f71ce8b270f96bc1f4f4aebd455a2cbb6881a7"}],"ci/roles/keystone_role_info/tasks/main.yml":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8b7820fa55db8f39275b82a796674364eade62e4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: Ensure role does not exist before tests"},{"line_number":2,"context_line":"  openstack.cloud.identity_role:"},{"line_number":3,"context_line":"     cloud: \"{{ cloud }}\""},{"line_number":4,"context_line":"     state: absent"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"83276dd7_1a791243","line":1,"updated":"2022-04-27 09:07:24.000000000","message":"Please rename this file from keystone_role_info to identity_role_info. We want to get rid of the old names and have role names which match module names.","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"c58eebad2b40774ebdfc6cd4942170560ce7aa3d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Ensure role does not exist before tests"},{"line_number":2,"context_line":"  openstack.cloud.identity_role:"},{"line_number":3,"context_line":"     cloud: \"{{ cloud }}\""},{"line_number":4,"context_line":"     state: absent"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fd86d056_000c595a","line":1,"in_reply_to":"83276dd7_1a791243","updated":"2022-04-27 15:18:45.000000000","message":"Done","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8b7820fa55db8f39275b82a796674364eade62e4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2191eb09_3fd7bc06","line":54,"updated":"2022-04-27 09:07:24.000000000","message":"Please remove roles once testing is done. Makes it easier to test locally.","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"c58eebad2b40774ebdfc6cd4942170560ce7aa3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"51eea13f_342d1997","line":54,"in_reply_to":"2191eb09_3fd7bc06","updated":"2022-04-27 15:18:45.000000000","message":"Done","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"}],"plugins/modules/identity_role_info.py":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"609424e3dda4c9b5da44ebf7a2399e8ec447250b","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    def run(self):"},{"line_number":94,"context_line":"        domain_id \u003d self.params.get(\u0027domain_id\u0027)"},{"line_number":95,"context_line":"        name \u003d self.params.get(\u0027name\u0027)"},{"line_number":96,"context_line":"        roles \u003d self.conn.identity.roles(name\u003dname, domain_id\u003ddomain_id)"},{"line_number":97,"context_line":"        roles \u003d [role.to_dict(computed\u003dFalse) for role in roles]"},{"line_number":98,"context_line":"        self.results.update({\u0027openstack_roles\u0027: roles})"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"c11c6c22_a7a834b8","line":96,"updated":"2022-04-20 10:33:34.000000000","message":"You remove the possibility to search for the id in this way","commit_id":"6dc20452374338d152fb5248bca8dfa4a5554f35"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"933e18b5dfbb34034faf2f824059309f096a077e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    def run(self):"},{"line_number":94,"context_line":"        domain_id \u003d self.params.get(\u0027domain_id\u0027)"},{"line_number":95,"context_line":"        name \u003d self.params.get(\u0027name\u0027)"},{"line_number":96,"context_line":"        roles \u003d self.conn.identity.roles(name\u003dname, domain_id\u003ddomain_id)"},{"line_number":97,"context_line":"        roles \u003d [role.to_dict(computed\u003dFalse) for role in roles]"},{"line_number":98,"context_line":"        self.results.update({\u0027openstack_roles\u0027: roles})"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1e6c6461_23cfea66","line":96,"in_reply_to":"7fed0fcf_4380ab8a","updated":"2022-05-09 09:08:55.000000000","message":"I was mistaken, most *_info modules allow to search by name and id. Latest patchset restores this functionality using cloud function search_roles().","commit_id":"6dc20452374338d152fb5248bca8dfa4a5554f35"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"876cadecfd4194e3519abb282b4e8e54c7f9262e","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    def run(self):"},{"line_number":94,"context_line":"        domain_id \u003d self.params.get(\u0027domain_id\u0027)"},{"line_number":95,"context_line":"        name \u003d self.params.get(\u0027name\u0027)"},{"line_number":96,"context_line":"        roles \u003d self.conn.identity.roles(name\u003dname, domain_id\u003ddomain_id)"},{"line_number":97,"context_line":"        roles \u003d [role.to_dict(computed\u003dFalse) for role in roles]"},{"line_number":98,"context_line":"        self.results.update({\u0027openstack_roles\u0027: roles})"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"f4d1dcf3_d6b04f96","line":96,"in_reply_to":"a9b7f4e7_d76b5ede","updated":"2022-04-27 09:08:15.000000000","message":"*but highlight/mention it in the commit message","commit_id":"6dc20452374338d152fb5248bca8dfa4a5554f35"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8b7820fa55db8f39275b82a796674364eade62e4","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    def run(self):"},{"line_number":94,"context_line":"        domain_id \u003d self.params.get(\u0027domain_id\u0027)"},{"line_number":95,"context_line":"        name \u003d self.params.get(\u0027name\u0027)"},{"line_number":96,"context_line":"        roles \u003d self.conn.identity.roles(name\u003dname, domain_id\u003ddomain_id)"},{"line_number":97,"context_line":"        roles \u003d [role.to_dict(computed\u003dFalse) for role in roles]"},{"line_number":98,"context_line":"        self.results.update({\u0027openstack_roles\u0027: roles})"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"a9b7f4e7_d76b5ede","line":96,"in_reply_to":"c11c6c22_a7a834b8","updated":"2022-04-27 09:07:24.000000000","message":"The previous code did allow to filter for id and name by name. But this was not documented. Using name to filter the id is unintuitive at least. Most other modules do not support the use of id at all.\n\nIn my opinion we should drop the id code completely but it in the commit message. If someone really wants to filter by id then this functionality can easily be reimplemented with a proper \u0027id\u0027 module argument.","commit_id":"6dc20452374338d152fb5248bca8dfa4a5554f35"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"c58eebad2b40774ebdfc6cd4942170560ce7aa3d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    def run(self):"},{"line_number":94,"context_line":"        domain_id \u003d self.params.get(\u0027domain_id\u0027)"},{"line_number":95,"context_line":"        name \u003d self.params.get(\u0027name\u0027)"},{"line_number":96,"context_line":"        roles \u003d self.conn.identity.roles(name\u003dname, domain_id\u003ddomain_id)"},{"line_number":97,"context_line":"        roles \u003d [role.to_dict(computed\u003dFalse) for role in roles]"},{"line_number":98,"context_line":"        self.results.update({\u0027openstack_roles\u0027: roles})"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7fed0fcf_4380ab8a","line":96,"in_reply_to":"f4d1dcf3_d6b04f96","updated":"2022-04-27 15:18:45.000000000","message":"Done","commit_id":"6dc20452374338d152fb5248bca8dfa4a5554f35"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8b7820fa55db8f39275b82a796674364eade62e4","unresolved":true,"context_lines":[{"line_number":7,"context_line":"DOCUMENTATION \u003d \u0027\u0027\u0027"},{"line_number":8,"context_line":"---"},{"line_number":9,"context_line":"module: identity_role_info"},{"line_number":10,"context_line":"short_description: Retrive information about roles"},{"line_number":11,"context_line":"author: OpenStack Ansible SIG"},{"line_number":12,"context_line":"description:"},{"line_number":13,"context_line":"  - Get information about identity roles in Openstack"}],"source_content_type":"text/x-python","patch_set":10,"id":"4ef87d1c_bb094cc1","line":10,"updated":"2022-04-27 09:07:24.000000000","message":"Would be cool if you could fix this preexisting typo: Retrive \u003d\u003e Retrieve.","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"c58eebad2b40774ebdfc6cd4942170560ce7aa3d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"DOCUMENTATION \u003d \u0027\u0027\u0027"},{"line_number":8,"context_line":"---"},{"line_number":9,"context_line":"module: identity_role_info"},{"line_number":10,"context_line":"short_description: Retrive information about roles"},{"line_number":11,"context_line":"author: OpenStack Ansible SIG"},{"line_number":12,"context_line":"description:"},{"line_number":13,"context_line":"  - Get information about identity roles in Openstack"}],"source_content_type":"text/x-python","patch_set":10,"id":"74ca2f15_a2277e61","line":10,"in_reply_to":"4ef87d1c_bb094cc1","updated":"2022-04-27 15:18:45.000000000","message":"Done","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8b7820fa55db8f39275b82a796674364eade62e4","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    required: false"},{"line_number":20,"context_line":"  name:"},{"line_number":21,"context_line":"    description:"},{"line_number":22,"context_line":"      - List role speficied by name"},{"line_number":23,"context_line":"    type: str"},{"line_number":24,"context_line":"    required: false"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5ea3235a_def09024","line":22,"updated":"2022-04-27 09:07:24.000000000","message":"speficied \u003d\u003e specified","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"c58eebad2b40774ebdfc6cd4942170560ce7aa3d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    required: false"},{"line_number":20,"context_line":"  name:"},{"line_number":21,"context_line":"    description:"},{"line_number":22,"context_line":"      - List role speficied by name"},{"line_number":23,"context_line":"    type: str"},{"line_number":24,"context_line":"    required: false"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dd9e99a0_fe983a91","line":22,"in_reply_to":"5ea3235a_def09024","updated":"2022-04-27 15:18:45.000000000","message":"Done","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8b7820fa55db8f39275b82a796674364eade62e4","unresolved":true,"context_lines":[{"line_number":91,"context_line":"    )"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def run(self):"},{"line_number":94,"context_line":"        domain_id \u003d self.params.get(\u0027domain_id\u0027)"},{"line_number":95,"context_line":"        name \u003d self.params.get(\u0027name\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        roles_by_name \u003d self.conn.identity.roles(name\u003dname, domain_id\u003ddomain_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a179958_821cbc6a","line":94,"updated":"2022-04-27 09:07:24.000000000","message":"You can use self.params[\u0027..\u0027] instead of self.params.get(\u0027..\u0027) because args are defined in argument_spec.","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"c58eebad2b40774ebdfc6cd4942170560ce7aa3d","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    )"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def run(self):"},{"line_number":94,"context_line":"        domain_id \u003d self.params.get(\u0027domain_id\u0027)"},{"line_number":95,"context_line":"        name \u003d self.params.get(\u0027name\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        roles_by_name \u003d self.conn.identity.roles(name\u003dname, domain_id\u003ddomain_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"6179d66c_38265e0d","line":94,"in_reply_to":"1a179958_821cbc6a","updated":"2022-04-27 15:18:45.000000000","message":"Done","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8b7820fa55db8f39275b82a796674364eade62e4","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        domain_id \u003d self.params.get(\u0027domain_id\u0027)"},{"line_number":95,"context_line":"        name \u003d self.params.get(\u0027name\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        roles_by_name \u003d self.conn.identity.roles(name\u003dname, domain_id\u003ddomain_id)"},{"line_number":98,"context_line":"        roles_by_id \u003d self.conn.identity.roles(id\u003dname, domain_id\u003ddomain_id)"},{"line_number":99,"context_line":"        roles \u003d list(roles_by_name) + list(roles_by_id)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"38609b5a_330ce2c3","line":97,"updated":"2022-04-27 09:07:24.000000000","message":"Please only pass name and domain_id to roles() if they are not None. Else None will be send as part of the request to OpenStack API.","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"c58eebad2b40774ebdfc6cd4942170560ce7aa3d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        domain_id \u003d self.params.get(\u0027domain_id\u0027)"},{"line_number":95,"context_line":"        name \u003d self.params.get(\u0027name\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        roles_by_name \u003d self.conn.identity.roles(name\u003dname, domain_id\u003ddomain_id)"},{"line_number":98,"context_line":"        roles_by_id \u003d self.conn.identity.roles(id\u003dname, domain_id\u003ddomain_id)"},{"line_number":99,"context_line":"        roles \u003d list(roles_by_name) + list(roles_by_id)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"727b1ef9_964a9857","line":97,"in_reply_to":"38609b5a_330ce2c3","updated":"2022-04-27 15:18:45.000000000","message":"Done","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8b7820fa55db8f39275b82a796674364eade62e4","unresolved":true,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        roles_by_name \u003d self.conn.identity.roles(name\u003dname, domain_id\u003ddomain_id)"},{"line_number":98,"context_line":"        roles_by_id \u003d self.conn.identity.roles(id\u003dname, domain_id\u003ddomain_id)"},{"line_number":99,"context_line":"        roles \u003d list(roles_by_name) + list(roles_by_id)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        roles \u003d [role.to_dict(computed\u003dFalse) for role in roles]"},{"line_number":102,"context_line":"        self.results.update({\u0027openstack_roles\u0027: roles})"}],"source_content_type":"text/x-python","patch_set":10,"id":"5ec265d8_5c295bdf","line":99,"updated":"2022-04-27 09:07:24.000000000","message":"Please drop id code as discussed in the other comment.","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"c58eebad2b40774ebdfc6cd4942170560ce7aa3d","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        roles_by_name \u003d self.conn.identity.roles(name\u003dname, domain_id\u003ddomain_id)"},{"line_number":98,"context_line":"        roles_by_id \u003d self.conn.identity.roles(id\u003dname, domain_id\u003ddomain_id)"},{"line_number":99,"context_line":"        roles \u003d list(roles_by_name) + list(roles_by_id)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        roles \u003d [role.to_dict(computed\u003dFalse) for role in roles]"},{"line_number":102,"context_line":"        self.results.update({\u0027openstack_roles\u0027: roles})"}],"source_content_type":"text/x-python","patch_set":10,"id":"17b3e865_34a558e5","line":99,"in_reply_to":"5ec265d8_5c295bdf","updated":"2022-04-27 15:18:45.000000000","message":"Done","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8b7820fa55db8f39275b82a796674364eade62e4","unresolved":true,"context_lines":[{"line_number":99,"context_line":"        roles \u003d list(roles_by_name) + list(roles_by_id)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        roles \u003d [role.to_dict(computed\u003dFalse) for role in roles]"},{"line_number":102,"context_line":"        self.results.update({\u0027openstack_roles\u0027: roles})"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":10,"id":"9c0dbd44_62656b73","line":102,"updated":"2022-04-27 09:07:24.000000000","message":"Please change to \n\n  self.exit_json(changed\u003dFalse, openstack_roles\u003droles)\n\nto be consistent across modules.","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"c58eebad2b40774ebdfc6cd4942170560ce7aa3d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        roles \u003d list(roles_by_name) + list(roles_by_id)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        roles \u003d [role.to_dict(computed\u003dFalse) for role in roles]"},{"line_number":102,"context_line":"        self.results.update({\u0027openstack_roles\u0027: roles})"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":10,"id":"822ce0db_d7e0045c","line":102,"in_reply_to":"9c0dbd44_62656b73","updated":"2022-04-27 15:18:45.000000000","message":"Done","commit_id":"d9fdf91db0e91ca0234e26e9c0ea5aca77e5f745"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"075b9090525692894bc864c314a047f51304f97d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"options:"},{"line_number":15,"context_line":"  domain_id:"},{"line_number":16,"context_line":"    description:"},{"line_number":17,"context_line":"      - Domain ID which owns the role"},{"line_number":18,"context_line":"    type: str"},{"line_number":19,"context_line":"    required: false"},{"line_number":20,"context_line":"  name:"}],"source_content_type":"text/x-python","patch_set":20,"id":"eb81ab7d_a11e17d6","line":17,"updated":"2022-05-09 13:13:01.000000000","message":"Although in the original have a - but i think we can remove here","commit_id":"1d22a94a90428d280446a7daf100623dc884b091"}]}