)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6f1e87a0cf976d912d5a9f23446fd3ce12b015c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a8a92b97_10af2f2b","updated":"2022-05-22 23:26:43.000000000","message":"Great, thanks, a few comments inside.","commit_id":"4cdde5bda8a63fcded08de130f24bca88903b852"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"0754da19b4ec432ab3b0cb0774b2d83a74a2f577","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"966b0aac_aeec70eb","updated":"2022-05-23 13:21:54.000000000","message":"Thanks for the review!","commit_id":"4cdde5bda8a63fcded08de130f24bca88903b852"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"2e1e592c906fb4b86be9e8336556335dd567e3d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"87ddb2fe_ca98b80c","updated":"2022-05-31 22:21:29.000000000","message":"Let\u0027s keep this one on hold and focus on the porting work for now.","commit_id":"1c731b2785be71d7953de6a077f3f34cbbad7f14"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"5e2501e5406c74d7ce0674f79d0f51452185b436","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"47513ce1_e74df8ce","updated":"2022-05-31 12:09:55.000000000","message":"Uploaded some micro changes.","commit_id":"1c731b2785be71d7953de6a077f3f34cbbad7f14"}],"ci/roles/recordset_info/tasks/filter.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6f1e87a0cf976d912d5a9f23446fd3ce12b015c1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    {{ {\u0027cloud\u0027: cloud, \u0027zone\u0027: zone, field: recordset[field]} }}"},{"line_number":5,"context_line":"  register: recordset_info"},{"line_number":6,"context_line":"- name: Assert single record returned"},{"line_number":7,"context_line":"  assert: "},{"line_number":8,"context_line":"    that: recordset_info.recordsets | length \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5c11e5f4_3d9db59f","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":10},"updated":"2022-05-22 23:26:43.000000000","message":"space","commit_id":"4cdde5bda8a63fcded08de130f24bca88903b852"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"0754da19b4ec432ab3b0cb0774b2d83a74a2f577","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    {{ {\u0027cloud\u0027: cloud, \u0027zone\u0027: zone, field: recordset[field]} }}"},{"line_number":5,"context_line":"  register: recordset_info"},{"line_number":6,"context_line":"- name: Assert single record returned"},{"line_number":7,"context_line":"  assert: "},{"line_number":8,"context_line":"    that: recordset_info.recordsets | length \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"98a15942_9d6af408","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":10},"in_reply_to":"5c11e5f4_3d9db59f","updated":"2022-05-23 13:21:54.000000000","message":"Done","commit_id":"4cdde5bda8a63fcded08de130f24bca88903b852"}],"ci/roles/recordset_info/tasks/main.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6f1e87a0cf976d912d5a9f23446fd3ce12b015c1","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    zone: \"{{ dns_zone_name }}\""},{"line_number":42,"context_line":"  register: recordset_info"},{"line_number":43,"context_line":"- name: Assert single record returned"},{"line_number":44,"context_line":"  assert: "},{"line_number":45,"context_line":"    that: recordset_info.recordsets | length \u003d\u003d 1"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Ensure second recordset"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f324bfcf_34431451","line":44,"range":{"start_line":44,"start_character":9,"end_line":44,"end_character":10},"updated":"2022-05-22 23:26:43.000000000","message":"space","commit_id":"4cdde5bda8a63fcded08de130f24bca88903b852"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"0754da19b4ec432ab3b0cb0774b2d83a74a2f577","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    zone: \"{{ dns_zone_name }}\""},{"line_number":42,"context_line":"  register: recordset_info"},{"line_number":43,"context_line":"- name: Assert single record returned"},{"line_number":44,"context_line":"  assert: "},{"line_number":45,"context_line":"    that: recordset_info.recordsets | length \u003d\u003d 1"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Ensure second recordset"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"45a5010b_c60160c0","line":44,"range":{"start_line":44,"start_character":9,"end_line":44,"end_character":10},"in_reply_to":"f324bfcf_34431451","updated":"2022-05-23 13:21:54.000000000","message":"Done","commit_id":"4cdde5bda8a63fcded08de130f24bca88903b852"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"0ae7834e43e9d7983ef8c4c26da932da3e9eec1e","unresolved":true,"context_lines":[{"line_number":18,"context_line":"- name: Ensure recordset"},{"line_number":19,"context_line":"  openstack.cloud.recordset:"},{"line_number":20,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":21,"context_line":"    zone: \"{{ dns_zone_name }}\""},{"line_number":22,"context_line":"    name: \"{{ recordset_name }}\""},{"line_number":23,"context_line":"    recordset_type: \"a\""},{"line_number":24,"context_line":"    records: \"{{ records }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1c920368_ad3cd60b","line":21,"updated":"2022-05-31 12:20:54.000000000","message":"atm this requires a zone id which is why ci failed in the past.","commit_id":"1c731b2785be71d7953de6a077f3f34cbbad7f14"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"0ae7834e43e9d7983ef8c4c26da932da3e9eec1e","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  vars:"},{"line_number":62,"context_line":"    field: \"{{ item }}\""},{"line_number":63,"context_line":"  loop:"},{"line_number":64,"context_line":"    - description"},{"line_number":65,"context_line":"    - name"},{"line_number":66,"context_line":"    - ttl"},{"line_number":67,"context_line":"    - type"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8433423b_f3d7312f","line":64,"updated":"2022-05-31 12:20:54.000000000","message":"Please test for all attributes like you did in your other patches :)","commit_id":"1c731b2785be71d7953de6a077f3f34cbbad7f14"}],"plugins/modules/recordset_info.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6f1e87a0cf976d912d5a9f23446fd3ce12b015c1","unresolved":true,"context_lines":[{"line_number":12,"context_line":"options:"},{"line_number":13,"context_line":"  description:"},{"line_number":14,"context_line":"    description: Description of retrieved recordsets"},{"line_number":15,"context_line":"    required: false"},{"line_number":16,"context_line":"    type: str"},{"line_number":17,"context_line":"  name:"},{"line_number":18,"context_line":"    description: Name or ID of the recordset"}],"source_content_type":"text/x-python","patch_set":4,"id":"6b15efe6_d4b29c2a","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":19},"updated":"2022-05-22 23:26:43.000000000","message":"usually we need to specify \"required\" only if it\u0027s true\nby default it\u0027s false, so can be dropped here","commit_id":"4cdde5bda8a63fcded08de130f24bca88903b852"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"0754da19b4ec432ab3b0cb0774b2d83a74a2f577","unresolved":false,"context_lines":[{"line_number":12,"context_line":"options:"},{"line_number":13,"context_line":"  description:"},{"line_number":14,"context_line":"    description: Description of retrieved recordsets"},{"line_number":15,"context_line":"    required: false"},{"line_number":16,"context_line":"    type: str"},{"line_number":17,"context_line":"  name:"},{"line_number":18,"context_line":"    description: Name or ID of the recordset"}],"source_content_type":"text/x-python","patch_set":4,"id":"5d1f04a2_bb52a2eb","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":19},"in_reply_to":"6b15efe6_d4b29c2a","updated":"2022-05-23 13:21:54.000000000","message":"Done","commit_id":"4cdde5bda8a63fcded08de130f24bca88903b852"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6f1e87a0cf976d912d5a9f23446fd3ce12b015c1","unresolved":true,"context_lines":[{"line_number":145,"context_line":"        supports_check_mode\u003dTrue"},{"line_number":146,"context_line":"    )"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    module_min_sdk_version \u003d \u00270.28.0\u0027"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def run(self):"},{"line_number":151,"context_line":"        search_args \u003d {k: v for k, v in self.params.items() if v is not None}"}],"source_content_type":"text/x-python","patch_set":4,"id":"a0fd95f4_a9886c64","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":2},"updated":"2022-05-22 23:26:43.000000000","message":"Do you want to add it to version in  stable/1.0.0? Otherwise it\u0027s not needed, since master(2.0.0) will require SDK \u003e\u003d 1.0.0 anyway","commit_id":"4cdde5bda8a63fcded08de130f24bca88903b852"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"0754da19b4ec432ab3b0cb0774b2d83a74a2f577","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        supports_check_mode\u003dTrue"},{"line_number":146,"context_line":"    )"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    module_min_sdk_version \u003d \u00270.28.0\u0027"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def run(self):"},{"line_number":151,"context_line":"        search_args \u003d {k: v for k, v in self.params.items() if v is not None}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9c72b867_3dcc14dc","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":2},"in_reply_to":"a0fd95f4_a9886c64","updated":"2022-05-23 13:21:54.000000000","message":"Done","commit_id":"4cdde5bda8a63fcded08de130f24bca88903b852"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"eb9ae0cd1d5115de2250f3270659a55412a905e2","unresolved":true,"context_lines":[{"line_number":139,"context_line":"        supports_check_mode\u003dTrue"},{"line_number":140,"context_line":"    )"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    module_min_sdk_version \u003d \u00271.0.0\u0027"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def run(self):"},{"line_number":145,"context_line":"        search_args \u003d {k: v for k, v in self.params.items() if v is not None}"}],"source_content_type":"text/x-python","patch_set":5,"id":"847f6e8b_d6b0ebbf","line":142,"range":{"start_line":142,"start_character":4,"end_line":142,"end_character":35},"updated":"2022-05-24 10:31:04.000000000","message":"Sorry, I meant to drop it completely, since the whole collection will require SDK \u003e\u003d 1.0.0. If we want to limit the whole collection, better to do it once in OpenstackModule class instead of adding module_min_sdk_version for each collection separately.","commit_id":"f29622e7fb49e97b1051058431ae302d912b3876"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"5e2501e5406c74d7ce0674f79d0f51452185b436","unresolved":true,"context_lines":[{"line_number":139,"context_line":"        supports_check_mode\u003dTrue"},{"line_number":140,"context_line":"    )"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    module_min_sdk_version \u003d \u00271.0.0\u0027"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def run(self):"},{"line_number":145,"context_line":"        search_args \u003d {k: v for k, v in self.params.items() if v is not None}"}],"source_content_type":"text/x-python","patch_set":5,"id":"dd221706_368372a2","line":142,"range":{"start_line":142,"start_character":4,"end_line":142,"end_character":35},"in_reply_to":"847f6e8b_d6b0ebbf","updated":"2022-05-31 12:09:55.000000000","message":"Keep this in mind though when backporting it to stable/1.0.0. It would be cool to include this module in our stable/1.0.0 series as well since sdk\u003c0.99.0 will probably a thing until yoga goes EOL which will be in how many years?","commit_id":"f29622e7fb49e97b1051058431ae302d912b3876"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"86e546c409e35bafde653a43113a44bee9dccc42","unresolved":true,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def run(self):"},{"line_number":148,"context_line":"        search_args \u003d {k: v for k, v in self.params.items() if v is not None}"},{"line_number":149,"context_line":"        recordsets \u003d self.conn.dns.recordsets(search_args)"},{"line_number":150,"context_line":"        recordsets \u003d [r.to_dict(computed\u003dFalse) for r in recordsets]"},{"line_number":151,"context_line":"        self.exit_json(changed\u003dFalse, recordsets\u003drecordsets)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"6db89646_ed67cc5a","line":149,"updated":"2022-05-31 12:16:28.000000000","message":"Although technically correct, this does not allow to search by name or id like our other *_info modules do. For consistency across modules i would prefer self.conn.search_recordsets().","commit_id":"1c731b2785be71d7953de6a077f3f34cbbad7f14"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"974837a062cb6f6ae07ecb798981a37b5411c73d","unresolved":true,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def run(self):"},{"line_number":148,"context_line":"        search_args \u003d {k: v for k, v in self.params.items() if v is not None}"},{"line_number":149,"context_line":"        recordsets \u003d self.conn.dns.recordsets(search_args)"},{"line_number":150,"context_line":"        recordsets \u003d [r.to_dict(computed\u003dFalse) for r in recordsets]"},{"line_number":151,"context_line":"        self.exit_json(changed\u003dFalse, recordsets\u003drecordsets)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7fe514a5_2c3d4b9b","line":149,"in_reply_to":"6db89646_ed67cc5a","updated":"2022-05-31 12:41:11.000000000","message":"The latter would also allow us to offer a filters option to do client-side (and server-side?) filtering without us having to implement each filter as separate module arguments.","commit_id":"1c731b2785be71d7953de6a077f3f34cbbad7f14"}]}