)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"a5b3daff1b90a05a7242b7ccbc082f51f2c78eaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2212b260_e3deda4a","updated":"2022-05-22 23:31:54.000000000","message":"the typo fails linters","commit_id":"57e7595263aa89281b776298c417f624efd7ae18"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"604d9cd6b9da33e6d6b86a025e00694c6a3ef436","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f31766c_1222fe75","updated":"2022-05-30 08:12:24.000000000","message":"Very nice refactoring, Rafael! Much better to read now ☺️\n\nFound a couple of minor issues and just went ahead and fixed them. Please have a look at the latest patchset.","commit_id":"3eb5d4bae52ae3bdf87158598d566f480dbf3e28"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"fecca260be74611200ac7bbf547a5591529b84e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9c20d088_7af04c6e","updated":"2022-05-31 12:37:03.000000000","message":"Thanks for the improvements, Jakob.","commit_id":"97b05533f14d622d2b02147011aa59a9aa07c372"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"bf8d17bf4a38da7b25f14c9cd13f5b5d5f0be1d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bf064aa8_5ec7f081","updated":"2022-05-31 07:45:00.000000000","message":"Went ahead and implemented these minor changes. What do you think, Rafael?","commit_id":"97b05533f14d622d2b02147011aa59a9aa07c372"}],"ci/roles/recordset/tasks/main.yml":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"6758f16068b3e5ad3faea344776d5f1fc12407fb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"- name: Verify recordset info"},{"line_number":26,"context_line":"  assert:"},{"line_number":27,"context_line":"    that:"},{"line_number":28,"context_line":"      - recordset is changed"},{"line_number":29,"context_line":"      - recordset[\"recordset\"].name \u003d\u003d recordset_name"},{"line_number":30,"context_line":"      - recordset[\"recordset\"].zone_name \u003d\u003d  dns_zone.zone.name"},{"line_number":31,"context_line":"      - recordset[\"recordset\"].records \u003d\u003d records"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6727076b_48512742","line":28,"updated":"2022-05-23 09:16:47.000000000","message":"I\u0027m not an specialist and ansible might be fine with this, but should be recordset.changed no?","commit_id":"57e7595263aa89281b776298c417f624efd7ae18"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"243759ad364c8e15ac7683ccda81f1fdf3fed301","unresolved":false,"context_lines":[{"line_number":25,"context_line":"- name: Verify recordset info"},{"line_number":26,"context_line":"  assert:"},{"line_number":27,"context_line":"    that:"},{"line_number":28,"context_line":"      - recordset is changed"},{"line_number":29,"context_line":"      - recordset[\"recordset\"].name \u003d\u003d recordset_name"},{"line_number":30,"context_line":"      - recordset[\"recordset\"].zone_name \u003d\u003d  dns_zone.zone.name"},{"line_number":31,"context_line":"      - recordset[\"recordset\"].records \u003d\u003d records"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"aa5841ef_162963ad","line":28,"in_reply_to":"6727076b_48512742","updated":"2022-05-23 13:18:42.000000000","message":"This way works: https://docs.ansible.com/ansible/latest/user_guide/playbooks_tests.html#testing-task-results","commit_id":"57e7595263aa89281b776298c417f624efd7ae18"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"271b936166de6a5eac1475d93f4f1c347dcd12d7","unresolved":true,"context_lines":[{"line_number":17,"context_line":"- name: Create a recordset"},{"line_number":18,"context_line":"  openstack.cloud.recordset:"},{"line_number":19,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":20,"context_line":"    zone: \"{{ dns_zone.zone.name }}\""},{"line_number":21,"context_line":"    name: \"{{ recordset_name }}\""},{"line_number":22,"context_line":"    recordset_type: \"a\""},{"line_number":23,"context_line":"    records: \"{{ records }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e58ad8d3_fe888ae0","line":20,"updated":"2022-05-31 07:39:55.000000000","message":"This fails because atm \"zone\" must be an id of a zone. But to be consistent with other modules i would leave this here as it is and instead fix our \"zone\" argument (see other comment).","commit_id":"0e57e032785ea558be28d338a27be505c05cad31"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"bf8d17bf4a38da7b25f14c9cd13f5b5d5f0be1d3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- name: Create a recordset"},{"line_number":18,"context_line":"  openstack.cloud.recordset:"},{"line_number":19,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":20,"context_line":"    zone: \"{{ dns_zone.zone.name }}\""},{"line_number":21,"context_line":"    name: \"{{ recordset_name }}\""},{"line_number":22,"context_line":"    recordset_type: \"a\""},{"line_number":23,"context_line":"    records: \"{{ records }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bc5a6445_ba33d211","line":20,"in_reply_to":"e58ad8d3_fe888ae0","updated":"2022-05-31 07:45:00.000000000","message":"Done","commit_id":"0e57e032785ea558be28d338a27be505c05cad31"}],"plugins/modules/recordset.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"a5b3daff1b90a05a7242b7ccbc082f51f2c78eaf","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            type: str"},{"line_number":111,"context_line":"            sample: \"c1c530a3-3619-46f3-b0f6-236927b2618c\""},{"line_number":112,"context_line":"        links:"},{"line_number":113,"context_line":"            descripiton: Links related to the resource"},{"line_number":114,"context_line":"            type: dict"},{"line_number":115,"context_line":"            returned: always"},{"line_number":116,"context_line":"        name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"8de5801d_217bcb42","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":23},"updated":"2022-05-22 23:31:54.000000000","message":"typo, \"description\"","commit_id":"57e7595263aa89281b776298c417f624efd7ae18"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"243759ad364c8e15ac7683ccda81f1fdf3fed301","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            type: str"},{"line_number":111,"context_line":"            sample: \"c1c530a3-3619-46f3-b0f6-236927b2618c\""},{"line_number":112,"context_line":"        links:"},{"line_number":113,"context_line":"            descripiton: Links related to the resource"},{"line_number":114,"context_line":"            type: dict"},{"line_number":115,"context_line":"            returned: always"},{"line_number":116,"context_line":"        name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"40239ce0_4d74378d","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":23},"in_reply_to":"8de5801d_217bcb42","updated":"2022-05-23 13:18:42.000000000","message":"Done","commit_id":"57e7595263aa89281b776298c417f624efd7ae18"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"a5b3daff1b90a05a7242b7ccbc082f51f2c78eaf","unresolved":true,"context_lines":[{"line_number":132,"context_line":"                - Recordset status"},{"line_number":133,"context_line":"                - Valid values include `PENDING_CREATE`, `ACTIVE`,`PENDING_DELETE`,"},{"line_number":134,"context_line":"                  `ERROR`"},{"line_number":135,"context_line":"            type: string"},{"line_number":136,"context_line":"            returned: always"},{"line_number":137,"context_line":"        type:"},{"line_number":138,"context_line":"            description:"}],"source_content_type":"text/x-python","patch_set":1,"id":"a1bc2c32_f2541e06","line":135,"range":{"start_line":135,"start_character":18,"end_line":135,"end_character":24},"updated":"2022-05-22 23:31:54.000000000","message":"\"str\"","commit_id":"57e7595263aa89281b776298c417f624efd7ae18"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"243759ad364c8e15ac7683ccda81f1fdf3fed301","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                - Recordset status"},{"line_number":133,"context_line":"                - Valid values include `PENDING_CREATE`, `ACTIVE`,`PENDING_DELETE`,"},{"line_number":134,"context_line":"                  `ERROR`"},{"line_number":135,"context_line":"            type: string"},{"line_number":136,"context_line":"            returned: always"},{"line_number":137,"context_line":"        type:"},{"line_number":138,"context_line":"            description:"}],"source_content_type":"text/x-python","patch_set":1,"id":"100f4695_cff71df2","line":135,"range":{"start_line":135,"start_character":18,"end_line":135,"end_character":24},"in_reply_to":"a1bc2c32_f2541e06","updated":"2022-05-23 13:18:42.000000000","message":"Done","commit_id":"57e7595263aa89281b776298c417f624efd7ae18"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"6758f16068b3e5ad3faea344776d5f1fc12407fb","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            kwargs \u003d {k: v for k, v in kwargs.items() if v is not None}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"            if recordset is None:"},{"line_number":218,"context_line":"                kwargs[\u0027ttl\u0027] \u003d ttl or 300"},{"line_number":219,"context_line":"                recordset \u003d self.conn.dns.create_recordset(zone, name\u003dname, **kwargs)"},{"line_number":220,"context_line":"                changed \u003d True"},{"line_number":221,"context_line":"            elif self._needs_update(recordset):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ca23c9c_39d813a4","line":218,"updated":"2022-05-23 09:16:47.000000000","message":"Why not set it as default?","commit_id":"57e7595263aa89281b776298c417f624efd7ae18"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"243759ad364c8e15ac7683ccda81f1fdf3fed301","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            kwargs \u003d {k: v for k, v in kwargs.items() if v is not None}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"            if recordset is None:"},{"line_number":218,"context_line":"                kwargs[\u0027ttl\u0027] \u003d ttl or 300"},{"line_number":219,"context_line":"                recordset \u003d self.conn.dns.create_recordset(zone, name\u003dname, **kwargs)"},{"line_number":220,"context_line":"                changed \u003d True"},{"line_number":221,"context_line":"            elif self._needs_update(recordset):"}],"source_content_type":"text/x-python","patch_set":1,"id":"cbe3ea78_e315ff41","line":218,"in_reply_to":"5ca23c9c_39d813a4","updated":"2022-05-23 13:18:42.000000000","message":"If we set it as default we will reset the ttl to 300 in the update case when the user doesn\u0027t specify a ttl.","commit_id":"57e7595263aa89281b776298c417f624efd7ae18"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"40960a79854698f311f1c7b5d44391fa7e2e73c7","unresolved":true,"context_lines":[{"line_number":211,"context_line":"        params \u003d {"},{"line_number":212,"context_line":"            description: description,"},{"line_number":213,"context_line":"            records: records,"},{"line_number":214,"context_line":"            type: recordset_type.upper(),"},{"line_number":215,"context_line":"            ttl: ttl,"},{"line_number":216,"context_line":"        }"},{"line_number":217,"context_line":"        kwargs \u003d {k: v for k, v in params.items() if v is not None}"}],"source_content_type":"text/x-python","patch_set":5,"id":"d522fe65_01d2f520","line":214,"updated":"2022-05-30 19:00:40.000000000","message":"You cannot do that because recordset_type might be None if state is absent.","commit_id":"9535cb1a3e7c65919983162f3962f9a79c7766c9"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"271b936166de6a5eac1475d93f4f1c347dcd12d7","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        params \u003d {"},{"line_number":212,"context_line":"            description: description,"},{"line_number":213,"context_line":"            records: records,"},{"line_number":214,"context_line":"            type: recordset_type.upper(),"},{"line_number":215,"context_line":"            ttl: ttl,"},{"line_number":216,"context_line":"        }"},{"line_number":217,"context_line":"        kwargs \u003d {k: v for k, v in params.items() if v is not None}"}],"source_content_type":"text/x-python","patch_set":5,"id":"95d50a3b_84d4d5dc","line":214,"in_reply_to":"d522fe65_01d2f520","updated":"2022-05-31 07:39:55.000000000","message":"Done","commit_id":"9535cb1a3e7c65919983162f3962f9a79c7766c9"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"271b936166de6a5eac1475d93f4f1c347dcd12d7","unresolved":true,"context_lines":[{"line_number":45,"context_line":"     type: int"},{"line_number":46,"context_line":"   zone:"},{"line_number":47,"context_line":"     description:"},{"line_number":48,"context_line":"        - Zone managing the recordset"},{"line_number":49,"context_line":"     required: true"},{"line_number":50,"context_line":"     type: str"},{"line_number":51,"context_line":"requirements:"}],"source_content_type":"text/x-python","patch_set":6,"id":"a13dd94c_697d1bb2","line":48,"updated":"2022-05-31 07:39:55.000000000","message":"Please add \"id or name\" somewhere here so that users know what is expected. (See other comment below about what is necessary to implement that)","commit_id":"0e57e032785ea558be28d338a27be505c05cad31"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"bf8d17bf4a38da7b25f14c9cd13f5b5d5f0be1d3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"     type: int"},{"line_number":46,"context_line":"   zone:"},{"line_number":47,"context_line":"     description:"},{"line_number":48,"context_line":"        - Zone managing the recordset"},{"line_number":49,"context_line":"     required: true"},{"line_number":50,"context_line":"     type: str"},{"line_number":51,"context_line":"requirements:"}],"source_content_type":"text/x-python","patch_set":6,"id":"4478acf6_eb7b3844","line":48,"in_reply_to":"a13dd94c_697d1bb2","updated":"2022-05-31 07:45:00.000000000","message":"Done","commit_id":"0e57e032785ea558be28d338a27be505c05cad31"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"271b936166de6a5eac1475d93f4f1c347dcd12d7","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        state \u003d self.params.get(\u0027state\u0027)"},{"line_number":218,"context_line":"        ttl \u003d self.params.get(\u0027ttl\u0027)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        recordset \u003d self.conn.dns.find_recordset(zone, name)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if self.ansible.check_mode:"},{"line_number":223,"context_line":"            self.exit_json(changed\u003dself._system_state_change(state, recordset))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1490950e_a3fa03ad","line":220,"updated":"2022-05-31 07:39:55.000000000","message":"Atm \"zone\" must be an id (or an resource object). To be consistent with other modules and make it easier to use, add this as a line before this \"recordset \u003d\" line:\n\n  zone \u003d self.conn.dns.find_zone(name_or_id\u003dzone, ignore_missing\u003dFalse)","commit_id":"0e57e032785ea558be28d338a27be505c05cad31"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"bf8d17bf4a38da7b25f14c9cd13f5b5d5f0be1d3","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        state \u003d self.params.get(\u0027state\u0027)"},{"line_number":218,"context_line":"        ttl \u003d self.params.get(\u0027ttl\u0027)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        recordset \u003d self.conn.dns.find_recordset(zone, name)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if self.ansible.check_mode:"},{"line_number":223,"context_line":"            self.exit_json(changed\u003dself._system_state_change(state, recordset))"}],"source_content_type":"text/x-python","patch_set":6,"id":"738b4be0_b4015b40","line":220,"in_reply_to":"1490950e_a3fa03ad","updated":"2022-05-31 07:45:00.000000000","message":"Done","commit_id":"0e57e032785ea558be28d338a27be505c05cad31"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"271b936166de6a5eac1475d93f4f1c347dcd12d7","unresolved":true,"context_lines":[{"line_number":234,"context_line":"                changed \u003d True"},{"line_number":235,"context_line":"            self.exit_json(changed\u003dchanged, recordset\u003drecordset)"},{"line_number":236,"context_line":"        elif state \u003d\u003d \u0027absent\u0027 and recordset is not None:"},{"line_number":237,"context_line":"            self.conn.delete_recordset(zone, recordset)"},{"line_number":238,"context_line":"            changed \u003d True"},{"line_number":239,"context_line":"        self.exit_json(changed\u003dchanged)"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"effb2af3_788d5d15","line":237,"updated":"2022-05-31 07:39:55.000000000","message":"nit: no need for cloud layer:\n\n  self.conn.dns.delete_recordet(recordset)","commit_id":"0e57e032785ea558be28d338a27be505c05cad31"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"bf8d17bf4a38da7b25f14c9cd13f5b5d5f0be1d3","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                changed \u003d True"},{"line_number":235,"context_line":"            self.exit_json(changed\u003dchanged, recordset\u003drecordset)"},{"line_number":236,"context_line":"        elif state \u003d\u003d \u0027absent\u0027 and recordset is not None:"},{"line_number":237,"context_line":"            self.conn.delete_recordset(zone, recordset)"},{"line_number":238,"context_line":"            changed \u003d True"},{"line_number":239,"context_line":"        self.exit_json(changed\u003dchanged)"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"79b76c12_03e88717","line":237,"in_reply_to":"effb2af3_788d5d15","updated":"2022-05-31 07:45:00.000000000","message":"Done","commit_id":"0e57e032785ea558be28d338a27be505c05cad31"}]}