)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"2cc52bb24594bd2c2e6c8b3412d2094b6248c021","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"cfe68533_67005468","updated":"2022-06-29 12:44:35.000000000","message":"Solid refactoring, Rafael :)\n\nDid a couple of changes to the patch:\n- rebased it on top of master\n- added assertions on return values\n- added return value docs\n- added more non-updateable params\n- moved up check for mutual exclusive params to fail early\n- added filter for subnet_pool_id when searching for a subnet since we have an subnet_pool param\n- added missing self.exit_json call\n- fixed indentation in options doc\n","commit_id":"dc5b770b89ca3047171de3a7f9bad2171cf7d9d3"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"3d58c1bfe93045dc1a73418e4ef1f6c91a3ed21e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"a12d4d73_0deb0292","updated":"2022-06-29 13:06:14.000000000","message":"Thanks for the improvements, looks ready now.","commit_id":"aa19d74cde10c9d1a3ad96e873494ba131eedf48"}],"plugins/modules/subnet.py":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"6efda42dbfff207f90fafe6f7d114a1da37f81c7","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            self.fail_json(msg\u003d\u0027no_gateway_ip is not allowed with gateway_ip\u0027)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        if network:"},{"line_number":318,"context_line":"            filters[\u0027network_id\u0027] \u003d network.id"},{"line_number":319,"context_line":"        subnet \u003d self.conn.network.find_subnet(subnet_name, **filters)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        if self.ansible.check_mode:"}],"source_content_type":"text/x-python","patch_set":7,"id":"d3950432_224b0905","line":318,"updated":"2022-06-09 07:36:46.000000000","message":"You can move this filters[\u0027network_id\u0027] \u003d network.id up when you check if network is not null","commit_id":"7131cb273ff311ac215224a5c1b2ee66a902c5bf"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"aa5bad0e7f2b2327ad2bf938797cfec751953c69","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            self.fail_json(msg\u003d\u0027no_gateway_ip is not allowed with gateway_ip\u0027)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        if network:"},{"line_number":318,"context_line":"            filters[\u0027network_id\u0027] \u003d network.id"},{"line_number":319,"context_line":"        subnet \u003d self.conn.network.find_subnet(subnet_name, **filters)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        if self.ansible.check_mode:"}],"source_content_type":"text/x-python","patch_set":7,"id":"eebd16c2_1dca476a","line":318,"in_reply_to":"d3950432_224b0905","updated":"2022-06-09 16:48:13.000000000","message":"The reason I had it this way was to use filters in the subnet_pool lookup (subnet_pool doesn\u0027t have a network_id), which was very subtle. I\u0027ve implemented the change you suggested and made that case more explicit.","commit_id":"7131cb273ff311ac215224a5c1b2ee66a902c5bf"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"3d58c1bfe93045dc1a73418e4ef1f6c91a3ed21e","unresolved":true,"context_lines":[{"line_number":409,"context_line":"        disable_gateway_ip \u003d self.params[\u0027disable_gateway_ip\u0027]"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        # fail early if incompatible options have been specified"},{"line_number":412,"context_line":"        if disable_gateway_ip and gateway_ip:"},{"line_number":413,"context_line":"            self.fail_json(msg\u003d\u0027no_gateway_ip is not allowed with gateway_ip\u0027)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        subnet_pool_filters \u003d {}"}],"source_content_type":"text/x-python","patch_set":21,"id":"53103f6a_caece515","line":412,"updated":"2022-06-29 13:06:14.000000000","message":"wondering if can this be done above in mutually_exclusive?","commit_id":"aa19d74cde10c9d1a3ad96e873494ba131eedf48"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"594d0c3183786b52bd811efc5733f66ed2cc227b","unresolved":true,"context_lines":[{"line_number":409,"context_line":"        disable_gateway_ip \u003d self.params[\u0027disable_gateway_ip\u0027]"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        # fail early if incompatible options have been specified"},{"line_number":412,"context_line":"        if disable_gateway_ip and gateway_ip:"},{"line_number":413,"context_line":"            self.fail_json(msg\u003d\u0027no_gateway_ip is not allowed with gateway_ip\u0027)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        subnet_pool_filters \u003d {}"}],"source_content_type":"text/x-python","patch_set":21,"id":"2dc22a21_865bcc4d","line":412,"in_reply_to":"53103f6a_caece515","updated":"2022-06-29 13:25:53.000000000","message":"Was wondering the same but i could not find out how to say\n\n  required_not_if((\u0027disable_gateway_ip\u0027, True, (\u0027gateway_ip\u0027)))\n  \nhttps://docs.ansible.com/ansible/latest/dev_guide/developing_program_flow_modules.html#argument-spec-dependencies","commit_id":"aa19d74cde10c9d1a3ad96e873494ba131eedf48"}]}