)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"796d965be21ab1cc6d2029f8fa95253d8c0ebf12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f9682ed4_0902354a","updated":"2022-06-14 16:57:06.000000000","message":"recheck","commit_id":"9dfbd209fdc3aae760ea4ea3166c24d643c0865b"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c31e5a9750e8dd7a3171c052b6d83686c2681f2c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c7765634_7989f134","updated":"2022-06-28 08:28:11.000000000","message":"Great work, Rafael! ☺️\n\nRebased and made two major changes by deprecating the is_public and volume attributes. What do you think?","commit_id":"b6c850d87252a879aab39a9295b1a14d5f7587cf"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"b095f45e8ba7edd5a5c9b8a527474839507deba9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3333c4d5_b08683a9","in_reply_to":"1686bf7f_cd73d998","updated":"2022-06-28 13:15:13.000000000","message":"\u003e Rebased and made two major changes by deprecating the is_public and volume attributes. What do you think?\n\nLGTM, thanks for the improvements.\n\n\u003e CI fails because module claims that image properties have changed although nothing should have changed:\n\nSeems this test was flaky because of the way we compared existing and updated tags. I\u0027ve pushed a fix.","commit_id":"b6c850d87252a879aab39a9295b1a14d5f7587cf"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"b7b44afc043096f827cad3d9a54c54facbae6c02","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f05c432c_169ca3b9","in_reply_to":"3333c4d5_b08683a9","updated":"2022-06-28 13:47:58.000000000","message":"Oops, seems we ran into a bit of a race condition.","commit_id":"b6c850d87252a879aab39a9295b1a14d5f7587cf"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"0fcc495b3165fa2c44f4d66fa3a0619dbbeb1813","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1686bf7f_cd73d998","in_reply_to":"c7765634_7989f134","updated":"2022-06-28 13:06:45.000000000","message":"CI fails because module claims that image properties have changed although nothing should have changed:\n\n2022-06-28 09:14:55.390165 | controller | TASK [image : Assert not changed] **********************************************\n2022-06-28 09:14:55.390193 | controller | task path: /home/zuul/src/opendev.org/openstack/ansible-collections-openstack/ci/roles/image/tasks/main.yml:55\n2022-06-28 09:14:55.422890 | controller | fatal: [localhost]: FAILED! \u003d\u003e {\n2022-06-28 09:14:55.422948 | controller |     \"assertion\": \"returned_image is not changed\",\n2022-06-28 09:14:55.422957 | controller |     \"changed\": false,\n2022-06-28 09:14:55.422962 | controller |     \"evaluated_to\": false,\n2022-06-28 09:14:55.422969 | controller |     \"msg\": \"Assertion failed\"\n2022-06-28 09:14:55.422974 | controller | }\n\nhttps://84c4bb7bd1265164198b-42fc6638fcd24f6173e405ab5e176652.ssl.cf2.rackcdn.com/845304/8/check/ansible-collections-openstack-functional-devstack/c76cace/job-output.txt","commit_id":"b6c850d87252a879aab39a9295b1a14d5f7587cf"}],"plugins/modules/image.py":[{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"b7b44afc043096f827cad3d9a54c54facbae6c02","unresolved":true,"context_lines":[{"line_number":550,"context_line":"                                   image\u003dself._return_value(image.id),"},{"line_number":551,"context_line":"                                   id\u003dimage.id)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"            # TODO: pass only updated properties"},{"line_number":554,"context_line":"            if self.conn.image.update_image_properties("},{"line_number":555,"context_line":"                    image\u003dimage,"},{"line_number":556,"context_line":"                    kernel\u003dself.params[\u0027kernel\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"8a6df14c_d913172d","line":553,"updated":"2022-06-28 13:47:58.000000000","message":"Not really necessary as curiously, update_image_properties checks for attr diffs. Kinda weird and inconsistent, but it\u0027s a thing.","commit_id":"5a871c6a461bc3612a6c9a3939878953605dcea5"}]}