)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"d4e4e0fbe9134cefcdf944733bce8c9bcd5eb72c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d20f9d7e_9b817a4b","updated":"2022-08-04 14:19:29.000000000","message":"LGTM. Just one small suggestion","commit_id":"73191f76df4eeba84c8925faf01825a4a2847b57"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"cf364858_6bd51aa6","updated":"2022-08-05 09:17:52.000000000","message":"Thanks, Arx! Added some comments ;) Please also look at old comments.","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"e71bac8e36738da9f6a6ff8a1f536e960ffbc215","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"4f32f505_bc3e767b","updated":"2022-08-08 10:02:32.000000000","message":"Thanks for the changes, Arx! Once CI has passed, it is ready for mergingggggggggg 😊\n\nRebased the patch and applied two cosmetic changes to docs.","commit_id":"ce6193cd2f8a85614fc117bc7c8d3b17c8d25cd3"}],"ci/roles/keystone_idp/tasks/main.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6dd8779c5c7cf0d2643d54683ca905b4e9718a13","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        name: \u0027{{ idp_name }}\u0027"},{"line_number":62,"context_line":"      register: identity_provider_info"},{"line_number":63,"context_line":"      ignore_errors: yes"},{"line_number":64,"context_line":"    - assert:"},{"line_number":65,"context_line":"        that:"},{"line_number":66,"context_line":"        - identity_provider_info is failed"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    - name: \u0027Create IDP\u0027"},{"line_number":69,"context_line":"      openstack.cloud.federation_idp:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"4747f733_8ee5646f","line":66,"range":{"start_line":64,"start_character":0,"end_line":66,"end_character":42},"updated":"2022-08-04 14:57:54.000000000","message":"With new logic you need to fix this test. It should not fail, but return empty values.","commit_id":"73191f76df4eeba84c8925faf01825a4a2847b57"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        name: \u0027{{ idp_name }}\u0027"},{"line_number":62,"context_line":"      register: identity_provider_info"},{"line_number":63,"context_line":"      ignore_errors: yes"},{"line_number":64,"context_line":"    - assert:"},{"line_number":65,"context_line":"        that:"},{"line_number":66,"context_line":"        - identity_provider_info is failed"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    - name: \u0027Create IDP\u0027"},{"line_number":69,"context_line":"      openstack.cloud.federation_idp:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"e9de65ce_d7810ffb","line":66,"range":{"start_line":64,"start_character":0,"end_line":66,"end_character":42},"in_reply_to":"4747f733_8ee5646f","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"73191f76df4eeba84c8925faf01825a4a2847b57"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":60,"context_line":"      openstack.cloud.federation_idp_info:"},{"line_number":61,"context_line":"        name: \u0027{{ idp_name }}\u0027"},{"line_number":62,"context_line":"      register: identity_provider_info"},{"line_number":63,"context_line":"      ignore_errors: yes"},{"line_number":64,"context_line":"    - assert:"},{"line_number":65,"context_line":"        that:"},{"line_number":66,"context_line":"        - identity_provider_info.identity_providers | length \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"17fc43ee_7b3e06c5","line":63,"updated":"2022-08-05 09:17:52.000000000","message":"Please drop.","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      openstack.cloud.federation_idp_info:"},{"line_number":61,"context_line":"        name: \u0027{{ idp_name }}\u0027"},{"line_number":62,"context_line":"      register: identity_provider_info"},{"line_number":63,"context_line":"      ignore_errors: yes"},{"line_number":64,"context_line":"    - assert:"},{"line_number":65,"context_line":"        that:"},{"line_number":66,"context_line":"        - identity_provider_info.identity_providers | length \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"b742c310_77112c07","line":63,"in_reply_to":"17fc43ee_7b3e06c5","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":97,"context_line":"      register: identity_provider_info"},{"line_number":98,"context_line":"    - assert:"},{"line_number":99,"context_line":"        that:"},{"line_number":100,"context_line":"        - identity_provider_info is successful"},{"line_number":101,"context_line":"        - \u0027\"identity_providers\" in identity_provider_info\u0027"},{"line_number":102,"context_line":"        - idps | length \u003d\u003d 1"},{"line_number":103,"context_line":"        - \u0027\"id\" in idp\u0027"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"93588645_aac52049","line":100,"updated":"2022-08-05 09:17:52.000000000","message":"Please drop, not required.","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"      register: identity_provider_info"},{"line_number":98,"context_line":"    - assert:"},{"line_number":99,"context_line":"        that:"},{"line_number":100,"context_line":"        - identity_provider_info is successful"},{"line_number":101,"context_line":"        - \u0027\"identity_providers\" in identity_provider_info\u0027"},{"line_number":102,"context_line":"        - idps | length \u003d\u003d 1"},{"line_number":103,"context_line":"        - \u0027\"id\" in idp\u0027"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"f080ea9e_88d9ddad","line":100,"in_reply_to":"93588645_aac52049","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":100,"context_line":"        - identity_provider_info is successful"},{"line_number":101,"context_line":"        - \u0027\"identity_providers\" in identity_provider_info\u0027"},{"line_number":102,"context_line":"        - idps | length \u003d\u003d 1"},{"line_number":103,"context_line":"        - \u0027\"id\" in idp\u0027"},{"line_number":104,"context_line":"        - \u0027\"name\" in idp\u0027"},{"line_number":105,"context_line":"        - \u0027\"domain_id\" in idp\u0027"},{"line_number":106,"context_line":"        - \u0027\"description\" in idp\u0027"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"2c23d67d_11579c6d","line":103,"updated":"2022-08-05 09:17:52.000000000","message":"Please replace with our usual way of asserting module results. For example:\n\nhttps://opendev.org/openstack/ansible-collections-openstack/src/commit/fdc67892e339cb0021df0458ccc8b593c46bd39c/ci/roles/router/tasks/main.yml#L63","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        - identity_provider_info is successful"},{"line_number":101,"context_line":"        - \u0027\"identity_providers\" in identity_provider_info\u0027"},{"line_number":102,"context_line":"        - idps | length \u003d\u003d 1"},{"line_number":103,"context_line":"        - \u0027\"id\" in idp\u0027"},{"line_number":104,"context_line":"        - \u0027\"name\" in idp\u0027"},{"line_number":105,"context_line":"        - \u0027\"domain_id\" in idp\u0027"},{"line_number":106,"context_line":"        - \u0027\"description\" in idp\u0027"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"f5dbb7ba_20a76377","line":103,"in_reply_to":"2c23d67d_11579c6d","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":121,"context_line":"      register: identity_provider_info"},{"line_number":122,"context_line":"    - assert:"},{"line_number":123,"context_line":"        that:"},{"line_number":124,"context_line":"        - identity_provider_info is successful"},{"line_number":125,"context_line":"        - \u0027\"identity_providers\" in identity_provider_info\u0027"},{"line_number":126,"context_line":"        # In CI we generally have a clean slate, but this might"},{"line_number":127,"context_line":"        # not be true for everyone..."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"69dfa54c_2c73e006","line":124,"updated":"2022-08-05 09:17:52.000000000","message":"Please drop, not required.","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"      register: identity_provider_info"},{"line_number":122,"context_line":"    - assert:"},{"line_number":123,"context_line":"        that:"},{"line_number":124,"context_line":"        - identity_provider_info is successful"},{"line_number":125,"context_line":"        - \u0027\"identity_providers\" in identity_provider_info\u0027"},{"line_number":126,"context_line":"        # In CI we generally have a clean slate, but this might"},{"line_number":127,"context_line":"        # not be true for everyone..."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ddcaab17_c45da3de","line":124,"in_reply_to":"69dfa54c_2c73e006","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"      register: identity_provider_info"},{"line_number":122,"context_line":"    - assert:"},{"line_number":123,"context_line":"        that:"},{"line_number":124,"context_line":"        - identity_provider_info is successful"},{"line_number":125,"context_line":"        - \u0027\"identity_providers\" in identity_provider_info\u0027"},{"line_number":126,"context_line":"        # In CI we generally have a clean slate, but this might"},{"line_number":127,"context_line":"        # not be true for everyone..."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"e4742879_8fa7c897","line":124,"in_reply_to":"69dfa54c_2c73e006","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":126,"context_line":"        # In CI we generally have a clean slate, but this might"},{"line_number":127,"context_line":"        # not be true for everyone..."},{"line_number":128,"context_line":"        - idps | length \u003e\u003d 1"},{"line_number":129,"context_line":"        - \u0027\"id\" in idp\u0027"},{"line_number":130,"context_line":"        - \u0027\"name\" in idp\u0027"},{"line_number":131,"context_line":"        - \u0027\"domain_id\" in idp\u0027"},{"line_number":132,"context_line":"        - \u0027\"description\" in idp\u0027"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"78b469f3_58343a09","line":129,"updated":"2022-08-05 09:17:52.000000000","message":"Please replace with our usual way of asserting module results (see above). Maybe not required since we already tested that above.","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        # In CI we generally have a clean slate, but this might"},{"line_number":127,"context_line":"        # not be true for everyone..."},{"line_number":128,"context_line":"        - idps | length \u003e\u003d 1"},{"line_number":129,"context_line":"        - \u0027\"id\" in idp\u0027"},{"line_number":130,"context_line":"        - \u0027\"name\" in idp\u0027"},{"line_number":131,"context_line":"        - \u0027\"domain_id\" in idp\u0027"},{"line_number":132,"context_line":"        - \u0027\"description\" in idp\u0027"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"edaf5ad2_e2c5e714","line":129,"in_reply_to":"78b469f3_58343a09","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":629,"context_line":"      register: identity_provider_info"},{"line_number":630,"context_line":"    - assert:"},{"line_number":631,"context_line":"        that:"},{"line_number":632,"context_line":"        - identity_provider_info is successful"},{"line_number":633,"context_line":"        - \u0027\"identity_providers\" in identity_provider_info\u0027"},{"line_number":634,"context_line":"        - identity_provider_info.identity_providers | length \u003d\u003d 1"},{"line_number":635,"context_line":"        - \u0027\"id\" in idp\u0027"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"e40e8c2a_b49f613a","line":632,"updated":"2022-08-05 09:17:52.000000000","message":"Please drop, not required.","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":629,"context_line":"      register: identity_provider_info"},{"line_number":630,"context_line":"    - assert:"},{"line_number":631,"context_line":"        that:"},{"line_number":632,"context_line":"        - identity_provider_info is successful"},{"line_number":633,"context_line":"        - \u0027\"identity_providers\" in identity_provider_info\u0027"},{"line_number":634,"context_line":"        - identity_provider_info.identity_providers | length \u003d\u003d 1"},{"line_number":635,"context_line":"        - \u0027\"id\" in idp\u0027"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bd958e11_37240100","line":632,"in_reply_to":"e40e8c2a_b49f613a","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":632,"context_line":"        - identity_provider_info is successful"},{"line_number":633,"context_line":"        - \u0027\"identity_providers\" in identity_provider_info\u0027"},{"line_number":634,"context_line":"        - identity_provider_info.identity_providers | length \u003d\u003d 1"},{"line_number":635,"context_line":"        - \u0027\"id\" in idp\u0027"},{"line_number":636,"context_line":"        - \u0027\"name\" in idp\u0027"},{"line_number":637,"context_line":"        - \u0027\"domain_id\" in idp\u0027"},{"line_number":638,"context_line":"        - \u0027\"description\" in idp\u0027"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"79c34538_6f71249e","line":635,"updated":"2022-08-05 09:17:52.000000000","message":"Please replace with our usual way of asserting module results (see above). Maybe not required since we already tested that above.","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        - identity_provider_info is successful"},{"line_number":633,"context_line":"        - \u0027\"identity_providers\" in identity_provider_info\u0027"},{"line_number":634,"context_line":"        - identity_provider_info.identity_providers | length \u003d\u003d 1"},{"line_number":635,"context_line":"        - \u0027\"id\" in idp\u0027"},{"line_number":636,"context_line":"        - \u0027\"name\" in idp\u0027"},{"line_number":637,"context_line":"        - \u0027\"domain_id\" in idp\u0027"},{"line_number":638,"context_line":"        - \u0027\"description\" in idp\u0027"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"53680dbc_61866dec","line":635,"in_reply_to":"79c34538_6f71249e","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":653,"context_line":"      register: identity_provider_info"},{"line_number":654,"context_line":"    - assert:"},{"line_number":655,"context_line":"        that:"},{"line_number":656,"context_line":"        - identity_provider_info is successful"},{"line_number":657,"context_line":"        - \u0027\"identity_providers\" in identity_provider_info\u0027"},{"line_number":658,"context_line":"        # In CI we generally have a clean slate, but this might"},{"line_number":659,"context_line":"        # not be true for everyone..."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"24605b88_77679b4e","line":656,"updated":"2022-08-05 09:17:52.000000000","message":"Please drop, not required.","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":653,"context_line":"      register: identity_provider_info"},{"line_number":654,"context_line":"    - assert:"},{"line_number":655,"context_line":"        that:"},{"line_number":656,"context_line":"        - identity_provider_info is successful"},{"line_number":657,"context_line":"        - \u0027\"identity_providers\" in identity_provider_info\u0027"},{"line_number":658,"context_line":"        # In CI we generally have a clean slate, but this might"},{"line_number":659,"context_line":"        # not be true for everyone..."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"c0a9b818_f24fd7f7","line":656,"in_reply_to":"24605b88_77679b4e","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":658,"context_line":"        # In CI we generally have a clean slate, but this might"},{"line_number":659,"context_line":"        # not be true for everyone..."},{"line_number":660,"context_line":"        - identity_provider_info.identity_providers | length \u003e\u003d 2"},{"line_number":661,"context_line":"        - \u0027\"id\" in idp_0\u0027"},{"line_number":662,"context_line":"        - \u0027\"name\" in idp_0\u0027"},{"line_number":663,"context_line":"        - \u0027\"domain_id\" in idp_0\u0027"},{"line_number":664,"context_line":"        - \u0027\"description\" in idp_0\u0027"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"0a0ab65d_5a0dcc29","line":661,"updated":"2022-08-05 09:17:52.000000000","message":"Please replace with our usual way of asserting module results (see above). Maybe not required since we already tested that above.","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":658,"context_line":"        # In CI we generally have a clean slate, but this might"},{"line_number":659,"context_line":"        # not be true for everyone..."},{"line_number":660,"context_line":"        - identity_provider_info.identity_providers | length \u003e\u003d 2"},{"line_number":661,"context_line":"        - \u0027\"id\" in idp_0\u0027"},{"line_number":662,"context_line":"        - \u0027\"name\" in idp_0\u0027"},{"line_number":663,"context_line":"        - \u0027\"domain_id\" in idp_0\u0027"},{"line_number":664,"context_line":"        - \u0027\"description\" in idp_0\u0027"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"5e7c9b98_95220665","line":661,"in_reply_to":"0a0ab65d_5a0dcc29","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":731,"context_line":"      openstack.cloud.federation_idp_info:"},{"line_number":732,"context_line":"        name: \u0027{{ idp_name }}\u0027"},{"line_number":733,"context_line":"      register: identity_provider_info"},{"line_number":734,"context_line":"      ignore_errors: True"},{"line_number":735,"context_line":"    - assert:"},{"line_number":736,"context_line":"        that:"},{"line_number":737,"context_line":"        - identity_provider_info.identity_providers | length \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"b575106e_9c6ec176","line":734,"updated":"2022-08-05 09:17:52.000000000","message":"Please drop.","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":731,"context_line":"      openstack.cloud.federation_idp_info:"},{"line_number":732,"context_line":"        name: \u0027{{ idp_name }}\u0027"},{"line_number":733,"context_line":"      register: identity_provider_info"},{"line_number":734,"context_line":"      ignore_errors: True"},{"line_number":735,"context_line":"    - assert:"},{"line_number":736,"context_line":"        that:"},{"line_number":737,"context_line":"        - identity_provider_info.identity_providers | length \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ddf52a4e_977ef3cc","line":734,"in_reply_to":"b575106e_9c6ec176","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"}],"plugins/modules/federation_idp_info.py":[{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"d6aa60acd72f1a5b8231e130c5d149abbdde1080","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        supports_check_mode\u003dTrue"},{"line_number":51,"context_line":"    )"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def normalize_idp(self, idp):"},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        Normalizes the IDP definitions so that the outputs are consistent with the"},{"line_number":56,"context_line":"        parameters"}],"source_content_type":"text/x-python","patch_set":2,"id":"546e9e23_30757c58","line":53,"updated":"2022-07-14 13:41:14.000000000","message":"We should delete this if we\u0027re not going to use it anymore.","commit_id":"a735055088c6264da5b13bec7c02bce429f4f150"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"d05d318a5f3cc3daca2dbcb0f71951a5eebaafad","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        supports_check_mode\u003dTrue"},{"line_number":51,"context_line":"    )"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def normalize_idp(self, idp):"},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        Normalizes the IDP definitions so that the outputs are consistent with the"},{"line_number":56,"context_line":"        parameters"}],"source_content_type":"text/x-python","patch_set":2,"id":"03f8f3f7_c0335ddb","line":53,"in_reply_to":"546e9e23_30757c58","updated":"2022-08-04 15:14:26.000000000","message":"Done","commit_id":"a735055088c6264da5b13bec7c02bce429f4f150"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c69b1ee236debf7838bbed6d3741283fa3c18c95","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        name \u003d self.params.get(\u0027name\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if name:"},{"line_number":61,"context_line":"            idp \u003d self.conn.identity.get_identity_provider(name)"},{"line_number":62,"context_line":"            idp \u003d idp.to_dict(computed\u003dFalse)"},{"line_number":63,"context_line":"            self.exit_json(changed\u003dFalse, identity_providers\u003d[idp])"},{"line_number":64,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"185e07f1_62b0ed26","line":61,"range":{"start_line":61,"start_character":37,"end_line":61,"end_character":58},"updated":"2022-08-04 10:56:26.000000000","message":"better to use find_identity_provider: https://github.com/openstack/openstacksdk/blob/d4e13ba34ab45b6865f2b0e1da2fb76dac03e2d4/openstack/identity/v3/_proxy.py#L1830\nIt won\u0027t throw exception if not found, just returns an empty list.","commit_id":"b9f6c0af27ca59ef0befde93410bc27dcb4f88b3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        name \u003d self.params.get(\u0027name\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if name:"},{"line_number":61,"context_line":"            idp \u003d self.conn.identity.get_identity_provider(name)"},{"line_number":62,"context_line":"            idp \u003d idp.to_dict(computed\u003dFalse)"},{"line_number":63,"context_line":"            self.exit_json(changed\u003dFalse, identity_providers\u003d[idp])"},{"line_number":64,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"cf6aa83f_a3e5d201","line":61,"range":{"start_line":61,"start_character":37,"end_line":61,"end_character":58},"in_reply_to":"185e07f1_62b0ed26","updated":"2022-08-05 09:17:52.000000000","message":"No need to create a branch if name is given. We can simply use identity.identity_providers() for both cases, where a name is given and where no name is given. In the former case, just pass it as a query argument [1], [2].\n\n[1] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/identity/v3/_proxy.py#L1862\n[2] https://opendev.org/openstack/openstacksdk/src/commit/3f81d0001dd994cde990d38f6e2671ee0694d7d5/openstack/identity/v3/identity_provider.py#L48","commit_id":"b9f6c0af27ca59ef0befde93410bc27dcb4f88b3"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        name \u003d self.params.get(\u0027name\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if name:"},{"line_number":61,"context_line":"            idp \u003d self.conn.identity.get_identity_provider(name)"},{"line_number":62,"context_line":"            idp \u003d idp.to_dict(computed\u003dFalse)"},{"line_number":63,"context_line":"            self.exit_json(changed\u003dFalse, identity_providers\u003d[idp])"},{"line_number":64,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"e61a6706_0312f45c","line":61,"range":{"start_line":61,"start_character":37,"end_line":61,"end_character":58},"in_reply_to":"cf6aa83f_a3e5d201","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"b9f6c0af27ca59ef0befde93410bc27dcb4f88b3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c69b1ee236debf7838bbed6d3741283fa3c18c95","unresolved":true,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if name:"},{"line_number":61,"context_line":"            idp \u003d self.conn.identity.get_identity_provider(name)"},{"line_number":62,"context_line":"            idp \u003d idp.to_dict(computed\u003dFalse)"},{"line_number":63,"context_line":"            self.exit_json(changed\u003dFalse, identity_providers\u003d[idp])"},{"line_number":64,"context_line":"        else:"},{"line_number":65,"context_line":"            providers \u003d self.conn.identity.identity_providers()"}],"source_content_type":"text/x-python","patch_set":8,"id":"257a0f08_5b964adf","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":45},"updated":"2022-08-04 10:56:26.000000000","message":"and this should be changed accordingly, for find_identity_provider","commit_id":"b9f6c0af27ca59ef0befde93410bc27dcb4f88b3"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if name:"},{"line_number":61,"context_line":"            idp \u003d self.conn.identity.get_identity_provider(name)"},{"line_number":62,"context_line":"            idp \u003d idp.to_dict(computed\u003dFalse)"},{"line_number":63,"context_line":"            self.exit_json(changed\u003dFalse, identity_providers\u003d[idp])"},{"line_number":64,"context_line":"        else:"},{"line_number":65,"context_line":"            providers \u003d self.conn.identity.identity_providers()"}],"source_content_type":"text/x-python","patch_set":8,"id":"b581d8be_0c782b10","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":45},"in_reply_to":"257a0f08_5b964adf","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"b9f6c0af27ca59ef0befde93410bc27dcb4f88b3"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"d4e4e0fbe9134cefcdf944733bce8c9bcd5eb72c","unresolved":true,"context_lines":[{"line_number":42,"context_line":"identity_providers:"},{"line_number":43,"context_line":"    description: Dictionary describing the identity providers"},{"line_number":44,"context_line":"    returned: success"},{"line_number":45,"context_line":"    type: complex"},{"line_number":46,"context_line":"    contains:"},{"line_number":47,"context_line":"        description:"},{"line_number":48,"context_line":"            description: Identity provider description"}],"source_content_type":"text/x-python","patch_set":10,"id":"ecafe6b3_42ab67cb","line":45,"updated":"2022-08-04 14:19:29.000000000","message":"type: list\nelements: dict","commit_id":"73191f76df4eeba84c8925faf01825a4a2847b57"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"7fbc3ccad452a99a4b6adf3ab905d7a59637c56b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"identity_providers:"},{"line_number":43,"context_line":"    description: Dictionary describing the identity providers"},{"line_number":44,"context_line":"    returned: success"},{"line_number":45,"context_line":"    type: complex"},{"line_number":46,"context_line":"    contains:"},{"line_number":47,"context_line":"        description:"},{"line_number":48,"context_line":"            description: Identity provider description"}],"source_content_type":"text/x-python","patch_set":10,"id":"52cb39a7_03c5cfd5","line":45,"in_reply_to":"ecafe6b3_42ab67cb","updated":"2022-08-04 15:17:58.000000000","message":"Done","commit_id":"73191f76df4eeba84c8925faf01825a4a2847b57"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3665a17b5aab6d4888ab6f899e4fc90206046443","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if name:"},{"line_number":84,"context_line":"            idp \u003d self.conn.identity.find_identity_provider(name)"},{"line_number":85,"context_line":"            if idp:"},{"line_number":86,"context_line":"                idp \u003d idp.to_dict(computed\u003dFalse)"},{"line_number":87,"context_line":"            self.exit_json(changed\u003dFalse, identity_providers\u003d[idp])"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            providers \u003d self.conn.identity.identity_providers()"}],"source_content_type":"text/x-python","patch_set":10,"id":"d6445272_0762fa1d","line":86,"range":{"start_line":85,"start_character":12,"end_line":86,"end_character":49},"updated":"2022-08-04 14:59:23.000000000","message":"if not, just return empty:\n\n  else:\n    self.exit_json(changed\u003dFalse, identity_providers\u003d[])","commit_id":"73191f76df4eeba84c8925faf01825a4a2847b57"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"7fbc3ccad452a99a4b6adf3ab905d7a59637c56b","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if name:"},{"line_number":84,"context_line":"            idp \u003d self.conn.identity.find_identity_provider(name)"},{"line_number":85,"context_line":"            if idp:"},{"line_number":86,"context_line":"                idp \u003d idp.to_dict(computed\u003dFalse)"},{"line_number":87,"context_line":"            self.exit_json(changed\u003dFalse, identity_providers\u003d[idp])"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            providers \u003d self.conn.identity.identity_providers()"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa95b171_116078b2","line":86,"range":{"start_line":85,"start_character":12,"end_line":86,"end_character":49},"in_reply_to":"d6445272_0762fa1d","updated":"2022-08-04 15:17:58.000000000","message":"Done","commit_id":"73191f76df4eeba84c8925faf01825a4a2847b57"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3665a17b5aab6d4888ab6f899e4fc90206046443","unresolved":true,"context_lines":[{"line_number":84,"context_line":"            idp \u003d self.conn.identity.find_identity_provider(name)"},{"line_number":85,"context_line":"            if idp:"},{"line_number":86,"context_line":"                idp \u003d idp.to_dict(computed\u003dFalse)"},{"line_number":87,"context_line":"            self.exit_json(changed\u003dFalse, identity_providers\u003d[idp])"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            providers \u003d self.conn.identity.identity_providers()"},{"line_number":90,"context_line":"            providers \u003d [p.to_dict(computed\u003dFalse) for p in providers]"}],"source_content_type":"text/x-python","patch_set":10,"id":"b4f3fe28_b5094043","line":87,"range":{"start_line":87,"start_character":61,"end_line":87,"end_character":66},"updated":"2022-08-04 14:59:23.000000000","message":"In case of not finding, it will be wrong","commit_id":"73191f76df4eeba84c8925faf01825a4a2847b57"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"7fbc3ccad452a99a4b6adf3ab905d7a59637c56b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            idp \u003d self.conn.identity.find_identity_provider(name)"},{"line_number":85,"context_line":"            if idp:"},{"line_number":86,"context_line":"                idp \u003d idp.to_dict(computed\u003dFalse)"},{"line_number":87,"context_line":"            self.exit_json(changed\u003dFalse, identity_providers\u003d[idp])"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            providers \u003d self.conn.identity.identity_providers()"},{"line_number":90,"context_line":"            providers \u003d [p.to_dict(computed\u003dFalse) for p in providers]"}],"source_content_type":"text/x-python","patch_set":10,"id":"f62ede3e_2a47e9e3","line":87,"range":{"start_line":87,"start_character":61,"end_line":87,"end_character":66},"in_reply_to":"b4f3fe28_b5094043","updated":"2022-08-04 15:17:58.000000000","message":"Done","commit_id":"73191f76df4eeba84c8925faf01825a4a2847b57"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":11,"context_line":"                   providers"},{"line_number":12,"context_line":"author: OpenStack Ansible SIG"},{"line_number":13,"context_line":"description:"},{"line_number":14,"context_line":"  - Fetch a federation identity provider."},{"line_number":15,"context_line":"options:"},{"line_number":16,"context_line":"  name:"},{"line_number":17,"context_line":"    description:"}],"source_content_type":"text/x-python","patch_set":16,"id":"29cc13af_86bc27df","line":14,"updated":"2022-08-05 09:17:52.000000000","message":"nit: Please rephrase to e.g.:\n\n  Fetch available federation identity providers.\n  \nPoint here is that we can not only query for a single provider but multiple.","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"                   providers"},{"line_number":12,"context_line":"author: OpenStack Ansible SIG"},{"line_number":13,"context_line":"description:"},{"line_number":14,"context_line":"  - Fetch a federation identity provider."},{"line_number":15,"context_line":"options:"},{"line_number":16,"context_line":"  name:"},{"line_number":17,"context_line":"    description:"}],"source_content_type":"text/x-python","patch_set":16,"id":"ae2e1966_b5ef74d0","line":14,"in_reply_to":"29cc13af_86bc27df","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  name:"},{"line_number":17,"context_line":"    description:"},{"line_number":18,"context_line":"      - The name of the identity provider to fetch."},{"line_number":19,"context_line":"      - If I(name) is specified, the module will return failed if the identity"},{"line_number":20,"context_line":"        provider doesn\u0027t exist."},{"line_number":21,"context_line":"    type: str"},{"line_number":22,"context_line":"    aliases: [\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"9dc3f81f_f5b303a5","line":19,"updated":"2022-08-05 09:17:52.000000000","message":"Please drop.","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  name:"},{"line_number":17,"context_line":"    description:"},{"line_number":18,"context_line":"      - The name of the identity provider to fetch."},{"line_number":19,"context_line":"      - If I(name) is specified, the module will return failed if the identity"},{"line_number":20,"context_line":"        provider doesn\u0027t exist."},{"line_number":21,"context_line":"    type: str"},{"line_number":22,"context_line":"    aliases: [\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"958cfca7_7b004f3d","line":19,"in_reply_to":"9dc3f81f_f5b303a5","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    aliases: [\u0027id\u0027]"},{"line_number":23,"context_line":"requirements:"},{"line_number":24,"context_line":"  - \"python \u003e\u003d 3.6\""},{"line_number":25,"context_line":"  - \"openstacksdk \u003e\u003d 0.44\""},{"line_number":26,"context_line":"extends_documentation_fragment:"},{"line_number":27,"context_line":"  - openstack.cloud.openstack"},{"line_number":28,"context_line":"\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"871322f9_0ce00891","line":25,"updated":"2022-08-05 09:17:52.000000000","message":"Please replace with:\n\n  - \"openstacksdk\"","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    aliases: [\u0027id\u0027]"},{"line_number":23,"context_line":"requirements:"},{"line_number":24,"context_line":"  - \"python \u003e\u003d 3.6\""},{"line_number":25,"context_line":"  - \"openstacksdk \u003e\u003d 0.44\""},{"line_number":26,"context_line":"extends_documentation_fragment:"},{"line_number":27,"context_line":"  - openstack.cloud.openstack"},{"line_number":28,"context_line":"\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"c1e6759e_bdd67c6c","line":25,"in_reply_to":"871322f9_0ce00891","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    returned: success"},{"line_number":45,"context_line":"    type: list"},{"line_number":46,"context_line":"    elements: dict"},{"line_number":47,"context_line":"    contains:"},{"line_number":48,"context_line":"        description:"},{"line_number":49,"context_line":"            description: Identity provider description"},{"line_number":50,"context_line":"            type: str"}],"source_content_type":"text/x-python","patch_set":16,"id":"e95539a7_ba82c51a","line":47,"updated":"2022-08-05 09:17:52.000000000","message":"\u0027name\u0027 is missing:\n\nIn [45]: sorted(\n    ...:     openstack.identity.v3.identity_provider.IdentityProvider()\n    ...:     .to_dict(computed\u003dFalse)\n    ...:     .keys()\n    ...: )\nOut[45]: [\u0027description\u0027, \u0027domain_id\u0027, \u0027id\u0027, \u0027is_enabled\u0027, \u0027name\u0027, \u0027remote_ids\u0027]","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    returned: success"},{"line_number":45,"context_line":"    type: list"},{"line_number":46,"context_line":"    elements: dict"},{"line_number":47,"context_line":"    contains:"},{"line_number":48,"context_line":"        description:"},{"line_number":49,"context_line":"            description: Identity provider description"},{"line_number":50,"context_line":"            type: str"}],"source_content_type":"text/x-python","patch_set":16,"id":"1c4bc297_256fbd51","line":47,"in_reply_to":"e95539a7_ba82c51a","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cd894bde37319affeab43fc3cc83966f7dd40e69","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    def run(self):"},{"line_number":80,"context_line":"        \"\"\" Module entry point \"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        name \u003d self.params.get(\u0027name\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if name:"},{"line_number":85,"context_line":"            idp \u003d self.conn.identity.find_identity_provider(name)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ae9fae00_8d06f937","line":82,"updated":"2022-08-05 09:17:52.000000000","message":"nit: self.params[\u0027name\u0027] is enough.","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"cc2e5a89a98a8ace5f9a759d9c6ab01d7118606f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def run(self):"},{"line_number":80,"context_line":"        \"\"\" Module entry point \"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        name \u003d self.params.get(\u0027name\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if name:"},{"line_number":85,"context_line":"            idp \u003d self.conn.identity.find_identity_provider(name)"}],"source_content_type":"text/x-python","patch_set":16,"id":"a0fe3f47_83d33c98","line":82,"in_reply_to":"ae9fae00_8d06f937","updated":"2022-08-05 09:53:02.000000000","message":"Done","commit_id":"7381f208789b56465601f081f47d02fc73e9c80d"}]}