)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"18b924ace491a6d6efd64b3125d87579132c55c0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"95e8fb75_4e9a3a5e","updated":"2022-08-10 13:30:58.000000000","message":"Hey Arx, not sure if this is work in progress or ready for review.\n\nVoted -1 simply to mark this patch as \"requires more work\".\n\nSome thoughts:\n\n* Use Gerrit\u0027s work-in-progress feature to mark the status of the patch. A minus workflow (-w) will be reset when a new patchset is uploaded and hence easy to miss.\n\n* Version checks are no longer necessary since we globally require openstacksdk \u003e\u003d0.99.0 anyway.\n\n* When a id is given in XXX_info modules, then we do not need nor want extra code to handle that. Instead most openstacksdk resources allow to pass ids as query arguments to openstack api. For example, identity.identity_providers() can be used for both cases: Where an id is given and where no id is given. No need to call get_identity_provider().\n\n* self.params.get(\u0027...\u0027) can be replaced with self.params[\u0027...\u0027] because parameters from argument_spec will always be in self.params. If not defined differently, they have a default value of None.\n\n* Add assertions on module results\n\n* Function normalize_mapping() is obsolete and can be dropped.\n\n* Check description of module attribute \u0027name\u0027\n","commit_id":"7f5b4b093c9ca6c28d06c1da8edd0b9a86c00f10"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"7a8f8fe332eaca9684d99be20ae71b59e0f680f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a2afd995_2fee4a5b","in_reply_to":"95e8fb75_4e9a3a5e","updated":"2022-08-15 09:57:46.000000000","message":"In the case of get_mapping, the documentation states it will return one single mapping, also, i changed it to find_mapping. in case we don\u0027t pass the name/id, it should return the list of mappings, so calling mappings function.","commit_id":"7f5b4b093c9ca6c28d06c1da8edd0b9a86c00f10"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"cec08cd592d9271cb0555c9dc55412b4431cad48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5fbf64f2_9c536145","updated":"2022-08-23 14:58:33.000000000","message":"Looks good. Nit inside.","commit_id":"93f5b14b648111cc220231f203b8648f74d3baf5"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"a498cbc3e4087391951824ad582ef65c8d49a0b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f48ebdc3_552a0c74","updated":"2022-09-20 09:46:54.000000000","message":"Latest patchset fixes outstanding issues. Should be fine now, but lets wait for ci.","commit_id":"8f7c7a8a36f7e6a9b30cbfa9b168744bc7358c8e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c49b62e761d067dd2ced71dc63aa006ca5714549","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"b357bb18_540addb9","updated":"2022-09-20 12:21:33.000000000","message":"Great, keystone does not respect parameters when listing mappings [1] 😞 Had to revert to old behaviour...\n\n[1] https://review.opendev.org/c/openstack/openstacksdk/+/858522","commit_id":"056cd65b3d24f2274b0f565a29643bb5764894aa"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"424129d6956895797a036cc89b50a6c1ce8b7af7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7ea6b115_9754f436","updated":"2022-09-21 12:31:19.000000000","message":"Took me a while to understand why Arx used find_mapping instead of get_mapping.. XD because get_mapping throws an exception on non-existing resources which is not what we want here.","commit_id":"c0bc0b079624b847d90225a80a0ef20b6ee8dfa5"}],"ci/roles/keystone_mapping/defaults/main.yml":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"9a7071f3b1b276ffd21df145d02e9803874ddfe8","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    any_one_of:"},{"line_number":23,"context_line":"    - group1"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"mapping_info_expected_values:"},{"line_number":26,"context_line":"  - id"},{"line_number":27,"context_line":"  - name"},{"line_number":28,"context_line":"  - rules"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"cf7a26f4_052ecfae","line":25,"updated":"2022-09-06 09:03:53.000000000","message":"Rename to expected_fields which we try to use consistently across our modules. This will also \"allow\" us to reuse this field for checking return values of mapping calls.","commit_id":"93f5b14b648111cc220231f203b8648f74d3baf5"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"c5b2855d7afea76a7e9e9d1db975c942ba589303","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    any_one_of:"},{"line_number":23,"context_line":"    - group1"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"mapping_info_expected_values:"},{"line_number":26,"context_line":"  - id"},{"line_number":27,"context_line":"  - name"},{"line_number":28,"context_line":"  - rules"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ac41cd6d_c8c593a8","line":25,"in_reply_to":"cf7a26f4_052ecfae","updated":"2022-09-19 07:43:33.000000000","message":"Done","commit_id":"93f5b14b648111cc220231f203b8648f74d3baf5"}],"ci/roles/keystone_mapping/tasks/main.yml":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"9a7071f3b1b276ffd21df145d02e9803874ddfe8","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        - \u0027\"id\" in mapping_0\u0027"},{"line_number":87,"context_line":"        - \u0027\"name\" in mapping_0\u0027"},{"line_number":88,"context_line":"        - \u0027\"rules\" in mapping_0\u0027"},{"line_number":89,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":90,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"},{"line_number":91,"context_line":"      vars:"},{"line_number":92,"context_line":"        mapping_0: \u0027{{ mapping_info.mappings[0] }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf2d4844_c94b13f9","side":"PARENT","line":89,"updated":"2022-09-06 09:03:53.000000000","message":"Why did you drop this test and the next line?","commit_id":"d47cf4333c2a8cc5b57a2c01b30d3bac96f487ba"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"c5b2855d7afea76a7e9e9d1db975c942ba589303","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        - \u0027\"id\" in mapping_0\u0027"},{"line_number":87,"context_line":"        - \u0027\"name\" in mapping_0\u0027"},{"line_number":88,"context_line":"        - \u0027\"rules\" in mapping_0\u0027"},{"line_number":89,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":90,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"},{"line_number":91,"context_line":"      vars:"},{"line_number":92,"context_line":"        mapping_0: \u0027{{ mapping_info.mappings[0] }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"a9f7215b_1fe2a981","side":"PARENT","line":89,"in_reply_to":"3a21cc95_4cb54bcd","updated":"2022-09-19 07:43:33.000000000","message":"Done","commit_id":"d47cf4333c2a8cc5b57a2c01b30d3bac96f487ba"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8ad47e5dade5d7c48e484356a0a8c8abb267a312","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        - \u0027\"id\" in mapping_0\u0027"},{"line_number":87,"context_line":"        - \u0027\"name\" in mapping_0\u0027"},{"line_number":88,"context_line":"        - \u0027\"rules\" in mapping_0\u0027"},{"line_number":89,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":90,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"},{"line_number":91,"context_line":"      vars:"},{"line_number":92,"context_line":"        mapping_0: \u0027{{ mapping_info.mappings[0] }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ae09df09_f6f165ed","side":"PARENT","line":89,"in_reply_to":"a9f7215b_1fe2a981","updated":"2022-09-20 09:45:56.000000000","message":"The three lines before do check whether they are returned actually. \n\nBut the purpose of this line and the next line to check that id and name have the right value.\n\nSo please readd those lines.","commit_id":"d47cf4333c2a8cc5b57a2c01b30d3bac96f487ba"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"a498cbc3e4087391951824ad582ef65c8d49a0b8","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        - \u0027\"id\" in mapping_0\u0027"},{"line_number":87,"context_line":"        - \u0027\"name\" in mapping_0\u0027"},{"line_number":88,"context_line":"        - \u0027\"rules\" in mapping_0\u0027"},{"line_number":89,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":90,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"},{"line_number":91,"context_line":"      vars:"},{"line_number":92,"context_line":"        mapping_0: \u0027{{ mapping_info.mappings[0] }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"cdec9c6f_e380afd8","side":"PARENT","line":89,"in_reply_to":"ae09df09_f6f165ed","updated":"2022-09-20 09:46:54.000000000","message":"Done","commit_id":"d47cf4333c2a8cc5b57a2c01b30d3bac96f487ba"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"5bc7e7d52e5a30667b94003caba34f1502624db6","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        - \u0027\"id\" in mapping_0\u0027"},{"line_number":87,"context_line":"        - \u0027\"name\" in mapping_0\u0027"},{"line_number":88,"context_line":"        - \u0027\"rules\" in mapping_0\u0027"},{"line_number":89,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":90,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"},{"line_number":91,"context_line":"      vars:"},{"line_number":92,"context_line":"        mapping_0: \u0027{{ mapping_info.mappings[0] }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3a21cc95_4cb54bcd","side":"PARENT","line":89,"in_reply_to":"bf2d4844_c94b13f9","updated":"2022-09-12 09:08:22.000000000","message":"Because i added the Verify returned values task, so all of these are unnecessary","commit_id":"d47cf4333c2a8cc5b57a2c01b30d3bac96f487ba"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"9a7071f3b1b276ffd21df145d02e9803874ddfe8","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        - \u0027\"id\" in mapping_1\u0027"},{"line_number":218,"context_line":"        - \u0027\"name\" in mapping_1\u0027"},{"line_number":219,"context_line":"        - \u0027\"rules\" in mapping_1\u0027"},{"line_number":220,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":221,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"},{"line_number":222,"context_line":"        - mapping_name_2 in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":223,"context_line":"        - mapping_name_2 in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"32e24459_86552384","side":"PARENT","line":220,"updated":"2022-09-06 09:03:53.000000000","message":"Why did you drop this line and the next three?","commit_id":"d47cf4333c2a8cc5b57a2c01b30d3bac96f487ba"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"5bc7e7d52e5a30667b94003caba34f1502624db6","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        - \u0027\"id\" in mapping_1\u0027"},{"line_number":218,"context_line":"        - \u0027\"name\" in mapping_1\u0027"},{"line_number":219,"context_line":"        - \u0027\"rules\" in mapping_1\u0027"},{"line_number":220,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":221,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"},{"line_number":222,"context_line":"        - mapping_name_2 in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":223,"context_line":"        - mapping_name_2 in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf8d43a0_bd77a0e6","side":"PARENT","line":220,"in_reply_to":"32e24459_86552384","updated":"2022-09-12 09:08:22.000000000","message":"No longer required because we already have the check for required fields","commit_id":"d47cf4333c2a8cc5b57a2c01b30d3bac96f487ba"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"a498cbc3e4087391951824ad582ef65c8d49a0b8","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        - \u0027\"id\" in mapping_1\u0027"},{"line_number":218,"context_line":"        - \u0027\"name\" in mapping_1\u0027"},{"line_number":219,"context_line":"        - \u0027\"rules\" in mapping_1\u0027"},{"line_number":220,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":221,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"},{"line_number":222,"context_line":"        - mapping_name_2 in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":223,"context_line":"        - mapping_name_2 in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"e4746e30_58649871","side":"PARENT","line":220,"in_reply_to":"9ae153a0_757c03af","updated":"2022-09-20 09:46:54.000000000","message":"Done","commit_id":"d47cf4333c2a8cc5b57a2c01b30d3bac96f487ba"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"c5b2855d7afea76a7e9e9d1db975c942ba589303","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        - \u0027\"id\" in mapping_1\u0027"},{"line_number":218,"context_line":"        - \u0027\"name\" in mapping_1\u0027"},{"line_number":219,"context_line":"        - \u0027\"rules\" in mapping_1\u0027"},{"line_number":220,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":221,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"},{"line_number":222,"context_line":"        - mapping_name_2 in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":223,"context_line":"        - mapping_name_2 in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"c5a6f455_a3f1d7d3","side":"PARENT","line":220,"in_reply_to":"bf8d43a0_bd77a0e6","updated":"2022-09-19 07:43:33.000000000","message":"Done","commit_id":"d47cf4333c2a8cc5b57a2c01b30d3bac96f487ba"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8ad47e5dade5d7c48e484356a0a8c8abb267a312","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        - \u0027\"id\" in mapping_1\u0027"},{"line_number":218,"context_line":"        - \u0027\"name\" in mapping_1\u0027"},{"line_number":219,"context_line":"        - \u0027\"rules\" in mapping_1\u0027"},{"line_number":220,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":221,"context_line":"        - mapping_name in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"},{"line_number":222,"context_line":"        - mapping_name_2 in (mapping_info.mappings | map(attribute\u003d\u0027id\u0027))"},{"line_number":223,"context_line":"        - mapping_name_2 in (mapping_info.mappings | map(attribute\u003d\u0027name\u0027))"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9ae153a0_757c03af","side":"PARENT","line":220,"in_reply_to":"c5a6f455_a3f1d7d3","updated":"2022-09-20 09:45:56.000000000","message":"Same as above, please readd the mappings|map.. lines.","commit_id":"d47cf4333c2a8cc5b57a2c01b30d3bac96f487ba"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8ad47e5dade5d7c48e484356a0a8c8abb267a312","unresolved":true,"context_lines":[{"line_number":33,"context_line":"      openstack.cloud.federation_mapping_info:"},{"line_number":34,"context_line":"        name: \u0027{{ mapping_name }}\u0027"},{"line_number":35,"context_line":"      register: mapping_info"},{"line_number":36,"context_line":"      ignore_errors: yes"},{"line_number":37,"context_line":"    - assert:"},{"line_number":38,"context_line":"        that:"},{"line_number":39,"context_line":"        - mapping_info.mappings | length \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"8bcc5a21_524ec4a1","line":36,"updated":"2022-09-20 09:45:56.000000000","message":"please drop","commit_id":"8f7c7a8a36f7e6a9b30cbfa9b168744bc7358c8e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"a498cbc3e4087391951824ad582ef65c8d49a0b8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      openstack.cloud.federation_mapping_info:"},{"line_number":34,"context_line":"        name: \u0027{{ mapping_name }}\u0027"},{"line_number":35,"context_line":"      register: mapping_info"},{"line_number":36,"context_line":"      ignore_errors: yes"},{"line_number":37,"context_line":"    - assert:"},{"line_number":38,"context_line":"        that:"},{"line_number":39,"context_line":"        - mapping_info.mappings | length \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"65f30c05_adffdedc","line":36,"in_reply_to":"8bcc5a21_524ec4a1","updated":"2022-09-20 09:46:54.000000000","message":"Done","commit_id":"8f7c7a8a36f7e6a9b30cbfa9b168744bc7358c8e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8ad47e5dade5d7c48e484356a0a8c8abb267a312","unresolved":true,"context_lines":[{"line_number":241,"context_line":"      openstack.cloud.federation_mapping_info:"},{"line_number":242,"context_line":"        name: \u0027{{ mapping_name }}\u0027"},{"line_number":243,"context_line":"      register: mapping_info"},{"line_number":244,"context_line":"      ignore_errors: True"},{"line_number":245,"context_line":"    - assert:"},{"line_number":246,"context_line":"        that:"},{"line_number":247,"context_line":"        - mapping_info.mappings | length \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"6e16b9d3_8065f7ea","line":244,"updated":"2022-09-20 09:45:56.000000000","message":"please drop","commit_id":"8f7c7a8a36f7e6a9b30cbfa9b168744bc7358c8e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"a498cbc3e4087391951824ad582ef65c8d49a0b8","unresolved":false,"context_lines":[{"line_number":241,"context_line":"      openstack.cloud.federation_mapping_info:"},{"line_number":242,"context_line":"        name: \u0027{{ mapping_name }}\u0027"},{"line_number":243,"context_line":"      register: mapping_info"},{"line_number":244,"context_line":"      ignore_errors: True"},{"line_number":245,"context_line":"    - assert:"},{"line_number":246,"context_line":"        that:"},{"line_number":247,"context_line":"        - mapping_info.mappings | length \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"f8bada54_115c91b3","line":244,"in_reply_to":"6e16b9d3_8065f7ea","updated":"2022-09-20 09:46:54.000000000","message":"Done","commit_id":"8f7c7a8a36f7e6a9b30cbfa9b168744bc7358c8e"}],"plugins/modules/federation_mapping_info.py":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"9a7071f3b1b276ffd21df145d02e9803874ddfe8","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  name:"},{"line_number":16,"context_line":"    description:"},{"line_number":17,"context_line":"      - The name of the mapping to fetch."},{"line_number":18,"context_line":"      - If I(name) is specified, the module will return failed if the mapping"},{"line_number":19,"context_line":"        doesn\u0027t exist."},{"line_number":20,"context_line":"    type: str"},{"line_number":21,"context_line":"    aliases: [\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"34add24c_d788e79e","line":18,"updated":"2022-09-06 09:03:53.000000000","message":"Nope, it will (should) return an empty list.","commit_id":"93f5b14b648111cc220231f203b8648f74d3baf5"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"c5b2855d7afea76a7e9e9d1db975c942ba589303","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  name:"},{"line_number":16,"context_line":"    description:"},{"line_number":17,"context_line":"      - The name of the mapping to fetch."},{"line_number":18,"context_line":"      - If I(name) is specified, the module will return failed if the mapping"},{"line_number":19,"context_line":"        doesn\u0027t exist."},{"line_number":20,"context_line":"    type: str"},{"line_number":21,"context_line":"    aliases: [\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"3dcf9223_c131248a","line":18,"in_reply_to":"34add24c_d788e79e","updated":"2022-09-19 07:43:33.000000000","message":"Done","commit_id":"93f5b14b648111cc220231f203b8648f74d3baf5"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"cec08cd592d9271cb0555c9dc55412b4431cad48","unresolved":true,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def run(self):"},{"line_number":77,"context_line":"        \"\"\" Module entry point \"\"\""},{"line_number":78,"context_line":"        name \u003d self.params.get(\u0027name\u0027, None)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        if name:"},{"line_number":81,"context_line":"            mapping \u003d self.conn.identity.find_mapping(name)"}],"source_content_type":"text/x-python","patch_set":13,"id":"57692c56_9d595e0b","line":78,"updated":"2022-08-23 14:58:33.000000000","message":"can just be self.params[\u0027name\u0027]","commit_id":"93f5b14b648111cc220231f203b8648f74d3baf5"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8ad47e5dade5d7c48e484356a0a8c8abb267a312","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def run(self):"},{"line_number":77,"context_line":"        \"\"\" Module entry point \"\"\""},{"line_number":78,"context_line":"        name \u003d self.params.get(\u0027name\u0027, None)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        if name:"},{"line_number":81,"context_line":"            mapping \u003d self.conn.identity.find_mapping(name)"}],"source_content_type":"text/x-python","patch_set":13,"id":"8a33753a_fd209f71","line":78,"in_reply_to":"57692c56_9d595e0b","updated":"2022-09-20 09:45:56.000000000","message":"Done","commit_id":"93f5b14b648111cc220231f203b8648f74d3baf5"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"9a7071f3b1b276ffd21df145d02e9803874ddfe8","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        \"\"\" Module entry point \"\"\""},{"line_number":78,"context_line":"        name \u003d self.params.get(\u0027name\u0027, None)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        if name:"},{"line_number":81,"context_line":"            mapping \u003d self.conn.identity.find_mapping(name)"},{"line_number":82,"context_line":"            mapping \u003d [mapping.to_dict(computed\u003dFalse)] if mapping else []"},{"line_number":83,"context_line":"            self.exit_json(changed\u003dFalse, mappings\u003dmapping)"}],"source_content_type":"text/x-python","patch_set":13,"id":"df00f61c_94fb9618","line":80,"updated":"2022-09-06 09:03:53.000000000","message":"This whole code block is not required. name of a mapping is actually refering to its id: id \u003d\u003d name [1]. So you can simply change that code to:\n\n  name_or_id \u003d self.params[\u0027name\u0027]\n  kwargs \u003d {}\n  if name_or_id:\n    kwargs[\u0027id\u0027] \u003d name_or_id\n  mappings \u003d self.conn.identity.mappings(**kwargs)\n\n[1] https://opendev.org/openstack/openstacksdk/src/commit/9fa6603d4e5104fb33e3688967cd128c0b8ad019/openstack/identity/v3/mapping.py#L39","commit_id":"93f5b14b648111cc220231f203b8648f74d3baf5"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"c5b2855d7afea76a7e9e9d1db975c942ba589303","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        \"\"\" Module entry point \"\"\""},{"line_number":78,"context_line":"        name \u003d self.params.get(\u0027name\u0027, None)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        if name:"},{"line_number":81,"context_line":"            mapping \u003d self.conn.identity.find_mapping(name)"},{"line_number":82,"context_line":"            mapping \u003d [mapping.to_dict(computed\u003dFalse)] if mapping else []"},{"line_number":83,"context_line":"            self.exit_json(changed\u003dFalse, mappings\u003dmapping)"}],"source_content_type":"text/x-python","patch_set":13,"id":"260975ac_8c8588e6","line":80,"in_reply_to":"50968ce8_296018f8","updated":"2022-09-19 07:43:33.000000000","message":"Done","commit_id":"93f5b14b648111cc220231f203b8648f74d3baf5"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"5bc7e7d52e5a30667b94003caba34f1502624db6","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        \"\"\" Module entry point \"\"\""},{"line_number":78,"context_line":"        name \u003d self.params.get(\u0027name\u0027, None)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        if name:"},{"line_number":81,"context_line":"            mapping \u003d self.conn.identity.find_mapping(name)"},{"line_number":82,"context_line":"            mapping \u003d [mapping.to_dict(computed\u003dFalse)] if mapping else []"},{"line_number":83,"context_line":"            self.exit_json(changed\u003dFalse, mappings\u003dmapping)"}],"source_content_type":"text/x-python","patch_set":13,"id":"50968ce8_296018f8","line":80,"in_reply_to":"df00f61c_94fb9618","updated":"2022-09-12 09:08:22.000000000","message":"It doesn\u0027t work, check previous patchsets, using self.conn.identity.mappings with kwargs, the filter doesn\u0027t work, i already pointed that in our meetings.","commit_id":"93f5b14b648111cc220231f203b8648f74d3baf5"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8ad47e5dade5d7c48e484356a0a8c8abb267a312","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  name:"},{"line_number":16,"context_line":"    description:"},{"line_number":17,"context_line":"      - The name of the mapping to fetch."},{"line_number":18,"context_line":"      - If I(name) is specified, the module will return an empty list."},{"line_number":19,"context_line":"    type: str"},{"line_number":20,"context_line":"    aliases: [\u0027id\u0027]"},{"line_number":21,"context_line":"requirements:"}],"source_content_type":"text/x-python","patch_set":15,"id":"39dd066b_52d2176c","line":18,"updated":"2022-09-20 09:45:56.000000000","message":"It will return an empty list if an name is specified and no such mapping exists. It will not always return an empty list when a name is specified..","commit_id":"8f7c7a8a36f7e6a9b30cbfa9b168744bc7358c8e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"a498cbc3e4087391951824ad582ef65c8d49a0b8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  name:"},{"line_number":16,"context_line":"    description:"},{"line_number":17,"context_line":"      - The name of the mapping to fetch."},{"line_number":18,"context_line":"      - If I(name) is specified, the module will return an empty list."},{"line_number":19,"context_line":"    type: str"},{"line_number":20,"context_line":"    aliases: [\u0027id\u0027]"},{"line_number":21,"context_line":"requirements:"}],"source_content_type":"text/x-python","patch_set":15,"id":"b7193732_c0949e01","line":18,"in_reply_to":"39dd066b_52d2176c","updated":"2022-09-20 09:46:54.000000000","message":"Done","commit_id":"8f7c7a8a36f7e6a9b30cbfa9b168744bc7358c8e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8ad47e5dade5d7c48e484356a0a8c8abb267a312","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        name \u003d self.params[\u0027name\u0027]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        if name:"},{"line_number":80,"context_line":"            mapping \u003d self.conn.identity.find_mapping(name)"},{"line_number":81,"context_line":"            mapping \u003d [mapping.to_dict(computed\u003dFalse)] if mapping else []"},{"line_number":82,"context_line":"            self.exit_json(changed\u003dFalse, mappings\u003dmapping)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ec3467fc_ced74914","line":80,"updated":"2022-09-20 09:45:56.000000000","message":"The previous function call to self.conn.identity.get_mapping does not have to be replaced with find_mapping because in mappings both id and name are equal: name IS id for mappings.\n\nSo you could actually replace the whole if-branch and simply pass name as query argument \u0027id\u0027 to self.conn.identity.mappings().","commit_id":"8f7c7a8a36f7e6a9b30cbfa9b168744bc7358c8e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"a498cbc3e4087391951824ad582ef65c8d49a0b8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        name \u003d self.params[\u0027name\u0027]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        if name:"},{"line_number":80,"context_line":"            mapping \u003d self.conn.identity.find_mapping(name)"},{"line_number":81,"context_line":"            mapping \u003d [mapping.to_dict(computed\u003dFalse)] if mapping else []"},{"line_number":82,"context_line":"            self.exit_json(changed\u003dFalse, mappings\u003dmapping)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"89ddaeba_de6744b1","line":80,"in_reply_to":"ec3467fc_ced74914","updated":"2022-09-20 09:46:54.000000000","message":"Done","commit_id":"8f7c7a8a36f7e6a9b30cbfa9b168744bc7358c8e"}]}