)]}'
{"id":"openstack%2Fansible-collections-openstack~849793","triplet_id":"openstack%2Fansible-collections-openstack~master~Icae77a43479fb4f0bae065d1c5d7942cb0f5fd6b","project":"openstack/ansible-collections-openstack","branch":"master","topic":"router-refactoring","attention_set":{},"removed_from_attention_set":{"34208":{"account":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"last_update":"2022-08-03 04:05:30.000000000","reason":"\u003cGERRIT_ACCOUNT_34208\u003e replied on the change","reason_account":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"}},"32962":{"account":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"last_update":"2022-08-03 12:57:29.000000000","reason":"\u003cGERRIT_ACCOUNT_32962\u003e replied on the change","reason_account":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}}},"hashtags":[],"change_id":"Icae77a43479fb4f0bae065d1c5d7942cb0f5fd6b","subject":"Refactored router module","status":"MERGED","created":"2022-07-14 08:27:37.000000000","updated":"2022-08-03 14:01:55.000000000","submitted":"2022-08-03 14:01:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"849793-router-refactoring","meta_rev_id":"d2f05013926b6bebfe2037e95d0d320f42674b73","_number":849793,"virtual_id_number":849793,"owner":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},{"value":0,"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-08-03 14:01:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"all":[{"value":2,"date":"2022-08-03 06:16:42.000000000","_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},{"value":2,"date":"2022-08-03 12:57:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2022-08-03 08:42:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"all":[{"value":0,"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},{"value":1,"date":"2022-08-03 12:57:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-14 09:43:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-08-02 08:25:47.000000000","updated_by":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"reviewer":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"state":"REVIEWER"},{"updated":"2022-08-03 08:42:32.000000000","updated_by":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"reviewer":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"state":"REVIEWER"}],"messages":[{"id":"2b71488ef68d49c388fd56a310b26f224291a664","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-07-14 08:27:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"90752e43f153a283e81f13f554451ae62d7e894d","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-07-14 08:27:54.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"3400d92a86bda7abded04b05998753b775e52b6a","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-07-14 08:29:01.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d97e67a0a6844528fe9cd2d29d9f1d67acbff089","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-14 09:43:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b45e4deb24b543cf802c732996fe9b27\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/27f8b8f337184116993a1c72d4fec6a9 : SUCCESS in 5m 51s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/e430765260d247e7a5119cb139d17457 : SUCCESS in 8m 38s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/e62395126791487ebe150971ef008a5b : SUCCESS in 8m 20s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/4e68eefa1278473182dbe7c5c04628ca : SUCCESS in 52m 42s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/309a44d9ce914665a89953121be71302 : SUCCESS in 58m 18s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/a96e25c647f9403880c9a3012e42fe5f : SUCCESS in 53m 21s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/d58718b42e6e4636989f4f1d3736f1d9 : SUCCESS in 44m 53s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/9bd1435889d647169abe444e4bd08ff9 : SUCCESS in 1h 01m 41s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/6bcd75b273f84a259487c09729321dc8 : SUCCESS in 26m 10s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/62006179635545788012b0248aaacc0f : SUCCESS in 24m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"97b2837f17c94e2a2e259db35a50f71156c6ed33","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-07-15 09:27:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ef88337c841d3e69cb8846e32c9fa113b22e6db2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-15 10:42:55.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/3886817d901f4b5ea73042142095a84c\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/6dbf42d4786b4083acff6de6384fffa3 : SUCCESS in 5m 22s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/28a4b625479b4e19b887d79f97ca5635 : SUCCESS in 8m 20s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/1ae5c39d943249edb3e1a9e97661ac84 : SUCCESS in 7m 53s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/f11140df807b4d66af2310331a2f26ad : FAILURE in 48m 59s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/1c1430a674994d0b9e2982907d3d2063 : FAILURE in 49m 51s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/c48aa151aab54807b1045b5b3ae2069f : FAILURE in 56m 00s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/a08439e4ed4c4ccaa3c074cfb049138e : FAILURE in 41m 29s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/d84f52569a924e5cafee261886034869 : FAILURE in 55m 43s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/e5486bd966e340bead1561113a4b4500 : SUCCESS in 26m 26s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/f81c29fb9c094be4bab2ca99374f5396 : SUCCESS in 31m 54s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"39bbb0edb75e5df69a549e3469eb9ac6835774fb","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-07-29 07:46:15.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0ef29fd7efadbccbe6c34cec074f7665cac9dccb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-29 07:56:00.000000000","message":"Patch Set 3: Verified-1\n\n(2 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/ba6c995fa5ce4f1c90a50f8321a40574\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/4a8920054e82491ba617e755c971c978 : FAILURE in 3m 49s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/654c0adcacc84b8eb7db54dc03012427 : FAILURE in 3m 57s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/743f92b3114f45a29a87f4c7e47be822 : FAILURE in 6m 46s\nSkipped 8 jobs","accounts_in_message":[],"_revision_number":3},{"id":"75d5a4804c11d95df01be34d01924371f38b8f8f","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-07-29 10:38:29.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"0a37f450a0546825e2c3c01bae6deb697ac71090","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-29 12:34:18.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/209d9572c232476f97aedd64f80fa981\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/f04d415287344b4f992afcce72593499 : SUCCESS in 4m 04s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/fb70594dcc594b3785fe5cd5356b9fd5 : FAILURE in 5m 29s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/6a267fba26b74bddbad7f5e6d5ed3073 : SUCCESS in 9m 06s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/572cef1c9fc440b5b38a967200287ca9 : FAILURE in 38m 52s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/8d631e01e604473fb894886633fdbcf9 : FAILURE in 38m 07s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/50c24f5a6d1548ef969fabd43ccfbd85 : FAILURE in 43m 02s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/09bc62d031654a3d8dd9e9dab5b3f9e5 : FAILURE in 43m 29s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/8585a428984c405d8d8b242dd115ad89 : FAILURE in 31m 48s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/e7d1a450d53b41088fc404f246201257 : SUCCESS in 36m 30s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/5d926a475580426f9e8bf013f9b6326f : SUCCESS in 36m 11s (non-voting)\n- tripleo-ci-centos-9-standalone-osa https://zuul.opendev.org/t/openstack/build/ba36a79d288d4784b6014b524988be5c : SUCCESS in 1h 39m 59s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"d59596d576833ba5a6424abd7063f8548c128bd5","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-07-29 13:36:06.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"559d4559606af8ba3f478d72c7358f625f368f0b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-29 15:51:57.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d84a8af57bf64646887822bc3ec5403e\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/5b0d9fb9d97d4e9589635bf55b122217 : SUCCESS in 3m 27s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/3b2c8f55e04f4fefbbba47108434e526 : FAILURE in 4m 35s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/9c0ae96b56fe448d8f0bb14c2f8be9ce : SUCCESS in 9m 10s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/b54cc435fcf64155a65a527bbd8d7577 : SUCCESS in 1h 00m 02s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/22ade092eea54ea1bb6f545c04295618 : SUCCESS in 59m 51s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/792971c06c6b41f09559dadacbbef8f4 : SUCCESS in 57m 02s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/4fbf69eb988a4524b692f5a7765972c1 : SUCCESS in 55m 15s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/45ea6f69e77440ea8320d82450d0593b : FAILURE in 35m 51s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/98330f9053c449199d777fdd44207565 : SUCCESS in 42m 30s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/9c7de2f63ed4433da03db74e73a5640b : SUCCESS in 40m 03s (non-voting)\n- tripleo-ci-centos-9-standalone-osa https://zuul.opendev.org/t/openstack/build/21f6806ff52942f9945ea4e7fbc38621 : SUCCESS in 1h 57m 48s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"bdb72d66b31f2642a2d9efb04966eed8fd17f70c","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-08-02 08:25:26.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"8599953ad213030f8f72fb59814087607260d825","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-08-02 08:25:47.000000000","message":"Patch Set 6:\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":6},{"id":"03deda58a0f82737ee44983b2a8314ac9eec0dd4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-02 10:29:08.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b34f8a2a0fc7487ea09234da9a968a15\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/2d512754a1d249fe8bd3ea21c521c6ba : SUCCESS in 4m 24s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/8aac48d06e8542d19279590a4aa3d9ff : FAILURE in 4m 55s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/320aa0a86d21479588091e650d85284d : SUCCESS in 8m 57s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/84d0b4b194bd48eb947fe20c58e98f05 : SUCCESS in 54m 34s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/6b5366ca8076445b81e65e9ba94275c4 : SUCCESS in 54m 38s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/e18befd53b564ced87e07f26d55125b8 : SUCCESS in 56m 31s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/42ed90f9049146b9b3c44924ca762c42 : SUCCESS in 1h 01m 27s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/200afd12a469461d89f185eb45f0bbca : FAILURE in 35m 44s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/87fc5b74cd6c4d5cb744c04d03796ef6 : SUCCESS in 35m 22s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/164eb258f2fa4ca0b67e14735f543d49 : SUCCESS in 36m 13s (non-voting)\n- tripleo-ci-centos-9-standalone-osa https://zuul.opendev.org/t/openstack/build/b80b68df8a284a92a88fd469bc33c7dc : SUCCESS in 1h 48m 08s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"cd94dcb3f54f0aabfcb2aa49cdc2c7aa3cd6d5eb","author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"date":"2022-08-03 04:05:30.000000000","message":"Patch Set 6: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"94d9b778c652e1307abf0ac36c7beba5390a0bd6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-08-03 06:16:42.000000000","message":"Patch Set 7: Patch Set 6 was rebased","accounts_in_message":[],"_revision_number":7},{"id":"4b01dacd5e7f1e2619a0ecae5857fa4fd68423ac","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-03 08:08:09.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/96717b5fa7fc4bd19c515871e9fa486f\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/830903e3b7464bd5a1987017558c16cc : SUCCESS in 5m 47s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/f795c50efc914691bc58b8714765e6fa : FAILURE in 3m 59s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/67bc67650139476cb0cce5f0f3006530 : SUCCESS in 9m 52s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/e05e45840a3f481a95ed8ce55484ede5 : SUCCESS in 1h 02m 41s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/bc7e07d0e026470cbc5e94c257da7215 : SUCCESS in 45m 30s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/4d5c8e8d289f4772b0698f2e0b85c7c9 : SUCCESS in 44m 57s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/a557b6a7a8bf46e796c33afa86d256ba : SUCCESS in 46m 58s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/fe0b6c55ee6d4c1eb5e7a89fc771ff8a : FAILURE in 27m 37s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/54dff0190c074c839c0970d2918cd28e : SUCCESS in 32m 03s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/418a4a08b5524d2ba3eb6d6deb8c4a1b : SUCCESS in 33m 34s (non-voting)\n- tripleo-ci-centos-9-standalone-osa https://zuul.opendev.org/t/openstack/build/00f89c1c67f74ee8800c9162907b3efc : SUCCESS in 1h 34m 03s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"33b2381773da30564afad0dc36deba2893ffd76d","author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"date":"2022-08-03 08:42:32.000000000","message":"Patch Set 7: Code-Review+1","accounts_in_message":[],"_revision_number":7},{"id":"b431de9d9d815c000ecb08070734ac3b87f6a1b1","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-08-03 12:57:29.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":7},{"id":"277c11cf36a004845936154ed623cdf23262cb38","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-03 12:58:04.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":7},{"id":"de260cdf61aee764b4ab8b005bea28b62ead30c0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-03 14:01:55.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5b7a1a0695c04514bdead9b4cd08786d\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/598eaa4d744d48149e374a791a176c60 : SUCCESS in 4m 28s\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/7ccc95d4fe56481884bf652d33aaf308 : SUCCESS in 8m 19s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/7b2d864001c8471b949c094fb9a87680 : SUCCESS in 1h 02m 43s","accounts_in_message":[],"_revision_number":7},{"id":"d2f05013926b6bebfe2037e95d0d320f42674b73","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-03 14:01:55.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"fdc67892e339cb0021df0458ccc8b593c46bd39c","revisions":{"25ee316ed2ae096cb35f28a3759391fdaac721f5":{"kind":"REWORK","_number":1,"created":"2022-07-14 08:27:37.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/93/849793/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/93/849793/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/1"}}},"commit":{"parents":[{"commit":"1b071aca6f1ff1a67962d7c0718957d05a391562","subject":"Update router for 2.0.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/1b071aca6f1ff1a67962d7c0718957d05a391562"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-14 08:27:15.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-14 08:27:15.000000000","tz":120},"subject":"Refactored router module","message":"Refactored router module\n\nExpanded and fixed module results docs, e.g. changed module result\ntype from complex to dict because we no longer return Munch objects.\n\nMoved ext_ips_spec into the module class because global scope is not\nnecessary. Renamed it to external_fixed_ips_spec to explain its\npurpose.\n\nSorted argument_spec and attribute docs by attribute name and fixed\nindentations.\n\nDropped self.fail() calls and let openstacksdk handle missing networks,\nsubnets.. instead because less code means less code to maintain.\n\nDo not check whether self.conn.network.update_router() returned a None\nvalue because this is not possible with our input values. Actually, I\ncould not find any code path in openstacksdk 0.99.0 where this function\ncould possibly return a None value.\n\nDropped check for router is None before returning it because router\ncannot be None except if openstacksdk has a bug.\n\nReplaced self.conn.delete_router with self.conn.network.delete_router\nbecause we already have a router object.\n\nReplaced self.conn.remove_router_interface with\nself.conn.network.remove_interface_from_router because the latter simply\ncalls the former anyway.\n\nLimited line length to 80 chars to be consistent with other OpenStack\nprojects. Personally, I prefer a 120 chars limit but consistency is more\nimportant.\n\nChange-Id: Icae77a43479fb4f0bae065d1c5d7942cb0f5fd6b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/25ee316ed2ae096cb35f28a3759391fdaac721f5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/25ee316ed2ae096cb35f28a3759391fdaac721f5"}]},"branch":"refs/heads/master"},"1198b9aaa543a6fce2be19c1b45bcd3b5100b565":{"kind":"REWORK","_number":2,"created":"2022-07-15 09:27:58.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/93/849793/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/93/849793/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/2"}}},"commit":{"parents":[{"commit":"1b071aca6f1ff1a67962d7c0718957d05a391562","subject":"Update router for 2.0.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/1b071aca6f1ff1a67962d7c0718957d05a391562"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-14 08:27:15.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-15 09:27:28.000000000","tz":120},"subject":"Refactored router module","message":"Refactored router module\n\nExpanded and fixed module results docs, e.g. changed module result\ntype from complex to dict because we no longer return Munch objects.\n\nMoved ext_ips_spec into the module class because global scope is not\nnecessary. Renamed it to external_fixed_ips_spec to explain its\npurpose.\n\nSorted argument_spec and attribute docs by attribute name and fixed\nindentations. Marked router attributes which cannot be updated.\n\nMark network attribute as required by enable_snat and interfaces\nattributes.\n\nChanged examples from deprecated ip to current ip_address attribute.\n\nDropped self.fail() calls and let openstacksdk handle missing networks,\nsubnets.. instead because less code means less code to maintain.\n\nDo not check whether self.conn.network.update_router() returned a None\nvalue because this is not possible with our input values. Actually, I\ncould not find any code path in openstacksdk 0.99.0 where this function\ncould possibly return a None value.\n\nDropped check for router is None before returning it because router\ncannot be None except if openstacksdk has a bug.\n\nReplaced self.conn.delete_router with self.conn.network.delete_router\nbecause we already have a router object.\n\nReplaced self.conn.remove_router_interface with\nself.conn.network.remove_interface_from_router because the latter simply\ncalls the former anyway.\n\nLimited line length to 80 chars to be consistent with other OpenStack\nprojects. Personally, I prefer a 120 chars limit but consistency is more\nimportant.\n\nAdded explanation in code comment why we cannot update a router\u0027s name.\n\nChange-Id: Icae77a43479fb4f0bae065d1c5d7942cb0f5fd6b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/1198b9aaa543a6fce2be19c1b45bcd3b5100b565"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/1198b9aaa543a6fce2be19c1b45bcd3b5100b565"}]},"branch":"refs/heads/master"},"0efd6fdaaf320a192a13461812bf490eb8046f45":{"kind":"REWORK","_number":3,"created":"2022-07-29 07:46:15.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/93/849793/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/93/849793/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/3"}}},"commit":{"parents":[{"commit":"ac401bb354c6a1d388848a3ebd18537beba080cc","subject":"Refactored server and server_info modules","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/ac401bb354c6a1d388848a3ebd18537beba080cc"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-28 10:15:11.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-29 07:46:10.000000000","tz":120},"subject":"Refactored router module","message":"Refactored router module\n\nExpanded and fixed module results docs.\n\nMoved ext_ips_spec into the module class because global scope is not\nnecessary. Renamed it to external_fixed_ips_spec to explain its\npurpose.\n\nSorted argument_spec and attribute docs by attribute name and fixed\nindentations. Marked router attributes which cannot be updated.\n\nMark network attribute as required by enable_snat and interfaces\nattributes.\n\nChanged examples from deprecated ip to current ip_address attribute.\n\nDropped self.fail() calls and let openstacksdk handle missing networks,\nsubnets.. instead because less code means less code to maintain.\n\nLimited line length to 80 chars to be consistent with other OpenStack\nprojects. Personally, I prefer a 120 chars limit but consistency is more\nimportant.\n\nAdded explanation in code comment why we cannot update a router\u0027s name.\n\nMoved upfront cleanup operations in router\u0027s integration tests to the\nbeginning of the role.\n\nAssigned meaningful names to result variables\nin router\u0027s ci role to easily identify which modules produced the\ndata.\n\nAdded tests for router ids, admin state and interfaces.\n\nChange-Id: Icae77a43479fb4f0bae065d1c5d7942cb0f5fd6b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/0efd6fdaaf320a192a13461812bf490eb8046f45"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/0efd6fdaaf320a192a13461812bf490eb8046f45"}]},"branch":"refs/heads/master"},"22b2fe021b54282edfefaafc62a40c1494104121":{"kind":"REWORK","_number":4,"created":"2022-07-29 10:38:29.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/93/849793/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/93/849793/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/4"}}},"commit":{"parents":[{"commit":"ac401bb354c6a1d388848a3ebd18537beba080cc","subject":"Refactored server and server_info modules","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/ac401bb354c6a1d388848a3ebd18537beba080cc"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-28 10:15:11.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-29 10:38:22.000000000","tz":120},"subject":"Refactored router module","message":"Refactored router module\n\nExpanded and fixed module results docs.\n\nMoved ext_ips_spec into the module class because global scope is not\nnecessary. Renamed it to external_fixed_ips_spec to explain its\npurpose.\n\nSorted argument_spec and attribute docs by attribute name and fixed\nindentations. Marked router attributes which cannot be updated.\n\nMark network attribute as required by enable_snat and interfaces\nattributes.\n\nChanged examples from deprecated ip to current ip_address attribute.\n\nDropped self.fail() calls and let openstacksdk handle missing networks,\nsubnets.. instead because less code means less code to maintain.\n\nLimited line length to 80 chars to be consistent with other OpenStack\nprojects. Personally, I prefer a 120 chars limit but consistency is more\nimportant.\n\nAdded explanation in code comment why we cannot update a router\u0027s name.\n\nMoved upfront cleanup operations in router\u0027s integration tests to the\nbeginning of the role.\n\nAssigned meaningful names to result variables\nin router\u0027s ci role to easily identify which modules produced the\ndata.\n\nAdded tests for router ids, admin state and interfaces.\n\nChange-Id: Icae77a43479fb4f0bae065d1c5d7942cb0f5fd6b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/22b2fe021b54282edfefaafc62a40c1494104121"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/22b2fe021b54282edfefaafc62a40c1494104121"}]},"branch":"refs/heads/master"},"d99d45a446250136bd3458eeac7d7508cf85bf57":{"kind":"REWORK","_number":5,"created":"2022-07-29 13:36:06.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/93/849793/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/93/849793/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/5"}}},"commit":{"parents":[{"commit":"ac401bb354c6a1d388848a3ebd18537beba080cc","subject":"Refactored server and server_info modules","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/ac401bb354c6a1d388848a3ebd18537beba080cc"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-28 10:15:11.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-29 13:34:35.000000000","tz":120},"subject":"Refactored router module","message":"Refactored router module\n\nExpanded and fixed module results docs.\n\nMoved ext_ips_spec into the module class because global scope is not\nnecessary. Renamed it to external_fixed_ips_spec to explain its\npurpose.\n\nSorted argument_spec and attribute docs by attribute name and fixed\nindentations. Marked router attributes which cannot be updated.\n\nMark network attribute as required by enable_snat and\nexternal_fixed_ips attributes. Fixed docstring of network attribute:\nModule attribute interfaces does not require the network attribute,\nits external_fixed_ips what requires network to be set.\n\nChanged examples from deprecated ip to current ip_address attribute.\n\nDropped self.fail() calls and let openstacksdk handle missing networks,\nsubnets.. instead because less code means less code to maintain.\n\nLimited line length to 80 chars to be consistent with other OpenStack\nprojects. Personally, I prefer a 120 chars limit but consistency is more\nimportant.\n\nAdded explanation in code comment why we cannot update a router\u0027s name.\n\nMoved upfront cleanup operations in router\u0027s integration tests to the\nbeginning of the role.\n\nAssigned meaningful names to result variables\nin router\u0027s ci role to easily identify which modules produced the\ndata.\n\nAdded tests for router ids, admin state and interfaces.\n\nChange-Id: Icae77a43479fb4f0bae065d1c5d7942cb0f5fd6b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/d99d45a446250136bd3458eeac7d7508cf85bf57"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/d99d45a446250136bd3458eeac7d7508cf85bf57"}]},"branch":"refs/heads/master"},"eba0de14f63b61b002976bea48459caac5539ffa":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2022-08-02 08:25:26.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/93/849793/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/93/849793/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/6"}}},"commit":{"parents":[{"commit":"1bf22feb2dd9f7e88ff6722ed10257d87ac5d4c5","subject":"Fixed code violating Flake8 rule E275","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/1bf22feb2dd9f7e88ff6722ed10257d87ac5d4c5"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-28 10:15:11.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-08-02 08:25:02.000000000","tz":120},"subject":"Refactored router module","message":"Refactored router module\n\nExpanded and fixed module results docs.\n\nMoved ext_ips_spec into the module class because global scope is not\nnecessary. Renamed it to external_fixed_ips_spec to explain its\npurpose.\n\nSorted argument_spec and attribute docs by attribute name and fixed\nindentations. Marked router attributes which cannot be updated.\n\nMark network attribute as required by enable_snat and\nexternal_fixed_ips attributes. Fixed docstring of network attribute:\nModule attribute interfaces does not require the network attribute,\nits external_fixed_ips what requires network to be set.\n\nChanged examples from deprecated ip to current ip_address attribute.\n\nDropped self.fail() calls and let openstacksdk handle missing networks,\nsubnets.. instead because less code means less code to maintain.\n\nLimited line length to 80 chars to be consistent with other OpenStack\nprojects. Personally, I prefer a 120 chars limit but consistency is more\nimportant.\n\nAdded explanation in code comment why we cannot update a router\u0027s name.\n\nMoved upfront cleanup operations in router\u0027s integration tests to the\nbeginning of the role.\n\nAssigned meaningful names to result variables\nin router\u0027s ci role to easily identify which modules produced the\ndata.\n\nAdded tests for router ids, admin state and interfaces.\n\nChange-Id: Icae77a43479fb4f0bae065d1c5d7942cb0f5fd6b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/eba0de14f63b61b002976bea48459caac5539ffa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/eba0de14f63b61b002976bea48459caac5539ffa"}]},"branch":"refs/heads/master"},"fdc67892e339cb0021df0458ccc8b593c46bd39c":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2022-08-03 06:16:42.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/93/849793/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/93/849793/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/93/849793/7"}}},"commit":{"parents":[{"commit":"d2eb98d04800bcfa180ae459483ddcb8a52497ec","subject":"Update baremetal_inspect to be compatible with new sdk","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/d2eb98d04800bcfa180ae459483ddcb8a52497ec"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-28 10:15:11.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-08-03 06:16:42.000000000","tz":0},"subject":"Refactored router module","message":"Refactored router module\n\nExpanded and fixed module results docs.\n\nMoved ext_ips_spec into the module class because global scope is not\nnecessary. Renamed it to external_fixed_ips_spec to explain its\npurpose.\n\nSorted argument_spec and attribute docs by attribute name and fixed\nindentations. Marked router attributes which cannot be updated.\n\nMark network attribute as required by enable_snat and\nexternal_fixed_ips attributes. Fixed docstring of network attribute:\nModule attribute interfaces does not require the network attribute,\nits external_fixed_ips what requires network to be set.\n\nChanged examples from deprecated ip to current ip_address attribute.\n\nDropped self.fail() calls and let openstacksdk handle missing networks,\nsubnets.. instead because less code means less code to maintain.\n\nLimited line length to 80 chars to be consistent with other OpenStack\nprojects. Personally, I prefer a 120 chars limit but consistency is more\nimportant.\n\nAdded explanation in code comment why we cannot update a router\u0027s name.\n\nMoved upfront cleanup operations in router\u0027s integration tests to the\nbeginning of the role.\n\nAssigned meaningful names to result variables\nin router\u0027s ci role to easily identify which modules produced the\ndata.\n\nAdded tests for router ids, admin state and interfaces.\n\nChange-Id: Icae77a43479fb4f0bae065d1c5d7942cb0f5fd6b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/fdc67892e339cb0021df0458ccc8b593c46bd39c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/fdc67892e339cb0021df0458ccc8b593c46bd39c"}]},"branch":"refs/heads/master","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}}]}],"submit_requirements":[]}