)]}'
{"id":"openstack%2Fansible-collections-openstack~849975","triplet_id":"openstack%2Fansible-collections-openstack~master~I9c52de03c53ef29d7cecdf26253c0c00a7cf3689","project":"openstack/ansible-collections-openstack","branch":"master","topic":"routers_info","attention_set":{},"removed_from_attention_set":{"34208":{"account":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"last_update":"2022-07-18 10:31:50.000000000","reason":"Change was submitted"},"32962":{"account":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"last_update":"2022-07-18 10:31:50.000000000","reason":"Change was submitted"},"10969":{"account":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"last_update":"2022-07-18 09:40:34.000000000","reason":"\u003cGERRIT_ACCOUNT_10969\u003e replied on the change","reason_account":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}}},"hashtags":[],"change_id":"I9c52de03c53ef29d7cecdf26253c0c00a7cf3689","subject":"Replaced code in routers_info module with openstacksdk function","status":"MERGED","created":"2022-07-15 09:56:14.000000000","updated":"2022-07-18 10:31:50.000000000","submitted":"2022-07-18 10:31:50.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"849975-routers_info","meta_rev_id":"51ed05df0ffc5c17974da9b8cdaf5233213f0dba","_number":849975,"virtual_id_number":849975,"owner":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-07-18 10:31:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"all":[{"value":2,"date":"2022-07-15 11:56:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"value":2,"date":"2022-07-18 09:40:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":0,"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"value":1,"date":"2022-07-18 09:40:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"}],"reviewers":{"REVIEWER":[{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-15 10:05:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-07-15 11:56:29.000000000","updated_by":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REVIEWER"},{"updated":"2022-07-15 11:56:29.000000000","updated_by":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"reviewer":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"state":"REVIEWER"}],"messages":[{"id":"dfd48754f0cff7872439ace67c217cbf2b83cb95","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-07-15 09:56:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"78fbddd9376e4c97d0d8f4d31fd293b617b908b7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-15 10:05:57.000000000","message":"Patch Set 1: Verified-1\n\n(3 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/3dfe52362a0f47b79bea87b4e2daeffe\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/486815083ac0474d9e96df651293be8f : FAILURE in 5m 00s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/cb0001254d4d4950bd49fa70975fb7f8 : FAILURE in 8m 08s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/013533d7cff94655847b47a916ca4cd1 : FAILURE in 8m 02s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/c232063a8dc1475a82732531cb8a2e05 : SKIPPED\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/3ab49300ad1c4ba7adf4d556630a5da3 : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/185c473900a04a60ade8508af62bfe75 : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/be5de11e485d4206a81ad1899dff75ea : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/8b81017d83254a12879d32eb5eae8164 : SKIPPED (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/605817d326d448669609bb0bca62eaa4 : SKIPPED (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/a5658bf486264425b310952aad452744 : SKIPPED (non-voting)\n\nWarning:\n  Job tox-pep8: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_routers_info.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-2.12: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_routers_info.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-devel: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_routers_info.py has only 1 lines\u0027\n  Comments left for invalid file plugins/modules/os_routers_info.py","accounts_in_message":[],"_revision_number":1},{"id":"9d83a9d0f3477305ee426e217b1ff03b0e24ff07","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-07-15 10:13:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9a4dc6d0396eae534de6f1e3d96fcfbf51c22031","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-15 10:28:51.000000000","message":"Patch Set 2: Verified-1\n\n(3 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/bf1f521d0e874e169c0c042ba019c0d5\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/e9e277a60bdc40999a46bbaed32158e6 : FAILURE in 7m 38s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/988c49fdf6e044a8bd05c11720f117e6 : FAILURE in 9m 22s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/57dc76656b8d4859aeeda94d088acc73 : FAILURE in 10m 23s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/f7f43f0c0990481c8c4b9fb656a88882 : SKIPPED\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/85efc5cb4f3545b6b1218d9e5c43b7fd : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/8b0daa83f9414a9683c2e7d55af128fd : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/51a5377802464dfc9a066978a5bd8a04 : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/70c924b61fa140078b49a6da4e4d927f : SKIPPED (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/906566ba42394898843dd61b891ad8a0 : SKIPPED (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/817dc84e93374164ab213b970b040199 : SKIPPED (non-voting)\n\nWarning:\n  Job openstack-tox-linters-ansible-2.12: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_routers_info.py has only 1 lines\u0027\n  Job tox-pep8: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_routers_info.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-devel: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_routers_info.py has only 1 lines\u0027\n  Comments left for invalid file plugins/modules/os_routers_info.py","accounts_in_message":[],"_revision_number":2},{"id":"21bc253e73fac2b38ca862c09d6795adbfafb827","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-07-15 10:34:45.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"48a1bb5b3696afbe805212501a5c564a0f1a2cd1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-15 11:51:59.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a39b0b2446e64f4988a11651dd3f7d91\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/5784e55e9c90440798b288ec356ae9be : SUCCESS in 6m 06s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/723b54783240449991c67665e146a581 : SUCCESS in 7m 40s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/7be962ca308943a7ba6eb3c4b6d4e9c4 : SUCCESS in 7m 22s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/85d1bc8825bd4aca9e5b2fc9303c9f6d : SUCCESS in 47m 23s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/45ac75547f6a492988ac868a0ee6b482 : SUCCESS in 49m 07s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/6590c720a21041c68e2fb476996d9348 : SUCCESS in 53m 06s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/14f73f026562423ea5a71b1d9d20ab6c : SUCCESS in 48m 40s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/fdd05dbf3f2845f8a6ec7950aa155747 : SUCCESS in 54m 16s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/0b32f816b10e413092fdefddaca7221b : SUCCESS in 30m 44s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/6bbe7dcdbc1944ed934c1618cb0a2151 : SUCCESS in 30m 45s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"ff848c18ce521dcd7a362d5190948b803c532c1b","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-07-15 11:56:29.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"72356172aebe170304762ab2cf33be62b2f4cf93","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2022-07-18 09:40:34.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"bc64667d6ca7e3f7917ef3708e2f26326d33e96a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-18 09:41:11.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"e442d2b000ae75b6522c759a10efb9a53e2811ad","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-18 10:31:50.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9a6598859ef841dfbf952a4a2b0a3f24\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/c0df0af4ca0c4e3e9ce6726b07ffa8fd : SUCCESS in 6m 12s\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/4c4d8725599b4cad9489f67665f5985d : SUCCESS in 9m 02s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/38e963f64f50430e8ab76a8783d9cffa : SUCCESS in 49m 53s","accounts_in_message":[],"_revision_number":3},{"id":"51ed05df0ffc5c17974da9b8cdaf5233213f0dba","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-18 10:31:50.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"1f5a2019a0a9167b78c4026a6afdd40a3d41874b","revisions":{"fe3224363e0632450624cffcf7d104f5a322a8f0":{"kind":"REWORK","_number":1,"created":"2022-07-15 09:56:14.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/75/849975/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/75/849975/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/75/849975/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/75/849975/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/75/849975/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/75/849975/1"}}},"commit":{"parents":[{"commit":"7ec8e4d0879bf97f1cbb8366c46bf0fe2accb10b","subject":"Update project module to be compatible with new sdk","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/7ec8e4d0879bf97f1cbb8366c46bf0fe2accb10b"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-15 09:50:27.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-15 09:50:27.000000000","tz":120},"subject":"Replaced code in routers_info module with openstacksdk function","message":"Replaced code in routers_info module with openstacksdk function\n\nReplaced custom code for interface listing with call to openstacksdk.\nThe original idea was to reduce the number of calls to the OpenStack\nAPI but this kind of optimization is better to be implemented in the\nSDK itself [1]. Reimplementing code like this increases our\nmaintenance burden, does not help other SDK users and increases the\nlikeliness of bugs. For example, variable allowed_device_owners\nintroduced a bug, it is not \u0027network_router_interface_distributed\u0027\nbut \u0027network:router_interface_distributed\u0027.\n\n[1] https://review.opendev.org/c/openstack/openstacksdk/+/849967\n\nChange-Id: I9c52de03c53ef29d7cecdf26253c0c00a7cf3689\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/fe3224363e0632450624cffcf7d104f5a322a8f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/fe3224363e0632450624cffcf7d104f5a322a8f0"}]},"branch":"refs/heads/master"},"24f35bc0b2bead9304a5b3783100ddadbae9dbe1":{"kind":"REWORK","_number":2,"created":"2022-07-15 10:13:47.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/75/849975/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/75/849975/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/75/849975/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/75/849975/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/75/849975/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/75/849975/2"}}},"commit":{"parents":[{"commit":"7ec8e4d0879bf97f1cbb8366c46bf0fe2accb10b","subject":"Update project module to be compatible with new sdk","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/7ec8e4d0879bf97f1cbb8366c46bf0fe2accb10b"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-15 09:50:27.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-15 10:13:41.000000000","tz":120},"subject":"Replaced code in routers_info module with openstacksdk function","message":"Replaced code in routers_info module with openstacksdk function\n\nReplaced custom code for interface listing with call to openstacksdk.\nThe original idea was to reduce the number of calls to the OpenStack\nAPI but this kind of optimization is better to be implemented in the\nSDK itself [1]. Reimplementing code like this increases our\nmaintenance burden, does not help other SDK users and increases the\nlikeliness of bugs. For example, variable allowed_device_owners\nintroduced a bug, it is not \u0027network_router_interface_distributed\u0027\nbut \u0027network:router_interface_distributed\u0027.\n\n[1] https://review.opendev.org/c/openstack/openstacksdk/+/849967\n\nChange-Id: I9c52de03c53ef29d7cecdf26253c0c00a7cf3689\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/24f35bc0b2bead9304a5b3783100ddadbae9dbe1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/24f35bc0b2bead9304a5b3783100ddadbae9dbe1"}]},"branch":"refs/heads/master"},"1f5a2019a0a9167b78c4026a6afdd40a3d41874b":{"kind":"REWORK","_number":3,"created":"2022-07-15 10:34:45.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/75/849975/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/75/849975/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/75/849975/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/75/849975/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/75/849975/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/75/849975/3"}}},"commit":{"parents":[{"commit":"7ec8e4d0879bf97f1cbb8366c46bf0fe2accb10b","subject":"Update project module to be compatible with new sdk","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/7ec8e4d0879bf97f1cbb8366c46bf0fe2accb10b"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-15 09:50:27.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-07-15 10:34:39.000000000","tz":120},"subject":"Replaced code in routers_info module with openstacksdk function","message":"Replaced code in routers_info module with openstacksdk function\n\nReplaced custom code for interface listing with call to openstacksdk.\nThe original idea was to reduce the number of calls to the OpenStack\nAPI but this kind of optimization is better to be implemented in the\nSDK itself [1]. Reimplementing code like this increases our\nmaintenance burden, does not help other SDK users and increases the\nlikeliness of bugs. For example, variable allowed_device_owners\nintroduced a bug, it is not \u0027network_router_interface_distributed\u0027\nbut \u0027network:router_interface_distributed\u0027.\n\n[1] https://review.opendev.org/c/openstack/openstacksdk/+/849967\n\nChange-Id: I9c52de03c53ef29d7cecdf26253c0c00a7cf3689\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/1f5a2019a0a9167b78c4026a6afdd40a3d41874b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/1f5a2019a0a9167b78c4026a6afdd40a3d41874b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}}]}],"submit_requirements":[]}