)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"3d2aab98584d05aa827e81aa8ba306a746de1516","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"60aed983_d674e6bd","updated":"2022-09-06 11:30:14.000000000","message":"Thanks for your contribution, Will 😊 Very much appreciated! Added a couple of comments below.","commit_id":"a9de8e856afb98c722d745c023aeae566af63bc5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"4d93609e1cf36b0b2515fd535b91f5a843d9f8bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"05f8f668_3a59bd03","updated":"2022-08-26 08:39:40.000000000","message":"recheck: failure seems unrelated","commit_id":"a9de8e856afb98c722d745c023aeae566af63bc5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"2bff23c80aed83b38c76a5f053ecec6305f2caed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"20a5834d_b1cd7f50","updated":"2022-09-14 09:20:30.000000000","message":"Thanks for the review. Think I\u0027ve addressed all the comments now.","commit_id":"ad248c6a3b3a34d9c82d2459899ee5c242519961"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"d9b973208b11abc5396e16083ba080e93843f81d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0171d177_c86567ef","updated":"2022-09-20 10:03:09.000000000","message":"Awesome, thank you 😎","commit_id":"2d0656f072193e25f2898bd2c5e08dec7c3afe1f"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"669eb140aad54237990ca956a05185a0b76dd9a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d40e06cd_aab87d90","updated":"2022-09-20 23:16:18.000000000","message":"Thanks for the patch!","commit_id":"2d0656f072193e25f2898bd2c5e08dec7c3afe1f"}],"ci/roles/network/tasks/main.yml":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"3d2aab98584d05aa827e81aa8ba306a746de1516","unresolved":true,"context_lines":[{"line_number":116,"context_line":"     mtu: \"{{ mtu }}\""},{"line_number":117,"context_line":"     port_security_enabled: \"{{ port_security_enabled }}\""},{"line_number":118,"context_line":"  register: result_create_nw_for_updates"},{"line_number":119,"context_line":"  ignore_errors: true"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"- name: Update network - update failure"},{"line_number":122,"context_line":"  openstack.cloud.network:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7ee95e93_9f423737","line":119,"updated":"2022-09-06 11:30:14.000000000","message":"Why ignore_errors?","commit_id":"a9de8e856afb98c722d745c023aeae566af63bc5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"2bff23c80aed83b38c76a5f053ecec6305f2caed","unresolved":false,"context_lines":[{"line_number":116,"context_line":"     mtu: \"{{ mtu }}\""},{"line_number":117,"context_line":"     port_security_enabled: \"{{ port_security_enabled }}\""},{"line_number":118,"context_line":"  register: result_create_nw_for_updates"},{"line_number":119,"context_line":"  ignore_errors: true"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"- name: Update network - update failure"},{"line_number":122,"context_line":"  openstack.cloud.network:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"4ab7ef7f_adda5d51","line":119,"in_reply_to":"7ee95e93_9f423737","updated":"2022-09-14 09:20:30.000000000","message":"Done","commit_id":"a9de8e856afb98c722d745c023aeae566af63bc5"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"3d2aab98584d05aa827e81aa8ba306a746de1516","unresolved":true,"context_lines":[{"line_number":149,"context_line":"     # NOTE: This property should be updated"},{"line_number":150,"context_line":"     port_security_enabled: \"{{ not port_security_enabled }}\""},{"line_number":151,"context_line":"  register: result_nw_update_success"},{"line_number":152,"context_line":"  ignore_errors: true"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"- name: Gather networks info - updates"},{"line_number":155,"context_line":"  openstack.cloud.networks_info:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"61e8d52e_ebefaea6","line":152,"updated":"2022-09-06 11:30:14.000000000","message":"This should fail on errors and not ignore errors","commit_id":"a9de8e856afb98c722d745c023aeae566af63bc5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"2bff23c80aed83b38c76a5f053ecec6305f2caed","unresolved":false,"context_lines":[{"line_number":149,"context_line":"     # NOTE: This property should be updated"},{"line_number":150,"context_line":"     port_security_enabled: \"{{ not port_security_enabled }}\""},{"line_number":151,"context_line":"  register: result_nw_update_success"},{"line_number":152,"context_line":"  ignore_errors: true"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"- name: Gather networks info - updates"},{"line_number":155,"context_line":"  openstack.cloud.networks_info:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"8b028ab0_6434702b","line":152,"in_reply_to":"61e8d52e_ebefaea6","updated":"2022-09-14 09:20:30.000000000","message":"Done","commit_id":"a9de8e856afb98c722d745c023aeae566af63bc5"}],"plugins/modules/network.py":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"3d2aab98584d05aa827e81aa8ba306a746de1516","unresolved":true,"context_lines":[{"line_number":256,"context_line":"                update_kwargs \u003d {}"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"                # Mappings from argument name to field in Network object."},{"line_number":259,"context_line":"                argument_mappings \u003d {"},{"line_number":260,"context_line":"                    \"is_router_external\": \"router:external\","},{"line_number":261,"context_line":"                    # NOTE(wszumski): Segmentation ID can only updated on VLAN"},{"line_number":262,"context_line":"                    # networks: The error you get back is:"}],"source_content_type":"text/x-python","patch_set":8,"id":"0ac61f44_0ddedf92","line":259,"updated":"2022-09-06 11:30:14.000000000","message":"This should not be necessary with openstacksdk \u003e\u003d0.99.0 ?!?","commit_id":"a9de8e856afb98c722d745c023aeae566af63bc5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"2bff23c80aed83b38c76a5f053ecec6305f2caed","unresolved":true,"context_lines":[{"line_number":256,"context_line":"                update_kwargs \u003d {}"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"                # Mappings from argument name to field in Network object."},{"line_number":259,"context_line":"                argument_mappings \u003d {"},{"line_number":260,"context_line":"                    \"is_router_external\": \"router:external\","},{"line_number":261,"context_line":"                    # NOTE(wszumski): Segmentation ID can only updated on VLAN"},{"line_number":262,"context_line":"                    # networks: The error you get back is:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a876fc9_e59d3eb5","line":259,"in_reply_to":"0ac61f44_0ddedf92","updated":"2022-09-14 09:20:30.000000000","message":"You are correct. I tested with `openstacksdk\u003d\u003d0.101.0` and this seemed unnecessary, thanks.","commit_id":"a9de8e856afb98c722d745c023aeae566af63bc5"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"d9b973208b11abc5396e16083ba080e93843f81d","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                update_kwargs \u003d {}"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"                # Mappings from argument name to field in Network object."},{"line_number":259,"context_line":"                argument_mappings \u003d {"},{"line_number":260,"context_line":"                    \"is_router_external\": \"router:external\","},{"line_number":261,"context_line":"                    # NOTE(wszumski): Segmentation ID can only updated on VLAN"},{"line_number":262,"context_line":"                    # networks: The error you get back is:"}],"source_content_type":"text/x-python","patch_set":8,"id":"0468a759_6f160d35","line":259,"in_reply_to":"7a876fc9_e59d3eb5","updated":"2022-09-20 10:03:09.000000000","message":"Done","commit_id":"a9de8e856afb98c722d745c023aeae566af63bc5"}]}
