)]}'
{"id":"openstack%2Fansible-collections-openstack~856201","triplet_id":"openstack%2Fansible-collections-openstack~stable%2F1.0.0~Ia09658467d98516ca1ea612e7301629b2f69d2d1","project":"openstack/ansible-collections-openstack","branch":"stable/1.0.0","topic":"keypair-stable/1.0.0","attention_set":{},"removed_from_attention_set":{"32962":{"account":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"last_update":"2022-09-07 18:02:48.000000000","reason":"\u003cGERRIT_ACCOUNT_32962\u003e replied on the change","reason_account":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}}},"hashtags":[],"change_id":"Ia09658467d98516ca1ea612e7301629b2f69d2d1","subject":"Do not remove trailing spaces when reading public key in keypair module","status":"MERGED","created":"2022-09-07 14:04:48.000000000","updated":"2022-09-07 19:07:27.000000000","submitted":"2022-09-07 19:07:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"856201-keypair-stable/1.0.0","cherry_pick_of_change":856238,"cherry_pick_of_patch_set":2,"meta_rev_id":"93e1e238f36a2d0a0acb356483593230b07987e1","_number":856201,"virtual_id_number":856201,"owner":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-09-07 19:07:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2022-09-07 15:39:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},{"value":0,"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2022-09-07 16:37:29.000000000","_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},{"value":2,"date":"2022-09-07 18:02:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},{"value":1,"date":"2022-09-07 18:02:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-07 15:39:08.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-09-07 16:21:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-09-07 16:37:29.000000000","updated_by":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"reviewer":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"state":"REVIEWER"}],"messages":[{"id":"4f4d55998b42a7cf3d851bc8f163fcdc38cc6806","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-09-07 14:04:48.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"d9e2ec590acd3edd845e8603c4dd6f1ef89eb69c","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2022-09-07 15:39:08.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-9-ovb-1ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/a4a7a0717b494214b4322dc1b26100b4 : FAILURE in 1h 32m 55s","accounts_in_message":[],"_revision_number":1},{"id":"afe771d525a39e63794c47721cbd5d9170cd5047","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-07 16:21:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9946d3a3a1214c46b43ecfe3f6a1aeb7\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/c0eb462142de46bbb98b5ce5b12a2578 : SUCCESS in 6m 08s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/bc4a57da5d11429ead92135e634eb6b6 : FAILURE in 5m 59s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/3e0ddaa228b749e8af8139e3cfcec6d1 : SUCCESS in 8m 16s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/907b4a7806ba459f9fa835150ce9583f : SUCCESS in 1h 05m 23s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/1a8c2d2e21dd4245a8257f778795dccc : SUCCESS in 52m 29s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/fe0d6ef3bc9b405c8881c0e32da2e852 : SUCCESS in 58m 51s\n- ansible-collections-openstack-functional-devstack-xena-ansible-2.12 https://zuul.opendev.org/t/openstack/build/e8657ef80b89423c94eea9052209137e : SUCCESS in 48m 56s\n- ansible-collections-openstack-functional-devstack-wallaby-ansible-2.12 https://zuul.opendev.org/t/openstack/build/b5644e5170c747a8a7809b6a2d529f1e : SUCCESS in 55m 05s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.11 https://zuul.opendev.org/t/openstack/build/32c22ff7feb54920a441a1ae3f615b47 : SUCCESS in 54m 24s\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/641ed8e4023c45b990e6e8449238c173 : SUCCESS in 24m 42s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/9e8ecf847f504ae3b1606d8a4893130f : SUCCESS in 28m 44s (non-voting)\n- tripleo-ci-centos-9-standalone-osa-wallaby https://zuul.opendev.org/t/openstack/build/2f116ff946804197954b19c1d89030b3 : SUCCESS in 1h 54m 05s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4fee0168144ac5101dbd97e9a42c25e28f19b871","author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"date":"2022-09-07 16:37:29.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"08d54c96c08c4a91d42ad151c710f645e620bcb6","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-09-07 18:02:48.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"286e870a3ffed212f8c2dc52419ca88a487fa51c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-07 18:03:29.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6cf8ad727b62a67bc5aee032272055a72a49205c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-07 19:07:27.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/293fcc3f99cc45d1b5e0214ab36bb9bf\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/b851bec8bccb47cb827ee5d47face4a4 : SUCCESS in 5m 54s\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/4c67b390c9af468d904f867ae644f6cc : SUCCESS in 11m 10s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/b1141df2ea0843a49d7bc20c4dee3319 : SUCCESS in 54m 14s\n- ansible-collections-openstack-functional-devstack-wallaby-ansible-2.12 https://zuul.opendev.org/t/openstack/build/3b021f6f9a934603a3e67546707ccc33 : SUCCESS in 1h 02m 14s\n- ansible-collections-openstack-functional-devstack-xena-ansible-2.12 https://zuul.opendev.org/t/openstack/build/92918fb220144e81824071268e07c594 : SUCCESS in 54m 02s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.11 https://zuul.opendev.org/t/openstack/build/e6afa7b7dc394edb9ede72318864ba42 : SUCCESS in 1h 03m 35s","accounts_in_message":[],"_revision_number":1},{"id":"93e1e238f36a2d0a0acb356483593230b07987e1","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-07 19:07:27.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8dfcd177311bc1cca0ea03c6333d6b9289e3c1b0","revisions":{"8dfcd177311bc1cca0ea03c6333d6b9289e3c1b0":{"kind":"REWORK","_number":1,"created":"2022-09-07 14:04:48.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/01/856201/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/01/856201/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/01/856201/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/01/856201/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/01/856201/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/01/856201/1"}}},"commit":{"parents":[{"commit":"39bb4909ee3a9418f60ff66d7496ed1f8259972d","subject":"Fix release job","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/39bb4909ee3a9418f60ff66d7496ed1f8259972d"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-09-07 07:09:08.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-09-07 14:04:48.000000000","tz":0},"subject":"Do not remove trailing spaces when reading public key in keypair module","message":"Do not remove trailing spaces when reading public key in keypair module\n\nPreviously, openstack.cloud.keypair would remove trailing spaces after\nreading a public key from a file. The openstack cli tool, python-\\\nopenstackclient, does not do so, i.e. it does not use rstrip to remove\nspaces at the end [1]. This breaks idempotency when using openstack\ncli tool and our keypair module at the same time.\n\nThe rstrip code was introduced to keypair when our modules were still\npart of ansible (non-core) in a completely unrelated change [2].\n\nNow, keypair module does no longer alter the public key and instead\nuploads it unchanged to OpenStack API.\n\n[1] https://opendev.org/openstack/python-openstackclient/src/commit/7df94c9f821aa7fabef09cad9e6ab16ed66d46b6/openstackclient/compute/v2/keypair.py#L103\n[2] https://github.com/ansible/ansible/commit/341efbf7ae078d9818b17036af5ccfed277db52d\n\nStory: 2008574\nTask: 41726\nChange-Id: Ia09658467d98516ca1ea612e7301629b2f69d2d1\n(cherry picked from commit 73827a3d574a6149bfc0984d0c9838ed4f9881d5)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/8dfcd177311bc1cca0ea03c6333d6b9289e3c1b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/8dfcd177311bc1cca0ea03c6333d6b9289e3c1b0"}]},"branch":"refs/heads/stable/1.0.0"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}}]}],"submit_requirements":[]}