)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e600f14958cbfc3ee4e01167f844e0f25c7192ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aecdf521_e2c7753b","updated":"2022-09-12 21:08:36.000000000","message":"Thanks for the contribution! Please fix 3 linter issues, it doesn\u0027t allow \"elements\" keyword in RETURN.","commit_id":"869073d8b543dade46c6d1627aa2973a0cbb8e0c"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"13bec5e383c98d7a596530e3827752661f74a8bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ae0067d9_2b16446e","updated":"2022-09-20 10:35:15.000000000","message":"Solid work, Kristian 👍 Thanks!\n\nAdded a couple of comments below.","commit_id":"0dfebebf7fca19feb1fbe98a541322becc49be61"}],"ci/roles/subnet/defaults/main.yml":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"13bec5e383c98d7a596530e3827752661f74a8bc","unresolved":true,"context_lines":[{"line_number":23,"context_line":"  - tags"},{"line_number":24,"context_line":"  - updated_at"},{"line_number":25,"context_line":"  - use_default_subnet_pool"},{"line_number":26,"context_line":"  - dns_publish_fixed_ip"},{"line_number":27,"context_line":"  - host_routes"},{"line_number":28,"context_line":"subnet_name: shade_subnet"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b72f77f0_790f4ca5","line":26,"updated":"2022-09-20 10:35:15.000000000","message":"Please move up, expected_fields is sorted for better readability.","commit_id":"0dfebebf7fca19feb1fbe98a541322becc49be61"},{"author":{"_account_id":32671,"name":"Kristian Kucerak","email":"kucerakk@gmail.com","username":"kucerakk"},"change_message_id":"d642fcd2b89943e3c27ad1875052133acb663e76","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  - tags"},{"line_number":24,"context_line":"  - updated_at"},{"line_number":25,"context_line":"  - use_default_subnet_pool"},{"line_number":26,"context_line":"  - dns_publish_fixed_ip"},{"line_number":27,"context_line":"  - host_routes"},{"line_number":28,"context_line":"subnet_name: shade_subnet"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"88029866_4aa9cc8b","line":26,"in_reply_to":"51d43765_e7d1e32b","updated":"2022-09-26 07:36:04.000000000","message":"Done","commit_id":"0dfebebf7fca19feb1fbe98a541322becc49be61"},{"author":{"_account_id":32671,"name":"Kristian Kucerak","email":"kucerakk@gmail.com","username":"kucerakk"},"change_message_id":"9baf3589e90ebcfed832fe3ac547a18811ec4e67","unresolved":true,"context_lines":[{"line_number":23,"context_line":"  - tags"},{"line_number":24,"context_line":"  - updated_at"},{"line_number":25,"context_line":"  - use_default_subnet_pool"},{"line_number":26,"context_line":"  - dns_publish_fixed_ip"},{"line_number":27,"context_line":"  - host_routes"},{"line_number":28,"context_line":"subnet_name: shade_subnet"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"51d43765_e7d1e32b","line":26,"in_reply_to":"b72f77f0_790f4ca5","updated":"2022-09-26 07:33:49.000000000","message":"done","commit_id":"0dfebebf7fca19feb1fbe98a541322becc49be61"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"13bec5e383c98d7a596530e3827752661f74a8bc","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  - updated_at"},{"line_number":25,"context_line":"  - use_default_subnet_pool"},{"line_number":26,"context_line":"  - dns_publish_fixed_ip"},{"line_number":27,"context_line":"  - host_routes"},{"line_number":28,"context_line":"subnet_name: shade_subnet"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c6321e77_b7f82a76","line":27,"updated":"2022-09-20 10:35:15.000000000","message":"Pleas drop, it\u0027s already an list entry, above.","commit_id":"0dfebebf7fca19feb1fbe98a541322becc49be61"},{"author":{"_account_id":32671,"name":"Kristian Kucerak","email":"kucerakk@gmail.com","username":"kucerakk"},"change_message_id":"d642fcd2b89943e3c27ad1875052133acb663e76","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  - updated_at"},{"line_number":25,"context_line":"  - use_default_subnet_pool"},{"line_number":26,"context_line":"  - dns_publish_fixed_ip"},{"line_number":27,"context_line":"  - host_routes"},{"line_number":28,"context_line":"subnet_name: shade_subnet"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a3eb397_e9ea2e7e","line":27,"in_reply_to":"1f6eb4b6_9945ec06","updated":"2022-09-26 07:36:04.000000000","message":"Done","commit_id":"0dfebebf7fca19feb1fbe98a541322becc49be61"},{"author":{"_account_id":32671,"name":"Kristian Kucerak","email":"kucerakk@gmail.com","username":"kucerakk"},"change_message_id":"9baf3589e90ebcfed832fe3ac547a18811ec4e67","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  - updated_at"},{"line_number":25,"context_line":"  - use_default_subnet_pool"},{"line_number":26,"context_line":"  - dns_publish_fixed_ip"},{"line_number":27,"context_line":"  - host_routes"},{"line_number":28,"context_line":"subnet_name: shade_subnet"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f6eb4b6_9945ec06","line":27,"in_reply_to":"c6321e77_b7f82a76","updated":"2022-09-26 07:33:49.000000000","message":"done","commit_id":"0dfebebf7fca19feb1fbe98a541322becc49be61"}],"plugins/modules/subnets_info.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e600f14958cbfc3ee4e01167f844e0f25c7192ae","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    msg: \"{{ result.subnets }}\""},{"line_number":79,"context_line":"\u0027\u0027\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":82,"context_line":"subnets:"},{"line_number":83,"context_line":"    description: has all the openstack information about the subnets"},{"line_number":84,"context_line":"    returned: always, but can be empty list"}],"source_content_type":"text/x-python","patch_set":2,"id":"824c2001_629d441a","line":81,"range":{"start_line":81,"start_character":1,"end_line":81,"end_character":8},"updated":"2022-09-12 21:08:36.000000000","message":"2022-09-12 14:41:59.307710 | ubuntu-focal | ERROR: Found 3 validate-modules issue(s) which need to be resolved:\n2022-09-12 14:41:59.307833 | ubuntu-focal | ERROR: plugins/modules/subnets_info.py:0:0: return-syntax-error: RETURN.subnets.contains.host_routes.element: extra keys not allowed @ data[\u0027subnets\u0027][\u0027contains\u0027][\u0027host_routes\u0027][\u0027element\u0027]. Got \u0027dict\u0027\n2022-09-12 14:41:59.307890 | ubuntu-focal | ERROR: plugins/modules/subnets_info.py:0:0: return-syntax-error: RETURN.subnets.contains.service_types.element: extra keys not allowed @ data[\u0027subnets\u0027][\u0027contains\u0027][\u0027service_types\u0027][\u0027element\u0027]. Got \u0027str\u0027\n2022-09-12 14:41:59.307943 | ubuntu-focal | ERROR: plugins/modules/subnets_info.py:0:0: return-syntax-error: RETURN.subnets.contains.tags.element: extra keys not allowed @ data[\u0027subnets\u0027][\u0027contains\u0027][\u0027tags\u0027][\u0027element\u0027]. Got \u0027str\u0027","commit_id":"869073d8b543dade46c6d1627aa2973a0cbb8e0c"},{"author":{"_account_id":32671,"name":"Kristian Kucerak","email":"kucerakk@gmail.com","username":"kucerakk"},"change_message_id":"9baf3589e90ebcfed832fe3ac547a18811ec4e67","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    msg: \"{{ result.subnets }}\""},{"line_number":79,"context_line":"\u0027\u0027\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":82,"context_line":"subnets:"},{"line_number":83,"context_line":"    description: has all the openstack information about the subnets"},{"line_number":84,"context_line":"    returned: always, but can be empty list"}],"source_content_type":"text/x-python","patch_set":2,"id":"0434a4af_eb14846f","line":81,"range":{"start_line":81,"start_character":1,"end_line":81,"end_character":8},"in_reply_to":"824c2001_629d441a","updated":"2022-09-26 07:33:49.000000000","message":"Done","commit_id":"869073d8b543dade46c6d1627aa2973a0cbb8e0c"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"13bec5e383c98d7a596530e3827752661f74a8bc","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    msg: \"{{ result.subnets }}\""},{"line_number":79,"context_line":"\u0027\u0027\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":82,"context_line":"subnets:"},{"line_number":83,"context_line":"    description: has all the openstack information about the subnets"},{"line_number":84,"context_line":"    returned: always, but can be empty list"}],"source_content_type":"text/x-python","patch_set":2,"id":"7668b452_39a33442","line":81,"range":{"start_line":81,"start_character":1,"end_line":81,"end_character":8},"in_reply_to":"824c2001_629d441a","updated":"2022-09-20 10:35:15.000000000","message":"Done","commit_id":"869073d8b543dade46c6d1627aa2973a0cbb8e0c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e600f14958cbfc3ee4e01167f844e0f25c7192ae","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        host_routes:"},{"line_number":130,"context_line":"            description: Additional routes for the subnet."},{"line_number":131,"context_line":"            type: list"},{"line_number":132,"context_line":"            element: dict"},{"line_number":133,"context_line":"        ipv6_address_mode:"},{"line_number":134,"context_line":"            description: The IPv6 address modes specifies mechanisms for assigning IP addresses."},{"line_number":135,"context_line":"            type: str"}],"source_content_type":"text/x-python","patch_set":2,"id":"07da6849_50f5a524","line":132,"range":{"start_line":132,"start_character":12,"end_line":132,"end_character":25},"updated":"2022-09-12 21:08:36.000000000","message":"please remove this","commit_id":"869073d8b543dade46c6d1627aa2973a0cbb8e0c"},{"author":{"_account_id":32671,"name":"Kristian Kucerak","email":"kucerakk@gmail.com","username":"kucerakk"},"change_message_id":"9baf3589e90ebcfed832fe3ac547a18811ec4e67","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        host_routes:"},{"line_number":130,"context_line":"            description: Additional routes for the subnet."},{"line_number":131,"context_line":"            type: list"},{"line_number":132,"context_line":"            element: dict"},{"line_number":133,"context_line":"        ipv6_address_mode:"},{"line_number":134,"context_line":"            description: The IPv6 address modes specifies mechanisms for assigning IP addresses."},{"line_number":135,"context_line":"            type: str"}],"source_content_type":"text/x-python","patch_set":2,"id":"c3e6a11c_fc055430","line":132,"range":{"start_line":132,"start_character":12,"end_line":132,"end_character":25},"in_reply_to":"07da6849_50f5a524","updated":"2022-09-26 07:33:49.000000000","message":"Done","commit_id":"869073d8b543dade46c6d1627aa2973a0cbb8e0c"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"13bec5e383c98d7a596530e3827752661f74a8bc","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        host_routes:"},{"line_number":130,"context_line":"            description: Additional routes for the subnet."},{"line_number":131,"context_line":"            type: list"},{"line_number":132,"context_line":"            element: dict"},{"line_number":133,"context_line":"        ipv6_address_mode:"},{"line_number":134,"context_line":"            description: The IPv6 address modes specifies mechanisms for assigning IP addresses."},{"line_number":135,"context_line":"            type: str"}],"source_content_type":"text/x-python","patch_set":2,"id":"55fed03f_c5846dbe","line":132,"range":{"start_line":132,"start_character":12,"end_line":132,"end_character":25},"in_reply_to":"07da6849_50f5a524","updated":"2022-09-20 10:35:15.000000000","message":"Kristian, I guess you meant \u0027elements\u0027 (missing an \u0027s\u0027)?","commit_id":"869073d8b543dade46c6d1627aa2973a0cbb8e0c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e600f14958cbfc3ee4e01167f844e0f25c7192ae","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        service_types:"},{"line_number":149,"context_line":"            description: The service types associated with the subnet."},{"line_number":150,"context_line":"            type: list"},{"line_number":151,"context_line":"            element: str"},{"line_number":152,"context_line":"        subnet_pool_id:"},{"line_number":153,"context_line":"            description: The ID of the subnet pool associated with the subnet."},{"line_number":154,"context_line":"            type: str"}],"source_content_type":"text/x-python","patch_set":2,"id":"d9515002_51e67c97","line":151,"range":{"start_line":151,"start_character":12,"end_line":151,"end_character":24},"updated":"2022-09-12 21:08:36.000000000","message":"please remove this","commit_id":"869073d8b543dade46c6d1627aa2973a0cbb8e0c"},{"author":{"_account_id":32671,"name":"Kristian Kucerak","email":"kucerakk@gmail.com","username":"kucerakk"},"change_message_id":"9baf3589e90ebcfed832fe3ac547a18811ec4e67","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        service_types:"},{"line_number":149,"context_line":"            description: The service types associated with the subnet."},{"line_number":150,"context_line":"            type: list"},{"line_number":151,"context_line":"            element: str"},{"line_number":152,"context_line":"        subnet_pool_id:"},{"line_number":153,"context_line":"            description: The ID of the subnet pool associated with the subnet."},{"line_number":154,"context_line":"            type: str"}],"source_content_type":"text/x-python","patch_set":2,"id":"288cf336_aa296c49","line":151,"range":{"start_line":151,"start_character":12,"end_line":151,"end_character":24},"in_reply_to":"d9515002_51e67c97","updated":"2022-09-26 07:33:49.000000000","message":"Done","commit_id":"869073d8b543dade46c6d1627aa2973a0cbb8e0c"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"13bec5e383c98d7a596530e3827752661f74a8bc","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        service_types:"},{"line_number":149,"context_line":"            description: The service types associated with the subnet."},{"line_number":150,"context_line":"            type: list"},{"line_number":151,"context_line":"            element: str"},{"line_number":152,"context_line":"        subnet_pool_id:"},{"line_number":153,"context_line":"            description: The ID of the subnet pool associated with the subnet."},{"line_number":154,"context_line":"            type: str"}],"source_content_type":"text/x-python","patch_set":2,"id":"eda40aeb_2976c76b","line":151,"range":{"start_line":151,"start_character":12,"end_line":151,"end_character":24},"in_reply_to":"d9515002_51e67c97","updated":"2022-09-20 10:35:15.000000000","message":"Kristian, I guess you meant \u0027elements\u0027 (missing an \u0027s\u0027)?","commit_id":"869073d8b543dade46c6d1627aa2973a0cbb8e0c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e600f14958cbfc3ee4e01167f844e0f25c7192ae","unresolved":true,"context_lines":[{"line_number":155,"context_line":"        tags:"},{"line_number":156,"context_line":"            description: The list of tags on the resource."},{"line_number":157,"context_line":"            type: list"},{"line_number":158,"context_line":"            element: str"},{"line_number":159,"context_line":"        prefix_length:"},{"line_number":160,"context_line":"            description: The prefix length to use for subnet allocation from a subnet pool."},{"line_number":161,"context_line":"            type: str"}],"source_content_type":"text/x-python","patch_set":2,"id":"e34f47bf_2bbc6ba6","line":158,"range":{"start_line":158,"start_character":12,"end_line":158,"end_character":24},"updated":"2022-09-12 21:08:36.000000000","message":"please remove this","commit_id":"869073d8b543dade46c6d1627aa2973a0cbb8e0c"},{"author":{"_account_id":32671,"name":"Kristian Kucerak","email":"kucerakk@gmail.com","username":"kucerakk"},"change_message_id":"9baf3589e90ebcfed832fe3ac547a18811ec4e67","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        tags:"},{"line_number":156,"context_line":"            description: The list of tags on the resource."},{"line_number":157,"context_line":"            type: list"},{"line_number":158,"context_line":"            element: str"},{"line_number":159,"context_line":"        prefix_length:"},{"line_number":160,"context_line":"            description: The prefix length to use for subnet allocation from a subnet pool."},{"line_number":161,"context_line":"            type: str"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ecc9518_3d47f1bf","line":158,"range":{"start_line":158,"start_character":12,"end_line":158,"end_character":24},"in_reply_to":"e34f47bf_2bbc6ba6","updated":"2022-09-26 07:33:49.000000000","message":"Done","commit_id":"869073d8b543dade46c6d1627aa2973a0cbb8e0c"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"13bec5e383c98d7a596530e3827752661f74a8bc","unresolved":true,"context_lines":[{"line_number":155,"context_line":"        tags:"},{"line_number":156,"context_line":"            description: The list of tags on the resource."},{"line_number":157,"context_line":"            type: list"},{"line_number":158,"context_line":"            element: str"},{"line_number":159,"context_line":"        prefix_length:"},{"line_number":160,"context_line":"            description: The prefix length to use for subnet allocation from a subnet pool."},{"line_number":161,"context_line":"            type: str"}],"source_content_type":"text/x-python","patch_set":2,"id":"012f59f2_4288bdbe","line":158,"range":{"start_line":158,"start_character":12,"end_line":158,"end_character":24},"in_reply_to":"e34f47bf_2bbc6ba6","updated":"2022-09-20 10:35:15.000000000","message":"Kristian, I guess you meant \u0027elements\u0027 (missing an \u0027s\u0027)?","commit_id":"869073d8b543dade46c6d1627aa2973a0cbb8e0c"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"13bec5e383c98d7a596530e3827752661f74a8bc","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    def run(self):"},{"line_number":177,"context_line":"        kwargs \u003d {}"},{"line_number":178,"context_line":"        if self.params[\u0027name\u0027]:"},{"line_number":179,"context_line":"            kwargs[\u0027name\u0027] \u003d self.params[\u0027name\u0027]"},{"line_number":180,"context_line":"        if self.params[\u0027filters\u0027]:"},{"line_number":181,"context_line":"            kwargs.update(self.params[\u0027filters\u0027])"},{"line_number":182,"context_line":"        subnets \u003d self.conn.network.subnets(**kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"585892df_d8b3cc53","line":179,"updated":"2022-09-20 10:35:15.000000000","message":"Unfortunately, this does not work when name is actually an id. The previous code allowed to search by name or id. The new code sends name as a query parameter but this will only return subnets with names matching \u0027name\u0027 [1].\n\nPlease continue to use sdk\u0027s cloud layer function self.conn.search_subnets() here. It is broken in sdk\u0027s master branch atm [2], i know, but artem is working on that. Maybe you could remind him of this issue, next time you see him ;)\n\n[1] https://docs.openstack.org/api-ref/network/v2/?expanded\u003dlist-subnets-detail#list-subnets\n[2] https://opendev.org/openstack/openstacksdk/src/commit/44089c11d6b959b14cfc8c0eeabc2209491de1aa/openstack/cloud/_network.py#L94","commit_id":"0dfebebf7fca19feb1fbe98a541322becc49be61"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"4efeba6c5627b1c37629773c025f6146f20d4adc","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    def run(self):"},{"line_number":177,"context_line":"        kwargs \u003d {}"},{"line_number":178,"context_line":"        if self.params[\u0027name\u0027]:"},{"line_number":179,"context_line":"            kwargs[\u0027name\u0027] \u003d self.params[\u0027name\u0027]"},{"line_number":180,"context_line":"        if self.params[\u0027filters\u0027]:"},{"line_number":181,"context_line":"            kwargs.update(self.params[\u0027filters\u0027])"},{"line_number":182,"context_line":"        subnets \u003d self.conn.network.subnets(**kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1e23bec8_aaec8291","line":179,"in_reply_to":"0aaa2bb9_e56e617c","updated":"2022-09-30 08:23:39.000000000","message":"Artem implemented the old functionality here:\n\n  https://review.opendev.org/c/openstack/openstacksdk/+/859845\n  \nKristian, could you please switch your code to use this search_resources() function? To test this without Artem\u0027s patch being merged, add this to your commit message:\n\nDepends-On: https://review.opendev.org/c/openstack/openstacksdk/+/859845","commit_id":"0dfebebf7fca19feb1fbe98a541322becc49be61"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"522e95b7d1a345449970d76d941576baa1638034","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    def run(self):"},{"line_number":177,"context_line":"        kwargs \u003d {}"},{"line_number":178,"context_line":"        if self.params[\u0027name\u0027]:"},{"line_number":179,"context_line":"            kwargs[\u0027name\u0027] \u003d self.params[\u0027name\u0027]"},{"line_number":180,"context_line":"        if self.params[\u0027filters\u0027]:"},{"line_number":181,"context_line":"            kwargs.update(self.params[\u0027filters\u0027])"},{"line_number":182,"context_line":"        subnets \u003d self.conn.network.subnets(**kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"031849aa_1c4a89d8","line":179,"in_reply_to":"1e23bec8_aaec8291","updated":"2022-10-26 08:03:02.000000000","message":"As we do not have a better approach in the sdk yet, let us go with this solution.","commit_id":"0dfebebf7fca19feb1fbe98a541322becc49be61"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ced83f5fb886e60e5368db972420f2487f55c22f","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    def run(self):"},{"line_number":177,"context_line":"        kwargs \u003d {}"},{"line_number":178,"context_line":"        if self.params[\u0027name\u0027]:"},{"line_number":179,"context_line":"            kwargs[\u0027name\u0027] \u003d self.params[\u0027name\u0027]"},{"line_number":180,"context_line":"        if self.params[\u0027filters\u0027]:"},{"line_number":181,"context_line":"            kwargs.update(self.params[\u0027filters\u0027])"},{"line_number":182,"context_line":"        subnets \u003d self.conn.network.subnets(**kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0aaa2bb9_e56e617c","line":179,"in_reply_to":"407604a1_98a24164","updated":"2022-09-27 12:22:32.000000000","message":"Different approach: https://review.opendev.org/c/openstack/openstacksdk/+/859409","commit_id":"0dfebebf7fca19feb1fbe98a541322becc49be61"},{"author":{"_account_id":32671,"name":"Kristian Kucerak","email":"kucerakk@gmail.com","username":"kucerakk"},"change_message_id":"9baf3589e90ebcfed832fe3ac547a18811ec4e67","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    def run(self):"},{"line_number":177,"context_line":"        kwargs \u003d {}"},{"line_number":178,"context_line":"        if self.params[\u0027name\u0027]:"},{"line_number":179,"context_line":"            kwargs[\u0027name\u0027] \u003d self.params[\u0027name\u0027]"},{"line_number":180,"context_line":"        if self.params[\u0027filters\u0027]:"},{"line_number":181,"context_line":"            kwargs.update(self.params[\u0027filters\u0027])"},{"line_number":182,"context_line":"        subnets \u003d self.conn.network.subnets(**kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e8b9aa47_b3db7352","line":179,"in_reply_to":"585892df_d8b3cc53","updated":"2022-09-26 07:33:49.000000000","message":"Discussed it with Artem, and he was not in favor of doing it through the cloud layer, instead he suggested to use get_subnet() from proxy to try to fetch subnet by ID and if it does not succeed, then go with regular list() including name and filters attrs. What do you think of this solution ?","commit_id":"0dfebebf7fca19feb1fbe98a541322becc49be61"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8bb3885d1ff3b495867da69733cb9eecf711bf11","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    def run(self):"},{"line_number":177,"context_line":"        kwargs \u003d {}"},{"line_number":178,"context_line":"        if self.params[\u0027name\u0027]:"},{"line_number":179,"context_line":"            kwargs[\u0027name\u0027] \u003d self.params[\u0027name\u0027]"},{"line_number":180,"context_line":"        if self.params[\u0027filters\u0027]:"},{"line_number":181,"context_line":"            kwargs.update(self.params[\u0027filters\u0027])"},{"line_number":182,"context_line":"        subnets \u003d self.conn.network.subnets(**kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"407604a1_98a24164","line":179,"in_reply_to":"e8b9aa47_b3db7352","updated":"2022-09-27 09:42:42.000000000","message":"We do not want to duplicate openstacksdk\u0027s functionality in Ansible modules, especially for functionality which once worked in openstacksdk.\n\nSubmitted a patch to restore old functionality in openstacksdk:\n\n  https://review.opendev.org/c/openstack/openstacksdk/+/859396","commit_id":"0dfebebf7fca19feb1fbe98a541322becc49be61"}]}