)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"7310ae5e774c18adef2235d9430c687769f7ac6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"06f83338_ea02e928","updated":"2022-09-19 13:36:39.000000000","message":"recheck depends-on updated","commit_id":"647770e2ee6ea4e5e57b67f64334369683d06f08"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"12993c2f34ee5d54b4cf95c03004a8ce60a2fac3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"20832da2_d6fa9d58","updated":"2022-09-30 08:19:45.000000000","message":"Thank you, Rafael ☺️\n\nPlease mark this patch as wip until Depends-On patch has been merged and the changes to .zuul.yaml have been undone.\n\nSome thoughts on the patch itself:\n* good idea to drop try-except blocks, esp. for getattr which cannot happen (anymore?)\n* drop changes to galaxy.yml\n* rename \u0027shelf\u0027 to \u0027shelve\u0027\n* add tests for shelve_offload\n* no need for two actions shelve_offload and shelf_offload, the latter is a typo.\n* when changing to different openstacksdk functions, check whether the new functions still support previous args, especially because openstacksdk is often ignoring unknown attributes silently\n* ensure to consider each edge cases of the previous code, e.g. special actions\n* state in code or commit message when you discard functionality of the previous code\n* please rename module attribute \u0027server\u0027 to \u0027name\u0027 for consistency with other modules. keep \u0027server\u0027 as an alias for backward compat.\n* Comment \u0027# admin_password is required by SDK, but not required by Nova API\u0027 does no longer apply which is why you dropped the conditional in the first place?\n* Comment about Munch in _wait() function does no longer apply?!?\n* what is the reason for \u0027# for some reason we don\u0027t wait for lock and unlock before exit\u0027?\n\nVoted -1 simply to mark this patch as \"requires more work\".","commit_id":"6657ecf6393d3b2478bbb94b68e1f8e699776cc6"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"3fb46ed676422b6c2fcd5e2dee82712abf0d2646","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"97dd593e_71ac8a60","in_reply_to":"20832da2_d6fa9d58","updated":"2022-10-03 23:06:42.000000000","message":"Thanks for the review. I agree on most of these points.\n\nThe shelf unload issue isn\u0027t a typo and isn\u0027t as cut and dry as it seems. Looking at the docs[1], it seems both are used. shelveOffload is the name of the action in the api, but the action is referred to as Shelf-Offload. I leaned towards shelf-offload since it makes more grammatical sense (to unload from the shelf). I understand the argument for using either name and honestly wouldn\u0027t lose any sleep whichever way we went. Just explaining my rationale.\n\n[1] https://docs.openstack.org/api-ref/compute/?expanded\u003dshelf-offload-remove-server-shelveoffload-action-detail#shelf-offload-remove-server-shelveoffload-action","commit_id":"6657ecf6393d3b2478bbb94b68e1f8e699776cc6"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"3cec7aa29ac3ef05b48e60382bee6e246b67810a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5682782b_a102dd77","in_reply_to":"5251d1e2_9715b7a0","updated":"2023-01-19 07:58:31.000000000","message":"Replaced Depends-On patch with TODO markers in code and fixe all outstanding issues.","commit_id":"6657ecf6393d3b2478bbb94b68e1f8e699776cc6"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"49917f53cdc7ba216955936f6f1a0fd0fd5c440b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c6b2d290_1bf941f8","in_reply_to":"97dd593e_71ac8a60","updated":"2022-10-04 13:29:27.000000000","message":"The noun is shelf [1],[2], but the verb (and action) is (to) shelve [3],[4]. Maybe we should submit a patch to fix the typo in Nova\u0027s API docs...\n\n[1] https://www.merriam-webster.com/dictionary/shelf\n[2] https://dictionary.cambridge.org/dictionary/english/shelf\n[3] https://www.merriam-webster.com/dictionary/shelve\n[4] https://dictionary.cambridge.org/dictionary/english/shelve","commit_id":"6657ecf6393d3b2478bbb94b68e1f8e699776cc6"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"61ec931a1ef4a03299c41839e71f5d5dffce2e83","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5251d1e2_9715b7a0","in_reply_to":"c6b2d290_1bf941f8","updated":"2022-10-04 17:21:15.000000000","message":"The last comment was more for me than for you. I agree the naming is not optimal but i would stick to api name(s).","commit_id":"6657ecf6393d3b2478bbb94b68e1f8e699776cc6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6f11c326918f1612bdbaec7c437c5e5f52c294be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"726d312c_93d24e20","updated":"2023-01-17 16:38:18.000000000","message":"A few nits","commit_id":"b580c4209192faca3d5b7a213695babb41665c4e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"2aae4bf86a589388aaf7d750b993191513d257be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"dbf3aab2_f4255093","updated":"2023-01-17 12:32:40.000000000","message":"recheck because of ansible galaxy issue","commit_id":"b580c4209192faca3d5b7a213695babb41665c4e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"310185dae0521a51e3c6eaf1090a898525d7ab60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"224d2158_a1c942c4","updated":"2023-01-18 14:05:04.000000000","message":"recheck because of unrelated ci failures","commit_id":"8dea7d4f189de1e87331a20c7d48f19e8734bd49"}],"plugins/modules/server_action.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6f11c326918f1612bdbaec7c437c5e5f52c294be","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  admin_password:"},{"line_number":26,"context_line":"    description:"},{"line_number":27,"context_line":"      - Admin password for server to rebuild."},{"line_number":28,"context_line":"    type: str"},{"line_number":29,"context_line":"  all_projects:"},{"line_number":30,"context_line":"    description:"},{"line_number":31,"context_line":"      - Whether to search for server in all projects or the current project"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ec377fe_5be13cb5","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":13},"updated":"2023-01-17 16:38:18.000000000","message":"\"no_log: true\" ?","commit_id":"b580c4209192faca3d5b7a213695babb41665c4e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"3cec7aa29ac3ef05b48e60382bee6e246b67810a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  admin_password:"},{"line_number":26,"context_line":"    description:"},{"line_number":27,"context_line":"      - Admin password for server to rebuild."},{"line_number":28,"context_line":"    type: str"},{"line_number":29,"context_line":"  all_projects:"},{"line_number":30,"context_line":"    description:"},{"line_number":31,"context_line":"      - Whether to search for server in all projects or the current project"}],"source_content_type":"text/x-python","patch_set":16,"id":"0c64f843_c3eafc4c","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":13},"in_reply_to":"8190dc0f_95fefe3d","updated":"2023-01-19 07:58:31.000000000","message":"Done","commit_id":"b580c4209192faca3d5b7a213695babb41665c4e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"d49df939fba3473f00c841226bf452d9231dae63","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  admin_password:"},{"line_number":26,"context_line":"    description:"},{"line_number":27,"context_line":"      - Admin password for server to rebuild."},{"line_number":28,"context_line":"    type: str"},{"line_number":29,"context_line":"  all_projects:"},{"line_number":30,"context_line":"    description:"},{"line_number":31,"context_line":"      - Whether to search for server in all projects or the current project"}],"source_content_type":"text/x-python","patch_set":16,"id":"8190dc0f_95fefe3d","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":13},"in_reply_to":"9ec377fe_5be13cb5","updated":"2023-01-17 16:49:46.000000000","message":"Ansible modules do not define no_log in DOCUMENTATION, at least none of Ansible\u0027s own modules in devel and stable-2.9 branch.","commit_id":"b580c4209192faca3d5b7a213695babb41665c4e"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6f11c326918f1612bdbaec7c437c5e5f52c294be","unresolved":true,"context_lines":[{"line_number":31,"context_line":"      - Whether to search for server in all projects or the current project"},{"line_number":32,"context_line":"        only."},{"line_number":33,"context_line":"    type: bool"},{"line_number":34,"context_line":"    default: \u0027no\u0027"},{"line_number":35,"context_line":"  image:"},{"line_number":36,"context_line":"    description:"},{"line_number":37,"context_line":"      - Image name or ID the server should be rebuilt with."}],"source_content_type":"text/x-python","patch_set":16,"id":"dbe8bc89_f232a9c9","line":34,"range":{"start_line":34,"start_character":13,"end_line":34,"end_character":17},"updated":"2023-01-17 16:38:18.000000000","message":"false","commit_id":"b580c4209192faca3d5b7a213695babb41665c4e"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"d49df939fba3473f00c841226bf452d9231dae63","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      - Whether to search for server in all projects or the current project"},{"line_number":32,"context_line":"        only."},{"line_number":33,"context_line":"    type: bool"},{"line_number":34,"context_line":"    default: \u0027no\u0027"},{"line_number":35,"context_line":"  image:"},{"line_number":36,"context_line":"    description:"},{"line_number":37,"context_line":"      - Image name or ID the server should be rebuilt with."}],"source_content_type":"text/x-python","patch_set":16,"id":"246dfbf3_5067b223","line":34,"range":{"start_line":34,"start_character":13,"end_line":34,"end_character":17},"in_reply_to":"dbe8bc89_f232a9c9","updated":"2023-01-17 16:49:46.000000000","message":"Done","commit_id":"b580c4209192faca3d5b7a213695babb41665c4e"}]}