)]}'
{"id":"openstack%2Fansible-collections-openstack~862935","triplet_id":"openstack%2Fansible-collections-openstack~master~I1f3b9314e4d82674cd2ae45f6209de5611e2b6cb","project":"openstack/ansible-collections-openstack","branch":"master","topic":"server","attention_set":{},"removed_from_attention_set":{"32962":{"account":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"last_update":"2022-10-29 08:05:06.000000000","reason":"\u003cGERRIT_ACCOUNT_32962\u003e replied on the change","reason_account":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}}},"hashtags":[],"change_id":"I1f3b9314e4d82674cd2ae45f6209de5611e2b6cb","subject":"Revert openstack.cloud.server parameter user_data to userdata","status":"MERGED","created":"2022-10-28 16:28:19.000000000","updated":"2022-10-29 08:57:48.000000000","submitted":"2022-10-29 08:57:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"862935-server","meta_rev_id":"eff8cf9de6d4816cb95672d31fa19f68adbe8737","_number":862935,"virtual_id_number":862935,"owner":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-10-29 08:57:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"all":[{"value":2,"date":"2022-10-29 08:05:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"value":2,"date":"2022-10-28 16:29:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"all":[{"value":1,"date":"2022-10-29 08:05:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-28 16:29:26.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2022-10-28 17:50:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6d6fccb8bf6ad3a552d4fd3692f51f1dffb00ee5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-10-28 16:28:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d147f29847c672a3a7876c8b055e2c3f96c94244","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2022-10-28 16:29:26.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3fdd7dbf1aaaa8a17f11647e761f2df859165989","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-10-28 17:50:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/327710571a614a25bdbbb2dc8743483f\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/efb0be5b642b4202b24a7124076b07bd : SUCCESS in 3m 49s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/cb099a93a434459384a8b39716fd5dd5 : SUCCESS in 6m 49s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/ec310087d1904b51bcaa24491f7e8512 : SUCCESS in 9m 15s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/eb7c533b25bb473da3107495325d2466 : SUCCESS in 57m 50s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/0764b00ca08d4fe3ac658ea65bdf67d2 : SUCCESS in 52m 51s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/448c4b97d90f473db653ff64b67f7454 : SUCCESS in 46m 47s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/486cfa8b40bc487ab14737dc3b0df18d : SUCCESS in 1h 00m 23s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/bd8d863d13b64847aa27f7b26539949b : SUCCESS in 52m 45s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/562adfcc0f4144f790f683f34afde154 : SUCCESS in 46m 51s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/bb1d2552a9af415a9e349fef186463fa : SUCCESS in 36m 38s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9bf283f0be80034dd4f1d6f13772949a33eb3c86","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-10-29 08:05:06.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7158f02bc835e311d35ffd4ec1fb7e67011f1a07","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-10-29 08:05:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f464383e8dd16b3d04d64117028945722975e8a2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-10-29 08:57:48.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/87bd28b63b7c4c6bb1e542910ecba613\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/48fdb879b633449d8d86b9dca87b985c : SUCCESS in 3m 10s\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/dfea4c60909844f08fd2f50b263ef5b6 : SUCCESS in 7m 09s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/2326c0f70e0044c6bb7cf3c2ea831b66 : SUCCESS in 51m 18s","accounts_in_message":[],"_revision_number":1},{"id":"eff8cf9de6d4816cb95672d31fa19f68adbe8737","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-10-29 08:57:48.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1e27b6b69c46c71bb809d6243fec65e5b456d4ce","revisions":{"1e27b6b69c46c71bb809d6243fec65e5b456d4ce":{"kind":"REWORK","_number":1,"created":"2022-10-28 16:28:19.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/35/862935/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/35/862935/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/35/862935/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/35/862935/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/35/862935/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/35/862935/1"}}},"commit":{"parents":[{"commit":"65ac75b51875d1a744a46b5edd2245a3e1bca7c8","subject":"Run *-devstack-ansible-devel job on Ubuntu 22.04 LTS (Jammy Jellyfish)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/65ac75b51875d1a744a46b5edd2245a3e1bca7c8"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-10-28 16:19:24.000000000","tz":120},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-10-28 16:19:24.000000000","tz":120},"subject":"Revert openstack.cloud.server parameter user_data to userdata","message":"Revert openstack.cloud.server parameter user_data to userdata\n\nopenstacksdk\u0027s create_server() [1] takes cloud-init userdata as a\nplaintext string (or other data types [2]) via argument \u0027userdata\u0027,\nnot \u0027user_data\u0027 [3]. This is \u0027userdata\u0027 argument of create_server()\nis different from the \u0027user_data\u0027 value which is returned [4]. The\nlatter is base64 decoded, while the former is e.g. a plaintext string.\nAs a (tiny) visual indicator for this difference, this patch reverts\nthe module parameter \u0027user_data\u0027 to \u0027userdata\u0027 which was used before\nthis module got refactored [5].\n\n[1] https://opendev.org/openstack/openstacksdk/src/commit/57fbb72e32351f795f5888306096e8d3d35a64ef/openstack/cloud/_compute.py#L678\n[2] https://opendev.org/openstack/openstacksdk/src/commit/57fbb72e32351f795f5888306096e8d3d35a64ef/openstack/cloud/_compute.py#L1757\n[3] https://opendev.org/openstack/openstacksdk/src/commit/57fbb72e32351f795f5888306096e8d3d35a64ef/openstack/cloud/_compute.py#L796\n[4] https://opendev.org/openstack/openstacksdk/src/commit/57fbb72e32351f795f5888306096e8d3d35a64ef/openstack/compute/v2/server.py#L223\n[5] https://opendev.org/openstack/ansible-collections-openstack/commit/ac401bb354c6a1d388848a3ebd18537beba080cc\n\nChange-Id: I1f3b9314e4d82674cd2ae45f6209de5611e2b6cb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/1e27b6b69c46c71bb809d6243fec65e5b456d4ce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/1e27b6b69c46c71bb809d6243fec65e5b456d4ce"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}}]}],"submit_requirements":[]}
