)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ebe55c398fa120cbadb5e06f761ece8423359719","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d1417144_91efbf5c","updated":"2022-11-02 14:45:53.000000000","message":"Please add integration tests for this module to the ci/ subfolder, else its hard to verify that the module is working and future changes do not introduce regressions. or example, you could add a security_group_rules subfolder like the one we already have for security_group_rule (without s): \n\n  https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/ci/roles/security_group_rule/","commit_id":"7f3c7f704e6a6c60e2ba66737a734afe4c5d1302"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"f510488b11adebda3ceafef2002c80e3aa453a21","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"97d90d78_e4d75d89","updated":"2022-11-02 14:46:18.000000000","message":"Please also add your module here:\n\n  https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/meta/runtime.yml","commit_id":"7f3c7f704e6a6c60e2ba66737a734afe4c5d1302"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"f25c4921326afc3ab89e888c5b8a0b1b16a707cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"81a8a93e_6bf52b48","updated":"2022-11-02 14:42:12.000000000","message":"Thank you for your contribution, Balazs. Very much appreciated 😊\n\nPlease bear with us, reviewing will take time. We have to finish porting the whole collection to openstacksdk \u003e\u003d0.99.0 and we still have dozens of modules to adapt :/","commit_id":"7f3c7f704e6a6c60e2ba66737a734afe4c5d1302"},{"author":{"_account_id":35259,"name":"PB","email":"pokoradi.1899@gmail.com","username":"pb1899"},"change_message_id":"d0de4e88863dfff1c6eb70cdcc941fd78ae5a099","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ff51f9a6_8390a5c6","in_reply_to":"97d90d78_e4d75d89","updated":"2022-11-03 10:53:56.000000000","message":"That\u0027s now has been done (added and squashed the commit).","commit_id":"7f3c7f704e6a6c60e2ba66737a734afe4c5d1302"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"14eac6342c34a2be3f8c5d703e86223bb7432914","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e3c8841f_140cd97d","updated":"2022-11-09 13:17:55.000000000","message":"Can you please add tests?","commit_id":"576539f23e165addd59fa59a6ad54b770c9a27ca"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c0f102357e09d94974b255f605608ff7a41ea6f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"ce21d811_1ff0e77a","updated":"2022-11-30 12:43:27.000000000","message":"Hey Balazs,\nthank you for your patch ☺️\n\nI only had time for a glimpse at the patch, not a proper reviews. Here are some notes:\n\n* be consistent with other modules in style and coding. for example, modules with a \u0027_will_change\u0027 method follow a similar structure which supports updates and idempotency. its worth to follow this style even if your module does not support updates yet\n\n* if your module does not support updates, please mark attributes which cannot be updated, e.g. put \u0027- This attribute cannot be updated.\u0027 into their description\n\n* author must be OpenStack Ansible SIG, if this patch is completely written from scratch by you, then you can add your name to copyright comment at the beginning.\n\n* always stick to attribute names from openstacksdk for module inputs and outputs\n\n* use consistent names, e.g. not secgroup_rules vs security_group (former is abbreviated, latter is long form). in this case security_group_rules is more consistent with sdk and other modules.\n\n* DOCUMENTATION is for users: use \"simple\" english, try to avoid abbreviations (e.g. \u0027NB\u0027), move technical details about impl to code comments if it is not important for module usage\n\n* drop try-except since it base class will handle sdk errors\n\n* do not try to fix every user error, you will never be able to catch and fix them all. for example, you could drop _deduplicate_rules and let openstack raise an error, then users will fix their rules.\n\n* if you get useable output from openstacksdk (e.g. from create_security_group_rules), then return it to the user\n\n* remove dead code, e.g. old code im comments\n\nTo be continued.\n","commit_id":"6556b7d01a36566806c29ba027c810eff742d753"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"2449540899ed4f5b706cde64706ade35caeed5a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"6e4f34d8_582a40f0","updated":"2022-11-30 10:35:11.000000000","message":"Last patchset fixes linting issues and rebases patch on top of soon-to-be-head-of-master-branch.","commit_id":"6556b7d01a36566806c29ba027c810eff742d753"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"245754264c68b05ed2eafedac75d5997cdc4f6ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"6701b9bd_7b0e0589","updated":"2023-01-10 11:13:55.000000000","message":"Now looks much better","commit_id":"f2cb204a14ae5f6f3a664bcb446fdcee9350f76d"}]}