)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"10c72fd1880eeef22e7e6372823ba3a5284d42aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ca70ee2e_27e6cad9","updated":"2022-11-08 14:05:43.000000000","message":"Thanks, Sagi! Will wait with merging until ci is done and parent commit has been merged.","commit_id":"b3c2e8f1ce9f04565ed7259cd966567d62c911af"}],"plugins/modules/volume_snapshot.py":[{"author":{"_account_id":36622,"name":"Peter Strunk","display_name":"Peter Strunk","email":"peter.strunk@garmin.com","username":"psgrmn"},"change_message_id":"b41c876bf20e3fbd7796ee13965f122743ea7e0d","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _present_volume_snapshot(self):"},{"line_number":103,"context_line":"        volume \u003d self.conn.get_volume(self.params[\u0027volume\u0027])"},{"line_number":104,"context_line":"        snapshot \u003d self.conn.get_volume_snapshot("},{"line_number":105,"context_line":"            self.params[\u0027display_name\u0027], filters\u003d{\u0027volume_id\u0027: volume.id})"},{"line_number":106,"context_line":"        if not snapshot:"},{"line_number":107,"context_line":"            snapshot \u003d self.conn.create_volume_snapshot("},{"line_number":108,"context_line":"                volume.id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"43b9904e_3dde0365","side":"PARENT","line":105,"range":{"start_line":104,"start_character":8,"end_line":105,"end_character":74},"updated":"2024-03-24 14:43:59.000000000","message":"this previously checked for snapshots with matching display names AND volume_id","commit_id":"8c889f8eb35e8a4161e5419114f114d35b84020e"},{"author":{"_account_id":36622,"name":"Peter Strunk","display_name":"Peter Strunk","email":"peter.strunk@garmin.com","username":"psgrmn"},"change_message_id":"b41c876bf20e3fbd7796ee13965f122743ea7e0d","unresolved":true,"context_lines":[{"line_number":140,"context_line":"        name \u003d self.params[\u0027name\u0027]"},{"line_number":141,"context_line":"        state \u003d self.params[\u0027state\u0027]"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        snapshot \u003d self.conn.block_storage.find_snapshot(name)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        if self.ansible.check_mode:"},{"line_number":146,"context_line":"            self.exit_json(changed\u003dself._will_change(state, snapshot))"}],"source_content_type":"text/x-python","patch_set":6,"id":"5373b7c0_56f34cc7","line":143,"range":{"start_line":143,"start_character":8,"end_line":143,"end_character":16},"updated":"2024-03-24 14:43:59.000000000","message":"This no longer considers volume_id and is causing the conditional on line 148 to have new behavior.\n\nWas this change meant to enforce new volumes can\u0027t be created with a unique volume_id but an existing display_name?\n\nThis breaks the pattern of creating a new volume_id under the matching display_name, and then removing the older volume_id after a successful create.","commit_id":"b3c2e8f1ce9f04565ed7259cd966567d62c911af"},{"author":{"_account_id":36622,"name":"Peter Strunk","display_name":"Peter Strunk","email":"peter.strunk@garmin.com","username":"psgrmn"},"change_message_id":"6832322e9521325246bc23064d9c0aa2bda959a5","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        name \u003d self.params[\u0027name\u0027]"},{"line_number":141,"context_line":"        state \u003d self.params[\u0027state\u0027]"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        snapshot \u003d self.conn.block_storage.find_snapshot(name)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        if self.ansible.check_mode:"},{"line_number":146,"context_line":"            self.exit_json(changed\u003dself._will_change(state, snapshot))"}],"source_content_type":"text/x-python","patch_set":6,"id":"8a3a30ba_76acff99","line":143,"range":{"start_line":143,"start_character":8,"end_line":143,"end_character":16},"in_reply_to":"5373b7c0_56f34cc7","updated":"2024-04-03 14:52:47.000000000","message":"Was able to do same workflow by using unique volume_id, unique display_name, and a common description","commit_id":"b3c2e8f1ce9f04565ed7259cd966567d62c911af"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"a04d2c89ddf688c554670a87cbb993a7ff8de2dc","unresolved":true,"context_lines":[{"line_number":162,"context_line":"            self._delete(snapshot)"},{"line_number":163,"context_line":"            self.exit_json(changed\u003dTrue)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        else:  # state \u003d\u003d \u0027absent\u0027 and not snapshot"},{"line_number":166,"context_line":"            self.exit_json(changed\u003dFalse)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def _create(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"aa1f25c5_cc8c037f","line":165,"range":{"start_line":165,"start_character":8,"end_line":165,"end_character":12},"updated":"2022-11-08 13:48:22.000000000","message":"else is not necessary","commit_id":"b3c2e8f1ce9f04565ed7259cd966567d62c911af"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"10c72fd1880eeef22e7e6372823ba3a5284d42aa","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            self._delete(snapshot)"},{"line_number":163,"context_line":"            self.exit_json(changed\u003dTrue)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        else:  # state \u003d\u003d \u0027absent\u0027 and not snapshot"},{"line_number":166,"context_line":"            self.exit_json(changed\u003dFalse)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def _create(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"86e5dc63_a6dfa9fe","line":165,"range":{"start_line":165,"start_character":8,"end_line":165,"end_character":12},"in_reply_to":"aa1f25c5_cc8c037f","updated":"2022-11-08 14:05:43.000000000","message":"True, but i added it to stylize the conditionals/branches. The idea is to get a uniform indentation across all branches in order to improve readability.","commit_id":"b3c2e8f1ce9f04565ed7259cd966567d62c911af"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"a04d2c89ddf688c554670a87cbb993a7ff8de2dc","unresolved":true,"context_lines":[{"line_number":199,"context_line":"            return False"},{"line_number":200,"context_line":"        elif state \u003d\u003d \u0027absent\u0027 and snapshot:"},{"line_number":201,"context_line":"            return True"},{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            # state \u003d\u003d \u0027absent\u0027 and not snapshot:"},{"line_number":204,"context_line":"            return False"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"4db51d41_54be39ab","line":202,"range":{"start_line":202,"start_character":8,"end_line":202,"end_character":12},"updated":"2022-11-08 13:48:22.000000000","message":"and here","commit_id":"b3c2e8f1ce9f04565ed7259cd966567d62c911af"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"10c72fd1880eeef22e7e6372823ba3a5284d42aa","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            return False"},{"line_number":200,"context_line":"        elif state \u003d\u003d \u0027absent\u0027 and snapshot:"},{"line_number":201,"context_line":"            return True"},{"line_number":202,"context_line":"        else:"},{"line_number":203,"context_line":"            # state \u003d\u003d \u0027absent\u0027 and not snapshot:"},{"line_number":204,"context_line":"            return False"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"239db25c_4291c562","line":202,"range":{"start_line":202,"start_character":8,"end_line":202,"end_character":12},"in_reply_to":"4db51d41_54be39ab","updated":"2022-11-08 14:05:43.000000000","message":"As above, added for better ascertainability.","commit_id":"b3c2e8f1ce9f04565ed7259cd966567d62c911af"}]}