)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"d893ba4bdfebffa17ff350600f53e78423fdd106","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f5c5ecee_f687519c","updated":"2022-11-07 14:25:22.000000000","message":"recheck because depends-on patch has been changed","commit_id":"948eabf84950db952d0599f46a7e7068c627cb94"}],"plugins/modules/config.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d6f422f2a2ebd2ae98da7c7a427965ffaef880fe","unresolved":true,"context_lines":[{"line_number":27,"context_line":"\u0027\u0027\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RETURN \u003d r\u0027\u0027\u0027"},{"line_number":30,"context_line":"ansible_facts:"},{"line_number":31,"context_line":"  description: A dictionary with a single entry C(openstack)."},{"line_number":32,"context_line":"  returned: always"},{"line_number":33,"context_line":"  type: dict"}],"source_content_type":"text/x-python","patch_set":6,"id":"37469b8c_0eb7211b","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":13},"updated":"2022-11-06 13:12:24.000000000","message":"I think Ansible folks against returning \"ansible_facts\" in modules, since it overrides other \"ansible_facts\". Probably it\u0027s better to rename it.","commit_id":"015d1c73e0a2740f64e95f5b5713fc31be838cc8"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"4ab03730ea527a02e9090711ee4a1aaadeece47e","unresolved":true,"context_lines":[{"line_number":27,"context_line":"\u0027\u0027\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RETURN \u003d r\u0027\u0027\u0027"},{"line_number":30,"context_line":"ansible_facts:"},{"line_number":31,"context_line":"  description: A dictionary with a single entry C(openstack)."},{"line_number":32,"context_line":"  returned: always"},{"line_number":33,"context_line":"  type: dict"}],"source_content_type":"text/x-python","patch_set":6,"id":"478ee138_cd1e8c7c","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":13},"in_reply_to":"37469b8c_0eb7211b","updated":"2022-11-06 13:23:48.000000000","message":"I agree but if we do so, then users wont be able to use fact \u0027openstack.clouds\u0027 anymore. They will have to use register. Do you think we should replace ansible_facts with a regular return value such as clouds anyway?","commit_id":"015d1c73e0a2740f64e95f5b5713fc31be838cc8"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"72a4b9bc358bdceb4d52177ce7c32c05dffe782d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u0027\u0027\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RETURN \u003d r\u0027\u0027\u0027"},{"line_number":30,"context_line":"ansible_facts:"},{"line_number":31,"context_line":"  description: A dictionary with a single entry C(openstack)."},{"line_number":32,"context_line":"  returned: always"},{"line_number":33,"context_line":"  type: dict"}],"source_content_type":"text/x-python","patch_set":6,"id":"b9311eba_81d75217","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":13},"in_reply_to":"478ee138_cd1e8c7c","updated":"2022-11-07 09:14:36.000000000","message":"Latest patchset replaced ansible_facts with clouds variable.","commit_id":"015d1c73e0a2740f64e95f5b5713fc31be838cc8"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d6f422f2a2ebd2ae98da7c7a427965ffaef880fe","unresolved":true,"context_lines":[{"line_number":90,"context_line":"                clouds.append(cloud.config)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        module.exit_json(changed\u003dFalse,"},{"line_number":93,"context_line":"                         ansible_facts\u003ddict(openstack\u003ddict(clouds\u003dclouds)))"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    except exceptions.SDKException as e:"},{"line_number":96,"context_line":"        module.fail_json(msg\u003dstr(e))"}],"source_content_type":"text/x-python","patch_set":6,"id":"0ed77925_cb191d99","line":93,"range":{"start_line":93,"start_character":25,"end_line":93,"end_character":38},"updated":"2022-11-06 13:12:24.000000000","message":"Maybe something like \"cloud_configs\u003d... \"","commit_id":"015d1c73e0a2740f64e95f5b5713fc31be838cc8"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"72a4b9bc358bdceb4d52177ce7c32c05dffe782d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                clouds.append(cloud.config)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        module.exit_json(changed\u003dFalse,"},{"line_number":93,"context_line":"                         ansible_facts\u003ddict(openstack\u003ddict(clouds\u003dclouds)))"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    except exceptions.SDKException as e:"},{"line_number":96,"context_line":"        module.fail_json(msg\u003dstr(e))"}],"source_content_type":"text/x-python","patch_set":6,"id":"436d399e_d75a6d34","line":93,"range":{"start_line":93,"start_character":25,"end_line":93,"end_character":38},"in_reply_to":"0ed77925_cb191d99","updated":"2022-11-07 09:14:36.000000000","message":"Renamed to \u0027clouds\u0027.","commit_id":"015d1c73e0a2740f64e95f5b5713fc31be838cc8"}]}