)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"b9d017df80d917fd1b7a6848950f235c43fe3d16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dea11433_5a96dd17","updated":"2022-11-29 09:29:55.000000000","message":"Thanks, one comment.","commit_id":"1b19382c86a628b874d8d4c036d4dfc58a8a61ea"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"782e184d002841e495398dcb0521dac0fe20c847","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0c5fcf8c_cd7ee912","updated":"2023-01-04 11:14:41.000000000","message":"param in SDK is called is_multiattach","commit_id":"f70f6584a1d377aca64fbb17211e9a601e14632c"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"e236ecfcfdbf0fe4a6cdac656e9c859905c77fde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"27211e2d_0f70a72e","updated":"2023-01-05 16:39:24.000000000","message":"Thank you, Polina! Added a couple of comments.\n\nVoted -1 simply to mark this patch as \"requires more work\".\n","commit_id":"d985df3a09902a9ea04f34f44225510ec7f810a8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"4d0be01693952388d9581a0f798d312e05271b6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"de09c1ae_3766b0f6","updated":"2023-01-10 12:36:15.000000000","message":"thanks Jakob","commit_id":"52e7bfe7a418392a142b0e953025fd2473141356"}],"ci/roles/volume/defaults/main.yml":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"740a15fe2de00be42d9cfa48c55cec02ec727ddc","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  - host"},{"line_number":13,"context_line":"  - image_id"},{"line_number":14,"context_line":"  - is_bootable"},{"line_number":15,"context_line":"  - is_multiattach"},{"line_number":16,"context_line":"  - migration_id"},{"line_number":17,"context_line":"  - migration_status"},{"line_number":18,"context_line":"  - project_id"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f62987ff_601ffd16","line":15,"updated":"2023-01-10 08:11:41.000000000","message":"Why did you remove is_encrypted?","commit_id":"2be26f7ef405444a3ab56166e35ff52d2b54f982"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"feec309c206c1b9a758150480a9e2ef8a5201172","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - host"},{"line_number":13,"context_line":"  - image_id"},{"line_number":14,"context_line":"  - is_bootable"},{"line_number":15,"context_line":"  - is_multiattach"},{"line_number":16,"context_line":"  - migration_id"},{"line_number":17,"context_line":"  - migration_status"},{"line_number":18,"context_line":"  - project_id"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5dda1552_4799dbcf","line":15,"in_reply_to":"f62987ff_601ffd16","updated":"2023-01-10 12:34:32.000000000","message":"Restored in latest patchset.","commit_id":"2be26f7ef405444a3ab56166e35ff52d2b54f982"}],"plugins/modules/volume.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"b9d017df80d917fd1b7a6848950f235c43fe3d16","unresolved":true,"context_lines":[{"line_number":35,"context_line":"   is_multiattach:"},{"line_number":36,"context_line":"     description:"},{"line_number":37,"context_line":"       - Whether disk will be shareble or not."},{"line_number":38,"context_line":"     type: bool"},{"line_number":39,"context_line":"     default: False"},{"line_number":40,"context_line":"   metadata:"},{"line_number":41,"context_line":"     description:"},{"line_number":42,"context_line":"       - Metadata for the volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"f1628911_7ffe15a9","line":39,"range":{"start_line":38,"start_character":1,"end_line":39,"end_character":19},"updated":"2022-11-29 09:29:55.000000000","message":"Do we really need a default value here? In this case it will be always passed to the API","commit_id":"1b19382c86a628b874d8d4c036d4dfc58a8a61ea"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"e236ecfcfdbf0fe4a6cdac656e9c859905c77fde","unresolved":false,"context_lines":[{"line_number":35,"context_line":"   is_multiattach:"},{"line_number":36,"context_line":"     description:"},{"line_number":37,"context_line":"       - Whether disk will be shareble or not."},{"line_number":38,"context_line":"     type: bool"},{"line_number":39,"context_line":"     default: False"},{"line_number":40,"context_line":"   metadata:"},{"line_number":41,"context_line":"     description:"},{"line_number":42,"context_line":"       - Metadata for the volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"b010d00b_4ba47395","line":39,"range":{"start_line":38,"start_character":1,"end_line":39,"end_character":19},"in_reply_to":"f1628911_7ffe15a9","updated":"2023-01-05 16:39:24.000000000","message":"Done","commit_id":"1b19382c86a628b874d8d4c036d4dfc58a8a61ea"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"b9d017df80d917fd1b7a6848950f235c43fe3d16","unresolved":true,"context_lines":[{"line_number":284,"context_line":"                self.params[\u0027snapshot\u0027], ignore_missing\u003dFalse, **find_filters)"},{"line_number":285,"context_line":"            kwargs[\u0027snapshot_id\u0027] \u003d snapshot.id"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if self.params[\u0027is_multiattach\u0027] is not None:"},{"line_number":288,"context_line":"            kwargs[\u0027multiattach\u0027] \u003d self.params[\u0027is_multiattach\u0027]"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        if self.params[\u0027image\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"197e3a52_8ac07203","line":287,"range":{"start_line":287,"start_character":8,"end_line":287,"end_character":53},"updated":"2022-11-29 09:29:55.000000000","message":"This doesn\u0027t make sense, since you have always the default value.\nLet\u0027s remove the default and leave this check.","commit_id":"1b19382c86a628b874d8d4c036d4dfc58a8a61ea"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"e236ecfcfdbf0fe4a6cdac656e9c859905c77fde","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                self.params[\u0027snapshot\u0027], ignore_missing\u003dFalse, **find_filters)"},{"line_number":285,"context_line":"            kwargs[\u0027snapshot_id\u0027] \u003d snapshot.id"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if self.params[\u0027is_multiattach\u0027] is not None:"},{"line_number":288,"context_line":"            kwargs[\u0027multiattach\u0027] \u003d self.params[\u0027is_multiattach\u0027]"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        if self.params[\u0027image\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"59b665a0_56d96bbf","line":287,"range":{"start_line":287,"start_character":8,"end_line":287,"end_character":53},"in_reply_to":"197e3a52_8ac07203","updated":"2023-01-05 16:39:24.000000000","message":"Done","commit_id":"1b19382c86a628b874d8d4c036d4dfc58a8a61ea"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ef1f42a9ea9e5385c0dbd63d868f2e50c21797b6","unresolved":true,"context_lines":[{"line_number":32,"context_line":"     type: bool"},{"line_number":33,"context_line":"     default: False"},{"line_number":34,"context_line":"     aliases: [bootable]"},{"line_number":35,"context_line":"   is_multiattach:"},{"line_number":36,"context_line":"     description:"},{"line_number":37,"context_line":"       - Whether disk will be shareble or not. By default is false."},{"line_number":38,"context_line":"     type: bool"}],"source_content_type":"text/x-python","patch_set":4,"id":"61503ea4_7267a1d8","line":35,"updated":"2023-01-05 16:41:33.000000000","message":"Please also add is_multiattach to expected_fields in ci/roles/volume/defaults/main.yml","commit_id":"d985df3a09902a9ea04f34f44225510ec7f810a8"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"740a15fe2de00be42d9cfa48c55cec02ec727ddc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"     type: bool"},{"line_number":33,"context_line":"     default: False"},{"line_number":34,"context_line":"     aliases: [bootable]"},{"line_number":35,"context_line":"   is_multiattach:"},{"line_number":36,"context_line":"     description:"},{"line_number":37,"context_line":"       - Whether disk will be shareble or not. By default is false."},{"line_number":38,"context_line":"     type: bool"}],"source_content_type":"text/x-python","patch_set":4,"id":"8f3b9c85_900378a8","line":35,"in_reply_to":"61503ea4_7267a1d8","updated":"2023-01-10 08:11:41.000000000","message":"Done","commit_id":"d985df3a09902a9ea04f34f44225510ec7f810a8"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"e236ecfcfdbf0fe4a6cdac656e9c859905c77fde","unresolved":true,"context_lines":[{"line_number":156,"context_line":"      description: The status of this volume migration (None means that a"},{"line_number":157,"context_line":"                   migration is not currently in progress)."},{"line_number":158,"context_line":"      type: str"},{"line_number":159,"context_line":"    multiattach:"},{"line_number":160,"context_line":"      description: If true, this volume can attach to more than one instance."},{"line_number":161,"context_line":"      type: bool"},{"line_number":162,"context_line":"    name:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff6f8d4f_67393ccc","line":159,"updated":"2023-01-05 16:39:24.000000000","message":"Please rename to is_multiattach and move it up to correct position (args are sorted).","commit_id":"d985df3a09902a9ea04f34f44225510ec7f810a8"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"feec309c206c1b9a758150480a9e2ef8a5201172","unresolved":false,"context_lines":[{"line_number":156,"context_line":"      description: The status of this volume migration (None means that a"},{"line_number":157,"context_line":"                   migration is not currently in progress)."},{"line_number":158,"context_line":"      type: str"},{"line_number":159,"context_line":"    multiattach:"},{"line_number":160,"context_line":"      description: If true, this volume can attach to more than one instance."},{"line_number":161,"context_line":"      type: bool"},{"line_number":162,"context_line":"    name:"}],"source_content_type":"text/x-python","patch_set":4,"id":"16504172_96fadf61","line":159,"in_reply_to":"ff6f8d4f_67393ccc","updated":"2023-01-10 12:34:32.000000000","message":"Done","commit_id":"d985df3a09902a9ea04f34f44225510ec7f810a8"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"e236ecfcfdbf0fe4a6cdac656e9c859905c77fde","unresolved":true,"context_lines":[{"line_number":283,"context_line":"                self.params[\u0027snapshot\u0027], ignore_missing\u003dFalse, **find_filters)"},{"line_number":284,"context_line":"            kwargs[\u0027snapshot_id\u0027] \u003d snapshot.id"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if self.params[\u0027is_multiattach\u0027] is not None:"},{"line_number":287,"context_line":"            kwargs[\u0027is_multiattach\u0027] \u003d self.params[\u0027is_multiattach\u0027]"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if self.params[\u0027image\u0027]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"f42da24e_03b63dc7","line":286,"updated":"2023-01-05 16:39:24.000000000","message":"Please add this to \u0027keys\u0027 above instead of adding this branch here.","commit_id":"d985df3a09902a9ea04f34f44225510ec7f810a8"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"740a15fe2de00be42d9cfa48c55cec02ec727ddc","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                self.params[\u0027snapshot\u0027], ignore_missing\u003dFalse, **find_filters)"},{"line_number":284,"context_line":"            kwargs[\u0027snapshot_id\u0027] \u003d snapshot.id"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if self.params[\u0027is_multiattach\u0027] is not None:"},{"line_number":287,"context_line":"            kwargs[\u0027is_multiattach\u0027] \u003d self.params[\u0027is_multiattach\u0027]"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if self.params[\u0027image\u0027]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa12462_ded36f7f","line":286,"in_reply_to":"f42da24e_03b63dc7","updated":"2023-01-10 08:11:41.000000000","message":"Done","commit_id":"d985df3a09902a9ea04f34f44225510ec7f810a8"}]}