)]}'
{"id":"openstack%2Fansible-collections-openstack~866683","triplet_id":"openstack%2Fansible-collections-openstack~master~I460b75c09a361e712bbfb002c1ad1d03b3dff8ee","project":"openstack/ansible-collections-openstack","branch":"master","topic":"module-template-removal","attention_set":{},"removed_from_attention_set":{"32962":{"account":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"last_update":"2022-12-12 13:22:04.000000000","reason":"\u003cGERRIT_ACCOUNT_32962\u003e replied on the change","reason_account":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}}},"hashtags":[],"change_id":"I460b75c09a361e712bbfb002c1ad1d03b3dff8ee","subject":"Dropped obsolete module templates","status":"MERGED","created":"2022-12-06 11:00:14.000000000","updated":"2022-12-12 14:20:03.000000000","submitted":"2022-12-12 14:20:03.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"866683-module-template-removal","meta_rev_id":"3b8303f98d1dfcd4d8cc15cd1c7f2d3b41e86ea0","_number":866683,"virtual_id_number":866683,"owner":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-12-12 14:20:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":0,"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"value":2,"date":"2022-12-11 17:59:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"all":[{"value":1,"date":"2022-12-12 13:22:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-06 13:43:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-12-11 17:57:59.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"CC"},{"updated":"2022-12-11 17:59:37.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REVIEWER"}],"messages":[{"id":"98e47c60e292bb83240562782c1094e73b0d0127","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-12-06 11:00:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ec6dddba9708e14b1fd4ab4fc4bd41391968c779","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-06 13:43:26.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/bc42b081d6fa44e88009f4a3e63ac4c5\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/dd7ba2923a924b4fb90da06f21a8f377 : SUCCESS in 3m 19s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/b803a5b8ff04449ba6dd1a81c249b00e : SUCCESS in 7m 12s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/b33a304888534986889f3983590b8ac4 : SUCCESS in 9m 07s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/c5b135476d0e4326a72dd3447e3dee57 : FAILURE in 42m 34s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/330d460dfe6641fbb63ab27f45ebfd53 : FAILURE in 40m 04s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/7c539fed6a6f45cfb5592e029ec530db : FAILURE in 42m 21s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/31285e188d354115a349fe4ad9a2df2e : FAILURE in 44m 18s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/59c6ed6899074b728545dbbebaa74aaa : FAILURE in 42m 51s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/2e69f95c0aa848a6903e6062aa644a28 : SUCCESS in 42m 17s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/bdd4814394ca4406a2539d77c9aa3312 : SUCCESS in 39m 11s (non-voting)\n- tripleo-ci-centos-9-standalone-osa https://zuul.opendev.org/t/openstack/build/11ba50d201eb4abc89a1fea9d38cab97 : SUCCESS in 2h 20m 30s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"fb14673cd5d1e6d72877089bd52db3a517e13c9c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-12-06 14:49:55.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"6c212e14de8053c31e7418ef9598064830039542","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-06 17:41:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e1421da14569405286217f7161f7ec09\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/bb63a98cfb974f2f810497f8f626ec18 : SUCCESS in 3m 35s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/c9127badcfab4e6398692e517732db9a : SUCCESS in 6m 10s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/65cebbb1fc8946aa86b45a8fb639181c : SUCCESS in 6m 45s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/885a4d48edc44244a426ec220d484fa4 : SUCCESS in 57m 39s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/82eac49bd5cb420091b4c9c9bf72261c : SUCCESS in 55m 29s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/da10baf87d9c4aba9f23f9d127e0b6ec : SUCCESS in 1h 03m 47s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/97c19fb205f240c79ecf5b2a1ee6e2b1 : SUCCESS in 1h 15m 54s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/643b24dff2d24a3aaf26a7b07cf7b7d4 : SUCCESS in 1h 02m 07s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/042b490761a54bd3bebb898b4c32cb7a : SUCCESS in 45m 41s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/fc7a7aa6056b4d57b22e4790948847b3 : SUCCESS in 42m 05s (non-voting)\n- tripleo-ci-centos-9-standalone-osa https://zuul.opendev.org/t/openstack/build/eb3d3d59a27c4276aa7cb7fe9615df69 : SUCCESS in 2h 37m 20s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e95cdff72f009985c5620a04cfae67a9a0209bdc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-12-09 12:26:16.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"1159aa705e3e54455bb3d60559782ac9a341f124","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-09 14:07:46.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/c513ef75bd804e3c8a953e9f95d8953b\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/fdb0307813c549c096f633458ef9efa4 : SUCCESS in 4m 40s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/f3d8906d3963499ebacfc007a3fed289 : SUCCESS in 6m 22s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/93798277d5ce4c438aca44ce8566504e : SUCCESS in 7m 36s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/0521174c63d84efbbf58eb50d3007c11 : FAILURE in 23m 14s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/6d62fada44434a0283c8cfa26204923e : FAILURE in 30m 21s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/0ed2dea58a3546c7963359caebd4ae19 : FAILURE in 24m 08s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/886f10f64ff44f9ab493df7f97ff5a00 : FAILURE in 25m 50s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/e370b1f7a0f44df7a69c6402094d0046 : FAILURE in 29m 10s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/01f0bbea45ca47f3842afa59a3582427 : SUCCESS in 33m 50s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/4c4ed15069084bcc8ea3b4405ae91331 : SUCCESS in 37m 23s (non-voting)\n- tripleo-ci-centos-9-standalone-osa https://zuul.opendev.org/t/openstack/build/23fddd581ed542b881ce2285bf1d7bed : SUCCESS in 1h 30m 41s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"bbea76951acf96f2b094f3202a4766fb1266f412","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-12-10 13:24:38.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"33064ab0cce870c0dc94cc76764457c44df5b1c0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-10 15:54:19.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5cee0add1c1d4d01a9a9fb3b553ee84a\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/bd6b7c9025a54b09bdcd97b087cdd602 : SUCCESS in 3m 47s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/0dde573a64e54e0c87a25e74890de555 : SUCCESS in 6m 31s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/991578dd63334adc9b74dafa6ca62df6 : SUCCESS in 8m 51s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/899168f6b50b4ed2afadb9dd480cc606 : SUCCESS in 1h 11m 29s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/8e5170129f34405ca123c249fc9249ae : SUCCESS in 57m 46s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/4516daa827d04da197136a0b11071744 : SUCCESS in 1h 07m 40s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/2a4247a1025143d9a38fdd10790e2ed5 : SUCCESS in 1h 16m 33s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/d639b93ed35b41aaa6db5fd024cb6463 : SUCCESS in 1h 02m 49s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/a885c84fbe41432faf9f5c255d98c998 : SUCCESS in 45m 13s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/daec2955a3064ac3a36ec53cfbf6da16 : SUCCESS in 47m 55s (non-voting)\n- tripleo-ci-centos-9-standalone-osa https://zuul.opendev.org/t/openstack/build/0a7cf86fa5244f5e9f8c5955cfa4789c : SUCCESS in 2h 14m 48s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"197e20154927314ab32dea0a53301b8e3903ee58","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2022-12-11 17:57:59.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"aafd47d26d680d5749a81db29143f6ed51f60f33","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2022-12-11 17:59:37.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"fb63ef3eb3a34dbc6188162a956b1bdc3fc49791","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-12-12 13:22:04.000000000","message":"Patch Set 4: Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"1c9cae607ef64a15d8577e49069266cbedde4f5a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-12 13:22:41.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"ebd5a167eb9994f3102001d30aef87dfd0b5d033","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-12 14:20:03.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/02458832332a46bdb11849bd285a4859\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/953cf1532a084c56937481ebd17d0ba0 : SUCCESS in 4m 02s\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/5dcc812e6e5c4f379f3f9bdcc4f6fba2 : SUCCESS in 7m 23s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/347381a3fe024e96a01bf0e62c64516f : SUCCESS in 56m 20s","accounts_in_message":[],"_revision_number":4},{"id":"3b8303f98d1dfcd4d8cc15cd1c7f2d3b41e86ea0","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-12 14:20:03.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"133af9666691ec458e265f66931e5ebc3742f764","revisions":{"613d79e80607799da50e80c84973c0f083245df6":{"kind":"REWORK","_number":1,"created":"2022-12-06 11:00:14.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/83/866683/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/83/866683/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/1"}}},"commit":{"parents":[{"commit":"8f12701f93daf2a0c873278490c5deed7162fd59","subject":"Added tests for router interface creation in a shared network","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/8f12701f93daf2a0c873278490c5deed7162fd59"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-12-06 10:48:49.000000000","tz":60},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-12-06 10:59:50.000000000","tz":60},"subject":"Dropped obsolete module templates","message":"Dropped obsolete module templates\n\nModule templates have little benefit because\n* they are not documented anywhere,\n* their structure is not suitable for our modules, hence not a\n  single module is written according to the templates,\n* contributers better base their own modules on existing modules\n  because we have modules for most OpenStack components,\n* they are outdated, e.g. normalizing is a relict of\n  openstacksdk\u003c0.99.0 and results,\n* they are bloated, e.g. *_info module is doing preliminary checks\n  and creating filters in separate functions which proved in other\n  modules to be much better readable when inlined,\n* they are hard to understand, e.g. argument_spec definition is\n  a huge Jinja2 template which does nothing except for copying\n  arguments from one place to another,\n* they are not tested.\n\nChange-Id: I460b75c09a361e712bbfb002c1ad1d03b3dff8ee\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/613d79e80607799da50e80c84973c0f083245df6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/613d79e80607799da50e80c84973c0f083245df6"}]},"branch":"refs/heads/master"},"3cd1787017f1de5e779715f5de791531435b51b2":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-12-06 14:49:55.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/83/866683/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/83/866683/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/2"}}},"commit":{"parents":[{"commit":"65b614211d75a51f17f349d25c0d9d52c14528d4","subject":"Added tests for router interface creation in a shared network","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/65b614211d75a51f17f349d25c0d9d52c14528d4"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-12-06 10:48:49.000000000","tz":60},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-12-06 14:49:42.000000000","tz":60},"subject":"Dropped obsolete module templates","message":"Dropped obsolete module templates\n\nModule templates have little benefit because\n* they are not documented anywhere,\n* their structure is not suitable for our modules, hence not a\n  single module is written according to the templates,\n* contributers better base their own modules on existing modules\n  because we have modules for most OpenStack components,\n* they are outdated, e.g. normalizing is a relict of\n  openstacksdk\u003c0.99.0 and results,\n* they are bloated, e.g. *_info module is doing preliminary checks\n  and creating filters in separate functions which proved in other\n  modules to be much better readable when inlined,\n* they are hard to understand, e.g. argument_spec definition is\n  a huge Jinja2 template which does nothing except for copying\n  arguments from one place to another,\n* they are not tested.\n\nChange-Id: I460b75c09a361e712bbfb002c1ad1d03b3dff8ee\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/3cd1787017f1de5e779715f5de791531435b51b2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/3cd1787017f1de5e779715f5de791531435b51b2"}]},"branch":"refs/heads/master"},"972cd69d430fdf0527647ffa1c142ad02be48365":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-12-09 12:26:16.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/83/866683/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/83/866683/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/3"}}},"commit":{"parents":[{"commit":"01e136fc94edb97ddf4196af2ab1ff0a0f7819c2","subject":"Added tests for router interface creation in a shared network","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/01e136fc94edb97ddf4196af2ab1ff0a0f7819c2"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-12-06 10:48:49.000000000","tz":60},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-12-09 12:26:05.000000000","tz":60},"subject":"Dropped obsolete module templates","message":"Dropped obsolete module templates\n\nModule templates have little benefit because\n* they are not documented anywhere,\n* their structure is not suitable for our modules, hence not a\n  single module is written according to the templates,\n* contributers better base their own modules on existing modules\n  because we have modules for most OpenStack components,\n* they are outdated, e.g. normalizing is a relict of\n  openstacksdk\u003c0.99.0 and results,\n* they are bloated, e.g. *_info module is doing preliminary checks\n  and creating filters in separate functions which proved in other\n  modules to be much better readable when inlined,\n* they are hard to understand, e.g. argument_spec definition is\n  a huge Jinja2 template which does nothing except for copying\n  arguments from one place to another,\n* they are not tested.\n\nChange-Id: I460b75c09a361e712bbfb002c1ad1d03b3dff8ee\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/972cd69d430fdf0527647ffa1c142ad02be48365"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/972cd69d430fdf0527647ffa1c142ad02be48365"}]},"branch":"refs/heads/master"},"133af9666691ec458e265f66931e5ebc3742f764":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2022-12-10 13:24:38.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/83/866683/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/83/866683/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/83/866683/4"}}},"commit":{"parents":[{"commit":"51f1fea8b3379701eec769d9f36c0d4e7db133fd","subject":"Added tests for router interface creation in a shared network","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/51f1fea8b3379701eec769d9f36c0d4e7db133fd"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-12-06 10:48:49.000000000","tz":60},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-12-10 13:24:27.000000000","tz":60},"subject":"Dropped obsolete module templates","message":"Dropped obsolete module templates\n\nModule templates have little benefit because\n* they are not documented anywhere,\n* their structure is not suitable for our modules, hence not a\n  single module is written according to the templates,\n* contributers better base their own modules on existing modules\n  because we have modules for most OpenStack components,\n* they are outdated, e.g. normalizing is a relict of\n  openstacksdk\u003c0.99.0 and results,\n* they are bloated, e.g. *_info module is doing preliminary checks\n  and creating filters in separate functions which proved in other\n  modules to be much better readable when inlined,\n* they are hard to understand, e.g. argument_spec definition is\n  a huge Jinja2 template which does nothing except for copying\n  arguments from one place to another,\n* they are not tested.\n\nChange-Id: I460b75c09a361e712bbfb002c1ad1d03b3dff8ee\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/133af9666691ec458e265f66931e5ebc3742f764"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/133af9666691ec458e265f66931e5ebc3742f764"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}}]}],"submit_requirements":[]}