)]}'
{"id":"openstack%2Fansible-collections-openstack~867656","triplet_id":"openstack%2Fansible-collections-openstack~stable%2F1.0.0~I460b75c09a361e712bbfb002c1ad1d03b3dff8ee","project":"openstack/ansible-collections-openstack","branch":"stable/1.0.0","topic":"module-template-removal","attention_set":{},"removed_from_attention_set":{"32962":{"account":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"last_update":"2022-12-15 10:43:07.000000000","reason":"\u003cGERRIT_ACCOUNT_32962\u003e replied on the change","reason_account":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}}},"hashtags":[],"change_id":"I460b75c09a361e712bbfb002c1ad1d03b3dff8ee","subject":"Dropped obsolete module templates","status":"MERGED","created":"2022-12-14 14:26:23.000000000","updated":"2022-12-15 11:58:30.000000000","submitted":"2022-12-15 11:58:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"867656-module-template-removal","meta_rev_id":"4a0ec2625becaa2b5d8bd3bcab2b23b4cd347957","_number":867656,"virtual_id_number":867656,"owner":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-12-15 11:58:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":0,"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"value":2,"date":"2022-12-15 10:33:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"all":[{"value":1,"date":"2022-12-15 10:43:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-12-14 16:18:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-12-15 10:33:03.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REVIEWER"}],"messages":[{"id":"9470561237edc5caf81e6c3207b0ce01e0e4bb85","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-12-14 14:26:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8c597e6ce081788ee2317a57ae9a1b59fac05e3c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-14 16:18:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9706350330ee47d681b7320a02ada03d\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/bd081f43c80c46098c0dfa4f088cecab : SUCCESS in 3m 58s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/ba4f35d5bf9841cd80a33dcb5cf401f7 : FAILURE in 5m 49s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/a78410bf3a1345b7ba4471456d1f2872 : SUCCESS in 7m 39s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/3ba9c6ed52234dca94870bbbc9e1faa2 : SUCCESS in 40m 16s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/37943bb452404cb2bcdb9f62d084a86b : SUCCESS in 57m 08s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/6656589b8eb34572a724245305b7c2cb : SUCCESS in 56m 51s\n- ansible-collections-openstack-functional-devstack-xena-ansible-2.12 https://zuul.opendev.org/t/openstack/build/9a5128da08b94267bb1fe66d02a59b9c : SUCCESS in 47m 05s\n- ansible-collections-openstack-functional-devstack-wallaby-ansible-2.12 https://zuul.opendev.org/t/openstack/build/3083b24fd1624dda8dea0e2d15d58d4e : SUCCESS in 48m 19s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.11 https://zuul.opendev.org/t/openstack/build/9dc92dde5f3849babdc6ffa09e00a348 : SUCCESS in 1h 02m 04s\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/d6b2c03447c744f89adfbf63916afbf8 : SUCCESS in 29m 29s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/9b51031582a5496c984e121433451693 : SUCCESS in 31m 33s (non-voting)\n- tripleo-ci-centos-9-standalone-osa-wallaby https://zuul.opendev.org/t/openstack/build/fd332bf30fa44e6eaa7b3268566bcc05 : SUCCESS in 1h 41m 37s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b3198afce4247e0261ec31a9b42fdb334f5637d7","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2022-12-15 10:33:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e047bef6e2339cc78cfce5f3634fb86f4ef15d8d","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2022-12-15 10:43:07.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"3077d20b8d7f16773a3d2bfb3e4153e4590f0cd4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-15 10:44:21.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"18b041f0884ab3ea9a4b2214975075f56f673f52","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-15 11:58:29.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b4d43baae132475fbc467cb2c240dd70\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/fe4a5becc5a24749ae4e0ec3b29fd923 : SUCCESS in 3m 15s\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/ab49d9b7ea194bcc8b229856ba61e3ab : SUCCESS in 8m 39s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/82989971bf4d4d67ad0d37d5ff810684 : SUCCESS in 46m 33s\n- ansible-collections-openstack-functional-devstack-wallaby-ansible-2.12 https://zuul.opendev.org/t/openstack/build/7febce96eb6543bf8303aa7e6a55c633 : SUCCESS in 45m 54s\n- ansible-collections-openstack-functional-devstack-xena-ansible-2.12 https://zuul.opendev.org/t/openstack/build/abb4f043761140879af23d2f5f95443d : SUCCESS in 50m 33s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.11 https://zuul.opendev.org/t/openstack/build/eaef3a8032c941d2b4ec20feabd0cb89 : SUCCESS in 1h 05m 34s","accounts_in_message":[],"_revision_number":1},{"id":"4a0ec2625becaa2b5d8bd3bcab2b23b4cd347957","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-15 11:58:30.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"922032cb9facfcad48ae4c4b6701993340d02374","revisions":{"922032cb9facfcad48ae4c4b6701993340d02374":{"kind":"REWORK","_number":1,"created":"2022-12-14 14:26:23.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/56/867656/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/56/867656/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/56/867656/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/56/867656/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/56/867656/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/56/867656/1"}}},"commit":{"parents":[{"commit":"a11943d9b1fae527b2be062d234e4be59d818fee","subject":"Renamed image-\u003eimage_name and flavor-\u003eflavor_name to avoid collisions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/a11943d9b1fae527b2be062d234e4be59d818fee"}]}],"author":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-12-06 10:48:49.000000000","tz":60},"committer":{"name":"Jakob Meng","email":"code@jakobmeng.de","date":"2022-12-14 14:26:08.000000000","tz":60},"subject":"Dropped obsolete module templates","message":"Dropped obsolete module templates\n\nModule templates have little benefit because\n* they are not documented anywhere,\n* their structure is not suitable for our modules, hence not a\n  single module is written according to the templates,\n* contributers better base their own modules on existing modules\n  because we have modules for most OpenStack components,\n* they are outdated, e.g. normalizing is a relict of\n  openstacksdk\u003c0.99.0 and results,\n* they are bloated, e.g. *_info module is doing preliminary checks\n  and creating filters in separate functions which proved in other\n  modules to be much better readable when inlined,\n* they are hard to understand, e.g. argument_spec definition is\n  a huge Jinja2 template which does nothing except for copying\n  arguments from one place to another,\n* they are not tested.\n\nChange-Id: I460b75c09a361e712bbfb002c1ad1d03b3dff8ee\n(cherry picked from commit 133af9666691ec458e265f66931e5ebc3742f764)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/922032cb9facfcad48ae4c4b6701993340d02374"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/922032cb9facfcad48ae4c4b6701993340d02374"}]},"branch":"refs/heads/stable/1.0.0"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"}}]}],"submit_requirements":[]}