)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2853872d6aca54f64fbc54dee1ac232a73657af5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e72ce3d2_c8d95613","updated":"2022-12-17 14:53:42.000000000","message":"a couple questions","commit_id":"a025b77f74691e72f882fcd7dccb86dcf43f48fa"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"f020df40aa25084ab8df8cb2420b313315f7b55c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"594041ab_18f4c97b","updated":"2022-12-15 11:37:46.000000000","message":"recheck because of unrelated ansible galaxy issue","commit_id":"a025b77f74691e72f882fcd7dccb86dcf43f48fa"}],"plugins/modules/security_group.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2853872d6aca54f64fbc54dee1ac232a73657af5","unresolved":true,"context_lines":[{"line_number":199,"context_line":"                               if self.params[k] is not None"},{"line_number":200,"context_line":"                               and self.params[k] !\u003d security_group[k]]"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        if non_updateable_keys:"},{"line_number":203,"context_line":"            self.fail_json(msg\u003d\u0027Cannot update parameters {0}\u0027"},{"line_number":204,"context_line":"                               .format(non_updateable_keys))"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        attributes \u003d dict((k, self.params[k])"},{"line_number":207,"context_line":"                          for k in [\u0027description\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac7a167_5699b850","line":204,"range":{"start_line":202,"start_character":0,"end_line":204,"end_character":60},"updated":"2022-12-17 14:53:42.000000000","message":"Why do we fail when non updateable parameters? Shouldn\u0027t we recreate the group in this case?","commit_id":"a025b77f74691e72f882fcd7dccb86dcf43f48fa"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c1124778710472921081f450c446cb3b9a48df26","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                               if self.params[k] is not None"},{"line_number":200,"context_line":"                               and self.params[k] !\u003d security_group[k]]"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        if non_updateable_keys:"},{"line_number":203,"context_line":"            self.fail_json(msg\u003d\u0027Cannot update parameters {0}\u0027"},{"line_number":204,"context_line":"                               .format(non_updateable_keys))"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        attributes \u003d dict((k, self.params[k])"},{"line_number":207,"context_line":"                          for k in [\u0027description\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"a6593127_ddb18c9d","line":204,"range":{"start_line":202,"start_character":0,"end_line":204,"end_character":60},"in_reply_to":"dac7a167_5699b850","updated":"2022-12-17 18:11:51.000000000","message":"Actually there are no module parameters which cannot be updated except for security group name, so this branch is never taken atm. But i still left it here in case somebody adds new module parameters in future which cannot be updated.\n\nWhether we want to raise an exception or silently recreate resources when attributes cannot be updates is something we should discuss with Artem. Fortunately there is only one module, compute_flavor, which is doing that iirc.","commit_id":"a025b77f74691e72f882fcd7dccb86dcf43f48fa"}],"plugins/modules/security_group_info.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2853872d6aca54f64fbc54dee1ac232a73657af5","unresolved":true,"context_lines":[{"line_number":187,"context_line":"                               if name in (item[\u0027id\u0027], item[\u0027name\u0027])]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self.exit(changed\u003dFalse,"},{"line_number":190,"context_line":"                  security_groups\u003d[sg.to_dict() for sg in security_groups])"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":3,"id":"d6bb4b87_7db76619","line":190,"range":{"start_line":190,"start_character":44,"end_line":190,"end_character":46},"updated":"2022-12-17 14:53:42.000000000","message":"is computed\u003dFalse required?","commit_id":"a025b77f74691e72f882fcd7dccb86dcf43f48fa"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c1124778710472921081f450c446cb3b9a48df26","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                               if name in (item[\u0027id\u0027], item[\u0027name\u0027])]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self.exit(changed\u003dFalse,"},{"line_number":190,"context_line":"                  security_groups\u003d[sg.to_dict() for sg in security_groups])"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":3,"id":"aede817b_c1bc8ada","line":190,"range":{"start_line":190,"start_character":44,"end_line":190,"end_character":46},"in_reply_to":"d6bb4b87_7db76619","updated":"2022-12-17 18:11:51.000000000","message":"Good catch, thanks!","commit_id":"a025b77f74691e72f882fcd7dccb86dcf43f48fa"}]}