)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d5971d5f6583988faaf1cf8106644ce9e1524900","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c22f3ab8_e3efb6cf","updated":"2023-01-01 12:15:42.000000000","message":"Great, thanks.\nI\u0027d add a few more Ansible bits:\n1. All modules should be idempotent if it\u0027s possible\n2. All modules should calculate \"changed\" value and support \"check mode\" if possible\n3. All modules are tested in CI for sanity and compatibility with latest Ansible collections rules and guidelines (probably worth to put some links to ansible-test etc)\n","commit_id":"1f8f0027ffa5fb1d7ff359ff7492703387b7c6f0"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"7b45989b4a89e898983666f31c9d05db4bddd606","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2cbefaf7_f3ef9637","in_reply_to":"c22f3ab8_e3efb6cf","updated":"2023-01-04 20:28:47.000000000","message":"Good idea, done!","commit_id":"1f8f0027ffa5fb1d7ff359ff7492703387b7c6f0"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"14b2580198dcf9eb4c6dccc5a7ecbd893958d30c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f328ed75_560a71db","updated":"2023-01-06 14:59:44.000000000","message":"Marked this patch as wip because i might want to add our docs about openstacksdk 1.0.0 and our branching strategy as well","commit_id":"bd95103ef998072c9899dcfc816d6d59e6f70a01"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"c68432dde6e764761914687e45034c45009082bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c618d985_932a79b9","updated":"2023-01-10 10:16:23.000000000","message":"You spend quite a lot time on those docs ;-) Awesome","commit_id":"5d7dc675ced1f3ab09214cba49a8ef8fb243b847"}],"README.md":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"38acaef721b008b4d4c65396bb8a159a4743e7c2","unresolved":true,"context_lines":[{"line_number":98,"context_line":"        server: Mysql-server"},{"line_number":99,"context_line":"        volume: mysql-data"},{"line_number":100,"context_line":"        device: /dev/vdb"},{"line_number":101,"context_line":"```"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"## Documentation"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":13,"id":"cd775025_7adf31d1","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":3},"updated":"2023-01-10 11:00:39.000000000","message":"Maybe worth to mention we support \"module_defaults\" as well, probably in other file.https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_module_defaults.html","commit_id":"5d7dc675ced1f3ab09214cba49a8ef8fb243b847"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"f5d6e9cbca8957600054e197add3439f02329351","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        server: Mysql-server"},{"line_number":99,"context_line":"        volume: mysql-data"},{"line_number":100,"context_line":"        device: /dev/vdb"},{"line_number":101,"context_line":"```"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"## Documentation"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":13,"id":"b9b13cc2_c96f8c3a","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":3},"in_reply_to":"cd775025_7adf31d1","updated":"2023-01-10 12:16:29.000000000","message":"Done","commit_id":"5d7dc675ced1f3ab09214cba49a8ef8fb243b847"}],"docs/DEVSTACK.md":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"21544142a224137e94d2e7fb0dd0d8ff811e8e01","unresolved":true,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"```sh"},{"line_number":82,"context_line":"# find out name of cirros image"},{"line_number":83,"context_line":"source ~/devstack/openrc admin admin"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"SDK_VER\u003d0.61.0"},{"line_number":86,"context_line":"ansible-playbook -vvv ci/run-collection.yml -e \"sdk_version\u003d${SDK_VER} cloud\u003ddevstack-admin cloud_alt\u003ddevstack-alt\""}],"source_content_type":"text/x-markdown","patch_set":3,"id":"863ba926_96f272cc","line":83,"updated":"2023-01-06 13:35:52.000000000","message":"this should not be necessary since you specify cloud later","commit_id":"71522f52a6213d974e0a7927454923d623e50f68"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"14b2580198dcf9eb4c6dccc5a7ecbd893958d30c","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"```sh"},{"line_number":82,"context_line":"# find out name of cirros image"},{"line_number":83,"context_line":"source ~/devstack/openrc admin admin"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"SDK_VER\u003d0.61.0"},{"line_number":86,"context_line":"ansible-playbook -vvv ci/run-collection.yml -e \"sdk_version\u003d${SDK_VER} cloud\u003ddevstack-admin cloud_alt\u003ddevstack-alt\""}],"source_content_type":"text/x-markdown","patch_set":3,"id":"ca76007b_dce4491a","line":83,"in_reply_to":"863ba926_96f272cc","updated":"2023-01-06 14:59:44.000000000","message":"True, thanks!","commit_id":"71522f52a6213d974e0a7927454923d623e50f68"}],"docs/branching.md":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"c68432dde6e764761914687e45034c45009082bf","unresolved":true,"context_lines":[{"line_number":100,"context_line":"  allows to drop `self.fail_json()` calls in modules. Less code means less to maintain."},{"line_number":101,"context_line":"* Some modules pass `ignore_missing\u003dTrue` to `self.conn.*.find_*` functions and then fail if the return value is `None`."},{"line_number":102,"context_line":"  Often this code can be simplified by changing `ignore_missing` to `False` and dropping the if-else branches."},{"line_number":103,"context_line":"* When module attribute that have choices, always doubt its values. The odule code was probably written long ago and the"},{"line_number":104,"context_line":"  choices given might be outdated. It might also make sense to drop the `choices` parameter completely when choices are"},{"line_number":105,"context_line":"  to narrow and might soon be outdated again."},{"line_number":106,"context_line":"* Check comments whether they are still relevant."}],"source_content_type":"text/x-markdown","patch_set":12,"id":"37fa8674_4532406f","line":103,"updated":"2023-01-10 10:16:23.000000000","message":"typo: \"... The _m_odule code ...\"","commit_id":"f5ed1e9060bf650d9d98ae39343704a976afb239"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"f5d6e9cbca8957600054e197add3439f02329351","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  allows to drop `self.fail_json()` calls in modules. Less code means less to maintain."},{"line_number":101,"context_line":"* Some modules pass `ignore_missing\u003dTrue` to `self.conn.*.find_*` functions and then fail if the return value is `None`."},{"line_number":102,"context_line":"  Often this code can be simplified by changing `ignore_missing` to `False` and dropping the if-else branches."},{"line_number":103,"context_line":"* When module attribute that have choices, always doubt its values. The odule code was probably written long ago and the"},{"line_number":104,"context_line":"  choices given might be outdated. It might also make sense to drop the `choices` parameter completely when choices are"},{"line_number":105,"context_line":"  to narrow and might soon be outdated again."},{"line_number":106,"context_line":"* Check comments whether they are still relevant."}],"source_content_type":"text/x-markdown","patch_set":12,"id":"19363330_1e1dc294","line":103,"in_reply_to":"37fa8674_4532406f","updated":"2023-01-10 12:16:29.000000000","message":"Done","commit_id":"f5ed1e9060bf650d9d98ae39343704a976afb239"}],"docs/releasing.md":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"38acaef721b008b4d4c65396bb8a159a4743e7c2","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"## Publishing to Fedora"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"**NOTE:** Before publishing an updated RPM for Fedora or RDO, contact Alfredo Moralejo Alonso \u003camoralej@redhat.com\u003e"},{"line_number":53,"context_line":"(amoralej) or Joel Capitao \u003cjcapitao@redhat.com\u003e (jcapitao[m]) in `#rdo` on [OFTC IRC](https://www.oftc.net/) about the"},{"line_number":54,"context_line":"latest release process."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":13,"id":"fc250f85_310e0631","line":52,"range":{"start_line":52,"start_character":42,"end_line":52,"end_character":53},"updated":"2023-01-10 11:00:39.000000000","message":"For fedora we don\u0027t need TripleO approval. Also AFAIK this collection is built automatically in RDO and uploaded to Fedora and Centos. (need to verify) In this case nobody has to do all this.","commit_id":"5d7dc675ced1f3ab09214cba49a8ef8fb243b847"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"f5d6e9cbca8957600054e197add3439f02329351","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"## Publishing to Fedora"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"**NOTE:** Before publishing an updated RPM for Fedora or RDO, contact Alfredo Moralejo Alonso \u003camoralej@redhat.com\u003e"},{"line_number":53,"context_line":"(amoralej) or Joel Capitao \u003cjcapitao@redhat.com\u003e (jcapitao[m]) in `#rdo` on [OFTC IRC](https://www.oftc.net/) about the"},{"line_number":54,"context_line":"latest release process."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":13,"id":"27915a02_91c02950","line":52,"range":{"start_line":52,"start_character":42,"end_line":52,"end_character":53},"in_reply_to":"fc250f85_310e0631","updated":"2023-01-10 12:16:29.000000000","message":"This warning is not about approval but about latest information on how the release process works atm. It might have changed until next time somebody reads this guide.\n\nThe collection is not automatically build and released from RDO to Fedora. We have to do it manually [1],[2].\n\n[1] https://koji.fedoraproject.org/koji/packageinfo?packageID\u003d33611\n[2] https://src.fedoraproject.org/rpms/ansible-collections-openstack/commits/rawhide","commit_id":"5d7dc675ced1f3ab09214cba49a8ef8fb243b847"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"38acaef721b008b4d4c65396bb8a159a4743e7c2","unresolved":true,"context_lines":[{"line_number":62,"context_line":"     https://src.fedoraproject.org/rpms/ansible-collections-openstack)"},{"line_number":63,"context_line":"   * [Koji page for `ansible-collections-openstack`](https://koji.fedoraproject.org/koji/packageinfo?packageID\u003d33611)"},{"line_number":64,"context_line":"   * [Bodhi\u0027s page `Create New Update`](https://bodhi.fedoraproject.org/updates/new)"},{"line_number":65,"context_line":"2. Install all necessary packaging tools, mainly `fedpkg`."},{"line_number":66,"context_line":"3. Create a scratch space with `mkdir fedora-scm`."},{"line_number":67,"context_line":"4. Fork Fedora repository [rpms/ansible-collections-openstack]("},{"line_number":68,"context_line":"   https://src.fedoraproject.org/rpms/ansible-collections-openstack)."}],"source_content_type":"text/x-markdown","patch_set":13,"id":"4a6a18f3_500a6c73","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":58},"updated":"2023-01-10 11:00:39.000000000","message":"Not sure we need to put here fedora tutorial. Maybe worth a link only, they can change the process any time.","commit_id":"5d7dc675ced1f3ab09214cba49a8ef8fb243b847"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"f5d6e9cbca8957600054e197add3439f02329351","unresolved":true,"context_lines":[{"line_number":62,"context_line":"     https://src.fedoraproject.org/rpms/ansible-collections-openstack)"},{"line_number":63,"context_line":"   * [Koji page for `ansible-collections-openstack`](https://koji.fedoraproject.org/koji/packageinfo?packageID\u003d33611)"},{"line_number":64,"context_line":"   * [Bodhi\u0027s page `Create New Update`](https://bodhi.fedoraproject.org/updates/new)"},{"line_number":65,"context_line":"2. Install all necessary packaging tools, mainly `fedpkg`."},{"line_number":66,"context_line":"3. Create a scratch space with `mkdir fedora-scm`."},{"line_number":67,"context_line":"4. Fork Fedora repository [rpms/ansible-collections-openstack]("},{"line_number":68,"context_line":"   https://src.fedoraproject.org/rpms/ansible-collections-openstack)."}],"source_content_type":"text/x-markdown","patch_set":13,"id":"108fb326_784e26bf","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":58},"in_reply_to":"4a6a18f3_500a6c73","updated":"2023-01-10 12:16:29.000000000","message":"Left it here because you put it into the original guide. I thought it is a good advice, so people who read the fedora guide(s) long time ago get hints on what to install.","commit_id":"5d7dc675ced1f3ab09214cba49a8ef8fb243b847"}]}