)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"e53734d802b4a1f08c0778fb2f28aeb2f467328a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"860350eb_ffd60daf","updated":"2023-01-26 12:38:40.000000000","message":"Accidentally uploaded this patch, its not ready yet.","commit_id":"0f017e67e7d4cee1013756e9c0f87b28258b81ee"}],"ci/roles/inventory/tasks/main.yml":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"570b45878b8e3d2c840fe8b6ce113cc04b79ad30","unresolved":true,"context_lines":[{"line_number":222,"context_line":"            mode: \u00270644\u0027"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        - name: List servers with inventory plugin"},{"line_number":225,"context_line":"          ansible.builtin.command:"},{"line_number":226,"context_line":"            cmd: ansible-inventory --list --yaml --inventory-file openstack.yaml"},{"line_number":227,"context_line":"            chdir: \"{{ tmp_dir.path }}\""},{"line_number":228,"context_line":"          environment:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fc78f437_5c24d345","line":225,"updated":"2023-01-28 11:03:51.000000000","message":"cool, nice approach to finally test this beast","commit_id":"7df6df4dfc97c88c00d754a80e0bdeadd8ca02b2"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cf5c8b6a48009be908f9596beb244b350acb2987","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            mode: \u00270644\u0027"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        - name: List servers with inventory plugin"},{"line_number":225,"context_line":"          ansible.builtin.command:"},{"line_number":226,"context_line":"            cmd: ansible-inventory --list --yaml --inventory-file openstack.yaml"},{"line_number":227,"context_line":"            chdir: \"{{ tmp_dir.path }}\""},{"line_number":228,"context_line":"          environment:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b9597cec_4135d89b","line":225,"in_reply_to":"fc78f437_5c24d345","updated":"2023-01-28 13:21:58.000000000","message":"Done","commit_id":"7df6df4dfc97c88c00d754a80e0bdeadd8ca02b2"}],"plugins/inventory/openstack.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"570b45878b8e3d2c840fe8b6ce113cc04b79ad30","unresolved":true,"context_lines":[{"line_number":173,"context_line":"            raise AnsibleParserError("},{"line_number":174,"context_line":"                \u0027Incompatible openstacksdk library found: {0}\u0027.format(e))"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        # Redict logging to stderr so it does not mix with output, in"},{"line_number":177,"context_line":"        # particular JSON output of ansible-inventory."},{"line_number":178,"context_line":"        # TODO: Integrate openstack\u0027s logging with Ansible\u0027s logging."},{"line_number":179,"context_line":"        if self.display.verbosity \u003e 3:"}],"source_content_type":"text/x-python","patch_set":3,"id":"f0d77244_ee1bb4a4","line":176,"updated":"2023-01-28 11:03:51.000000000","message":"redict seem a wrong word. Assume \"redirect\"","commit_id":"7df6df4dfc97c88c00d754a80e0bdeadd8ca02b2"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cf5c8b6a48009be908f9596beb244b350acb2987","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            raise AnsibleParserError("},{"line_number":174,"context_line":"                \u0027Incompatible openstacksdk library found: {0}\u0027.format(e))"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        # Redict logging to stderr so it does not mix with output, in"},{"line_number":177,"context_line":"        # particular JSON output of ansible-inventory."},{"line_number":178,"context_line":"        # TODO: Integrate openstack\u0027s logging with Ansible\u0027s logging."},{"line_number":179,"context_line":"        if self.display.verbosity \u003e 3:"}],"source_content_type":"text/x-python","patch_set":3,"id":"a5deb255_35d5b698","line":176,"in_reply_to":"f0d77244_ee1bb4a4","updated":"2023-01-28 13:21:58.000000000","message":"Done","commit_id":"7df6df4dfc97c88c00d754a80e0bdeadd8ca02b2"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"39337094364bd6c0355287dd7200384cd3fecd18","unresolved":true,"context_lines":[{"line_number":204,"context_line":"                              else (server[\u0027id\u0027], server))"},{"line_number":205,"context_line":"                             for server in servers)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        else:  # self.get_option(\u0027inventory_hostname\u0027) \u003d\u003d \u0027uuid\u0027"},{"line_number":208,"context_line":"            inventory \u003d dict((server[\u0027id\u0027], server)"},{"line_number":209,"context_line":"                             for server in servers)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"593a44d5_b019bcb3","line":207,"range":{"start_line":207,"start_character":15,"end_line":207,"end_character":64},"updated":"2023-01-28 12:18:56.000000000","message":"what is this comment?","commit_id":"7df6df4dfc97c88c00d754a80e0bdeadd8ca02b2"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cf5c8b6a48009be908f9596beb244b350acb2987","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                              else (server[\u0027id\u0027], server))"},{"line_number":205,"context_line":"                             for server in servers)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        else:  # self.get_option(\u0027inventory_hostname\u0027) \u003d\u003d \u0027uuid\u0027"},{"line_number":208,"context_line":"            inventory \u003d dict((server[\u0027id\u0027], server)"},{"line_number":209,"context_line":"                             for server in servers)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"05459464_258feabf","line":207,"range":{"start_line":207,"start_character":15,"end_line":207,"end_character":64},"in_reply_to":"593a44d5_b019bcb3","updated":"2023-01-28 13:21:58.000000000","message":"A visual clue for the reader. Shows what this else branch is about.","commit_id":"7df6df4dfc97c88c00d754a80e0bdeadd8ca02b2"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"570b45878b8e3d2c840fe8b6ce113cc04b79ad30","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                    # do not query OpenStack API for additional data"},{"line_number":324,"context_line":"                    return server"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"                # TODO: Consider expanding \u0027flavor\u0027, \u0027image\u0027 and"},{"line_number":327,"context_line":"                #       \u0027security_groups\u0027 when users still require this"},{"line_number":328,"context_line":"                #       functionality."},{"line_number":329,"context_line":"                # Ref.: https://opendev.org/openstack/openstacksdk/src/commit/\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"63b3205a_e31a1779","line":326,"updated":"2023-01-28 11:03:51.000000000","message":"Somehow I can\u0027t even imagine why should this ever be required for inventory plugin. Grouping servers by flavor? Hmm, not sure it is worth of performance impact","commit_id":"7df6df4dfc97c88c00d754a80e0bdeadd8ca02b2"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"28751afc7762b46255c9249af5e5c39a30566a87","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                    # do not query OpenStack API for additional data"},{"line_number":324,"context_line":"                    return server"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"                # TODO: Consider expanding \u0027flavor\u0027, \u0027image\u0027 and"},{"line_number":327,"context_line":"                #       \u0027security_groups\u0027 when users still require this"},{"line_number":328,"context_line":"                #       functionality."},{"line_number":329,"context_line":"                # Ref.: https://opendev.org/openstack/openstacksdk/src/commit/\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"7e4686dc_5ce0e4ff","line":326,"in_reply_to":"2e8acb86_128d4c64","updated":"2023-01-28 13:24:33.000000000","message":"Done","commit_id":"7df6df4dfc97c88c00d754a80e0bdeadd8ca02b2"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"cf5c8b6a48009be908f9596beb244b350acb2987","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                    # do not query OpenStack API for additional data"},{"line_number":324,"context_line":"                    return server"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"                # TODO: Consider expanding \u0027flavor\u0027, \u0027image\u0027 and"},{"line_number":327,"context_line":"                #       \u0027security_groups\u0027 when users still require this"},{"line_number":328,"context_line":"                #       functionality."},{"line_number":329,"context_line":"                # Ref.: https://opendev.org/openstack/openstacksdk/src/commit/\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"2e8acb86_128d4c64","line":326,"in_reply_to":"63b3205a_e31a1779","updated":"2023-01-28 13:21:58.000000000","message":"A lot of code duplication from SDK is why I left it out. For example it is used to create groups further down the file to group hosts by flavors and by images. I left this comment in the code so that future readers know that functionality have been removed and how it can be restored easily: By copying code which might have been deleted from SDK by then (because it was moved from inventory script to SDK in the past).","commit_id":"7df6df4dfc97c88c00d754a80e0bdeadd8ca02b2"}]}