)]}'
{"id":"openstack%2Fansible-collections-openstack~880027","triplet_id":"openstack%2Fansible-collections-openstack~master~Ie3672022386bf06a95a53497c04ac8936237b679","project":"openstack/ansible-collections-openstack","branch":"master","attention_set":{},"removed_from_attention_set":{"10239":{"account":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"last_update":"2023-09-01 15:55:08.000000000","reason":"Change was abandoned"},"10969":{"account":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"last_update":"2023-09-01 15:55:08.000000000","reason":"Change was abandoned"},"28619":{"account":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"last_update":"2023-05-04 15:43:14.000000000","reason":"\u003cGERRIT_ACCOUNT_28619\u003e replied on the change","reason_account":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}}},"hashtags":[],"change_id":"Ie3672022386bf06a95a53497c04ac8936237b679","subject":"Treat empty default_project_name as missing one","status":"ABANDONED","created":"2023-04-11 08:10:24.000000000","updated":"2023-09-01 15:55:08.000000000","total_comment_count":4,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"4a3c0b7c3746a3687f89f4e46a0d0da7f9bc44f4","_number":880027,"virtual_id_number":880027,"owner":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2023-04-11 09:41:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-11 09:41:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-04-12 10:50:34.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"CC"},{"updated":"2023-04-17 22:22:18.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"CC"}],"messages":[{"id":"50643601db9046f14756900f00dd8897e9d93925","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-04-11 08:10:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9bcd9f842265a3644ea0e1a0a733d8ef7bbe587b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-11 09:41:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8e1b6131d57440c4bd84380ed90a0af7\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/6f67201e8795480984356b58bf2c458b : SUCCESS in 2m 50s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/da0c493de42849b6bd4e37c796a19597 : SUCCESS in 5m 49s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/ffed47975de54d58b96cebf6f2cc3658 : SUCCESS in 4m 39s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/479bc467ff1b41bdbe237a0d5ba7a106 : SUCCESS in 55m 10s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/535a22dd41a94bc78063bb85bcb5d5af : SUCCESS in 55m 55s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/b9e3f14c51494107a173df225f7e2035 : SUCCESS in 1h 08m 36s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/a4aa00763cab46df957c9a35cb3c0940 : SUCCESS in 1h 09m 39s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/55c01e66f1804afebbe2f11f0e5d72e7 : SUCCESS in 1h 12m 29s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/502484273fcc41999643b7f509474be4 : SUCCESS in 40m 37s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/089e0e10bd10463b902b08087c113450 : SUCCESS in 40m 07s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7444288d615bd1a3f01e0c6b06b5107c3a6a3e53","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2023-04-12 10:50:34.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ca033cdaafb1f57453536f3f181c720e30e80ebd","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2023-04-17 22:22:18.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e8da8b9dc128cc367072cfd48bac55aefb018722","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-05-04 15:43:14.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"4a3c0b7c3746a3687f89f4e46a0d0da7f9bc44f4","tag":"autogenerated:gerrit:abandon","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-09-01 15:55:08.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4c00d19e418d9b48f14d7ffc87a5db9c4394d64f","revisions":{"4c00d19e418d9b48f14d7ffc87a5db9c4394d64f":{"kind":"REWORK","_number":1,"created":"2023-04-11 08:10:24.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/27/880027/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/27/880027/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/27/880027/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/27/880027/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/27/880027/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/27/880027/1"}}},"commit":{"parents":[{"commit":"18cf839db42f3983d16e68057e0d12a86882acf8","subject":"Highlight our mode of operation more prominently","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/18cf839db42f3983d16e68057e0d12a86882acf8"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@cleura.com","date":"2023-04-11 08:10:16.000000000","tz":120},"committer":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@cleura.com","date":"2023-04-11 08:10:16.000000000","tz":120},"subject":"Treat empty default_project_name as missing one","message":"Treat empty default_project_name as missing one\n\nAt the moment identity_user module treats empty default_project_name\nargument that is provided as an empty string, as valid name_or_id.\n\nAs it\u0027s quite tricky to \"undefine\" a variable on a role level playbooks might\nbe quite tricky, as in example [1]. So quite much complexity must be\nadded to such roles to use omit when resulting variable is an empty\nstring. At the same time providing empty string worked nicely before\nrefactoring [2] made for collection version 2.0.\n\nSo it\u0027s way easier to change condition in the module to ensure that\nempty strings are not treated as valid name_or_id.\n\n[1] https://opendev.org/openstack/openstack-ansible-plugins/src/branch/master/roles/service_setup/tasks/main.yml#L68-L90\n[2] https://opendev.org/openstack/ansible-collections-openstack/commit/c9afdbfd73d788450d0e9f28ffc6893e350c0460\n\nChange-Id: Ie3672022386bf06a95a53497c04ac8936237b679\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/4c00d19e418d9b48f14d7ffc87a5db9c4394d64f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/4c00d19e418d9b48f14d7ffc87a5db9c4394d64f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}