)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e69f65f80b26142522ac47990ad29f725c717652","unresolved":true,"context_lines":[{"line_number":19,"context_line":"as it is being changed to \"os-volume-type-access:is_public\" which is not"},{"line_number":20,"context_line":"expected by api. Which expects just \"is_public\""},{"line_number":21,"context_line":"https://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dupdate-a-volume-type-detail#update-a-volume-type"},{"line_number":22,"context_line":"Which results in \"\u0027os-volume-type-access:is_public\u0027 was unexpected\""},{"line_number":23,"context_line":"reply. I guess the change is required by openstacksdk or on the API side"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Idc26a5240b5f3314c8384c7326d8a82dcc8c6171"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7bbab2e5_f305da43","line":22,"updated":"2023-08-10 07:32:00.000000000","message":"this is pretty bad. API change is not the way to go since it will take ages till it reaches clouds and in the meanwhile module should still work","commit_id":"d9ee88326417a8b0a8b57bd533a2c6f5f4d3533b"},{"author":{"_account_id":32053,"name":"Denys Mishchenko","email":"denis@mischenko.org.ua","username":"arddennis"},"change_message_id":"6a58fca331e1059b42aaa4be8191e2c2e9b366d1","unresolved":true,"context_lines":[{"line_number":19,"context_line":"as it is being changed to \"os-volume-type-access:is_public\" which is not"},{"line_number":20,"context_line":"expected by api. Which expects just \"is_public\""},{"line_number":21,"context_line":"https://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dupdate-a-volume-type-detail#update-a-volume-type"},{"line_number":22,"context_line":"Which results in \"\u0027os-volume-type-access:is_public\u0027 was unexpected\""},{"line_number":23,"context_line":"reply. I guess the change is required by openstacksdk or on the API side"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Idc26a5240b5f3314c8384c7326d8a82dcc8c6171"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5eeb62ad_80884f20","line":22,"in_reply_to":"7bbab2e5_f305da43","updated":"2023-08-16 14:47:28.000000000","message":"I can implement one of the workarounds:\n* re-create volume-type in case of visibility change\n* warn that such change is not allowed on execution\n\nI am not sure how to make an exception for this case in sdk","commit_id":"d9ee88326417a8b0a8b57bd533a2c6f5f4d3533b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e69f65f80b26142522ac47990ad29f725c717652","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"12d24c47_8819891f","updated":"2023-08-10 07:32:00.000000000","message":"In addition to the comments inline I suggest to separate the encryption_type module into the separate change to keep things smaller","commit_id":"d9ee88326417a8b0a8b57bd533a2c6f5f4d3533b"},{"author":{"_account_id":32053,"name":"Denys Mishchenko","email":"denis@mischenko.org.ua","username":"arddennis"},"change_message_id":"6a58fca331e1059b42aaa4be8191e2c2e9b366d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e6681e01_7c9aba9e","updated":"2023-08-16 14:47:28.000000000","message":"* removed volume_type_encryption from this change\n* removed id from the module attributes, now only universal name or id will be used.\n* removed a way to rename volume_type and appropriate ci task\n* rebased on top of 890522 for the ci/run-collection change required by linters\n\nAlso to be noted: this module will work only with Zed as find_type is not available in previous releases. I can use additional function to search in listed public and private volume types if needed.","commit_id":"147ad6c4526f09771bc4425dc63bbb9c853476c9"}],"plugins/modules/volume_type.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e69f65f80b26142522ac47990ad29f725c717652","unresolved":true,"context_lines":[{"line_number":13,"context_line":"description:"},{"line_number":14,"context_line":"  - Add, remove or update volume types in OpenStack."},{"line_number":15,"context_line":"options:"},{"line_number":16,"context_line":"  id:"},{"line_number":17,"context_line":"    description:"},{"line_number":18,"context_line":"      - ID of the volume type. This is optional and used to update volume type"},{"line_number":19,"context_line":"        name."}],"source_content_type":"text/x-python","patch_set":4,"id":"f555a865_48372016","line":16,"updated":"2023-08-10 07:32:00.000000000","message":"and here as for others: name_or_id","commit_id":"d9ee88326417a8b0a8b57bd533a2c6f5f4d3533b"}],"plugins/modules/volume_type_encryption.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e69f65f80b26142522ac47990ad29f725c717652","unresolved":true,"context_lines":[{"line_number":12,"context_line":"description:"},{"line_number":13,"context_line":"  - Add, remove or update volume type encryption in OpenStack."},{"line_number":14,"context_line":"options:"},{"line_number":15,"context_line":"  volume_type_id:"},{"line_number":16,"context_line":"    description:"},{"line_number":17,"context_line":"      - ID of the volume type. This is optional and used to update volume type"},{"line_number":18,"context_line":"        name."}],"source_content_type":"text/x-python","patch_set":4,"id":"75c2f629_73e01099","line":15,"updated":"2023-08-10 07:32:00.000000000","message":"also here you should just have \"name\" as name_or_id","commit_id":"d9ee88326417a8b0a8b57bd533a2c6f5f4d3533b"},{"author":{"_account_id":32053,"name":"Denys Mishchenko","email":"denis@mischenko.org.ua","username":"arddennis"},"change_message_id":"6a58fca331e1059b42aaa4be8191e2c2e9b366d1","unresolved":true,"context_lines":[{"line_number":12,"context_line":"description:"},{"line_number":13,"context_line":"  - Add, remove or update volume type encryption in OpenStack."},{"line_number":14,"context_line":"options:"},{"line_number":15,"context_line":"  volume_type_id:"},{"line_number":16,"context_line":"    description:"},{"line_number":17,"context_line":"      - ID of the volume type. This is optional and used to update volume type"},{"line_number":18,"context_line":"        name."}],"source_content_type":"text/x-python","patch_set":4,"id":"d85ce395_c92fc733","line":15,"in_reply_to":"75c2f629_73e01099","updated":"2023-08-16 14:47:28.000000000","message":"The idea was to allow volume type name changing. If an additional field \"new name\" is used such a task can\u0027t be idempotent. But I guess this is a rare case and I will remove this from the code. name_or_id is more simple.","commit_id":"d9ee88326417a8b0a8b57bd533a2c6f5f4d3533b"}],"plugins/modules/volume_type_info.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"e69f65f80b26142522ac47990ad29f725c717652","unresolved":true,"context_lines":[{"line_number":13,"context_line":"  - Get volume type details in OpenStack."},{"line_number":14,"context_line":"  - Get volume type encryption details in OpenStack"},{"line_number":15,"context_line":"options:"},{"line_number":16,"context_line":"  id:"},{"line_number":17,"context_line":"    description:"},{"line_number":18,"context_line":"      - ID of the volume type."},{"line_number":19,"context_line":"    type: str"}],"source_content_type":"text/x-python","patch_set":4,"id":"b4a9f132_f7630a25","line":16,"updated":"2023-08-10 07:32:00.000000000","message":"current practice in modules is to use \"name\" parameter with meaning name_or_id. See i.e. https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/plugins/modules/volume_backup_info.py as reference","commit_id":"d9ee88326417a8b0a8b57bd533a2c6f5f4d3533b"}]}