)]}'
{"id":"openstack%2Fansible-collections-openstack~893367","triplet_id":"openstack%2Fansible-collections-openstack~master~Id0f69fe4c985c4c38b493577250cad4e589b9d24","project":"openstack/ansible-collections-openstack","branch":"master","attention_set":{},"removed_from_attention_set":{"28619":{"account":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"last_update":"2023-10-16 15:31:30.000000000","reason":"Change was submitted"},"27900":{"account":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"last_update":"2023-10-16 14:01:54.000000000","reason":"\u003cGERRIT_ACCOUNT_27900\u003e replied on the change","reason_account":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}}},"hashtags":[],"change_id":"Id0f69fe4c985c4c38b493577250cad4e589b9d24","subject":"Prevent routers to be always updated if no shared public network","status":"MERGED","created":"2023-08-31 13:06:45.000000000","updated":"2023-10-16 15:31:30.000000000","submitted":"2023-10-16 15:31:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"893367","meta_rev_id":"18ab8ff21aae5a7d8dba55d33eaa1b674a98ecb5","_number":893367,"virtual_id_number":893367,"owner":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-10-16 15:31:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"recommended":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"all":[{"value":1,"date":"2023-10-16 10:21:42.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":2,"date":"2023-10-16 14:01:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":1,"date":"2023-10-16 14:01:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-08-31 14:36:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-10-16 14:01:54.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"}],"messages":[{"id":"871e2a77a05ba54b587c13b027212891e485aa9f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-08-31 13:06:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b062015fb941578a5a50e2c2836de1d5420e38cb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-08-31 14:36:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3ad718aa7ec94538a7321bf4be777481\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/97194a2082a94879b6dda68d704f6c18 : SUCCESS in 2m 45s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/25432b31204c43f48c3c9038cb1f93cf : SUCCESS in 6m 14s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/5600b91157db4e51a7259cee7a2fb2e9 : SUCCESS in 6m 01s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/512b920ed13943b0acbb29c8d1c6a77c : SUCCESS in 1h 05m 49s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/ef691d7f44a94b9cb3e6336d575557a0 : SUCCESS in 1h 05m 54s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/c3e5dab7ab8b4b8686416348d9be23b4 : SUCCESS in 1h 01m 45s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/6605f8f95891462a9a018ae14165162c : SUCCESS in 51m 26s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/836d3e15897b40dfa0a5711f60ce78fa : SUCCESS in 46m 49s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/fbd5b820b18842a79a140d49c56d26fd : SUCCESS in 42m 06s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/5c414dd7057a4e94b42a70b4fc41207c : SUCCESS in 33m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8d41a2f51f66bdb8c6a41782146fddb25dab8899","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2023-10-16 10:04:51.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"0088789e278e726d673218946805b29c48d14eb1","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-10-16 10:21:42.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"6298d1ce85507b3dc1d6f5bf506cf509e85b4e1b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-16 11:48:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/aa98cbe8c37448f49ad429caf8c03863\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/91e68f489db9473a8840f21e467ec207 : SUCCESS in 2m 34s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/a22b28dfa1884a5aa8026485945cc1eb : FAILURE in 4m 31s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/95f8049045fb46ac93da2a93dc3557fd : SUCCESS in 5m 14s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/565b2204024f4fe5882b4588586ee632 : SUCCESS in 1h 02m 31s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/ef4e1c4a820a401b92985aed08c7a921 : SUCCESS in 1h 04m 08s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/5c7c7d1438c345b3a99e2551b3ee75df : SUCCESS in 51m 07s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/fc60c3608c5a4256a3c4fd44b3e78083 : SUCCESS in 1h 07m 01s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/91fa6eefdb0340cbaabf9c87a2d0c809 : SUCCESS in 51m 45s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/1efea3df2a8745be96b7a7843bab545d : SUCCESS in 37m 47s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/51d05ae783104eadb305fde36b420f17 : SUCCESS in 38m 20s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"7725a1865fc5ceb820fe6531bd61d366eff9d97c","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2023-10-16 14:01:54.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"95fc510d5a751cb8fac849599d09741c5aebbdf5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-16 14:02:32.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"ef85afa8a98de65176f29005de0cd195dc0a9248","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-16 15:31:30.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1912a60a15634068a8d034173790e4b6\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/3774af9932d54a27a14bacad83fa8a0e : SUCCESS in 2m 40s\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/bf869430f59842d7aa9b91ffa9fc08ea : SUCCESS in 5m 39s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/717fba8576ae4e159cd785d14ad1dcc6 : SUCCESS in 1h 23m 27s","accounts_in_message":[],"_revision_number":2},{"id":"18ab8ff21aae5a7d8dba55d33eaa1b674a98ecb5","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-16 15:31:30.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b25e93dbddb425b96b912dadcea4ed0884ad37d2","revisions":{"66206456f492c52507c68b53a30393659d01dcbc":{"kind":"REWORK","_number":1,"created":"2023-08-31 13:06:45.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/67/893367/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/67/893367/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/893367/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/893367/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/893367/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/893367/1"}}},"commit":{"parents":[{"commit":"8612171af384a992fef55a51115f0c1b3e5da8f5","subject":"Merge \"Image filters should be dict not set\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/8612171af384a992fef55a51115f0c1b3e5da8f5"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@cleura.com","date":"2023-08-31 13:06:38.000000000","tz":120},"committer":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@cleura.com","date":"2023-08-31 13:06:38.000000000","tz":120},"subject":"Prevent routers to be always updated if no shared public network","message":"Prevent routers to be always updated if no shared public network\n\nCurrent logic assumes that external_fixed_ips should be always defined,\notherwise `req_fip_map` is an empty sequence, which makes _needs_update\nto return True.\nWith that not having external_fixed_ips is a vaild case whenever\ndeployment does not have shared public network. This usually\nthe case when public network is not passed to computes and public\nnetwork is used only for routers and floating IPs.\n\nPatch changes logic and verifies content of req_fip_map only when\nexternal_fixed_ips is truthy.\n\nChange-Id: Id0f69fe4c985c4c38b493577250cad4e589b9d24\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/66206456f492c52507c68b53a30393659d01dcbc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/66206456f492c52507c68b53a30393659d01dcbc"}]},"branch":"refs/heads/master"},"b25e93dbddb425b96b912dadcea4ed0884ad37d2":{"kind":"REWORK","_number":2,"created":"2023-10-16 10:04:51.000000000","uploader":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"ref":"refs/changes/67/893367/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/67/893367/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/893367/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/893367/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/893367/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/893367/2"}}},"commit":{"parents":[{"commit":"8612171af384a992fef55a51115f0c1b3e5da8f5","subject":"Merge \"Image filters should be dict not set\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/8612171af384a992fef55a51115f0c1b3e5da8f5"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@cleura.com","date":"2023-08-31 13:06:38.000000000","tz":120},"committer":{"name":"gtema","email":"artem.goncharov@gmail.com","date":"2023-10-16 10:04:50.000000000","tz":120},"subject":"Prevent routers to be always updated if no shared public network","message":"Prevent routers to be always updated if no shared public network\n\nCurrent logic assumes that external_fixed_ips should be always defined,\notherwise `req_fip_map` is an empty sequence, which makes _needs_update\nto return True.\nWith that not having external_fixed_ips is a vaild case whenever\ndeployment does not have shared public network. This usually\nthe case when public network is not passed to computes and public\nnetwork is used only for routers and floating IPs.\n\nPatch changes logic by addind a `is not None` support to only compare\nexternal_fip configration when user explicitly passed something (passing\nan empty dict is equal to requesting \"empty\" configuration).\n\nCo-Authored-by: Artem Goncharov\nChange-Id: Id0f69fe4c985c4c38b493577250cad4e589b9d24\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/b25e93dbddb425b96b912dadcea4ed0884ad37d2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/b25e93dbddb425b96b912dadcea4ed0884ad37d2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}