)]}'
{"id":"openstack%2Fansible-collections-openstack~893370","triplet_id":"openstack%2Fansible-collections-openstack~master~Ib2e68b8045fe4f91a2f5f8c4a9b4bb0a5493859a","project":"openstack/ansible-collections-openstack","branch":"master","hashtags":[],"change_id":"Ib2e68b8045fe4f91a2f5f8c4a9b4bb0a5493859a","subject":"Ensure that double-stack routers are not always updated","status":"ABANDONED","created":"2023-08-31 13:23:14.000000000","updated":"2023-11-07 19:14:32.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b343557d04b612ba7027cfce60bbaa46c3e960ec","_number":893370,"virtual_id_number":893370,"owner":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2023-08-31 15:06:10.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-08-31 15:06:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a9648d5a56b099acaa2472ac23d437578c5d09a3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-08-31 13:23:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"36e8a35cd3a778bef70fce4c3fc62391eb9c10e7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-08-31 13:39:44.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"450a68439819c415d1209a4217177a34b67ec74e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-08-31 15:06:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/eae036b7f8774492a15bc756f392df6f\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/c1a57fcacf104c08916a431ac965fc27 : SUCCESS in 3m 13s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/b21bb2fa0dd6493b8d2d97ffecea410a : SUCCESS in 6m 38s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/cf1b9d1ed5b34056b0dbcfbe22f39686 : SUCCESS in 6m 19s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/9efc10538b0e462e8b72467a2969bc91 : SUCCESS in 1h 00m 38s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/22e500fb603040359e427289f5370c84 : SUCCESS in 1h 08m 03s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/0fb6832cacbb46f9a00ad892bb228e56 : SUCCESS in 59m 07s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/22263996c5734db08e438e8a5d982def : SUCCESS in 1h 03m 35s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/4e9528359883497ba6ae131d62b50ff2 : SUCCESS in 1h 07m 33s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/915a516f58df45b7b332f4ada228d342 : SUCCESS in 40m 28s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/01d2a7b27ca442beaf3a228daf506197 : SUCCESS in 37m 32s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"b343557d04b612ba7027cfce60bbaa46c3e960ec","tag":"autogenerated:gerrit:abandon","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2023-11-07 19:14:32.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4bd3fb28747b30a30752b276dcaaa0ba7d5485d1","revisions":{"bc0a9e9f6d11179ca87738aa3be439fa2dd0d880":{"kind":"REWORK","_number":1,"created":"2023-08-31 13:23:14.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/70/893370/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/70/893370/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/70/893370/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/70/893370/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/70/893370/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/70/893370/1"}}},"commit":{"parents":[{"commit":"66206456f492c52507c68b53a30393659d01dcbc","subject":"Prevent routers to be always updated if no shared public network","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/66206456f492c52507c68b53a30393659d01dcbc"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@cleura.com","date":"2023-08-31 13:22:36.000000000","tz":120},"committer":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@cleura.com","date":"2023-08-31 13:22:36.000000000","tz":120},"subject":"Ensure that double-stack routers are not always updated","message":"Ensure that double-stack routers are not always updated\n\nCurrent logic assumes, that a router that does not need an update\nonly if there is a single external IP present. However, in case\na public network does have an IPv6 subnet, router will recieve an IPv6\naddress as well, resulting in cur_ext_fips be always more then 1.\nWith that we identify versions of IP addresses that are present and\ncount them separately.\nRouter is updated only In case there\u0027s extra IPv4 or IPv6 present.\n\nChange-Id: Ib2e68b8045fe4f91a2f5f8c4a9b4bb0a5493859a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/bc0a9e9f6d11179ca87738aa3be439fa2dd0d880"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/bc0a9e9f6d11179ca87738aa3be439fa2dd0d880"}]},"branch":"refs/heads/master"},"4bd3fb28747b30a30752b276dcaaa0ba7d5485d1":{"kind":"REWORK","_number":2,"created":"2023-08-31 13:39:44.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/70/893370/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/70/893370/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/70/893370/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/70/893370/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/70/893370/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/70/893370/2"}}},"commit":{"parents":[{"commit":"66206456f492c52507c68b53a30393659d01dcbc","subject":"Prevent routers to be always updated if no shared public network","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/66206456f492c52507c68b53a30393659d01dcbc"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@cleura.com","date":"2023-08-31 13:22:36.000000000","tz":120},"committer":{"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","date":"2023-08-31 13:39:44.000000000","tz":0},"subject":"Ensure that double-stack routers are not always updated","message":"Ensure that double-stack routers are not always updated\n\nCurrent logic assumes, that a router that does not need an update\nonly if there is a single external IP present. However, in case\na public network does have an IPv6 subnet, router will recieve an IPv6\naddress as well, resulting in cur_ext_fips be always more then 1.\nWith that we identify versions of IP addresses that are present and\ncount them separately.\nRouter is updated only In case there\u0027s extra IPv4 or IPv6 present.\n\nChange-Id: Ib2e68b8045fe4f91a2f5f8c4a9b4bb0a5493859a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/4bd3fb28747b30a30752b276dcaaa0ba7d5485d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/4bd3fb28747b30a30752b276dcaaa0ba7d5485d1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}