)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34112,"name":"Kaloyan Kotlarski","email":"kaloyan.kotlarski@storpool.com","username":"kkotlarski"},"change_message_id":"4014cab7aa7fb1bd19f043b794301e22d3f16956","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aefa0bc4_65490c1b","updated":"2024-07-31 14:06:08.000000000","message":"recheck","commit_id":"d5c638c7f6a375098c62e05dc512465c6efc24bc"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d1099e4a04c82693c1133a44b086cefa43ce2286","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9b2faf72_4adf7360","updated":"2024-11-07 19:26:53.000000000","message":"@kaloyan.kotlarski@storpool.com please take a look at addressed issues.","commit_id":"67615e43bb4e69bab332a383e25716081118bcc9"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"fa6c730044ef58dffa4b15677514606296326b90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a89231d3_9b0e77ad","updated":"2024-11-24 10:39:07.000000000","message":"@dtantsur@protonmail.com can you please advise here?","commit_id":"c8c22f7c2c6cf87a64cdc40aafa610098fa1d603"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"4cdb222b0c877c8a4589ca551bae12d0e5b81d04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"802b4ddf_5d172e0a","updated":"2024-11-24 10:38:47.000000000","message":"ERROR: plugins/modules/baremetal_node_action.py:0:0: doc-default-does-not-match-spec: Argument \u0027vifs\u0027 in argument_spec defines default as ([]) but documentation defines default as (None)\n\nplease fix docs","commit_id":"c8c22f7c2c6cf87a64cdc40aafa610098fa1d603"}],"plugins/modules/baremetal_node_action.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"a2791126b866af6464e859faf4d73e76b676ec7a","unresolved":true,"context_lines":[{"line_number":232,"context_line":"                # Node already in an active state"},{"line_number":233,"context_line":"                self.exit_json(changed\u003dchanged)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"            for vif_id in self.params[\u0027vifs\u0027]:"},{"line_number":236,"context_line":"                self.conn.baremetal.attach_vif_to_node("},{"line_number":237,"context_line":"                    node[\u0027id\u0027],"},{"line_number":238,"context_line":"                    vif_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"b7d3d6d7_8dddd134","line":235,"range":{"start_line":235,"start_character":12,"end_line":235,"end_character":46},"updated":"2024-10-10 08:09:50.000000000","message":"please add check that self.params[\u0027vifs\u0027] is not None","commit_id":"f7ca587f57bef98e77d119cf24697e9d4f58cea6"},{"author":{"_account_id":34112,"name":"Kaloyan Kotlarski","email":"kaloyan.kotlarski@storpool.com","username":"kkotlarski"},"change_message_id":"cee4c197e1662d97672b0cbde9192008ba2ba808","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                # Node already in an active state"},{"line_number":233,"context_line":"                self.exit_json(changed\u003dchanged)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"            for vif_id in self.params[\u0027vifs\u0027]:"},{"line_number":236,"context_line":"                self.conn.baremetal.attach_vif_to_node("},{"line_number":237,"context_line":"                    node[\u0027id\u0027],"},{"line_number":238,"context_line":"                    vif_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"20bd248e_154a82c6","line":235,"range":{"start_line":235,"start_character":12,"end_line":235,"end_character":46},"in_reply_to":"b7d3d6d7_8dddd134","updated":"2024-10-16 07:11:45.000000000","message":"Added a default value of an empty list to the `vifs` parameter.","commit_id":"f7ca587f57bef98e77d119cf24697e9d4f58cea6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"a2791126b866af6464e859faf4d73e76b676ec7a","unresolved":true,"context_lines":[{"line_number":264,"context_line":"                wait\u003dself.params[\u0027wait\u0027],"},{"line_number":265,"context_line":"                timeout\u003dself.params[\u0027timeout\u0027])"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"            for vif_id in self.params[\u0027vifs\u0027]:"},{"line_number":268,"context_line":"                self.conn.baremetal.detach_vif_from_node("},{"line_number":269,"context_line":"                    node[\u0027id\u0027],"},{"line_number":270,"context_line":"                    vif_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"93646e2a_302111b6","line":267,"range":{"start_line":267,"start_character":8,"end_line":267,"end_character":46},"updated":"2024-10-10 08:09:50.000000000","message":"please add check that self.params[\u0027vifs\u0027] is not None\nor set it as [] by default","commit_id":"f7ca587f57bef98e77d119cf24697e9d4f58cea6"},{"author":{"_account_id":34112,"name":"Kaloyan Kotlarski","email":"kaloyan.kotlarski@storpool.com","username":"kkotlarski"},"change_message_id":"cee4c197e1662d97672b0cbde9192008ba2ba808","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                wait\u003dself.params[\u0027wait\u0027],"},{"line_number":265,"context_line":"                timeout\u003dself.params[\u0027timeout\u0027])"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"            for vif_id in self.params[\u0027vifs\u0027]:"},{"line_number":268,"context_line":"                self.conn.baremetal.detach_vif_from_node("},{"line_number":269,"context_line":"                    node[\u0027id\u0027],"},{"line_number":270,"context_line":"                    vif_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"0bca67c1_d861b416","line":267,"range":{"start_line":267,"start_character":8,"end_line":267,"end_character":46},"in_reply_to":"93646e2a_302111b6","updated":"2024-10-16 07:11:45.000000000","message":"Done","commit_id":"f7ca587f57bef98e77d119cf24697e9d4f58cea6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b6dadbda9c827536cfc0c0adbbb46e84d63438a3","unresolved":true,"context_lines":[{"line_number":44,"context_line":"      description:"},{"line_number":45,"context_line":"        - A list of Neutron port UUIDs to attach to the Node when deploying it"},{"line_number":46,"context_line":"      type: list"},{"line_number":47,"context_line":"      elements: str"},{"line_number":48,"context_line":"      default: []"},{"line_number":49,"context_line":"    maintenance:"},{"line_number":50,"context_line":"      description:"}],"source_content_type":"text/x-python","patch_set":3,"id":"8a377e3e_f83cae39","line":47,"updated":"2024-10-16 16:09:12.000000000","message":"VIF API accepts more than just strings. Let\u0027s future-proof it by accepting a list of \"id: \u003cuuid\u003e\"?","commit_id":"67615e43bb4e69bab332a383e25716081118bcc9"},{"author":{"_account_id":34112,"name":"Kaloyan Kotlarski","email":"kaloyan.kotlarski@storpool.com","username":"kkotlarski"},"change_message_id":"92776404bb15fceb873d9fd1cff3f4346513990f","unresolved":true,"context_lines":[{"line_number":44,"context_line":"      description:"},{"line_number":45,"context_line":"        - A list of Neutron port UUIDs to attach to the Node when deploying it"},{"line_number":46,"context_line":"      type: list"},{"line_number":47,"context_line":"      elements: str"},{"line_number":48,"context_line":"      default: []"},{"line_number":49,"context_line":"    maintenance:"},{"line_number":50,"context_line":"      description:"}],"source_content_type":"text/x-python","patch_set":3,"id":"574ad37d_c22dae1c","line":47,"in_reply_to":"8a377e3e_f83cae39","updated":"2024-11-14 11:39:49.000000000","message":"I don\u0027t quite understand, you\u0027re offering to change it to a list of dicts that have a key named \"id\" that points to an uuid string?","commit_id":"67615e43bb4e69bab332a383e25716081118bcc9"}]}