)]}'
{"id":"openstack%2Fansible-collections-openstack~931335","triplet_id":"openstack%2Fansible-collections-openstack~master~Ib92b3b80f2873327161e23b0ce6bfc6c34850538","project":"openstack/ansible-collections-openstack","branch":"master","topic":"fix-bug-2061604","attention_set":{},"removed_from_attention_set":{"4146":{"account":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"last_update":"2024-10-08 10:33:25.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib92b3b80f2873327161e23b0ce6bfc6c34850538","subject":"Run functional testing regardless of pep8/linter results","status":"MERGED","created":"2024-10-03 18:20:38.000000000","updated":"2024-10-08 10:33:25.000000000","submitted":"2024-10-08 10:33:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"931335-fix-bug-2061604","meta_rev_id":"4447d14c7ed537044ba0d80d05e717f9325f19bd","_number":931335,"virtual_id_number":931335,"owner":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-10-08 10:33:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"all":[{"value":2,"date":"2024-10-08 08:11:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":2,"date":"2024-10-08 09:53:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":1,"date":"2024-10-08 09:53:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-10-03 18:21:41.000000000","updated_by":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"reviewer":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"state":"REVIEWER"},{"updated":"2024-10-03 19:28:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-10-06 20:20:03.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REVIEWER"}],"messages":[{"id":"e055a2c4cbc5fc22a1a60a41378fec35848a1b41","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2024-10-03 18:20:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"35e3ce9ce3e1985f045e7d582c6de0422aa321ee","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2024-10-03 18:21:41.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"592f662a1697b3ea6cdc690b8893cbb3eae339e5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-10-03 19:28:21.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/505db08861364200950077b889a55572\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/06780d71e3134818b674af7b4ff86d1b : SUCCESS in 3m 02s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/9ed778bf1d17496ab7f1f56a439d9ece : SUCCESS in 3m 53s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/fb20c63f74814ab2ba2754821bed34d0 : SUCCESS in 5m 18s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/75aa4bc7f41d45ab846100555af7f928 : FAILURE in 51m 06s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/07a69e3a5e4545fc91ad5d7cd1ad6370 : FAILURE in 52m 52s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/faa3ce9871d249b6aa77948cb8455c2e : FAILURE in 1h 01m 42s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/f3c5ab12457f40578082e1c1322845a1 : FAILURE in 37m 18s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/9349248ffcea4b1e9f88b5d81a2571e3 : FAILURE in 35m 18s (non-voting)\n- ansible-collections-openstack-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/11fd44953f8946409fd1be4ec43d96f4 : SUCCESS in 25m 13s\n- ansible-collections-openstack-functional-devstack-octavia https://zuul.opendev.org/t/openstack/build/b031875a505e4d90afa216c9e13644d9 : SUCCESS in 41m 47s\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/68764a6bcafd4991ae9f153c821998ff : SUCCESS in 35m 29s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/073d9f8c6b754164bc7ef981a3696a22 : SUCCESS in 19m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4f05396fdc1e835a61f9eff4f263255363d327b7","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2024-10-06 20:20:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3f5e06fde58b1b6675066a98ad07068f6ace7661","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2024-10-06 20:31:15.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5ca4a107a85d7bf12d0817eb02cab0066cfa7ed5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"real_author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2024-10-08 08:11:10.000000000","message":"Patch Set 2: Patch Set 1 was rebased on behalf of \u003cGERRIT_ACCOUNT_4146\u003e\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"**changekind:TRIVIAL_REBASE** OR is:MIN\")\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}],"_revision_number":2},{"id":"4207165507960bc4e7b50cc84a425fffdd40f68a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-10-08 09:16:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/88b6f7f75ef44ec2852e8d1e9eff656c\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/8fc912cf047d4f8d9ec5dd3399227c83 : SUCCESS in 2m 47s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/ffe8af29eecf40c08166df7eefbf9d71 : SUCCESS in 5m 39s (non-voting)\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/3592d8ce465f444b996232c6e11810ab : SUCCESS in 8m 35s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/22128783b67d4af08d4d6c8aedb5cd82 : SUCCESS in 1h 02m 57s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/3364abc9a60c408e88f3111effd00531 : SUCCESS in 58m 04s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/5ac12c0f41d5481ba477fd13a8829aee : SUCCESS in 1h 03m 29s\n- ansible-collections-openstack-functional-devstack-ansible-2.12 https://zuul.opendev.org/t/openstack/build/0cd862de26384d1baed74bc4a71f8929 : SUCCESS in 56m 10s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/352ddc993cd34ad4848090223fb89f6a : SUCCESS in 55m 00s (non-voting)\n- ansible-collections-openstack-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/8a73fba7104041b991c1981eb808a9ca : SUCCESS in 25m 49s\n- ansible-collections-openstack-functional-devstack-octavia https://zuul.opendev.org/t/openstack/build/2dd151f179314e5f8c97555da6567885 : SUCCESS in 32m 50s\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/b42e8afe229844ff9b3a8510426088d1 : SUCCESS in 37m 51s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/81dcf5a2c1454cddac038029538a0149 : SUCCESS in 39m 22s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"2aa2b76cb0f18ea95f66a4ead1c6f6dabc8701cc","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2024-10-08 09:53:08.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"50d21154d208fd7a0664e2ae18f933bb6812a677","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-10-08 09:53:35.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"301f09b017a7e864143b0ca7bad92f1c6dfedd74","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-10-08 10:33:25.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/05fc3d47dd9846bdbc554ddea1917fab\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/f076e5ec477b41fc8dfed3e93b59af51 : SUCCESS in 3m 20s\n- openstack-tox-linters-ansible-2.12 https://zuul.opendev.org/t/openstack/build/89134e1bf4c241ab91855946662f4f82 : SUCCESS in 5m 15s","accounts_in_message":[],"_revision_number":2},{"id":"4447d14c7ed537044ba0d80d05e717f9325f19bd","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-10-08 10:33:25.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8aefe5dc3a0fc5c62fbfbaf990d3d84f68d45954","revisions":{"f8a9dd6896f8e5f121aa621ceed1e1b4e27d6569":{"kind":"REWORK","_number":1,"created":"2024-10-03 18:20:38.000000000","uploader":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"ref":"refs/changes/35/931335/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/35/931335/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/35/931335/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/35/931335/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/35/931335/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/35/931335/1"}}},"commit":{"parents":[{"commit":"c49d68a080b9492f5ea6843efa79d2f5185db3cd","subject":"Fix exception when creating object from file","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/c49d68a080b9492f5ea6843efa79d2f5185db3cd"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2024-10-03 18:18:11.000000000","tz":-420},"committer":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2024-10-03 18:18:11.000000000","tz":-420},"subject":"Run functional testing regardless of pep8/linter results","message":"Run functional testing regardless of pep8/linter results\n\nThe parent change was pushed up initially with a super minor pep8 under\nindentation issue. The Zuul config at the time prevent functional\ntesting from running so we got no indiciation of whether or not the\nproposed fix actually fixed the issue.\n\nUpdate the Zuul config to run pep8 and functional tests concurrently.\nFormatting errors are independent of functionality and getting quick\nfeedback on both gives contributors and reviewers as much feedback as\npossible when making decisions about the next step for the code review\nprocess.\n\nThe fewer round trips we force everyone to make the less likely we are\nto forget about a change or ignore it and otherwise extend the time it\ntakes to get code merged.\n\nChange-Id: Ib92b3b80f2873327161e23b0ce6bfc6c34850538\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/f8a9dd6896f8e5f121aa621ceed1e1b4e27d6569"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/f8a9dd6896f8e5f121aa621ceed1e1b4e27d6569"}]},"branch":"refs/heads/master"},"8aefe5dc3a0fc5c62fbfbaf990d3d84f68d45954":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-10-08 08:11:10.000000000","uploader":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"real_uploader":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"ref":"refs/changes/35/931335/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/35/931335/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/35/931335/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/35/931335/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/35/931335/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/35/931335/2"}}},"commit":{"parents":[{"commit":"217e965357842684d63fd6e53767efe225f3fda0","subject":"Fix CI in collection","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/217e965357842684d63fd6e53767efe225f3fda0"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2024-10-03 18:18:11.000000000","tz":-420},"committer":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2024-10-08 08:11:10.000000000","tz":0},"subject":"Run functional testing regardless of pep8/linter results","message":"Run functional testing regardless of pep8/linter results\n\nThe parent change was pushed up initially with a super minor pep8 under\nindentation issue. The Zuul config at the time prevent functional\ntesting from running so we got no indiciation of whether or not the\nproposed fix actually fixed the issue.\n\nUpdate the Zuul config to run pep8 and functional tests concurrently.\nFormatting errors are independent of functionality and getting quick\nfeedback on both gives contributors and reviewers as much feedback as\npossible when making decisions about the next step for the code review\nprocess.\n\nThe fewer round trips we force everyone to make the less likely we are\nto forget about a change or ignore it and otherwise extend the time it\ntakes to get code merged.\n\nChange-Id: Ib92b3b80f2873327161e23b0ce6bfc6c34850538\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/8aefe5dc3a0fc5c62fbfbaf990d3d84f68d45954"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/8aefe5dc3a0fc5c62fbfbaf990d3d84f68d45954"}]},"branch":"refs/heads/master","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}