)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35591,"name":"Amir Nikpour","display_name":"Amir Nikpour","email":"amnik.free@gmail.com","username":"amnik"},"change_message_id":"10e7c8ad1c82d82c9786a603b1884c82a81ec6e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c914268b_7aa5b74b","updated":"2024-10-24 10:27:17.000000000","message":"Hi Shnaidman Sagi. I\u0027ve submitted a patch and would appreciate it if you could take some time to review it and provide your feedback. Thank you.","commit_id":"6a6cd3b89cbaab85f3e1f07bd338d121d9911097"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"4b52354ee5d43108fa296e3cafd301093940345a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8ed7a362_e7fd5766","updated":"2024-10-31 11:31:52.000000000","message":"Hi, Amir\nI\u0027m not sure I understand - why just not to pass \"*\" as a `target_project_id` to the module? Will it be different than introducing another variable?","commit_id":"6a6cd3b89cbaab85f3e1f07bd338d121d9911097"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"1e62bef0838361801a46d49173f59ebc847872bd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"52f89c27_1f1c05a2","in_reply_to":"228eb597_c2000eec","updated":"2024-10-31 14:56:51.000000000","message":"Ack, seems reasonable. Can you please add tests?","commit_id":"6a6cd3b89cbaab85f3e1f07bd338d121d9911097"},{"author":{"_account_id":35591,"name":"Amir Nikpour","display_name":"Amir Nikpour","email":"amnik.free@gmail.com","username":"amnik"},"change_message_id":"a62d49951d09d66cbc238d0c9746e1cd1bce4591","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1af1096e_357a1ca9","in_reply_to":"52f89c27_1f1c05a2","updated":"2024-10-31 16:19:14.000000000","message":"Yes I will add.","commit_id":"6a6cd3b89cbaab85f3e1f07bd338d121d9911097"},{"author":{"_account_id":35591,"name":"Amir Nikpour","display_name":"Amir Nikpour","email":"amnik.free@gmail.com","username":"amnik"},"change_message_id":"a0592da285ed641fbc10144d6bfcc0665c0198b4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"228eb597_c2000eec","in_reply_to":"8ed7a362_e7fd5766","updated":"2024-10-31 13:33:15.000000000","message":"Yes it has the same result. But adding target_all_project variable make this module more consistent with openstack CLI that has --target-all-projects option which separate it from target_project_id, and I think makes it more meaningful for users. \nhttps://docs.openstack.org/python-openstackclient/latest/cli/command-objects/network-rbac.html","commit_id":"6a6cd3b89cbaab85f3e1f07bd338d121d9911097"}]}