)]}'
{"plugins/inventory/openstack.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"012e64cc526dcc21673b502bb213e119c1e1f679","unresolved":true,"context_lines":[{"line_number":279,"context_line":"            clouds_yaml_path \u003d self.get_option(\u0027clouds_yaml_path\u0027)"},{"line_number":280,"context_line":"            config_files \u003d openstack.config.loader.CONFIG_FILES"},{"line_number":281,"context_line":"            if clouds_yaml_path:"},{"line_number":282,"context_line":"                config_files +\u003d clouds_yaml_path"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"            config \u003d openstack.config.loader.OpenStackConfig("},{"line_number":285,"context_line":"                config_files\u003dconfig_files)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1e6277fe_4adff888","side":"PARENT","line":282,"range":{"start_line":282,"start_character":16,"end_line":282,"end_character":48},"updated":"2025-01-27 20:50:34.000000000","message":"Maybe better to change to:\n`config_files \u003d clouds_yaml_path + config_files`\n?\nSo it will be first to search as in docs above.","commit_id":"fef560eb5bf3ad6d76557112a25ab56844d8f0ac"},{"author":{"_account_id":37691,"name":"Matthias Rabe","display_name":"Matthias R.","email":"mr@matthias-rabe.de","username":"matthias-rabe"},"change_message_id":"650740fc1ba3f9da68c2cf5419e7da64d30a400e","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            clouds_yaml_path \u003d self.get_option(\u0027clouds_yaml_path\u0027)"},{"line_number":280,"context_line":"            config_files \u003d openstack.config.loader.CONFIG_FILES"},{"line_number":281,"context_line":"            if clouds_yaml_path:"},{"line_number":282,"context_line":"                config_files +\u003d clouds_yaml_path"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"            config \u003d openstack.config.loader.OpenStackConfig("},{"line_number":285,"context_line":"                config_files\u003dconfig_files)"}],"source_content_type":"text/x-python","patch_set":1,"id":"44f75a0e_4efd7113","side":"PARENT","line":282,"range":{"start_line":282,"start_character":16,"end_line":282,"end_character":48},"in_reply_to":"14bc42bc_d647ab4d","updated":"2025-02-04 16:10:00.000000000","message":"Yes, I have tested it and prepending clouds_yaml_path to config_files instead of appending it solved my problem with conflicting credentials in ~/.config/openstack/clouds.yaml. So, for me it is ok to use your suggestion.","commit_id":"fef560eb5bf3ad6d76557112a25ab56844d8f0ac"},{"author":{"_account_id":37691,"name":"Matthias Rabe","display_name":"Matthias R.","email":"mr@matthias-rabe.de","username":"matthias-rabe"},"change_message_id":"401e61ff107d592fe38dd13872bab73df2f046a0","unresolved":true,"context_lines":[{"line_number":279,"context_line":"            clouds_yaml_path \u003d self.get_option(\u0027clouds_yaml_path\u0027)"},{"line_number":280,"context_line":"            config_files \u003d openstack.config.loader.CONFIG_FILES"},{"line_number":281,"context_line":"            if clouds_yaml_path:"},{"line_number":282,"context_line":"                config_files +\u003d clouds_yaml_path"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"            config \u003d openstack.config.loader.OpenStackConfig("},{"line_number":285,"context_line":"                config_files\u003dconfig_files)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a7e787ab_20a694a2","side":"PARENT","line":282,"range":{"start_line":282,"start_character":16,"end_line":282,"end_character":48},"in_reply_to":"1e6277fe_4adff888","updated":"2025-01-30 14:07:54.000000000","message":"I think it can lead to unexpected behavior if configuration files from out of the ansible project are always read. Maybe if we make it configurable?\n\n            config_files \u003d openstack.config.loader.CONFIG_FILES\n            clouds_yaml_path \u003d self.get_option(\u0027clouds_yaml_path\u0027)\n            if clouds_yaml_path:\n                clouds_yaml_path_behaviour \u003d self.get_option(\u0027clouds_yaml_path_behaviour\u0027)\n                if not clouds_yaml_path_behaviour:\n                    config_files +\u003d clouds_yaml_path\n                elif clouds_yaml_path_behaviour \u003d\u003d \u0027append\u0027:\n                    config_files +\u003d clouds_yaml_path\n                elif clouds_yaml_path_behaviour \u003d\u003d \u0027prepend\u0027:\n                    config_files \u003d clouds_yaml_path + config_files\n                elif clouds_yaml_path_behaviour \u003d\u003d \u0027only\u0027:\n                    config_files \u003d clouds_yaml_path\n                else:\n                    raise AnsibleParserError(\"invalid value: clouds_yaml_path_behaviour \u003d %s\" % clouds_yaml_path_behaviour)\n\nThis example is untested, just to give you an idea of what I am talking about...","commit_id":"fef560eb5bf3ad6d76557112a25ab56844d8f0ac"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"59d75d462d30508f9464b5fc427520e567d69118","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            clouds_yaml_path \u003d self.get_option(\u0027clouds_yaml_path\u0027)"},{"line_number":280,"context_line":"            config_files \u003d openstack.config.loader.CONFIG_FILES"},{"line_number":281,"context_line":"            if clouds_yaml_path:"},{"line_number":282,"context_line":"                config_files +\u003d clouds_yaml_path"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"            config \u003d openstack.config.loader.OpenStackConfig("},{"line_number":285,"context_line":"                config_files\u003dconfig_files)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6651c5_94adccf9","side":"PARENT","line":282,"range":{"start_line":282,"start_character":16,"end_line":282,"end_character":48},"in_reply_to":"44f75a0e_4efd7113","updated":"2025-02-19 11:24:24.000000000","message":"So, would you like to push the change?","commit_id":"fef560eb5bf3ad6d76557112a25ab56844d8f0ac"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"035ea00a7f8004feb10f2d654c6ed5115b0141e3","unresolved":true,"context_lines":[{"line_number":279,"context_line":"            clouds_yaml_path \u003d self.get_option(\u0027clouds_yaml_path\u0027)"},{"line_number":280,"context_line":"            config_files \u003d openstack.config.loader.CONFIG_FILES"},{"line_number":281,"context_line":"            if clouds_yaml_path:"},{"line_number":282,"context_line":"                config_files +\u003d clouds_yaml_path"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"            config \u003d openstack.config.loader.OpenStackConfig("},{"line_number":285,"context_line":"                config_files\u003dconfig_files)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fc48df8e_9b903367","side":"PARENT","line":282,"range":{"start_line":282,"start_character":16,"end_line":282,"end_character":48},"in_reply_to":"9f6651c5_94adccf9","updated":"2025-04-15 20:21:10.000000000","message":"Is this ready to land @sshnaidm@redhat.com?","commit_id":"fef560eb5bf3ad6d76557112a25ab56844d8f0ac"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"9fb857aadc67d2b2d88fa7e0db9455d8e79557a7","unresolved":true,"context_lines":[{"line_number":279,"context_line":"            clouds_yaml_path \u003d self.get_option(\u0027clouds_yaml_path\u0027)"},{"line_number":280,"context_line":"            config_files \u003d openstack.config.loader.CONFIG_FILES"},{"line_number":281,"context_line":"            if clouds_yaml_path:"},{"line_number":282,"context_line":"                config_files +\u003d clouds_yaml_path"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"            config \u003d openstack.config.loader.OpenStackConfig("},{"line_number":285,"context_line":"                config_files\u003dconfig_files)"}],"source_content_type":"text/x-python","patch_set":1,"id":"14bc42bc_d647ab4d","side":"PARENT","line":282,"range":{"start_line":282,"start_character":16,"end_line":282,"end_character":48},"in_reply_to":"a7e787ab_20a694a2","updated":"2025-01-31 20:39:44.000000000","message":"I think it brings too much complexity here.\nWhat is the possible problem to read files from /etc/openstack ?","commit_id":"fef560eb5bf3ad6d76557112a25ab56844d8f0ac"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"98a50077916352b68846a5e131346bd390a51889","unresolved":true,"context_lines":[{"line_number":279,"context_line":"            clouds_yaml_path \u003d self.get_option(\u0027clouds_yaml_path\u0027)"},{"line_number":280,"context_line":"            config_files \u003d openstack.config.loader.CONFIG_FILES"},{"line_number":281,"context_line":"            if clouds_yaml_path:"},{"line_number":282,"context_line":"                config_files +\u003d clouds_yaml_path"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"            config \u003d openstack.config.loader.OpenStackConfig("},{"line_number":285,"context_line":"                config_files\u003dconfig_files)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6bd6dd23_87428047","side":"PARENT","line":282,"range":{"start_line":282,"start_character":16,"end_line":282,"end_character":48},"in_reply_to":"fc48df8e_9b903367","updated":"2025-04-24 22:40:51.000000000","message":"@mr@matthias-rabe.de looks like your chain of commits needs to be squashed into one commit to handle the review comments. Can you do so? Working to land outstanding changes so we can make a release.","commit_id":"fef560eb5bf3ad6d76557112a25ab56844d8f0ac"}]}