)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"051ab749d1c43904dec4044c3c34f8aa42a43e80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fe1de0a7_bd501819","updated":"2025-04-21 12:25:39.000000000","message":"Currently there is a problem with subnets pool idempotency test, I\u0027d recommend to disable it with TODO comment in this patch to pass one fix. I can take a look later: https://github.com/openstack/ansible-collections-openstack/blob/41cf92df998491b9b8a91a20eacd9528acd0fc77/ci/roles/subnet/tasks/subnet-pool.yaml#L128","commit_id":"1b240f323d31bb6102264a2cf8cfd78c2a0e2742"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"643a404bb1f0bc050993c4969e27a96aa6de8d66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"23d70a59_26ec6181","updated":"2025-04-19 06:00:32.000000000","message":"recheck next attempt","commit_id":"1b240f323d31bb6102264a2cf8cfd78c2a0e2742"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"94b53418f695085f6c35bf33d1796177abd3275f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"92382bec_5deb5ee2","updated":"2025-04-18 17:09:57.000000000","message":"retry hoping for this to be a race","commit_id":"1b240f323d31bb6102264a2cf8cfd78c2a0e2742"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"4b4d4650b578eb7c3a1d688247d4348eec39ad1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ce5d508e_bbb5546d","updated":"2025-04-22 13:28:45.000000000","message":"And also here: https://github.com/openstack/ansible-collections-openstack/blob/master/ci/roles/subnet/tasks/subnet-allocation.yml#L122-L138","commit_id":"0ef86378bc09801d5078a69ecb6773b2102efa87"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"18c096d637268d6c3da454859460b0650c65306a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8df0a55e_af7e4c7b","updated":"2025-04-22 14:09:14.000000000","message":"Looking good on passing the tests - LGTM","commit_id":"08d8cd8c25f6128063ed6500f7d038cabb1b819b"}],"plugins/modules/recordset.py":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"622eb245e8f475954d58f81c12de1044b299398a","unresolved":true,"context_lines":[{"line_number":239,"context_line":"            elif self._needs_update(kwargs, recordset):"},{"line_number":240,"context_line":"                recordset \u003d self.conn.dns.update_recordset(recordset, **kwargs)"},{"line_number":241,"context_line":"                changed \u003d True"},{"line_number":242,"context_line":"            # NOTE(gtema): this is a workaround to temporarily bring the zone_id param back which may not me populated by SDK"},{"line_number":243,"context_line":"            rs \u003d recordset.to_dict(computed\u003dFalse)"},{"line_number":244,"context_line":"            rs[\"zone_id\"] \u003d zone.id"},{"line_number":245,"context_line":"            self.exit_json(changed\u003dchanged, recordset\u003drs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ce0dfc3_c620c484","line":242,"updated":"2025-04-21 14:45:21.000000000","message":"Nit: might be better to split this comment over 2 lines","commit_id":"1b240f323d31bb6102264a2cf8cfd78c2a0e2742"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"18c096d637268d6c3da454859460b0650c65306a","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            elif self._needs_update(kwargs, recordset):"},{"line_number":240,"context_line":"                recordset \u003d self.conn.dns.update_recordset(recordset, **kwargs)"},{"line_number":241,"context_line":"                changed \u003d True"},{"line_number":242,"context_line":"            # NOTE(gtema): this is a workaround to temporarily bring the zone_id param back which may not me populated by SDK"},{"line_number":243,"context_line":"            rs \u003d recordset.to_dict(computed\u003dFalse)"},{"line_number":244,"context_line":"            rs[\"zone_id\"] \u003d zone.id"},{"line_number":245,"context_line":"            self.exit_json(changed\u003dchanged, recordset\u003drs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1e387cba_491bd1b1","line":242,"in_reply_to":"5ce0dfc3_c620c484","updated":"2025-04-22 14:09:14.000000000","message":"Done","commit_id":"1b240f323d31bb6102264a2cf8cfd78c2a0e2742"}]}