)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38575,"name":"Austin Jamias","display_name":"Austin Jamias","email":"ajamias@redhat.com","username":"ajamias"},"change_message_id":"283e2000a8ff7f1800a1fd951b226070b1b42d8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f8cd70d_fee04681","updated":"2025-11-10 22:07:36.000000000","message":"Hello, this change is for a feature in the OSAC project. The original issue for our project can be found here: https://github.com/innabox/issues/issues/286#issuecomment-3504473578","commit_id":"ac02e8dc29dfc6b093da0f2e79ae89e4bfe1c21a"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"23ed65b03d824051f21c647cf4af5ed9dbae81ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d700e30_703a1e31","updated":"2025-11-10 22:05:19.000000000","message":"Looks good to me, the corresponding info modules return tags so if a user want to add a tag they would call the info module and then merge in the new tag to add.","commit_id":"ac02e8dc29dfc6b093da0f2e79ae89e4bfe1c21a"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"20ed36ea3e7da9c454d65113b2d0be92101bb1f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7a362d7_d6872c7a","updated":"2025-11-11 10:01:40.000000000","message":"The CI error does not look related to this specific change.\n\n```\nERROR: Found 1 pylint issue(s) which need to be resolved:\nERROR: plugins/module_utils/openstack.py:35:0: ansible-bad-import-from: Import raise_from from the Python standard library equivalent instead of ansible.module_utils.six\n```\n\nI Austin proposed a separate fix for the linting issue: https://review.opendev.org/c/openstack/ansible-collections-openstack/+/966655","commit_id":"ac02e8dc29dfc6b093da0f2e79ae89e4bfe1c21a"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c46f16a3350d4ba04c206b39394032486e7b1fae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c43e32ba_bb31854b","updated":"2025-11-14 17:05:07.000000000","message":"Is it possible to add some test checking that tags are actually set? As it will also ensure idempotency of the action.\n\nOtherwise lgtm","commit_id":"00a4d10b957d16a50a1fd5a7330516c1e42c7f8d"},{"author":{"_account_id":38575,"name":"Austin Jamias","display_name":"Austin Jamias","email":"ajamias@redhat.com","username":"ajamias"},"change_message_id":"c075925c941d14921aca927f755c69f52c5577c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d845651_eda02e3a","updated":"2025-11-11 15:37:55.000000000","message":"recheck manage_volume test failed and is not related to this change","commit_id":"00a4d10b957d16a50a1fd5a7330516c1e42c7f8d"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ae8c846ef7b940459a1fa5c219f9766c53789b84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"67431cda_18305c9b","updated":"2025-11-26 10:36:17.000000000","message":"LGTM, thanks!","commit_id":"dbc6f7d44aa1c200fa9188ada338d1858735efdc"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"9d7216c1ef5272d8db46080ac076f0a397f23334","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0fff4d74_a52ed9f6","updated":"2025-11-26 13:54:40.000000000","message":"Looks good","commit_id":"dbc6f7d44aa1c200fa9188ada338d1858735efdc"}],"ci/roles/network/tasks/main.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"21f6ba2e55c40bae22dc5f31a9382e20d07cc412","unresolved":true,"context_lines":[{"line_number":69,"context_line":"     external: false"},{"line_number":70,"context_line":"     mtu: \"{{ mtu }}\""},{"line_number":71,"context_line":"     port_security_enabled: \"{{ port_security_enabled }}\""},{"line_number":72,"context_line":"     tags:"},{"line_number":73,"context_line":"       - foo"},{"line_number":74,"context_line":"       - bar"},{"line_number":75,"context_line":"  register: result_create_nw_with_new_params"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"65785596_a1252fbd","line":72,"range":{"start_line":72,"start_character":1,"end_line":72,"end_character":10},"updated":"2026-04-14 21:04:48.000000000","message":"nit: it\u0027s easy to confuse between Ansible tags and module args \"tags\", just matter of indent","commit_id":"dbc6f7d44aa1c200fa9188ada338d1858735efdc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"05e1abd00962c00219d610dc9d6f0dfa6ff83261","unresolved":false,"context_lines":[{"line_number":69,"context_line":"     external: false"},{"line_number":70,"context_line":"     mtu: \"{{ mtu }}\""},{"line_number":71,"context_line":"     port_security_enabled: \"{{ port_security_enabled }}\""},{"line_number":72,"context_line":"     tags:"},{"line_number":73,"context_line":"       - foo"},{"line_number":74,"context_line":"       - bar"},{"line_number":75,"context_line":"  register: result_create_nw_with_new_params"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4f13fb97_fca85671","line":72,"range":{"start_line":72,"start_character":1,"end_line":72,"end_character":10},"in_reply_to":"64021dfc_f912d332","updated":"2026-05-05 18:48:32.000000000","message":"Argh, right - so let’s leave it as is - thanks.","commit_id":"dbc6f7d44aa1c200fa9188ada338d1858735efdc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0d040e22421fb83a9867b24fb884aacf070fbbc8","unresolved":true,"context_lines":[{"line_number":69,"context_line":"     external: false"},{"line_number":70,"context_line":"     mtu: \"{{ mtu }}\""},{"line_number":71,"context_line":"     port_security_enabled: \"{{ port_security_enabled }}\""},{"line_number":72,"context_line":"     tags:"},{"line_number":73,"context_line":"       - foo"},{"line_number":74,"context_line":"       - bar"},{"line_number":75,"context_line":"  register: result_create_nw_with_new_params"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7c618e2d_4aef9555","line":72,"range":{"start_line":72,"start_character":1,"end_line":72,"end_character":10},"in_reply_to":"65785596_a1252fbd","updated":"2026-05-05 17:42:46.000000000","message":"I agree, shouldn\u0027t we rename it to something that doesn\u0027t create a collision? And I don\u0027t think it\u0027s nitpicking","commit_id":"dbc6f7d44aa1c200fa9188ada338d1858735efdc"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2ec66bf9d86d6677e58ef9dc7dc775ea314908b1","unresolved":true,"context_lines":[{"line_number":69,"context_line":"     external: false"},{"line_number":70,"context_line":"     mtu: \"{{ mtu }}\""},{"line_number":71,"context_line":"     port_security_enabled: \"{{ port_security_enabled }}\""},{"line_number":72,"context_line":"     tags:"},{"line_number":73,"context_line":"       - foo"},{"line_number":74,"context_line":"       - bar"},{"line_number":75,"context_line":"  register: result_create_nw_with_new_params"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"64021dfc_f912d332","line":72,"range":{"start_line":72,"start_character":1,"end_line":72,"end_character":10},"in_reply_to":"7c618e2d_4aef9555","updated":"2026-05-05 18:19:51.000000000","message":"tags is also something established accross the board in several Openstack resources, for different projects Nova, Neutron, Glance, Heat. Also modules in ``ansible-collections-openstack`` for ``image``, ``server`` and ``stack`` already implement ``tags`` and uses ``tags`` - I can understand the ansible confusion, but I think this change should not change that pattern. (If we do want to change it, there should be a separate change updating all the modules, and a deprecation period for compatibility).\n\n[1] https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/plugins/modules/image.py#L107\n[2] https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/plugins/modules/server.py#L208\n[3] https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/plugins/modules/stack.py#L49","commit_id":"dbc6f7d44aa1c200fa9188ada338d1858735efdc"}],"plugins/modules/network.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"21f6ba2e55c40bae22dc5f31a9382e20d07cc412","unresolved":true,"context_lines":[{"line_number":269,"context_line":"            if is_vlan_transparent is not None:"},{"line_number":270,"context_line":"                kwargs[\"is_vlan_transparent\"] \u003d is_vlan_transparent"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"            if not net:"},{"line_number":273,"context_line":"                net \u003d self.conn.network.create_network(name\u003dname, **kwargs)"},{"line_number":274,"context_line":"                changed \u003d True"},{"line_number":275,"context_line":"            else:"},{"line_number":276,"context_line":"                changed \u003d False"}],"source_content_type":"text/x-python","patch_set":5,"id":"4b4f2126_677e160d","line":273,"range":{"start_line":272,"start_character":4,"end_line":273,"end_character":75},"updated":"2026-04-14 21:04:48.000000000","message":"When you create network there is no \"tags\" in kwargs, right?\nSame for network and subnet","commit_id":"dbc6f7d44aa1c200fa9188ada338d1858735efdc"},{"author":{"_account_id":38575,"name":"Austin Jamias","display_name":"Austin Jamias","email":"ajamias@redhat.com","username":"ajamias"},"change_message_id":"717f7a6468681c25935b87a2f1e79eb4ac2f68d6","unresolved":true,"context_lines":[{"line_number":269,"context_line":"            if is_vlan_transparent is not None:"},{"line_number":270,"context_line":"                kwargs[\"is_vlan_transparent\"] \u003d is_vlan_transparent"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"            if not net:"},{"line_number":273,"context_line":"                net \u003d self.conn.network.create_network(name\u003dname, **kwargs)"},{"line_number":274,"context_line":"                changed \u003d True"},{"line_number":275,"context_line":"            else:"},{"line_number":276,"context_line":"                changed \u003d False"}],"source_content_type":"text/x-python","patch_set":5,"id":"fb37efa4_f154fd04","line":273,"range":{"start_line":272,"start_character":4,"end_line":273,"end_character":75},"in_reply_to":"4b4f2126_677e160d","updated":"2026-05-05 19:06:29.000000000","message":"Correct, there is no \"tags\" in the params when any of the resources are created. The tags are set only after they are created.","commit_id":"dbc6f7d44aa1c200fa9188ada338d1858735efdc"}]}