)]}'
{"tasks/rhel7stig/sshd.yml":[{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"af84f473e8d243eb4f02744724c866671c45ac69","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    state: absent"},{"line_number":32,"context_line":"    regexp: \u0027^{{ item.name }}\\s+(?!{{ item.value }})\u0027"},{"line_number":33,"context_line":"    validate: \u0027/usr/sbin/sshd -T -f %s\u0027"},{"line_number":34,"context_line":"  with_items: \"{{ sshd_settings_rhel7 | selectattr(\u0027enabled\u0027) }}\""},{"line_number":35,"context_line":"  notify:"},{"line_number":36,"context_line":"    - restart ssh"},{"line_number":37,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6045ba19_29d5053e","line":34,"updated":"2022-05-23 08:49:34.000000000","message":"Should this be selecting where \u0027enabled\u0027 is \u0027False\u0027?","commit_id":"aa1feb45271c8fbe8eba7d555ded9d41a70eff64"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"a4966be29c082420b773cb9d69beb0e0a769921a","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    state: absent"},{"line_number":32,"context_line":"    regexp: \u0027^{{ item.name }}\\s+(?!{{ item.value }})\u0027"},{"line_number":33,"context_line":"    validate: \u0027/usr/sbin/sshd -T -f %s\u0027"},{"line_number":34,"context_line":"  with_items: \"{{ sshd_settings_rhel7 | selectattr(\u0027enabled\u0027) }}\""},{"line_number":35,"context_line":"  notify:"},{"line_number":36,"context_line":"    - restart ssh"},{"line_number":37,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"eb2d7912_979fe67f","line":34,"in_reply_to":"6045ba19_29d5053e","updated":"2022-05-24 16:17:30.000000000","message":"Not sure. As if it\u0027s not enabled, and we drop such option - it can get enabled/disabled by default, and it\u0027s not what we want.\n\nBut the bare minimum, is to drop config lines that we\u0027re adding now inside block. But yeah. we still don\u0027t ensure how true are the ones, that are not enabled (comparing to default).","commit_id":"aa1feb45271c8fbe8eba7d555ded9d41a70eff64"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6c5c0bfa73fec4e152b975026f73f36c9604cb45","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    state: absent"},{"line_number":32,"context_line":"    regexp: \u0027^{{ item.name }}\\s+(?!{{ item.value }})\u0027"},{"line_number":33,"context_line":"    validate: \u0027/usr/sbin/sshd -T -f %s\u0027"},{"line_number":34,"context_line":"  with_items: \"{{ sshd_settings_rhel7 | selectattr(\u0027enabled\u0027) }}\""},{"line_number":35,"context_line":"  notify:"},{"line_number":36,"context_line":"    - restart ssh"},{"line_number":37,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fcceaca0_bb3a354e","line":34,"in_reply_to":"e4ba2626_287a7e36","updated":"2022-06-04 06:41:56.000000000","message":"It\u0027s not?:)\n\nAs if you check regexp, it has negative lookahead. So regexp will match only if key/value do not match. And inside block - they always should?\n\nBut yes, as I wrote in commit msg - it\u0027s not ideal as duplicated records still can be there, if they are identical. At least it won\u0027t be confusing or contraversary.\n\n\nAnd tbh I couldn\u0027t come up with anything better... Ideas are really welcome here.","commit_id":"aa1feb45271c8fbe8eba7d555ded9d41a70eff64"},{"author":{"_account_id":31542,"name":"Andrew Bonney","email":"andrew.bonney@bbc.co.uk","username":"andrewbonney"},"change_message_id":"ed700022c8ae18c9387c2512552f6a62ccf63d59","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    state: absent"},{"line_number":32,"context_line":"    regexp: \u0027^{{ item.name }}\\s+(?!{{ item.value }})\u0027"},{"line_number":33,"context_line":"    validate: \u0027/usr/sbin/sshd -T -f %s\u0027"},{"line_number":34,"context_line":"  with_items: \"{{ sshd_settings_rhel7 | selectattr(\u0027enabled\u0027) }}\""},{"line_number":35,"context_line":"  notify:"},{"line_number":36,"context_line":"    - restart ssh"},{"line_number":37,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e4ba2626_287a7e36","line":34,"in_reply_to":"eb2d7912_979fe67f","updated":"2022-05-30 08:52:11.000000000","message":"Will this not result in changes every time these tasks are run? Once the block is established, next time the lineinfile task runs it will show a change as each of the enabled options is removed from within the block again?","commit_id":"aa1feb45271c8fbe8eba7d555ded9d41a70eff64"}]}