)]}'
{"tasks/collect.yml":[{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"1e2a451f7203cb4cecbbe463673f30a8629e2df8","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                # NOTE(flaper87): This should go away. Services should be"},{"line_number":302,"context_line":"                # using a `logs` volume"},{"line_number":303,"context_line":"                # NOTE(mandre) Do not copy logs if the containers is bind mounting /var/log directory"},{"line_number":304,"context_line":"                if ! ${engine} inspect $cont | jq .[0].Mounts[].$source_mount | grep -x  \u0027\"/var/log[/]*\"\u0027 2\u003e1 \u003e /dev/null; then"},{"line_number":305,"context_line":"                      container_cp $cont /var/log $INFO_DIR/log;"},{"line_number":306,"context_line":"                fi;"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_50e93ee3","line":304,"range":{"start_line":304,"start_character":16,"end_line":304,"end_character":127},"updated":"2019-06-14 09:11:08.000000000","message":"I only test this part of the patch and also that the source_mount\u003dSource for docker.","commit_id":"cc24a877ea48ac7b9d89ffff54ef5cbffacabf54"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c9a0729397f4ae7fac8e2b880ced997f26448f4b","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                # NOTE(flaper87): This should go away. Services should be"},{"line_number":302,"context_line":"                # using a `logs` volume"},{"line_number":303,"context_line":"                # NOTE(mandre) Do not copy logs if the containers is bind mounting /var/log directory"},{"line_number":304,"context_line":"                if ! ${engine} inspect $cont | jq .[0].Mounts[].$source_mount | grep -x  \u0027\"/var/log[/]*\"\u0027 2\u003e1 \u003e /dev/null; then"},{"line_number":305,"context_line":"                      container_cp $cont /var/log $INFO_DIR/log;"},{"line_number":306,"context_line":"                fi;"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_35427cac","line":304,"updated":"2019-06-14 07:03:39.000000000","message":"so v3 makes it work for both docker/podman (source/Source ^)","commit_id":"cc24a877ea48ac7b9d89ffff54ef5cbffacabf54"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b606b5ca21f1184a716f28aef1583c4c27ad7fb5","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                # NOTE(flaper87): This should go away. Services should be"},{"line_number":302,"context_line":"                # using a `logs` volume"},{"line_number":303,"context_line":"                # NOTE(mandre) Do not copy logs if the containers is bind mounting /var/log directory"},{"line_number":304,"context_line":"                if ! ${engine} inspect $cont | jq .[0].Mounts[].$source_mount | grep -x  \u0027\"/var/log[/]*\"\u0027 2\u003e1 \u003e /dev/null; then"},{"line_number":305,"context_line":"                      container_cp $cont /var/log $INFO_DIR/log;"},{"line_number":306,"context_line":"                fi;"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_24e9efe4","line":304,"in_reply_to":"9fb8cfa7_35427cac","updated":"2019-06-14 09:13:01.000000000","message":"yes for both docker and podman logs are collected like before \ndocker:- http://logs.openstack.org/67/662767/3/check/tripleo-ci-centos-7-scenario007-multinode-oooq-container/dab7a19/logs/subnode-2/var/log/extra/docker/containers/nova_compute/log\npodman:- http://logs.openstack.org/67/662767/3/check/tripleo-ci-centos-7-scenario007-multinode-oooq-container/dab7a19/logs/undercloud/var/log/extra/podman/containers/nova_compute/log/\n\n\nRegarding /var/log/ mass log collection which only seen in Pike randomly, i tested couple of times at https://review.rdoproject.org/r/#/c/20171/ and have not seen the issue.","commit_id":"cc24a877ea48ac7b9d89ffff54ef5cbffacabf54"}]}
