)]}'
{"README.rst":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"eca80470b85f0b87075e32483d34946ca4fa4781","unresolved":false,"context_lines":[{"line_number":51,"context_line":"-  ``collect_log_types`` - A list of which type of logs will be collected,"},{"line_number":52,"context_line":"   such as openstack logs, network logs, system logs, etc."},{"line_number":53,"context_line":"   Acceptable values are system, monitoring, network, openstack and container."},{"line_number":54,"context_line":"-  ``artcl_collect_sosreport`` – true/false – If true, create and"},{"line_number":55,"context_line":"   collect a sosreport for each host."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Documentation generation related"},{"line_number":58,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3fa7e38b_4dc33c07","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":37},"updated":"2020-01-22 09:54:40.000000000","message":"It is already added here: https://opendev.org/openstack/ansible-role-collect-logs/src/branch/master/README.rst#enabling-sosreport-collection","commit_id":"547e7f22d655eee2bbbd69b5b621f31f5ced25fb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"697bee82e0b60f8100b60120b3f9da366a5d3524","unresolved":false,"context_lines":[{"line_number":107,"context_line":"   ssh to connect"},{"line_number":108,"context_line":"-  ``artcl_rsync_url`` – rsync target for uploading the logs. The"},{"line_number":109,"context_line":"   localhost needs to have passwordless authentication to the target or"},{"line_number":110,"context_line":"   the ``PROVISIONER_KEY`` var specificed in the environment."},{"line_number":111,"context_line":"-  ``artcl_use_swift``: false/true – use swift object storage to publish"},{"line_number":112,"context_line":"   the logs"},{"line_number":113,"context_line":"-  ``artcl_swift_auth_url`` – the OpenStack auth URL for Swift"}],"source_content_type":"text/x-rst","patch_set":21,"id":"3fa7e38b_f71f1fb5","line":110,"range":{"start_line":110,"start_character":38,"end_line":110,"end_character":39},"updated":"2020-01-27 07:20:25.000000000","message":"remove","commit_id":"dd2a83eea3f5c355f861b917142a701eff49afeb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"697bee82e0b60f8100b60120b3f9da366a5d3524","unresolved":false,"context_lines":[{"line_number":233,"context_line":"Usage with InfraRed"},{"line_number":234,"context_line":"-------------------"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Run the following steps to execute the role by"},{"line_number":237,"context_line":"`infrared \u003chttps://infrared.readthedocs.io/en/latest/\u003e`__."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"1. Install infrared and add ansible-role-collect-logs plugin by providing"}],"source_content_type":"text/x-rst","patch_set":21,"id":"3fa7e38b_97482bb4","line":236,"range":{"start_line":236,"start_character":44,"end_line":236,"end_character":46},"updated":"2020-01-27 07:20:25.000000000","message":"with","commit_id":"dd2a83eea3f5c355f861b917142a701eff49afeb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1090e097ea6aec9ee99b02e5f6a73e2ba3d7b532","unresolved":false,"context_lines":[{"line_number":233,"context_line":"Usage with InfraRed"},{"line_number":234,"context_line":"-------------------"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Run the following steps to execute the role by"},{"line_number":237,"context_line":"`infrared \u003chttps://infrared.readthedocs.io/en/latest/\u003e`__."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"1. Install infrared and add ansible-role-collect-logs plugin by providing"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_042e39aa","line":236,"updated":"2020-01-28 07:20:41.000000000","message":"with https://review.opendev.org/#/c/682042/21..22/README.rst","commit_id":"7ddd07111e98a0ed17fa4751d6d3fdda1421c267"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d7ed634cc23680d6fa9ce3659f8b0f40a15091a8","unresolved":false,"context_lines":[{"line_number":233,"context_line":"Usage with InfraRed"},{"line_number":234,"context_line":"-------------------"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Run the following steps to execute the role by"},{"line_number":237,"context_line":"`infrared \u003chttps://infrared.readthedocs.io/en/latest/\u003e`__."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"1. Install infrared and add ansible-role-collect-logs plugin by providing"}],"source_content_type":"text/x-rst","patch_set":23,"id":"3fa7e38b_151e500c","line":236,"range":{"start_line":236,"start_character":44,"end_line":236,"end_character":46},"updated":"2020-01-29 07:09:45.000000000","message":"with https://review.opendev.org/#/c/682042/22..23/README.rst\n https://review.opendev.org/#/c/682042/21..22/README.rst\n\ndo you disagree? say so. Sure this is a very minor comment and you have addressed others I made. However if you consistently just ignore commnts then you will be less likely to receive reviews from that person in future.","commit_id":"25d62887fe6ca915df59ff5fafb096efb5e5de33"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"48a6e61d5db752bea28be255f7de7d20b088484a","unresolved":false,"context_lines":[{"line_number":233,"context_line":"Usage with InfraRed"},{"line_number":234,"context_line":"-------------------"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Run the following steps to execute the role by"},{"line_number":237,"context_line":"`infrared \u003chttps://infrared.readthedocs.io/en/latest/\u003e`__."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"1. Install infrared and add ansible-role-collect-logs plugin by providing"}],"source_content_type":"text/x-rst","patch_set":23,"id":"3fa7e38b_15697024","line":236,"range":{"start_line":236,"start_character":44,"end_line":236,"end_character":46},"in_reply_to":"3fa7e38b_151e500c","updated":"2020-01-29 07:50:36.000000000","message":"oh, I\u0027m sorry, I overlooked it, I don\u0027t disagree. I overlooked it in 21..22 comment and in 22..23 I made a wrong assumption of the purpose of the comment because no text was highlighted. I don\u0027t know what I was thinking. \n\nI\u0027ll change it in the following patch, so we don\u0027t need to run check jobs for a typo.","commit_id":"25d62887fe6ca915df59ff5fafb096efb5e5de33"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bd1495417dce091c7ecfb83f87c1d68020787538","unresolved":false,"context_lines":[{"line_number":233,"context_line":"Usage with InfraRed"},{"line_number":234,"context_line":"-------------------"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"Run the following steps to execute the role by"},{"line_number":237,"context_line":"`infrared \u003chttps://infrared.readthedocs.io/en/latest/\u003e`__."},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"1. Install infrared and add ansible-role-collect-logs plugin by providing"}],"source_content_type":"text/x-rst","patch_set":23,"id":"3fa7e38b_bbdc0d17","line":236,"range":{"start_line":236,"start_character":44,"end_line":236,"end_character":46},"in_reply_to":"3fa7e38b_15697024","updated":"2020-01-29 10:03:00.000000000","message":"ack np sorry i was grumpy (it was early and the caffeine didn\u0027t kick in yet, is all i can say ) but I +2 as it wasn\u0027t worth blocking or revising just for that unless there were other coments.","commit_id":"25d62887fe6ca915df59ff5fafb096efb5e5de33"}],"infrared_plugin/main.yml":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"ec50af7c8e894c847b31300f6f3d74cfd4af2654","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# This section takes care of preparing the collected data for publishing"},{"line_number":17,"context_line":"# and for publishing itself"},{"line_number":18,"context_line":"- hosts: localhost"},{"line_number":19,"context_line":"  roles:"},{"line_number":20,"context_line":"    - ansible-role-collect-logs"},{"line_number":21,"context_line":"  pre_tasks:"},{"line_number":22,"context_line":"    - name: Remap infrared parameters to role variables"},{"line_number":23,"context_line":"      set_fact:"},{"line_number":24,"context_line":"        \"{{ item.key }}\": \"{{ item.value }}\""},{"line_number":25,"context_line":"      with_dict: \"{{ other }}\""},{"line_number":26,"context_line":"    - name: Disable artcl_collect to prepare for publishing"},{"line_number":27,"context_line":"      set_fact:"},{"line_number":28,"context_line":"        # override artcl_collect to false because in ansible-role-collect-logs"},{"line_number":29,"context_line":"        # role collect and publish tasks are complementary"},{"line_number":30,"context_line":"        artcl_collect: false"},{"line_number":31,"context_line":"      when: artcl_publish|bool"},{"line_number":32,"context_line":"    - name: Set path to a report server key"},{"line_number":33,"context_line":"      set_fact:"},{"line_number":34,"context_line":"        artcl_report_server_key: \"-i {{ artcl_report_server_key }}\""},{"line_number":35,"context_line":"      when: artcl_report_server_key is defined"},{"line_number":36,"context_line":"    - name: Extract the logs"},{"line_number":37,"context_line":"      shell: |"},{"line_number":38,"context_line":"        cat *.tar | tar xf - -i"},{"line_number":39,"context_line":"      args:"},{"line_number":40,"context_line":"        chdir: \"{{ artcl_collect_dir }}\""},{"line_number":41,"context_line":"        executable: /bin/bash"},{"line_number":42,"context_line":"      ignore_errors: true"},{"line_number":43,"context_line":"    - name: delete the tar file after extraction"},{"line_number":44,"context_line":"      shell: |"},{"line_number":45,"context_line":"        rm -r *.tar"},{"line_number":46,"context_line":"      args:"},{"line_number":47,"context_line":"        chdir: \"{{ artcl_collect_dir }}\""},{"line_number":48,"context_line":"        executable: /bin/bash"},{"line_number":49,"context_line":"      ignore_errors: true"},{"line_number":50,"context_line":"  post_tasks:"},{"line_number":51,"context_line":"    # TODO: local_working_dir should be uniqe per each run - a job should never"},{"line_number":52,"context_line":"    # fail due to a reson that f.e. the artifacts weren\u0027t removed properly in"},{"line_number":53,"context_line":"    # a previous run"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_962efba8","line":50,"range":{"start_line":19,"start_character":2,"end_line":50,"end_character":13},"updated":"2019-12-10 12:57:39.000000000","message":"That is old ansible syntax, use just tasks with include role, so they order of actions is also visible.\n\npre_tasks and post_tasks are no longer needed since we have include_role.","commit_id":"3824eca67be82297c7bea4133af187971e614d0c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"41bf5c12048448b3518339b78da6ffef6cf5bd24","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - name: Remap infrared parameters to role variables"},{"line_number":22,"context_line":"      set_fact:"},{"line_number":23,"context_line":"        \"{{ item.key }}\": \"{{ item.value }}\""},{"line_number":24,"context_line":"      with_dict: \"{{ other }}\""},{"line_number":25,"context_line":"    - name: Disable artcl_collect to prepare for publishing"},{"line_number":26,"context_line":"      set_fact:"},{"line_number":27,"context_line":"        # override artcl_collect to false because in ansible-role-collect-logs"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa7e38b_1ddbb2ea","line":24,"updated":"2020-01-14 08:55:25.000000000","message":"Please add line between tasks to be consistent with the other files","commit_id":"9b4da8bc999685058c755b53a70bb2cc6948e27e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"eca80470b85f0b87075e32483d34946ca4fa4781","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# This section collects data from the nodes"},{"line_number":5,"context_line":"- hosts: \"{{ other.openstack_nodes }}\""},{"line_number":6,"context_line":"  remote_user: stack"},{"line_number":7,"context_line":"  become: true"},{"line_number":8,"context_line":"  tasks:"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_cdd64cc5","line":6,"range":{"start_line":6,"start_character":15,"end_line":6,"end_character":20},"updated":"2020-01-22 09:54:40.000000000","message":"Can we move it under a var, it might varies if in future infrared used in upstream, here `zuul` user is used?","commit_id":"547e7f22d655eee2bbbd69b5b621f31f5ced25fb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"697bee82e0b60f8100b60120b3f9da366a5d3524","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    - name: Remap infrared parameters to role variables"},{"line_number":10,"context_line":"      set_fact:"},{"line_number":11,"context_line":"        \"{{ item.key }}\": \"{{ item.value }}\""},{"line_number":12,"context_line":"      with_dict: \"{{ other }}\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    - name: Ansible role collect logs"},{"line_number":15,"context_line":"      include_role:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_971a6bc4","line":12,"range":{"start_line":12,"start_character":21,"end_line":12,"end_character":26},"updated":"2020-01-27 07:20:25.000000000","message":"can\u0027t find that here and grep didn\u0027t help against the repo where is it defined?\n\n[EDIT]: likely it is expected by infrared/set there as a default?","commit_id":"dd2a83eea3f5c355f861b917142a701eff49afeb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1090e097ea6aec9ee99b02e5f6a73e2ba3d7b532","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    - name: Remap infrared parameters to role variables"},{"line_number":10,"context_line":"      set_fact:"},{"line_number":11,"context_line":"        \"{{ item.key }}\": \"{{ item.value }}\""},{"line_number":12,"context_line":"      with_dict: \"{{ other }}\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    - name: Ansible role collect logs"},{"line_number":15,"context_line":"      include_role:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_e4367d01","line":12,"range":{"start_line":12,"start_character":21,"end_line":12,"end_character":26},"in_reply_to":"3fa7e38b_2810f857","updated":"2020-01-28 07:20:41.000000000","message":"k thanks","commit_id":"dd2a83eea3f5c355f861b917142a701eff49afeb"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"926d66beb05f85868eac163dcf18edd165a61064","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    - name: Remap infrared parameters to role variables"},{"line_number":10,"context_line":"      set_fact:"},{"line_number":11,"context_line":"        \"{{ item.key }}\": \"{{ item.value }}\""},{"line_number":12,"context_line":"      with_dict: \"{{ other }}\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    - name: Ansible role collect logs"},{"line_number":15,"context_line":"      include_role:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_2810f857","line":12,"range":{"start_line":12,"start_character":21,"end_line":12,"end_character":26},"in_reply_to":"3fa7e38b_971a6bc4","updated":"2020-01-27 12:31:21.000000000","message":"this is related to infrared plugin structure: https://infrared.readthedocs.io/en/stable/plugins.html#plugin-structure\n\ninfrared prefixes plugin argument values by a group the plugin belongs to.","commit_id":"dd2a83eea3f5c355f861b917142a701eff49afeb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"697bee82e0b60f8100b60120b3f9da366a5d3524","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - name: Extract the logs"},{"line_number":41,"context_line":"      shell: |"},{"line_number":42,"context_line":"        cat *.tar | tar xf - -i"},{"line_number":43,"context_line":"      args:"},{"line_number":44,"context_line":"        chdir: \"{{ artcl_collect_dir }}\""},{"line_number":45,"context_line":"        executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_d769c325","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":27},"updated":"2020-01-27 07:20:25.000000000","message":"does it need the set -euxo pipefail (hmmm tox-linters is green here so looks like no... i recall a change from sorin recently that added this to all shell: tasks ).\n\nMainly though why are you using cat and pipe into tar here vs tar ... args *.tar or somesuch?","commit_id":"dd2a83eea3f5c355f861b917142a701eff49afeb"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"926d66beb05f85868eac163dcf18edd165a61064","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - name: Extract the logs"},{"line_number":41,"context_line":"      shell: |"},{"line_number":42,"context_line":"        cat *.tar | tar xf - -i"},{"line_number":43,"context_line":"      args:"},{"line_number":44,"context_line":"        chdir: \"{{ artcl_collect_dir }}\""},{"line_number":45,"context_line":"        executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_a8fb8813","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":27},"in_reply_to":"3fa7e38b_d769c325","updated":"2020-01-27 12:31:21.000000000","message":"I don\u0027t remember why I\u0027ve done it this way, it\u0027s a copy-paste from somewhere .. it works for now, we can change it anytime then","commit_id":"dd2a83eea3f5c355f861b917142a701eff49afeb"}],"molecule/infrared/playbook.yml":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"0501a69cf1dd9efffb137e6f5d51c6d158b60135","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Converge"},{"line_number":3,"context_line":"  hosts: all"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    infrared_venv: \"~/.virtualenvs/.infrared\""},{"line_number":6,"context_line":"    infrared_location: \"/tmp/infrared\""},{"line_number":7,"context_line":"  tasks:"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_4c001300","line":5,"range":{"start_line":5,"start_character":19,"end_line":5,"end_character":34},"updated":"2020-01-22 20:58:52.000000000","message":"I don\u0027t like this either but for historical reasons related that more or less popular wrapper, ok.","commit_id":"547e7f22d655eee2bbbd69b5b621f31f5ced25fb"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"01eabe25dd1d0984a1e2476644f5646456e3487f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Converge"},{"line_number":3,"context_line":"  hosts: all"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    infrared_venv: \"~/.virtualenvs/.infrared\""},{"line_number":6,"context_line":"    infrared_location: \"/tmp/infrared\""},{"line_number":7,"context_line":"  tasks:"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_9f660fee","line":5,"range":{"start_line":5,"start_character":19,"end_line":5,"end_character":34},"in_reply_to":"3fa7e38b_4c001300","updated":"2020-01-24 16:50:01.000000000","message":"can we use mktemp and registry the dir?","commit_id":"547e7f22d655eee2bbbd69b5b621f31f5ced25fb"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c0f5f4e195d570fa1851582833a7cd1825627daf","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Converge"},{"line_number":3,"context_line":"  hosts: all"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    infrared_venv: \"~/.virtualenvs/.infrared\""},{"line_number":6,"context_line":"    infrared_location: \"/tmp/infrared\""},{"line_number":7,"context_line":"  tasks:"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_7cf6b660","line":5,"range":{"start_line":5,"start_character":19,"end_line":5,"end_character":34},"in_reply_to":"3fa7e38b_9f660fee","updated":"2020-01-26 23:33:56.000000000","message":"I\u0027m afraid that we can have either a global variable defined in molecule.yml for all playbooks or a tempfile task in every playbook","commit_id":"547e7f22d655eee2bbbd69b5b621f31f5ced25fb"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"0501a69cf1dd9efffb137e6f5d51c6d158b60135","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  hosts: all"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    infrared_venv: \"~/.virtualenvs/.infrared\""},{"line_number":6,"context_line":"    infrared_location: \"/tmp/infrared\""},{"line_number":7,"context_line":"  tasks:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    - name: \"Create Infrared venv\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_61107859","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":38},"updated":"2020-01-22 20:58:52.000000000","message":"this is not a safe or portable temporary directory to use. use lookup(\u0027env\u0027, \u0027TMP\u0027) or tempfile module to get a real tmp dirl","commit_id":"547e7f22d655eee2bbbd69b5b621f31f5ced25fb"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"01eabe25dd1d0984a1e2476644f5646456e3487f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  hosts: all"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    infrared_venv: \"~/.virtualenvs/.infrared\""},{"line_number":6,"context_line":"    infrared_location: \"/tmp/infrared\""},{"line_number":7,"context_line":"  tasks:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    - name: \"Create Infrared venv\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_1f98dfc9","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":38},"in_reply_to":"3fa7e38b_61107859","updated":"2020-01-24 16:50:01.000000000","message":"same.. define a top level mktemp dir.. and use that.. \n\nhttps://docs.ansible.com/ansible/2.3/tempfile_module.html\nstate: directory","commit_id":"547e7f22d655eee2bbbd69b5b621f31f5ced25fb"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"70cb2ac48987ece7084dbe308024efd9e7c6aa8e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        chdir: \"{{ infrared_location }}\""},{"line_number":47,"context_line":"        executable: /bin/bash"},{"line_number":48,"context_line":"      register: plugin_install_output"},{"line_number":49,"context_line":"      ignore_errors: true"},{"line_number":50,"context_line":"      changed_when: true"},{"line_number":51,"context_line":"      tags:"},{"line_number":52,"context_line":"        # the task is always changed, skip idempotence"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_e14d4893","line":49,"range":{"start_line":49,"start_character":6,"end_line":49,"end_character":25},"updated":"2020-01-22 20:51:23.000000000","message":"Avoid doing that, write the code in such way that you do not have to use ignore_errors. Bad things can happen, and we need to catch them, not to pretend they never happened.","commit_id":"547e7f22d655eee2bbbd69b5b621f31f5ced25fb"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"3fa365c820f637a51a8f3d532fe25f4dae6c6b0c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        chdir: \"{{ infrared_location }}\""},{"line_number":47,"context_line":"        executable: /bin/bash"},{"line_number":48,"context_line":"      register: plugin_install_output"},{"line_number":49,"context_line":"      ignore_errors: true"},{"line_number":50,"context_line":"      changed_when: true"},{"line_number":51,"context_line":"      tags:"},{"line_number":52,"context_line":"        # the task is always changed, skip idempotence"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_bf38abca","line":49,"range":{"start_line":49,"start_character":6,"end_line":49,"end_character":25},"in_reply_to":"3fa7e38b_e14d4893","updated":"2020-01-24 16:45:29.000000000","message":"agree.. let\u0027s remove ignore_errors on the test. ;)","commit_id":"547e7f22d655eee2bbbd69b5b621f31f5ced25fb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"697bee82e0b60f8100b60120b3f9da366a5d3524","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # the task is always changed, skip idempotence"},{"line_number":49,"context_line":"        - molecule-idempotence-notest"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    - name: \"Debug, plugin installation\""},{"line_number":52,"context_line":"      debug:"},{"line_number":53,"context_line":"        msg: \"{{ plugin_install_output }}\""},{"line_number":54,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_d7522368","line":51,"range":{"start_line":51,"start_character":13,"end_line":51,"end_character":39},"updated":"2020-01-27 07:20:25.000000000","message":"just suggestion for logs \"Debug: output from plugin installation task main playbook\"","commit_id":"dd2a83eea3f5c355f861b917142a701eff49afeb"}],"molecule/infrared/verify.yml":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"0501a69cf1dd9efffb137e6f5d51c6d158b60135","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Converge"},{"line_number":3,"context_line":"  hosts: all"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    infrared_venv: \"~/.virtualenvs/.infrared\""},{"line_number":6,"context_line":"    infrared_location: \"/tmp/infrared\""},{"line_number":7,"context_line":"  tasks:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    - name: \"List available plugins\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_0c0e9b32","line":6,"range":{"start_line":5,"start_character":4,"end_line":6,"end_character":38},"updated":"2020-01-22 20:58:52.000000000","message":"You can define vars in molecule file to avoid repeating on each playbook.","commit_id":"547e7f22d655eee2bbbd69b5b621f31f5ced25fb"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"697bee82e0b60f8100b60120b3f9da366a5d3524","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      register: plugin_output"},{"line_number":14,"context_line":"      changed_when: false"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    - name: \"Debug, plugin output\""},{"line_number":17,"context_line":"      debug:"},{"line_number":18,"context_line":"        msg: \"{{ plugin_output }}\""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_37585787","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":33},"updated":"2020-01-27 07:20:25.000000000","message":"can you include \u0027verify\u0027 in there somewhere please its hard to follow in the logs \n\ne.g. \"Debug: verify playbook list plugins output\"","commit_id":"dd2a83eea3f5c355f861b917142a701eff49afeb"}],"molecule/sova/molecule.yml":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"976144e9287399455d17a1705fba897d1347b53a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  inventory:"},{"line_number":17,"context_line":"    group_vars:"},{"line_number":18,"context_line":"      all:"},{"line_number":19,"context_line":"        infrared_location: \"{{ lookup(\u0027env\u0027, \u0027HOME\u0027) }}/.infrared\""},{"line_number":20,"context_line":"        infrared_venv: \"{{ infrared_location }}/.infrared\""},{"line_number":21,"context_line":"verifier:"},{"line_number":22,"context_line":"  name: ansible"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_f21f2db5","line":19,"range":{"start_line":19,"start_character":31,"end_line":19,"end_character":53},"updated":"2020-01-27 09:16:39.000000000","message":"Put a safety net here to fallaback to \u0027~\u0027 if HOME is not defined:\n\n{{ lookup(\u0027env\u0027, \u0027HOME\u0027) or \u0027~\u0027 }}\n\nUse the same pattern anywhere you use lookup because the default behavior is to expand to empty string when not defined. So it will try to use system root folder :p","commit_id":"dd2a83eea3f5c355f861b917142a701eff49afeb"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7b973b7a63e6615c92528f66a60997d6941053fb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  inventory:"},{"line_number":21,"context_line":"    group_vars:"},{"line_number":22,"context_line":"      all:"},{"line_number":23,"context_line":"        infrared_location: \"{{ lookup(\u0027env\u0027, \u0027HOME\u0027) or \u0027~\u0027 }}/.infrared\""},{"line_number":24,"context_line":"        infrared_venv: \"{{ infrared_location }}/.infrared\""},{"line_number":25,"context_line":"verifier:"},{"line_number":26,"context_line":"  name: ansible"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"3fa7e38b_7fd9b681","line":23,"range":{"start_line":23,"start_character":30,"end_line":23,"end_character":60},"updated":"2020-01-28 07:52:38.000000000","message":"and what is it this for?","commit_id":"7ddd07111e98a0ed17fa4751d6d3fdda1421c267"}],"molecule/sova/playbook.yml":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"3e5ce561279f0c00a0c0e99e0b73faaca718cd5e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        tasks_from: sova.yml"},{"line_number":12,"context_line":"      tags:"},{"line_number":13,"context_line":"        - molecule-idempotence-notest"},{"line_number":14,"context_line":"    - block:"},{"line_number":15,"context_line":"        - name: \"Create Infrared venv\""},{"line_number":16,"context_line":"          pip:"},{"line_number":17,"context_line":"            name: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_db8b09be","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":12},"updated":"2020-01-10 10:28:04.000000000","message":"my impression is that you want to create a new scenario called \"infrared\" that does this and avoid touching the existing sova one, especially as i doubt you need the execution of include_role to do your test.","commit_id":"3c161cd8a04c8e65a2a0084c18d68184cc76508d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"88b2c63568ddd777ee723f01a8c867b2a58ccb3a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            executable: /bin/bash"},{"line_number":49,"context_line":"          register: output"},{"line_number":50,"context_line":"          ignore_errors: true"},{"line_number":51,"context_line":"        - debug:"},{"line_number":52,"context_line":"            msg: \"{{ output }}\""},{"line_number":53,"context_line":"        - name: \"List available plugins\""},{"line_number":54,"context_line":"          shell: |"},{"line_number":55,"context_line":"            export PATH\u003d$PATH:/usr/local/sbin:/usr/sbin"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_b84c139d","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":31},"updated":"2020-01-10 09:26:32.000000000","message":"will be removed in the next patchset","commit_id":"3c161cd8a04c8e65a2a0084c18d68184cc76508d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"88b2c63568ddd777ee723f01a8c867b2a58ccb3a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"          args:"},{"line_number":59,"context_line":"            executable: /bin/bash"},{"line_number":60,"context_line":"          register: plugin_output"},{"line_number":61,"context_line":"        - name: \"Debug\""},{"line_number":62,"context_line":"          debug:"},{"line_number":63,"context_line":"            msg: \"{{ plugin_output }}\""},{"line_number":64,"context_line":"        - name: \"Check if ansible-role-collect-logs is present\""},{"line_number":65,"context_line":"          fail:"},{"line_number":66,"context_line":"            msg: \"ansible-role-collect-logs not installed\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_9849178f","line":63,"range":{"start_line":61,"start_character":0,"end_line":63,"end_character":38},"updated":"2020-01-10 09:26:32.000000000","message":"will be removed in the next patchset","commit_id":"3c161cd8a04c8e65a2a0084c18d68184cc76508d"}],"tasks/collect.yml":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"051731b0df9f6f94836aea4df34c49f7dc5c949c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        path: \"{{ artcl_collect_dir }}/{{ inventory_hostname }}.tar\""},{"line_number":117,"context_line":"        state: absent"},{"line_number":118,"context_line":"  # do not execute when running as infrared plugin"},{"line_number":119,"context_line":"  when: other is not defined and other.openstack_nodes is not defined"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_f3e008fb","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":69},"updated":"2019-10-07 14:11:42.000000000","message":"oh, this should be:\n\nother is not defined or (other is defined and other.openstack_nodes is not defined)","commit_id":"e93d4918f0c366eed4ead585255d1b69d1619a02"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"1c6cdf3fb035c65e47775c59f5cfa0bd4a840422","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"- delegate_to: localhost"},{"line_number":108,"context_line":"  # do not execute when running as infrared plugin"},{"line_number":109,"context_line":"  when: artcl_gzip_only|bool and (other is not defined or (other is defined and other.openstack_nodes is not defined))"},{"line_number":110,"context_line":"  block:"},{"line_number":111,"context_line":"    - name: Extract the logs"},{"line_number":112,"context_line":"      shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_766b3fef","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":118},"updated":"2019-12-10 12:50:51.000000000","message":"line too long / hard to read\nconsidering that you already have an AND on it you\ncan split it into a when list.","commit_id":"3824eca67be82297c7bea4133af187971e614d0c"}],"tox.ini":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"12c0546ad1ce0eb787a63812c991b9a456defeea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"# for tty option"},{"line_number":3,"context_line":"minversion \u003d 3.4.0"},{"line_number":4,"context_line":"envlist \u003d docs, linters, molecule"},{"line_number":5,"context_line":"skipdist \u003d True"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-properties","patch_set":21,"id":"3fa7e38b_d294718e","line":3,"updated":"2020-01-27 08:27:52.000000000","message":"Is it fine to bump the tox version so high? Or are we using a so old version?","commit_id":"dd2a83eea3f5c355f861b917142a701eff49afeb"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"f7765f75033fd07ebeec34deb115bbcb1f28e895","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"# for tty option"},{"line_number":3,"context_line":"minversion \u003d 3.4.0"},{"line_number":4,"context_line":"envlist \u003d docs, linters, molecule"},{"line_number":5,"context_line":"skipdist \u003d True"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-properties","patch_set":21,"id":"3fa7e38b_327f05df","line":3,"in_reply_to":"3fa7e38b_d294718e","updated":"2020-01-27 09:18:54.000000000","message":"Yes is fine. We use latest tox everywhere from pip. Redhat does no longer build rpm either.\n\nThat is not a call to randomlu put latest version there, but is safe to put whatever min version we need.\n\nAlso versions starts with 3.4 are able to bootstrap itselft, meaning that that tox will install an newer version of tox when it needs it. Super cool feature!","commit_id":"dd2a83eea3f5c355f861b917142a701eff49afeb"}]}