)]}'
{"defaults/main.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"fbb0e7f89d1c84f4657cd2503d1ed092e0303762","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# formally in tq common and tqe extras-common"},{"line_number":3,"context_line":"# do not use lookup(\u0027HOME\u0027) as HOME may no be defined on all platforms"},{"line_number":4,"context_line":"local_working_dir: \"~/.quickstart\""},{"line_number":5,"context_line":"artcl_collect_dir: \"{{ local_working_dir }}/collected_files\""},{"line_number":6,"context_line":"working_dir: \"/home/{{ undercloud_user }}\""},{"line_number":7,"context_line":"undercloud_user: stack"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_e82c6bb3","line":4,"range":{"start_line":4,"start_character":20,"end_line":4,"end_character":21},"updated":"2020-01-21 11:47:12.000000000","message":"in which platforms HOME is not defined?","commit_id":"944b4e65fd3720360c633b411df1af88e2a7ef19"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"ebe1cf77eeb2ef0922d063e1c85223096c0c86ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# formally in tq common and tqe extras-common"},{"line_number":3,"context_line":"# do not use lookup(\u0027HOME\u0027) as HOME may no be defined on all platforms"},{"line_number":4,"context_line":"local_working_dir: \"~/.quickstart\""},{"line_number":5,"context_line":"artcl_collect_dir: \"{{ local_working_dir }}/collected_files\""},{"line_number":6,"context_line":"working_dir: \"/home/{{ undercloud_user }}\""},{"line_number":7,"context_line":"undercloud_user: stack"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_e329ec39","line":4,"range":{"start_line":4,"start_character":20,"end_line":4,"end_character":21},"in_reply_to":"3fa7e38b_e82c6bb3","updated":"2020-01-21 12:15:22.000000000","message":"- running from tox default\n- often hidden when program called\n- Windows (not me) but true\n\n\nAlso the worst part about it is that when not defined it will result in empty string, so .quickstart will try to writ to root. I bet some of you encountered a curious `/.quickstart`  \n\nAnyway, I got a better idea, more backwards compatible:\n\n{{ lookup(\u0027env\u0027,\u0027HOMCSSSE\u0027) or ~ }}","commit_id":"944b4e65fd3720360c633b411df1af88e2a7ef19"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"f427066071cd6bd0715e5ab4cefdbd299c9d3e97","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  - name: package-list"},{"line_number":156,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} list installed\""},{"line_number":157,"context_line":"  - name: repolist"},{"line_number":158,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} repolist -v\""},{"line_number":159,"context_line":"  - name: selinux"},{"line_number":160,"context_line":"    cmd: \u003e"},{"line_number":161,"context_line":"      test -f /usr/sbin/getenforce \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_03c43393","line":158,"range":{"start_line":158,"start_character":10,"end_line":158,"end_character":31},"updated":"2020-01-22 11:23:30.000000000","message":"you can\u0027t run 2 parallel processes of dnf/yum, if there is your intention","commit_id":"14fe3ea71770575a4cb3ae97d85a110c348ffd5e"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"5ac8e8923a07c2be7b566adcef5f5115dc105738","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  - name: package-list"},{"line_number":156,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} list installed\""},{"line_number":157,"context_line":"  - name: repolist"},{"line_number":158,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} repolist -v\""},{"line_number":159,"context_line":"  - name: selinux"},{"line_number":160,"context_line":"    cmd: \u003e"},{"line_number":161,"context_line":"      test -f /usr/sbin/getenforce \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_03d5131a","line":158,"range":{"start_line":158,"start_character":10,"end_line":158,"end_character":31},"in_reply_to":"3fa7e38b_03c43393","updated":"2020-01-22 11:30:18.000000000","message":"AFAIK that limit affects only operations that update data like installing, removing or updating. neither list or repolist do this.\n\nIf what you say is true, we should clearly see an error.\n\nPS. There are workarounds, but first lets see if they are really needed.","commit_id":"14fe3ea71770575a4cb3ae97d85a110c348ffd5e"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"f86faa32c96eacbf31a7d06ba56620b8d5755315","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  - name: package-list"},{"line_number":156,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} list installed\""},{"line_number":157,"context_line":"  - name: repolist"},{"line_number":158,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} repolist -v\""},{"line_number":159,"context_line":"  - name: selinux"},{"line_number":160,"context_line":"    cmd: \u003e"},{"line_number":161,"context_line":"      test -f /usr/sbin/getenforce \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_b0fc6a71","line":158,"range":{"start_line":158,"start_character":10,"end_line":158,"end_character":31},"in_reply_to":"3fa7e38b_03d5131a","updated":"2020-01-23 17:15:32.000000000","message":"Even then it locks rpm DB. But I think it just waits until other process finishes and starts. Should be checked and tested, though","commit_id":"14fe3ea71770575a4cb3ae97d85a110c348ffd5e"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"a0b585158c6b49a2f218f69092ffbd7fd92cf38f","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  - name: package-list"},{"line_number":156,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} list installed\""},{"line_number":157,"context_line":"  - name: repolist"},{"line_number":158,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} repolist -v\""},{"line_number":159,"context_line":"  - name: selinux"},{"line_number":160,"context_line":"    cmd: \u003e"},{"line_number":161,"context_line":"      test -f /usr/sbin/getenforce \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_82f172e2","line":158,"range":{"start_line":158,"start_character":10,"end_line":158,"end_character":31},"in_reply_to":"3fa7e38b_2e68c8ba","updated":"2020-02-01 19:33:27.000000000","message":"It\u0027s race condition, we shouldn\u0027t wait till it happens.","commit_id":"14fe3ea71770575a4cb3ae97d85a110c348ffd5e"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"8ea6ebb7917e4e0ebc93ee7051c2f2dbd842d595","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  - name: package-list"},{"line_number":156,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} list installed\""},{"line_number":157,"context_line":"  - name: repolist"},{"line_number":158,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} repolist -v\""},{"line_number":159,"context_line":"  - name: selinux"},{"line_number":160,"context_line":"    cmd: \u003e"},{"line_number":161,"context_line":"      test -f /usr/sbin/getenforce \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_2e68c8ba","line":158,"range":{"start_line":158,"start_character":10,"end_line":158,"end_character":31},"in_reply_to":"3fa7e38b_b0fc6a71","updated":"2020-01-30 13:09:04.000000000","message":"If you can show me one case where this failed I will alter the code.","commit_id":"14fe3ea71770575a4cb3ae97d85a110c348ffd5e"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e5ab9064820975d2209c4a6818892b25d0d43747","unresolved":false,"context_lines":[{"line_number":153,"context_line":"  - name: rpms"},{"line_number":154,"context_line":"    cmd: rpm -qa | sort"},{"line_number":155,"context_line":"  - name: package-list"},{"line_number":156,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} list installed\""},{"line_number":157,"context_line":"  - name: repolist"},{"line_number":158,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} repolist -v\""},{"line_number":159,"context_line":"  - name: selinux"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_30163aa3","line":156,"range":{"start_line":156,"start_character":32,"end_line":156,"end_character":47},"updated":"2020-01-23 17:18:18.000000000","message":"you need to write it to some file in /var/log/extra","commit_id":"db4cf2ab671e815d24f6461e7862263e4ab8ba3a"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"8ea6ebb7917e4e0ebc93ee7051c2f2dbd842d595","unresolved":false,"context_lines":[{"line_number":153,"context_line":"  - name: rpms"},{"line_number":154,"context_line":"    cmd: rpm -qa | sort"},{"line_number":155,"context_line":"  - name: package-list"},{"line_number":156,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} list installed\""},{"line_number":157,"context_line":"  - name: repolist"},{"line_number":158,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} repolist -v\""},{"line_number":159,"context_line":"  - name: selinux"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_0e086c23","line":156,"range":{"start_line":156,"start_character":32,"end_line":156,"end_character":47},"in_reply_to":"3fa7e38b_30163aa3","updated":"2020-01-30 13:09:04.000000000","message":"That is done by the implementation, read the README file.","commit_id":"db4cf2ab671e815d24f6461e7862263e4ab8ba3a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e5ab9064820975d2209c4a6818892b25d0d43747","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  - name: package-list"},{"line_number":156,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} list installed\""},{"line_number":157,"context_line":"  - name: repolist"},{"line_number":158,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} repolist -v\""},{"line_number":159,"context_line":"  - name: selinux"},{"line_number":160,"context_line":"    cmd: \u003e"},{"line_number":161,"context_line":"      test -f /usr/sbin/getenforce \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_d0748606","line":158,"range":{"start_line":158,"start_character":10,"end_line":158,"end_character":44},"updated":"2020-01-23 17:18:18.000000000","message":"ditto","commit_id":"db4cf2ab671e815d24f6461e7862263e4ab8ba3a"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"8ea6ebb7917e4e0ebc93ee7051c2f2dbd842d595","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  - name: package-list"},{"line_number":156,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} list installed\""},{"line_number":157,"context_line":"  - name: repolist"},{"line_number":158,"context_line":"    cmd: \"{{ ansible_pkg_mgr }} repolist -v\""},{"line_number":159,"context_line":"  - name: selinux"},{"line_number":160,"context_line":"    cmd: \u003e"},{"line_number":161,"context_line":"      test -f /usr/sbin/getenforce \u0026\u0026"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_6e20009f","line":158,"range":{"start_line":158,"start_character":10,"end_line":158,"end_character":44},"in_reply_to":"3fa7e38b_d0748606","updated":"2020-01-30 13:09:04.000000000","message":"That is done by the implementation, read the README file.","commit_id":"db4cf2ab671e815d24f6461e7862263e4ab8ba3a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"1c8631686239c34dc7392405bb2ccda86394cbde","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    - name: rpms"},{"line_number":157,"context_line":"      cmd: rpm -qa | sort"},{"line_number":158,"context_line":"    - name: package-list"},{"line_number":159,"context_line":"      cmd: \"{{ ansible_pkg_mgr }} list installed\""},{"line_number":160,"context_line":"    - name: repolist"},{"line_number":161,"context_line":"      cmd: \"{{ ansible_pkg_mgr }} repolist -v\""},{"line_number":162,"context_line":"    - name: selinux"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_1c80b49b","line":159,"range":{"start_line":159,"start_character":6,"end_line":159,"end_character":49},"updated":"2020-01-29 15:54:08.000000000","message":"please address my comments from previous patches","commit_id":"79b7c1571f1b629765a5285a401ac305c5b445ed"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"8e154e35f3bdc79f15d76636d9941a664f5bb47f","unresolved":false,"context_lines":[{"line_number":152,"context_line":"# Behavior fully documented in readme."},{"line_number":153,"context_line":"# Keep the dictionary sorted when adding new values."},{"line_number":154,"context_line":"artcl_commands:"},{"line_number":155,"context_line":"  system:"},{"line_number":156,"context_line":"    cpuinfo:"},{"line_number":157,"context_line":"      cmd: cat /proc/cpuinfo"},{"line_number":158,"context_line":"    delorean-logs:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_ce622942","line":155,"updated":"2020-02-03 17:05:56.000000000","message":"let\u0027s move this out of defaults and into vars so we can break this up as needed.","commit_id":"22b322e2596e6811d690303c8cbb12cf0b8a339c"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"ed97755d6c1e41233bbcb68c76cc8a4bcc819938","unresolved":false,"context_lines":[{"line_number":152,"context_line":"# Behavior fully documented in readme."},{"line_number":153,"context_line":"# Keep the dictionary sorted when adding new values."},{"line_number":154,"context_line":"artcl_commands:"},{"line_number":155,"context_line":"  system:"},{"line_number":156,"context_line":"    cpuinfo:"},{"line_number":157,"context_line":"      cmd: cat /proc/cpuinfo"},{"line_number":158,"context_line":"    delorean-logs:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_4c7dd71c","line":155,"in_reply_to":"3fa7e38b_ce622942","updated":"2020-02-04 09:58:33.000000000","message":"I doubled checked and this would be a big mistake, it would move them from #2 to #18 making very hard to override, read https://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#variable-precedence-where-should-i-put-a-variable -- I printed a copy and taped it on my wall.","commit_id":"22b322e2596e6811d690303c8cbb12cf0b8a339c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0690ef1d20365813635dbb2835234dd4bea60f11","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  system:"},{"line_number":156,"context_line":"    cpuinfo:"},{"line_number":157,"context_line":"      cmd: cat /proc/cpuinfo"},{"line_number":158,"context_line":"    delorean-logs:"},{"line_number":159,"context_line":"      cmd: \u003e"},{"line_number":160,"context_line":"        if [[ -e /home/{{ undercloud_user }}/DLRN/data/repos ]]; then"},{"line_number":161,"context_line":"        rm -rf /tmp/delorean_logs \u0026\u0026 mkdir /tmp/delorean_logs;"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_0227c268","line":158,"range":{"start_line":158,"start_character":12,"end_line":158,"end_character":13},"updated":"2020-02-01 20:03:17.000000000","message":"let\u0027s keep consistent, either dashes or underscores.","commit_id":"22b322e2596e6811d690303c8cbb12cf0b8a339c"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"8e154e35f3bdc79f15d76636d9941a664f5bb47f","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  system:"},{"line_number":156,"context_line":"    cpuinfo:"},{"line_number":157,"context_line":"      cmd: cat /proc/cpuinfo"},{"line_number":158,"context_line":"    delorean-logs:"},{"line_number":159,"context_line":"      cmd: \u003e"},{"line_number":160,"context_line":"        if [[ -e /home/{{ undercloud_user }}/DLRN/data/repos ]]; then"},{"line_number":161,"context_line":"        rm -rf /tmp/delorean_logs \u0026\u0026 mkdir /tmp/delorean_logs;"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_4e607935","line":158,"range":{"start_line":158,"start_character":12,"end_line":158,"end_character":13},"in_reply_to":"3fa7e38b_0227c268","updated":"2020-02-03 17:05:56.000000000","message":"agree.. needs _ not -","commit_id":"22b322e2596e6811d690303c8cbb12cf0b8a339c"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"ed97755d6c1e41233bbcb68c76cc8a4bcc819938","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  system:"},{"line_number":156,"context_line":"    cpuinfo:"},{"line_number":157,"context_line":"      cmd: cat /proc/cpuinfo"},{"line_number":158,"context_line":"    delorean-logs:"},{"line_number":159,"context_line":"      cmd: \u003e"},{"line_number":160,"context_line":"        if [[ -e /home/{{ undercloud_user }}/DLRN/data/repos ]]; then"},{"line_number":161,"context_line":"        rm -rf /tmp/delorean_logs \u0026\u0026 mkdir /tmp/delorean_logs;"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_ec6b6351","line":158,"range":{"start_line":158,"start_character":12,"end_line":158,"end_character":13},"in_reply_to":"3fa7e38b_4e607935","updated":"2020-02-04 09:58:33.000000000","message":"That was backwards compatibility, not a mistake, I kept the same filenames. I do agree that it should be consistent but addressing this aspect should be done in a different change.","commit_id":"22b322e2596e6811d690303c8cbb12cf0b8a339c"}],"molecule/default/playbook.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"820642b6e8be5a9509194ec1c2dd60ddbb1f43cc","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Converge"},{"line_number":13,"context_line":"  hosts: all"},{"line_number":14,"context_line":"  gather_facts: true  # needed!!!!"},{"line_number":15,"context_line":"  strategy: free"},{"line_number":16,"context_line":"  tasks:"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa7e38b_70af6e7c","line":14,"updated":"2020-01-31 07:27:08.000000000","message":"either add some more info here or remove the # needed!!!!\n(or at least revise the number of exclamation marks!!!!)","commit_id":"f7da662b7c73c5773e415f5a429593d129160c7e"}],"tasks/collect.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"820642b6e8be5a9509194ec1c2dd60ddbb1f43cc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        state: present"},{"line_number":8,"context_line":"        name:"},{"line_number":9,"context_line":"          - gzip"},{"line_number":10,"context_line":"          - lsof"},{"line_number":11,"context_line":"          - lvm2"},{"line_number":12,"context_line":"          - net-tools  # netstat"},{"line_number":13,"context_line":"          - pciutils  # lspci"},{"line_number":14,"context_line":"          - psmisc  # pstree"},{"line_number":15,"context_line":"          - rsync"},{"line_number":16,"context_line":"          - socat"},{"line_number":17,"context_line":"          - sysstat"},{"line_number":18,"context_line":"          - tar"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    - name: Prepare directory with extra logs"},{"line_number":21,"context_line":"      file: dest\u003d/var/log/extra state\u003ddirectory"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa7e38b_d0bd02b3","line":18,"range":{"start_line":10,"start_character":5,"end_line":18,"end_character":15},"updated":"2020-01-31 07:27:08.000000000","message":"perhaps these need to move into the defaults/main or vars/main if we have one","commit_id":"f7da662b7c73c5773e415f5a429593d129160c7e"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"592df7ed2a612b3983c8b8bbd3b00ba664bc2ec2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        state: present"},{"line_number":8,"context_line":"        name:"},{"line_number":9,"context_line":"          - gzip"},{"line_number":10,"context_line":"          - lsof"},{"line_number":11,"context_line":"          - lvm2"},{"line_number":12,"context_line":"          - net-tools  # netstat"},{"line_number":13,"context_line":"          - pciutils  # lspci"},{"line_number":14,"context_line":"          - psmisc  # pstree"},{"line_number":15,"context_line":"          - rsync"},{"line_number":16,"context_line":"          - socat"},{"line_number":17,"context_line":"          - sysstat"},{"line_number":18,"context_line":"          - tar"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    - name: Prepare directory with extra logs"},{"line_number":21,"context_line":"      file: dest\u003d/var/log/extra state\u003ddirectory"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa7e38b_2bc66b43","line":18,"range":{"start_line":10,"start_character":5,"end_line":18,"end_character":15},"in_reply_to":"3fa7e38b_d0bd02b3","updated":"2020-01-31 09:30:57.000000000","message":"Done","commit_id":"f7da662b7c73c5773e415f5a429593d129160c7e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"820642b6e8be5a9509194ec1c2dd60ddbb1f43cc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# - import_tasks: collect/monitoring.yml"},{"line_number":40,"context_line":"#   when: \"\u0027monitoring\u0027 in collect_log_types\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# - import_tasks: collect/openstack.yml"},{"line_number":43,"context_line":"#   when: \"\u0027openstack\u0027 in collect_log_types\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- name: Set default collect list"},{"line_number":46,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa7e38b_10c4fa41","line":43,"range":{"start_line":42,"start_character":1,"end_line":43,"end_character":4},"updated":"2020-01-31 07:27:08.000000000","message":"remove these?","commit_id":"f7da662b7c73c5773e415f5a429593d129160c7e"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"592df7ed2a612b3983c8b8bbd3b00ba664bc2ec2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# - import_tasks: collect/monitoring.yml"},{"line_number":40,"context_line":"#   when: \"\u0027monitoring\u0027 in collect_log_types\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# - import_tasks: collect/openstack.yml"},{"line_number":43,"context_line":"#   when: \"\u0027openstack\u0027 in collect_log_types\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- name: Set default collect list"},{"line_number":46,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa7e38b_cbd237ff","line":43,"range":{"start_line":42,"start_character":1,"end_line":43,"end_character":4},"in_reply_to":"3fa7e38b_10c4fa41","updated":"2020-01-31 09:30:57.000000000","message":"Done","commit_id":"f7da662b7c73c5773e415f5a429593d129160c7e"}],"tasks/collect/container.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0690ef1d20365813635dbb2835234dd4bea60f11","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  ignore_errors: true"},{"line_number":4,"context_line":"  block:"},{"line_number":5,"context_line":"    - name: check if ODL container is enabled"},{"line_number":6,"context_line":"      shell: |"},{"line_number":7,"context_line":"        docker ps | grep opendaylight_api ||"},{"line_number":8,"context_line":"        podman ps | grep opendaylight_api"},{"line_number":9,"context_line":"      register: odl_container_enabled"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_e2daa648","line":6,"range":{"start_line":6,"start_character":13,"end_line":6,"end_character":14},"updated":"2020-02-01 20:03:17.000000000","message":"should use \"\u003e\" or \"\\\" below\nbetter to set pipefail as well, although it will work w/o it here.","commit_id":"22b322e2596e6811d690303c8cbb12cf0b8a339c"}],"tasks/collect/network.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"820642b6e8be5a9509194ec1c2dd60ddbb1f43cc","unresolved":false,"context_lines":[{"line_number":33,"context_line":"          [[ ! -z \"$PIDS\" ]] \u0026\u0026 ps --no-headers -f --pids \"$PIDS\";"},{"line_number":34,"context_line":"          echo \"\";"},{"line_number":35,"context_line":"        done) \u0026\u003e\u003e /var/log/extra/network-netns;"},{"line_number":36,"context_line":"        command -v ovs-vsctl \u0026\u0026 (for NB in $(ovs-vsctl show | grep Bridge |awk \u0027{print $2}\u0027); do"},{"line_number":37,"context_line":"          echo \"\u003d\u003d\u003d\u003d Bridge name - $NB \u003d\u003d\u003d\u003d\";"},{"line_number":38,"context_line":"          ovs-ofctl show $NB;"},{"line_number":39,"context_line":"          ovs-ofctl dump-flows $NB;"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa7e38b_90d54aef","line":36,"range":{"start_line":36,"start_character":11,"end_line":36,"end_character":26},"updated":"2020-01-31 07:27:08.000000000","message":"does that also need to go into there then instead https://review.opendev.org/#/c/703586/14/tasks/collect.yml@18","commit_id":"f7da662b7c73c5773e415f5a429593d129160c7e"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"592df7ed2a612b3983c8b8bbd3b00ba664bc2ec2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"          [[ ! -z \"$PIDS\" ]] \u0026\u0026 ps --no-headers -f --pids \"$PIDS\";"},{"line_number":34,"context_line":"          echo \"\";"},{"line_number":35,"context_line":"        done) \u0026\u003e\u003e /var/log/extra/network-netns;"},{"line_number":36,"context_line":"        command -v ovs-vsctl \u0026\u0026 (for NB in $(ovs-vsctl show | grep Bridge |awk \u0027{print $2}\u0027); do"},{"line_number":37,"context_line":"          echo \"\u003d\u003d\u003d\u003d Bridge name - $NB \u003d\u003d\u003d\u003d\";"},{"line_number":38,"context_line":"          ovs-ofctl show $NB;"},{"line_number":39,"context_line":"          ovs-ofctl dump-flows $NB;"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa7e38b_2bef4bb3","line":36,"range":{"start_line":36,"start_character":11,"end_line":36,"end_character":26},"in_reply_to":"3fa7e38b_90d54aef","updated":"2020-01-31 09:30:57.000000000","message":"That avoids failure on machines without ovs. the temp comment is now removed.","commit_id":"f7da662b7c73c5773e415f5a429593d129160c7e"}],"tasks/collect/system.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"fbb0e7f89d1c84f4657cd2503d1ed092e0303762","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        warn: false"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    - name: get current selinux status"},{"line_number":21,"context_line":"      shell: |"},{"line_number":22,"context_line":"        /usr/sbin/getenforce \u003e/var/log/extra/selinux.txt || true"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Collecting /proc/cpuinfo|meminfo|swaps"},{"line_number":25,"context_line":"      shell: \"cat /proc/{{ item }} \u0026\u003e /var/log/extra/{{ item }}.txt\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_c305d010","line":22,"range":{"start_line":21,"start_character":13,"end_line":22,"end_character":8},"updated":"2020-01-21 11:47:12.000000000","message":"what is the reason for this change?","commit_id":"944b4e65fd3720360c633b411df1af88e2a7ef19"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"fbb0e7f89d1c84f4657cd2503d1ed092e0303762","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    - name: get current selinux status"},{"line_number":21,"context_line":"      shell: |"},{"line_number":22,"context_line":"        /usr/sbin/getenforce \u003e/var/log/extra/selinux.txt || true"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Collecting /proc/cpuinfo|meminfo|swaps"},{"line_number":25,"context_line":"      shell: \"cat /proc/{{ item }} \u0026\u003e /var/log/extra/{{ item }}.txt\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_e3232ca9","line":22,"range":{"start_line":22,"start_character":57,"end_line":22,"end_character":64},"updated":"2020-01-21 11:47:12.000000000","message":"why do we need \"|| true\" here?","commit_id":"944b4e65fd3720360c633b411df1af88e2a7ef19"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"de196d7f2ab5115925d0f55ab5abff4c5c681ce1","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    - name: get current selinux status"},{"line_number":21,"context_line":"      shell: |"},{"line_number":22,"context_line":"        /usr/sbin/getenforce \u003e/var/log/extra/selinux.txt || true"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Collecting /proc/cpuinfo|meminfo|swaps"},{"line_number":25,"context_line":"      shell: \"cat /proc/{{ item }} \u0026\u003e /var/log/extra/{{ item }}.txt\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_23dce4e0","line":22,"range":{"start_line":22,"start_character":57,"end_line":22,"end_character":64},"in_reply_to":"3fa7e38b_631dfc0e","updated":"2020-01-21 12:24:07.000000000","message":"all this role will makes noise, nothing is going to console. This creates inconsistency, either add it to all (but why to do it?) or let\u0027s not add to any one.\n\nAlso first comment was about \":|\" and multiline for shell, what is it for??","commit_id":"944b4e65fd3720360c633b411df1af88e2a7ef19"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"ebe1cf77eeb2ef0922d063e1c85223096c0c86ea","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    - name: get current selinux status"},{"line_number":21,"context_line":"      shell: |"},{"line_number":22,"context_line":"        /usr/sbin/getenforce \u003e/var/log/extra/selinux.txt || true"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Collecting /proc/cpuinfo|meminfo|swaps"},{"line_number":25,"context_line":"      shell: \"cat /proc/{{ item }} \u0026\u003e /var/log/extra/{{ item }}.txt\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_631dfc0e","line":22,"range":{"start_line":22,"start_character":57,"end_line":22,"end_character":64},"in_reply_to":"3fa7e38b_e3232ca9","updated":"2020-01-21 12:15:22.000000000","message":"getenforce can be missing and I do not want more noise to the console when it does. (containers!)","commit_id":"944b4e65fd3720360c633b411df1af88e2a7ef19"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"fbb0e7f89d1c84f4657cd2503d1ed092e0303762","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        for user in $(cut -f1 -d\u0027:\u0027 /etc/passwd); do \\"},{"line_number":34,"context_line":"        echo $user; crontab -u $user -l | grep -v \u0027^$\\|^\\s*\\#\\|^\\s*PATH\u0027; done \\"},{"line_number":35,"context_line":"        \u0026\u003e /var/log/extra/installed_crons.txt"},{"line_number":36,"context_line":"      failed_when: false"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # used by OSP Release Engineering to import into internal builds"},{"line_number":39,"context_line":"    - name: package import delorean"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_e3480c63","line":36,"range":{"start_line":36,"start_character":6,"end_line":36,"end_character":24},"updated":"2020-01-21 11:47:12.000000000","message":"we don\u0027t care about errors in this role","commit_id":"944b4e65fd3720360c633b411df1af88e2a7ef19"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"de196d7f2ab5115925d0f55ab5abff4c5c681ce1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        for user in $(cut -f1 -d\u0027:\u0027 /etc/passwd); do \\"},{"line_number":34,"context_line":"        echo $user; crontab -u $user -l | grep -v \u0027^$\\|^\\s*\\#\\|^\\s*PATH\u0027; done \\"},{"line_number":35,"context_line":"        \u0026\u003e /var/log/extra/installed_crons.txt"},{"line_number":36,"context_line":"      failed_when: false"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # used by OSP Release Engineering to import into internal builds"},{"line_number":39,"context_line":"    - name: package import delorean"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_23f5c452","line":36,"range":{"start_line":36,"start_character":6,"end_line":36,"end_character":24},"in_reply_to":"3fa7e38b_431000f5","updated":"2020-01-21 12:24:07.000000000","message":"As I wrote in comment before, all this is going with ignore_errors and it was intentionally. Either add it to all or not to any task.","commit_id":"944b4e65fd3720360c633b411df1af88e2a7ef19"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"ebe1cf77eeb2ef0922d063e1c85223096c0c86ea","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        for user in $(cut -f1 -d\u0027:\u0027 /etc/passwd); do \\"},{"line_number":34,"context_line":"        echo $user; crontab -u $user -l | grep -v \u0027^$\\|^\\s*\\#\\|^\\s*PATH\u0027; done \\"},{"line_number":35,"context_line":"        \u0026\u003e /var/log/extra/installed_crons.txt"},{"line_number":36,"context_line":"      failed_when: false"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # used by OSP Release Engineering to import into internal builds"},{"line_number":39,"context_line":"    - name: package import delorean"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_431000f5","line":36,"range":{"start_line":36,"start_character":6,"end_line":36,"end_character":24},"in_reply_to":"3fa7e38b_e3480c63","updated":"2020-01-21 12:15:22.000000000","message":"We don\u0027t care about the results but we care about output, seeing too red-herrings in console (or ara) can be distracting. \n\nIdeally we should see only real errors.","commit_id":"944b4e65fd3720360c633b411df1af88e2a7ef19"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"de196d7f2ab5115925d0f55ab5abff4c5c681ce1","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    - name: get current selinux status"},{"line_number":24,"context_line":"      shell: \u003e"},{"line_number":25,"context_line":"        test -f /usr/sbin/getenforce \u0026\u0026"},{"line_number":26,"context_line":"        /usr/sbin/getenforce \u003e/var/log/extra/selinux.txt || true"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Collecting /proc/cpuinfo|meminfo|swaps"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_a39694ed","line":25,"range":{"start_line":25,"start_character":8,"end_line":25,"end_character":39},"updated":"2020-01-21 12:24:07.000000000","message":"not needed","commit_id":"b8f43f4eb0b9d8b41cd4712409ea8a9fec893fa8"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fd4310a643ab34b418ecd95bb3989d560f8fa2a3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      failed_when: false"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    - name: get current selinux status"},{"line_number":24,"context_line":"      shell: \u003e"},{"line_number":25,"context_line":"        test -f /usr/sbin/getenforce \u0026\u0026"},{"line_number":26,"context_line":"        /usr/sbin/getenforce \u003e/var/log/extra/selinux.txt || true"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_5b4c553f","line":24,"range":{"start_line":24,"start_character":12,"end_line":24,"end_character":13},"updated":"2020-01-22 07:31:08.000000000","message":"why not use cmd as above?","commit_id":"bdbb4e470999b715e091183e46073c170ebf3263"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fd4310a643ab34b418ecd95bb3989d560f8fa2a3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    - name: get current selinux status"},{"line_number":24,"context_line":"      shell: \u003e"},{"line_number":25,"context_line":"        test -f /usr/sbin/getenforce \u0026\u0026"},{"line_number":26,"context_line":"        /usr/sbin/getenforce \u003e/var/log/extra/selinux.txt || true"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Collecting /proc/cpuinfo|meminfo|swaps"},{"line_number":29,"context_line":"      shell: \"cat /proc/{{ item }} \u0026\u003e /var/log/extra/{{ item }}.txt\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_5b6535af","line":26,"range":{"start_line":26,"start_character":58,"end_line":26,"end_character":63},"updated":"2020-01-22 07:31:08.000000000","message":"why || true instead of failed_when: false","commit_id":"bdbb4e470999b715e091183e46073c170ebf3263"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fd4310a643ab34b418ecd95bb3989d560f8fa2a3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        /usr/sbin/getenforce \u003e/var/log/extra/selinux.txt || true"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Collecting /proc/cpuinfo|meminfo|swaps"},{"line_number":29,"context_line":"      shell: \"cat /proc/{{ item }} \u0026\u003e /var/log/extra/{{ item }}.txt\""},{"line_number":30,"context_line":"      with_items:"},{"line_number":31,"context_line":"        - cpuinfo"},{"line_number":32,"context_line":"        - meminfo"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_9b464d22","line":29,"range":{"start_line":29,"start_character":13,"end_line":29,"end_character":15},"updated":"2020-01-22 07:31:08.000000000","message":"why this one doesn\u0027t need cmd: like the others on line 18 and above","commit_id":"bdbb4e470999b715e091183e46073c170ebf3263"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fd4310a643ab34b418ecd95bb3989d560f8fa2a3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        pstree -p \u0026\u003e /var/log/extra/pstree.txt"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    - name: sysctl -a"},{"line_number":69,"context_line":"      shell: |"},{"line_number":70,"context_line":"        sysctl -a \u0026\u003e /var/log/extra/sysctl.txt"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    - name: Get haproxy stats"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_1b5c9dee","line":69,"updated":"2020-01-22 07:31:08.000000000","message":"why no cmd and no failed_when:false?\n\nperhaps using | is enough for that bit (from commit message): - avoid runtime warnings from ansible due to use of shell","commit_id":"bdbb4e470999b715e091183e46073c170ebf3263"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"820642b6e8be5a9509194ec1c2dd60ddbb1f43cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3fa7e38b_90feaa6b","updated":"2020-01-31 07:27:08.000000000","message":"this file is really the headline here in the sense that this is where you\u0027re trying to improve performance with async\n\nAs discussed yesterday try to break this change up if possible and post reviews ontop with everyting else","commit_id":"f7da662b7c73c5773e415f5a429593d129160c7e"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0690ef1d20365813635dbb2835234dd4bea60f11","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    # TODO(ssbarnea): Investigate dumping these directly to localhost to avoid"},{"line_number":26,"context_line":"    # rsync on them, could allow us to run rsync in parallel too."},{"line_number":27,"context_line":"    - name: Dump stdout from commands"},{"line_number":28,"context_line":"      delegate_to: localhost"},{"line_number":29,"context_line":"      connection: local"},{"line_number":30,"context_line":"      become: false"},{"line_number":31,"context_line":"      when:"},{"line_number":32,"context_line":"        - \"\u0027stdout\u0027 in job\""},{"line_number":33,"context_line":"        - job.stdout|length\u003e0"},{"line_number":34,"context_line":"      copy:"},{"line_number":35,"context_line":"        content: \"{{ job.stdout }}\""},{"line_number":36,"context_line":"        # dest: \"/var/log/extra/{{ job.item.item.key }}.txt\""},{"line_number":37,"context_line":"        dest: \"{{ artcl_collect_dir }}/{{ inventory_hostname }}/{{ job.item.item.key }}.txt\""},{"line_number":38,"context_line":"      loop: \"{{ _jobs.results }}\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_229f5e65","line":35,"range":{"start_line":27,"start_character":5,"end_line":35,"end_character":35},"updated":"2020-02-01 20:03:17.000000000","message":"I don\u0027t think it\u0027s a good decision to collect all stdouts in the memory. \nFirstly, it just consumes a lot of memory. Secondly, it generates this huge collection debug file, which is not parseable. And debug there is not a problem.\nYou can redirect output to the file in command itself, it also will solve stderr issue below. It may create empty file, but this never was a problem.\nIf some of tasks fail here, we also can lose ALL stdouts, Let\u0027s keep redirection in command as it\u0027s much more reliable and resource efficient.","commit_id":"22b322e2596e6811d690303c8cbb12cf0b8a339c"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"ed97755d6c1e41233bbcb68c76cc8a4bcc819938","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    # TODO(ssbarnea): Investigate dumping these directly to localhost to avoid"},{"line_number":26,"context_line":"    # rsync on them, could allow us to run rsync in parallel too."},{"line_number":27,"context_line":"    - name: Dump stdout from commands"},{"line_number":28,"context_line":"      delegate_to: localhost"},{"line_number":29,"context_line":"      connection: local"},{"line_number":30,"context_line":"      become: false"},{"line_number":31,"context_line":"      when:"},{"line_number":32,"context_line":"        - \"\u0027stdout\u0027 in job\""},{"line_number":33,"context_line":"        - job.stdout|length\u003e0"},{"line_number":34,"context_line":"      copy:"},{"line_number":35,"context_line":"        content: \"{{ job.stdout }}\""},{"line_number":36,"context_line":"        # dest: \"/var/log/extra/{{ job.item.item.key }}.txt\""},{"line_number":37,"context_line":"        dest: \"{{ artcl_collect_dir }}/{{ inventory_hostname }}/{{ job.item.item.key }}.txt\""},{"line_number":38,"context_line":"      loop: \"{{ _jobs.results }}\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_4cf95780","line":35,"range":{"start_line":27,"start_character":5,"end_line":35,"end_character":35},"in_reply_to":"3fa7e38b_229f5e65","updated":"2020-02-04 09:58:33.000000000","message":"I am aware of the risks and I will keep existing behavior for the moment, giving us enough time to investigate pros/cons of using ansible as a broker. I will start doing spin-offs out of this review with parts we already agreed on. I will put a DNM on this CR which was used more for building and valdating the POC.","commit_id":"22b322e2596e6811d690303c8cbb12cf0b8a339c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0690ef1d20365813635dbb2835234dd4bea60f11","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        index_var: idx"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # Save exit code and stderr of commands here, so we know what failed to collect"},{"line_number":45,"context_line":"    # An ideal collection should produce nothing in this file."},{"line_number":46,"context_line":"    - name: Dump collection errors summary"},{"line_number":47,"context_line":"      delegate_to: localhost"},{"line_number":48,"context_line":"      connection: local"},{"line_number":49,"context_line":"      become: false"},{"line_number":50,"context_line":"      blockinfile:"},{"line_number":51,"context_line":"        dest: \"{{ artcl_collect_dir }}/{{ inventory_hostname }}//_artcl_.txt\""},{"line_number":52,"context_line":"        insertafter: EOF"},{"line_number":53,"context_line":"        marker: \"\""},{"line_number":54,"context_line":"        create: true"},{"line_number":55,"context_line":"        block: |"},{"line_number":56,"context_line":"          Commands that returned an error code or had non-empty stderr."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"          {% for r in _jobs.results -%}"},{"line_number":59,"context_line":"          {% if r.rc !\u003d 0 or r.stderr %}"},{"line_number":60,"context_line":"          \u003d\u003d\u003d {{ r.item.item.key }} command returned {{ r.rc }} \u003d\u003d\u003d"},{"line_number":61,"context_line":"          {{ r.cmd -}} STDERR:"},{"line_number":62,"context_line":"          {{ r.stderr }}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"          {% endif -%}"},{"line_number":65,"context_line":"          {% endfor %}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    # Commands that are not safe to run recursively, or need to run at the end"},{"line_number":68,"context_line":"    - name: Collect errors and rename if more than 10 MB"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3fa7e38b_42e93ae2","line":65,"range":{"start_line":45,"start_character":3,"end_line":65,"end_character":22},"updated":"2020-02-01 20:03:17.000000000","message":"I think \"stderr\"s should be in the same file with \"stdout\". Usually \"stderr\" is not less informative than \"stdout\" here, so it will be confusing to search information in multiple files instead of one. Please combine them in one file for each command.","commit_id":"22b322e2596e6811d690303c8cbb12cf0b8a339c"}],"zuul.d/layout.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"820642b6e8be5a9509194ec1c2dd60ddbb1f43cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3fa7e38b_30c6d643","updated":"2020-01-31 07:27:08.000000000","message":"no merge on this one right? just for testing","commit_id":"f7da662b7c73c5773e415f5a429593d129160c7e"}]}