)]}'
{"files/collect-container-logs.sh":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"13162b1379c584ba532869da7a72f4f22d8c3512","unresolved":false,"context_lines":[{"line_number":44,"context_line":"${engine} ps -a | grep -vE \u0027 (IMAGE|Exited \\(0\\)|Up) \u0027 \u0026\u003e\u003e /var/log/extra/failed_containers.log;"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Get inspect infos for all containers even the ones not running."},{"line_number":47,"context_line":"for cont in $(${engine} ps -a | awk {\u0027print $NF\u0027} | grep -v NAMES); do"},{"line_number":48,"context_line":"    INFO_DIR\u003d$BASE_CONTAINER_EXTRA/containers/${cont};"},{"line_number":49,"context_line":"    mkdir -p $INFO_DIR;"},{"line_number":50,"context_line":"    ("}],"source_content_type":"text/x-sh","patch_set":1,"id":"1fa4df85_7cd38639","line":47,"updated":"2020-02-28 13:48:36.000000000","message":"why not \"ps -qa\"?","commit_id":"d431d12cc6803c7656391ab96cfad1f99ecd1f65"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2bb6e40a5c08b3370336d1bfbb96994c15542e22","unresolved":false,"context_lines":[{"line_number":44,"context_line":"${engine} ps -a | grep -vE \u0027 (IMAGE|Exited \\(0\\)|Up) \u0027 \u0026\u003e\u003e /var/log/extra/failed_containers.log;"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Get inspect infos for all containers even the ones not running."},{"line_number":47,"context_line":"for cont in $(${engine} ps -a | awk {\u0027print $NF\u0027} | grep -v NAMES); do"},{"line_number":48,"context_line":"    INFO_DIR\u003d$BASE_CONTAINER_EXTRA/containers/${cont};"},{"line_number":49,"context_line":"    mkdir -p $INFO_DIR;"},{"line_number":50,"context_line":"    ("}],"source_content_type":"text/x-sh","patch_set":1,"id":"1fa4df85_7f9b78c8","line":47,"in_reply_to":"1fa4df85_3c00ae67","updated":"2020-02-28 14:09:15.000000000","message":"I might do a follow-up in order to avoid those pipes ;). Having the container name in the log output is better than its ID anyway.","commit_id":"d431d12cc6803c7656391ab96cfad1f99ecd1f65"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a12bb691b42153359df9f5975907cd85068bd00b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"${engine} ps -a | grep -vE \u0027 (IMAGE|Exited \\(0\\)|Up) \u0027 \u0026\u003e\u003e /var/log/extra/failed_containers.log;"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Get inspect infos for all containers even the ones not running."},{"line_number":47,"context_line":"for cont in $(${engine} ps -a | awk {\u0027print $NF\u0027} | grep -v NAMES); do"},{"line_number":48,"context_line":"    INFO_DIR\u003d$BASE_CONTAINER_EXTRA/containers/${cont};"},{"line_number":49,"context_line":"    mkdir -p $INFO_DIR;"},{"line_number":50,"context_line":"    ("}],"source_content_type":"text/x-sh","patch_set":1,"id":"1fa4df85_3c00ae67","line":47,"in_reply_to":"1fa4df85_7cd38639","updated":"2020-02-28 14:00:04.000000000","message":"it was like this before I just did copy paste","commit_id":"d431d12cc6803c7656391ab96cfad1f99ecd1f65"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"13162b1379c584ba532869da7a72f4f22d8c3512","unresolved":false,"context_lines":[{"line_number":53,"context_line":"done;"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Get other infos for running containers"},{"line_number":56,"context_line":"for cont in $(${engine} ps | awk {\u0027print $NF\u0027} | grep -v NAMES); do"},{"line_number":57,"context_line":"    ("},{"line_number":58,"context_line":"        if [ ${engine} \u003d \u0027docker\u0027 ]; then"},{"line_number":59,"context_line":"            ${engine} top $cont auxw;"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1fa4df85_dc163af2","line":56,"updated":"2020-02-28 13:48:36.000000000","message":"why not \"ps -q\" ?","commit_id":"d431d12cc6803c7656391ab96cfad1f99ecd1f65"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"c4de9fb9f1fb6691fa2cc1c1efb024ec3e7ba748","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Get other infos for running containers"},{"line_number":56,"context_line":"for cont in $(${engine} ps | awk {\u0027print $NF\u0027} | grep -v NAMES); do"},{"line_number":57,"context_line":"    ("},{"line_number":58,"context_line":"        if [ ${engine} \u003d \u0027docker\u0027 ]; then"},{"line_number":59,"context_line":"            ${engine} top $cont auxw;"},{"line_number":60,"context_line":"        # NOTE(cjeanner): `podman top` does not support `ps` options."},{"line_number":61,"context_line":"        elif [ ${engine} \u003d \u0027podman\u0027 ]; then"},{"line_number":62,"context_line":"            ${engine} top $cont;"},{"line_number":63,"context_line":"        fi"},{"line_number":64,"context_line":"        ${engine} exec $cont top -bwn1;"},{"line_number":65,"context_line":"        ${engine} exec $cont bash -c \"\\$(command -v dnf || command -v yum) list installed\";"},{"line_number":66,"context_line":"    ) \u0026\u003e\u003e $INFO_DIR/${engine}_info.log;"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    container_cp $cont /var/lib/kolla/config_files/config.json $INFO_DIR/config.json;"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1fa4df85_a77eb916","line":66,"range":{"start_line":57,"start_character":0,"end_line":66,"end_character":39},"updated":"2020-03-02 06:13:32.000000000","message":"these are no longer getting collected after this patch. INFO_DIR missing for this block.","commit_id":"d431d12cc6803c7656391ab96cfad1f99ecd1f65"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"28111bb562ef1be1066e8d6b670a429a19bff3b7","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Get other infos for running containers"},{"line_number":56,"context_line":"for cont in $(${engine} ps | awk {\u0027print $NF\u0027} | grep -v NAMES); do"},{"line_number":57,"context_line":"    ("},{"line_number":58,"context_line":"        if [ ${engine} \u003d \u0027docker\u0027 ]; then"},{"line_number":59,"context_line":"            ${engine} top $cont auxw;"},{"line_number":60,"context_line":"        # NOTE(cjeanner): `podman top` does not support `ps` options."},{"line_number":61,"context_line":"        elif [ ${engine} \u003d \u0027podman\u0027 ]; then"},{"line_number":62,"context_line":"            ${engine} top $cont;"},{"line_number":63,"context_line":"        fi"},{"line_number":64,"context_line":"        ${engine} exec $cont top -bwn1;"},{"line_number":65,"context_line":"        ${engine} exec $cont bash -c \"\\$(command -v dnf || command -v yum) list installed\";"},{"line_number":66,"context_line":"    ) \u0026\u003e\u003e $INFO_DIR/${engine}_info.log;"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    container_cp $cont /var/lib/kolla/config_files/config.json $INFO_DIR/config.json;"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1fa4df85_470a658a","line":66,"range":{"start_line":57,"start_character":0,"end_line":66,"end_character":39},"in_reply_to":"1fa4df85_27de4911","updated":"2020-03-02 06:25:16.000000000","message":"proposed https://review.opendev.org/710704","commit_id":"d431d12cc6803c7656391ab96cfad1f99ecd1f65"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"21f10e353897e34382850ed4b443888499491b39","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Get other infos for running containers"},{"line_number":56,"context_line":"for cont in $(${engine} ps | awk {\u0027print $NF\u0027} | grep -v NAMES); do"},{"line_number":57,"context_line":"    ("},{"line_number":58,"context_line":"        if [ ${engine} \u003d \u0027docker\u0027 ]; then"},{"line_number":59,"context_line":"            ${engine} top $cont auxw;"},{"line_number":60,"context_line":"        # NOTE(cjeanner): `podman top` does not support `ps` options."},{"line_number":61,"context_line":"        elif [ ${engine} \u003d \u0027podman\u0027 ]; then"},{"line_number":62,"context_line":"            ${engine} top $cont;"},{"line_number":63,"context_line":"        fi"},{"line_number":64,"context_line":"        ${engine} exec $cont top -bwn1;"},{"line_number":65,"context_line":"        ${engine} exec $cont bash -c \"\\$(command -v dnf || command -v yum) list installed\";"},{"line_number":66,"context_line":"    ) \u0026\u003e\u003e $INFO_DIR/${engine}_info.log;"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    container_cp $cont /var/lib/kolla/config_files/config.json $INFO_DIR/config.json;"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1fa4df85_27de4911","line":66,"range":{"start_line":57,"start_character":0,"end_line":66,"end_character":39},"in_reply_to":"1fa4df85_a77eb916","updated":"2020-03-02 06:19:32.000000000","message":"ohhh getting collected but at wrong location /podman_info.log","commit_id":"d431d12cc6803c7656391ab96cfad1f99ecd1f65"}]}