)]}'
{"defaults/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"11f18c6f01a9ad9b1dc35e09e7e37aa106681486","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        systemctl -t service --failed --no-legend | awk \u0027{print $1}\u0027"},{"line_number":206,"context_line":"        | xargs -r -n1 journalctl -u"},{"line_number":207,"context_line":"    lsof:"},{"line_number":208,"context_line":"      cmd: \"lsof -P -n \u0026|\""},{"line_number":209,"context_line":"    pstree:"},{"line_number":210,"context_line":"      cmd: \"pstree -p \u0026\""},{"line_number":211,"context_line":"    sysctl:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_d625e6c3","line":208,"range":{"start_line":208,"start_character":23,"end_line":208,"end_character":25},"updated":"2020-03-31 07:31:54.000000000","message":"why do we need this bit please? I guess \u0026 cos you\u0027re chaining commands, perhaps? but | ?","commit_id":"ade013b43e37750fd4c0df74612b6ebd0f2a2def"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"a8a7e14f8b84c14656e5395380cf03e36e4ef16c","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        systemctl -t service --failed --no-legend | awk \u0027{print $1}\u0027"},{"line_number":206,"context_line":"        | xargs -r -n1 journalctl -u"},{"line_number":207,"context_line":"    lsof:"},{"line_number":208,"context_line":"      cmd: \"lsof -P -n \u0026|\""},{"line_number":209,"context_line":"    pstree:"},{"line_number":210,"context_line":"      cmd: \"pstree -p \u0026\""},{"line_number":211,"context_line":"    sysctl:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_96acf9ed","line":208,"range":{"start_line":208,"start_character":23,"end_line":208,"end_character":25},"in_reply_to":"df33271e_d625e6c3","updated":"2020-04-17 13:19:19.000000000","message":"That joins stderr and stdout, mainly it keeps current behavior.\n\nI personally am against putting stderr in the same place but others have different oppinionts. If we are to change behavior it should be outside this change.","commit_id":"ade013b43e37750fd4c0df74612b6ebd0f2a2def"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"11f18c6f01a9ad9b1dc35e09e7e37aa106681486","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    lsof:"},{"line_number":208,"context_line":"      cmd: \"lsof -P -n \u0026|\""},{"line_number":209,"context_line":"    pstree:"},{"line_number":210,"context_line":"      cmd: \"pstree -p \u0026\""},{"line_number":211,"context_line":"    sysctl:"},{"line_number":212,"context_line":"      cmd: \"sysctl -a \u0026|\""},{"line_number":213,"context_line":"    haproxy-stats:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_f6010a08","line":210,"updated":"2020-03-31 07:31:54.000000000","message":"so why that one doesn\u0027t need the | for example\n\nand why do only some of these commands have them others don\u0027t.","commit_id":"ade013b43e37750fd4c0df74612b6ebd0f2a2def"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"a8a7e14f8b84c14656e5395380cf03e36e4ef16c","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    lsof:"},{"line_number":208,"context_line":"      cmd: \"lsof -P -n \u0026|\""},{"line_number":209,"context_line":"    pstree:"},{"line_number":210,"context_line":"      cmd: \"pstree -p \u0026\""},{"line_number":211,"context_line":"    sysctl:"},{"line_number":212,"context_line":"      cmd: \"sysctl -a \u0026|\""},{"line_number":213,"context_line":"    haproxy-stats:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_168aa968","line":210,"in_reply_to":"df33271e_f6010a08","updated":"2020-04-17 13:19:19.000000000","message":"That is a BUG! One that would render the command useless.","commit_id":"ade013b43e37750fd4c0df74612b6ebd0f2a2def"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"11f18c6f01a9ad9b1dc35e09e7e37aa106681486","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        systemctl status \"*\" \u0026|"},{"line_number":233,"context_line":"    denials:"},{"line_number":234,"context_line":"      cmd: \u003e"},{"line_number":235,"context_line":"        grep -i denied /var/log/audit/audit*"},{"line_number":236,"context_line":"    seqfaults:"},{"line_number":237,"context_line":"      cmd: \u003e"},{"line_number":238,"context_line":"        grep -v ansible-command /var/log/messages | grep segfault"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_41058e10","line":235,"updated":"2020-03-31 07:31:54.000000000","message":"why not there then \u0026|","commit_id":"ade013b43e37750fd4c0df74612b6ebd0f2a2def"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"a8a7e14f8b84c14656e5395380cf03e36e4ef16c","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        systemctl status \"*\" \u0026|"},{"line_number":233,"context_line":"    denials:"},{"line_number":234,"context_line":"      cmd: \u003e"},{"line_number":235,"context_line":"        grep -i denied /var/log/audit/audit*"},{"line_number":236,"context_line":"    seqfaults:"},{"line_number":237,"context_line":"      cmd: \u003e"},{"line_number":238,"context_line":"        grep -v ansible-command /var/log/messages | grep segfault"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_b6981dc0","line":235,"in_reply_to":"df33271e_41058e10","updated":"2020-04-17 13:19:19.000000000","message":"Because we do not need to record the fact that grep failed to find any matches.","commit_id":"ade013b43e37750fd4c0df74612b6ebd0f2a2def"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1b495543cb3660e7993cdcf04f9042d7d8191bfb","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        grep -i denied /var/log/audit/audit*"},{"line_number":236,"context_line":"    seqfaults:"},{"line_number":237,"context_line":"      cmd: \u003e"},{"line_number":238,"context_line":"        grep -v ansible-command /var/log/messages | grep segfault"},{"line_number":239,"context_line":"    oom-killers.txt:"},{"line_number":240,"context_line":"      cmd: |"},{"line_number":241,"context_line":"        grep -v ansible-command /var/log/messages | grep oom-killer"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_acf62862","line":238,"range":{"start_line":238,"start_character":18,"end_line":238,"end_character":19},"updated":"2020-04-20 07:26:58.000000000","message":"any idea why these were duplicated at https://review.opendev.org/#/c/715927/2/tasks/collect/system.yml ? perhaps  the question is \u0027why do you no longer need to duplicate those\u0027","commit_id":"7567e453a4e93572de9aa8bdc1d058ba5af34dd0"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"fe3f37c44934a6341a25d4fdaa663cea1902a414","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        grep -i denied /var/log/audit/audit*"},{"line_number":236,"context_line":"    seqfaults:"},{"line_number":237,"context_line":"      cmd: \u003e"},{"line_number":238,"context_line":"        grep -v ansible-command /var/log/messages | grep segfault"},{"line_number":239,"context_line":"    oom-killers.txt:"},{"line_number":240,"context_line":"      cmd: |"},{"line_number":241,"context_line":"        grep -v ansible-command /var/log/messages | grep oom-killer"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f493fa4_b9c9ab79","line":238,"range":{"start_line":238,"start_character":18,"end_line":238,"end_character":19},"in_reply_to":"3f4c43b2_acf62862","updated":"2020-04-22 08:25:21.000000000","message":"ditto, likely lack of \u0027tee awareness\u0027. Also that one was quite dangereus as a command because in special cases it could have generate OOM with Python due to loading huge amount of data. Usually you need to put a safety \"tail/head\" to avoid OOM with big logs.","commit_id":"7567e453a4e93572de9aa8bdc1d058ba5af34dd0"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4bd553da1777ae6a63df2709a1783bb495190be1","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        systemctl -t service --failed --no-legend | awk \u0027{print $1}\u0027"},{"line_number":207,"context_line":"        | xargs -r -n1 journalctl -u"},{"line_number":208,"context_line":"    lsof:"},{"line_number":209,"context_line":"      cmd: lsof -P -n"},{"line_number":210,"context_line":"    pstree:"},{"line_number":211,"context_line":"      cmd: pstree -p"},{"line_number":212,"context_line":"    sysctl:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_d778882b","line":209,"range":{"start_line":209,"start_character":3,"end_line":209,"end_character":21},"updated":"2020-04-24 09:59:07.000000000","message":"was this intentional?","commit_id":"f88f2fc2f63a81c953a8424f024ead723531d2e8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f67700f42fd07cc546083ff4fb958be1c61237df","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        mv /tmp/delorean_logs/home/{{ undercloud_user }}/DLRN/data/repos/* {{ artcl_collect_dir }}/delorean_logs/;"},{"line_number":257,"context_line":"        mv /tmp/delorean_logs/projects.ini {{ artcl_collect_dir }}/delorean_logs/;"},{"line_number":258,"context_line":"        fi"},{"line_number":259,"context_line":"      disable_capture: true"},{"line_number":260,"context_line":"    journal:"},{"line_number":261,"context_line":"      cmd: journalctl --since\u003d-4h --lines\u003d100000"},{"line_number":262,"context_line":"  monitoring: {}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_9262a53d","line":259,"range":{"start_line":259,"start_character":6,"end_line":259,"end_character":21},"updated":"2020-04-23 14:43:07.000000000","message":"btw, shouldn\u0027t this be capture_disable?\nhttps://opendev.org/openstack/ansible-role-collect-logs/src/branch/master/tasks/collect.yml#L38-L42","commit_id":"f88f2fc2f63a81c953a8424f024ead723531d2e8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4bd553da1777ae6a63df2709a1783bb495190be1","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        mv /tmp/delorean_logs/home/{{ undercloud_user }}/DLRN/data/repos/* {{ artcl_collect_dir }}/delorean_logs/;"},{"line_number":267,"context_line":"        mv /tmp/delorean_logs/projects.ini {{ artcl_collect_dir }}/delorean_logs/;"},{"line_number":268,"context_line":"        fi"},{"line_number":269,"context_line":"      disable_capture: true"},{"line_number":270,"context_line":"    journal:"},{"line_number":271,"context_line":"      cmd: journalctl --since\u003d-4h --lines\u003d100000"},{"line_number":272,"context_line":"  monitoring: {}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_7779b42d","line":269,"range":{"start_line":269,"start_character":6,"end_line":269,"end_character":21},"updated":"2020-04-24 09:59:07.000000000","message":"capture_disable\n\nhttps://opendev.org/openstack/ansible-role-collect-logs/src/branch/master/tasks/collect.yml#L38-L42","commit_id":"d37516d65bbf42ffe041a4b3f02f1337160cac73"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"59d376831b132d01fbb094705f8cdb9a4fc35b3b","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        mv /tmp/delorean_logs/home/{{ undercloud_user }}/DLRN/data/repos/* {{ artcl_collect_dir }}/delorean_logs/;"},{"line_number":270,"context_line":"        mv /tmp/delorean_logs/projects.ini {{ artcl_collect_dir }}/delorean_logs/;"},{"line_number":271,"context_line":"        fi"},{"line_number":272,"context_line":"      disable_capture: true"},{"line_number":273,"context_line":"    journal:"},{"line_number":274,"context_line":"      cmd: journalctl --since\u003d-4h --lines\u003d100000"},{"line_number":275,"context_line":"  monitoring: {}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f493fa4_8b3a5931","line":272,"range":{"start_line":272,"start_character":6,"end_line":272,"end_character":21},"updated":"2020-04-24 13:34:06.000000000","message":"s/disable_capture/capture_disable unless I understand something wrong: https://github.com/openstack/ansible-role-collect-logs/blob/master/tasks/collect.yml#L37","commit_id":"344e4ef010e98883739807be4db795a6e650efad"}],"tasks/collect/system.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1b495543cb3660e7993cdcf04f9042d7d8191bfb","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    - name: Search for AVC denied"},{"line_number":77,"context_line":"      shell: \u003e"},{"line_number":78,"context_line":"        grep -i denied /var/log/audit/audit* \u0026\u0026"},{"line_number":79,"context_line":"        grep -i denied /var/log/audit/audit* \u003e /var/log/extra/denials.txt"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    - name: Search for segfaults in logs"},{"line_number":82,"context_line":"      shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_0ccf5c29","side":"PARENT","line":79,"range":{"start_line":78,"start_character":8,"end_line":79,"end_character":46},"updated":"2020-04-20 07:26:58.000000000","message":"what was the purpose of that? anyone know? i see @zbr you have it as \u0027normal\u0027 i.e. no duplication on https://review.opendev.org/#/c/715927/2/defaults/main.yml@235","commit_id":"14649111bc2dd412d81064a6bdbd5f991197a9a8"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"fe3f37c44934a6341a25d4fdaa663cea1902a414","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    - name: Search for AVC denied"},{"line_number":77,"context_line":"      shell: \u003e"},{"line_number":78,"context_line":"        grep -i denied /var/log/audit/audit* \u0026\u0026"},{"line_number":79,"context_line":"        grep -i denied /var/log/audit/audit* \u003e /var/log/extra/denials.txt"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    - name: Search for segfaults in logs"},{"line_number":82,"context_line":"      shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f493fa4_39dd9b42","side":"PARENT","line":79,"range":{"start_line":78,"start_character":8,"end_line":79,"end_character":46},"in_reply_to":"3f4c43b2_0ccf5c29","updated":"2020-04-22 08:25:21.000000000","message":"TBH, I suppose this is either the result of a copy/paste error or someoene did not know to use\"tee\" in order to display and redirect the same console output.","commit_id":"14649111bc2dd412d81064a6bdbd5f991197a9a8"}]}