)]}'
{"infrared_plugin/main.yml":[{"author":{"_account_id":6683,"name":"Pavel Sedlák","email":"psedlak@redhat.com","username":"psedlak"},"change_message_id":"1a78210de46ad19f586a403fae1f8587f842a2e6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - name: Include collect lists typical for infrared deployments"},{"line_number":15,"context_line":"      include_vars:"},{"line_number":16,"context_line":"        file: ../vars/infrared-collect-exclude-list.yml"},{"line_number":17,"context_line":"      when: artcl_use_infrared_collect_lists | default(false) | bool"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Ansible role collect logs"},{"line_number":20,"context_line":"      include_role:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_573ef98a","line":17,"updated":"2020-04-09 22:05:59.000000000","message":"I\u0027m not sure if there is use case for the conditional inclusion under new variable.\n\nThere are few confusing things about this which lead me to feel it\u0027s likely wrong or not needed:\n\n- it\u0027s prefixed artcl, while it\u0027s not artcl property\n- with adoption of arctl and this plugin in IR workflows, there wont be any other ir collect logs anymore, THIS is the place with defaults then\n- if user wants customization, it should be (here in the ir plugin part) more aligned with existing IR approach, to be done in style of archive-custom param https://github.com/redhat-openstack/infrared/blob/master/plugins/collect-logs/plugin.spec#L21 (extending the \"sane\" always working default - the ir approach)\n\nAnd since there is already \u0027artcl_collect..append\u0027 opt, i believe all what is needed is to make sure it does get appended to list included here (may already be case) and that\u0027s all (as bonus point same for exclude? we dont use/needed that in IR but who knows since it seems heavily used with arctl?)","commit_id":"957757c19986f7b1a0dbf598cf308f4330ff6880"}],"vars/infrared-collect-exclude-list.yml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"060368175913ba38cc3e6036ad4b128368158dae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"artcl_collect_list:"},{"line_number":2,"context_line":"  - /etc/"},{"line_number":3,"context_line":"  - /etc/neutron"},{"line_number":4,"context_line":"  - /etc/tempest/saved_state.json"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_b36626ec","line":1,"updated":"2020-04-02 19:15:59.000000000","message":"linters: [warning] missing document start \"---\" (document-start)","commit_id":"c6ff809a0d846f0c529e66f54cdbedf63680ac7d"}]}