)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"ea95b21386b5e386c963fcd51727f29b777d73d0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sorin Sbarnea \u003cssbarnea@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-04-17 12:50:55 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow artcl to be run by Zuul"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Avoid implicit use of lookup env which breaks under Zuul CI"},{"line_number":10,"context_line":"- Add Zuul job that tests direct role usage and avoids regression."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1f493fa4_4988b070","line":7,"updated":"2020-04-21 09:14:24.000000000","message":"You mean run by zuul executor ?","commit_id":"d22b4dc24420a32df10457a216b727cd3963c20d"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"d0e80ffacf530bc18cf6c3c417f9d4a458e405e3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sorin Sbarnea \u003cssbarnea@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-04-17 12:50:55 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow artcl to be run by Zuul"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Avoid implicit use of lookup env which breaks under Zuul CI"},{"line_number":10,"context_line":"- Add Zuul job that tests direct role usage and avoids regression."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1f493fa4_a9133466","line":7,"in_reply_to":"1f493fa4_4988b070","updated":"2020-04-21 09:44:45.000000000","message":"Yep, most problems where caused by special security constraints related to Zuul executor. The good part is that these constraints do make sense, and they highlighted few\nshortcomings in current implementation.","commit_id":"d22b4dc24420a32df10457a216b727cd3963c20d"}],"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4cefcc17025288d61d7747bac60e30fd0cd2ef28","unresolved":false,"context_lines":[{"line_number":236,"context_line":"ara_enabled: true"},{"line_number":237,"context_line":"ara_overcloud_db_path: \"/var/lib/mistral/overcloud/ara_overcloud.sqlite\""},{"line_number":238,"context_line":"ara_generate_html: true"},{"line_number":239,"context_line":"ara_graphite_prefix: \"tripleo.{{ lookup(\u0027env\u0027, \u0027STABLE_RELEASE\u0027)|default(\u0027master\u0027, true) }}.{{ lookup(\u0027env\u0027, \u0027TOCI_JOBTYPE\u0027) }}.\""},{"line_number":240,"context_line":"ara_only_successful_tasks: true"},{"line_number":241,"context_line":"ara_tasks_map:"},{"line_number":242,"context_line":"  \"overcloud-deploy : Deploy the overcloud\": overcloud.deploy.seconds"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f4c43b2_3d5ec043","side":"PARENT","line":239,"range":{"start_line":239,"start_character":33,"end_line":239,"end_character":64},"updated":"2020-04-20 10:36:49.000000000","message":"Is it not possible to use {{ ansible_env.STABLE_RELEASE }} here?","commit_id":"b1d1684f0529f506659e2cf25c2af608e54909d1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4cefcc17025288d61d7747bac60e30fd0cd2ef28","unresolved":false,"context_lines":[{"line_number":236,"context_line":"ara_enabled: true"},{"line_number":237,"context_line":"ara_overcloud_db_path: \"/var/lib/mistral/overcloud/ara_overcloud.sqlite\""},{"line_number":238,"context_line":"ara_generate_html: true"},{"line_number":239,"context_line":"ara_graphite_prefix: \"tripleo.{{ lookup(\u0027env\u0027, \u0027STABLE_RELEASE\u0027)|default(\u0027master\u0027, true) }}.{{ lookup(\u0027env\u0027, \u0027TOCI_JOBTYPE\u0027) }}.\""},{"line_number":240,"context_line":"ara_only_successful_tasks: true"},{"line_number":241,"context_line":"ara_tasks_map:"},{"line_number":242,"context_line":"  \"overcloud-deploy : Deploy the overcloud\": overcloud.deploy.seconds"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f4c43b2_7d54c821","side":"PARENT","line":239,"range":{"start_line":239,"start_character":95,"end_line":239,"end_character":124},"updated":"2020-04-20 10:36:49.000000000","message":"Is it not possible to use {{ ansible_env.TOCI_JOBTYPE }} here?","commit_id":"b1d1684f0529f506659e2cf25c2af608e54909d1"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"a7881c5bd132c640ca36e0806a7351d734e0af66","unresolved":false,"context_lines":[{"line_number":236,"context_line":"ara_enabled: true"},{"line_number":237,"context_line":"ara_overcloud_db_path: \"/var/lib/mistral/overcloud/ara_overcloud.sqlite\""},{"line_number":238,"context_line":"ara_generate_html: true"},{"line_number":239,"context_line":"ara_graphite_prefix: \"tripleo.{{ lookup(\u0027env\u0027, \u0027STABLE_RELEASE\u0027)|default(\u0027master\u0027, true) }}.{{ lookup(\u0027env\u0027, \u0027TOCI_JOBTYPE\u0027) }}.\""},{"line_number":240,"context_line":"ara_only_successful_tasks: true"},{"line_number":241,"context_line":"ara_tasks_map:"},{"line_number":242,"context_line":"  \"overcloud-deploy : Deploy the overcloud\": overcloud.deploy.seconds"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f4c43b2_dd1b5c7e","side":"PARENT","line":239,"range":{"start_line":239,"start_character":33,"end_line":239,"end_character":64},"in_reply_to":"3f4c43b2_3d5ec043","updated":"2020-04-20 11:31:41.000000000","message":"Nope, I asked infra and they said the same,","commit_id":"b1d1684f0529f506659e2cf25c2af608e54909d1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4cefcc17025288d61d7747bac60e30fd0cd2ef28","unresolved":false,"context_lines":[{"line_number":261,"context_line":"influxdb_user:"},{"line_number":262,"context_line":"influxdb_password:"},{"line_number":263,"context_line":"influxdb_dbname: testdb"},{"line_number":264,"context_line":"influxdb_data_file_path: \"{{ lookup(\u0027env\u0027, \u0027LOCAL_WORKING_DIR\u0027)|default(\u0027/tmp\u0027, true) }}/influxdb_data\""},{"line_number":265,"context_line":"influxdb_create_data_file: true"},{"line_number":266,"context_line":"odl_extra_log_dir: /var/log/extra/odl"},{"line_number":267,"context_line":"odl_extra_info_log: \"{{ odl_extra_log_dir }}/odl_info.log\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f4c43b2_dd323c10","side":"PARENT","line":264,"range":{"start_line":264,"start_character":29,"end_line":264,"end_character":63},"updated":"2020-04-20 10:36:49.000000000","message":"Is it not possible to use {{ ansible_env.LOCAL_WORKING_DIR }} here?","commit_id":"b1d1684f0529f506659e2cf25c2af608e54909d1"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"316e89fb8924eee1b12c796e2762ad2f7d73cab2","unresolved":false,"context_lines":[{"line_number":261,"context_line":"influxdb_user:"},{"line_number":262,"context_line":"influxdb_password:"},{"line_number":263,"context_line":"influxdb_dbname: testdb"},{"line_number":264,"context_line":"influxdb_data_file_path: \"{{ lookup(\u0027env\u0027, \u0027LOCAL_WORKING_DIR\u0027)|default(\u0027/tmp\u0027, true) }}/influxdb_data\""},{"line_number":265,"context_line":"influxdb_create_data_file: true"},{"line_number":266,"context_line":"odl_extra_log_dir: /var/log/extra/odl"},{"line_number":267,"context_line":"odl_extra_info_log: \"{{ odl_extra_log_dir }}/odl_info.log\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f493fa4_ce6fa690","side":"PARENT","line":264,"range":{"start_line":264,"start_character":29,"end_line":264,"end_character":63},"in_reply_to":"3f4c43b2_dd323c10","updated":"2020-04-21 08:01:27.000000000","message":"ditto","commit_id":"b1d1684f0529f506659e2cf25c2af608e54909d1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4cefcc17025288d61d7747bac60e30fd0cd2ef28","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# formally in tq common and tqe extras-common"},{"line_number":3,"context_line":"# zuul does not allow use of lookup env plugin (security), so we cannot use them"},{"line_number":4,"context_line":"# defaults but we can load non-zuul values from vars."},{"line_number":5,"context_line":"local_working_dir: \"{{ zuul_work_dir | default(\u0027~\u0027) }}/.quickstart\""},{"line_number":6,"context_line":"artcl_collect_dir: \"{{ local_working_dir }}/collected_files\""},{"line_number":7,"context_line":"working_dir: \"/home/{{ undercloud_user }}\""},{"line_number":8,"context_line":"undercloud_user: stack"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f4c43b2_9d7ef4ac","line":5,"range":{"start_line":5,"start_character":23,"end_line":5,"end_character":51},"updated":"2020-04-20 10:36:49.000000000","message":"Is it not possible to use {{ ansible_env.HOME }} here?","commit_id":"d22b4dc24420a32df10457a216b727cd3963c20d"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"a7881c5bd132c640ca36e0806a7351d734e0af66","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# formally in tq common and tqe extras-common"},{"line_number":3,"context_line":"# zuul does not allow use of lookup env plugin (security), so we cannot use them"},{"line_number":4,"context_line":"# defaults but we can load non-zuul values from vars."},{"line_number":5,"context_line":"local_working_dir: \"{{ zuul_work_dir | default(\u0027~\u0027) }}/.quickstart\""},{"line_number":6,"context_line":"artcl_collect_dir: \"{{ local_working_dir }}/collected_files\""},{"line_number":7,"context_line":"working_dir: \"/home/{{ undercloud_user }}\""},{"line_number":8,"context_line":"undercloud_user: stack"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f4c43b2_78ee96b4","line":5,"range":{"start_line":5,"start_character":23,"end_line":5,"end_character":51},"in_reply_to":"3f4c43b2_9d7ef4ac","updated":"2020-04-20 11:31:41.000000000","message":"I rememeber asking on #zuul about this and decided not to do it but after doing an experiment, it seems to work: https://zuul.opendev.org/t/openstack/build/4bb0bce14a6340e0b861959b6c46aaa9/console\n\n\nI am sure that only some variables are listed because is likely that some could contain secrets.\n\nI will double check with zuul cores to see what is the optimal way to address this.\n\nIf we can avoid the hack orloading unsecure.yml it would be great.","commit_id":"d22b4dc24420a32df10457a216b727cd3963c20d"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"316e89fb8924eee1b12c796e2762ad2f7d73cab2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# formally in tq common and tqe extras-common"},{"line_number":3,"context_line":"# zuul does not allow use of lookup env plugin (security), so we cannot use them"},{"line_number":4,"context_line":"# defaults but we can load non-zuul values from vars."},{"line_number":5,"context_line":"local_working_dir: \"{{ zuul_work_dir | default(\u0027~\u0027) }}/.quickstart\""},{"line_number":6,"context_line":"artcl_collect_dir: \"{{ local_working_dir }}/collected_files\""},{"line_number":7,"context_line":"working_dir: \"/home/{{ undercloud_user }}\""},{"line_number":8,"context_line":"undercloud_user: stack"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f493fa4_0e518ed9","line":5,"range":{"start_line":5,"start_character":23,"end_line":5,"end_character":51},"in_reply_to":"3f4c43b2_9d7ef4ac","updated":"2020-04-21 08:01:27.000000000","message":"ansible_env related to remote, not controller, and can also be undefined if gather facts did not run. We already experimented it and ruled it out via https://review.opendev.org/#/c/721253/","commit_id":"d22b4dc24420a32df10457a216b727cd3963c20d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4cefcc17025288d61d7747bac60e30fd0cd2ef28","unresolved":false,"context_lines":[{"line_number":153,"context_line":"# give up log upload after 30 minutes"},{"line_number":154,"context_line":"artcl_publish_timeout: 1800"},{"line_number":155,"context_line":"artcl_artifact_url: \"file://{{ local_working_dir }}\""},{"line_number":156,"context_line":"artcl_full_artifact_url: \"{{ artcl_artifact_url }}/{{ artcl_build_tag }}/\""},{"line_number":157,"context_line":"artcl_use_rsync: false"},{"line_number":158,"context_line":"artcl_rsync_use_daemon: false"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f4c43b2_dd4d1c9b","line":156,"range":{"start_line":156,"start_character":54,"end_line":156,"end_character":69},"updated":"2020-04-20 10:36:49.000000000","message":"Is it not possible to use {{ ansible_env.BUILD_TAG }} here?","commit_id":"d22b4dc24420a32df10457a216b727cd3963c20d"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"316e89fb8924eee1b12c796e2762ad2f7d73cab2","unresolved":false,"context_lines":[{"line_number":153,"context_line":"# give up log upload after 30 minutes"},{"line_number":154,"context_line":"artcl_publish_timeout: 1800"},{"line_number":155,"context_line":"artcl_artifact_url: \"file://{{ local_working_dir }}\""},{"line_number":156,"context_line":"artcl_full_artifact_url: \"{{ artcl_artifact_url }}/{{ artcl_build_tag }}/\""},{"line_number":157,"context_line":"artcl_use_rsync: false"},{"line_number":158,"context_line":"artcl_rsync_use_daemon: false"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f493fa4_8e5e3ee4","line":156,"range":{"start_line":156,"start_character":54,"end_line":156,"end_character":69},"in_reply_to":"3f4c43b2_dd4d1c9b","updated":"2020-04-21 08:01:27.000000000","message":"ditto","commit_id":"d22b4dc24420a32df10457a216b727cd3963c20d"}],"playbooks/empty.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"385037dc8bb17ca6cb3d68378e34f00b00266ec6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- host: all"},{"line_number":2,"context_line":"  tasks:"},{"line_number":3,"context_line":"    - debug:"},{"line_number":4,"context_line":"        msg: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4c43b2_0314979f","line":1,"updated":"2020-04-15 10:36:26.000000000","message":"linters: [warning] missing document start \"---\" (document-start)","commit_id":"4309ae9784523b51e46a903dd0e01f141e025f56"}],"tasks/main.yml":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"05cbfce71b12f5f4a6295e9a2eaaf451493e909b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Load unsecure.yml defaults when outside zuul"},{"line_number":8,"context_line":"  when: zuul is not defined"},{"line_number":9,"context_line":"  include_vars: unsecure.yml"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Load operating system specific variables"},{"line_number":12,"context_line":"  include_vars: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f4c43b2_35defb3e","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":28},"updated":"2020-04-17 11:41:05.000000000","message":"Any idea if we should use a different name for this file?\n\nThis needs to be loaded on any call that is outside zuul, mainly because it contains env lookups which are forbidden under zuul.","commit_id":"c4dd6fa67e3f20a88a12e698a30b96f34dc8a74e"}],"tasks/publish.yml":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b31ef8604b934627770446f2eb665c5e0670b172","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    \u003e {{ artcl_collect_dir }}/console.log"},{"line_number":17,"context_line":"  args:"},{"line_number":18,"context_line":"    executable: /bin/bash"},{"line_number":19,"context_line":"  when: artcl_build_url"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- include: sova.yml"},{"line_number":22,"context_line":"  ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f493fa4_4869b2bc","line":19,"range":{"start_line":19,"start_character":2,"end_line":19,"end_character":23},"updated":"2020-04-22 10:05:02.000000000","message":"Is the condition correct? The url contains false in case of zuul an a string otherwise ... I got the following error:\n\nTASK [ansible-role-collect-logs : Fetch console log] ***************************\ntask path: /home/rhos-ci/staging/workspace/DFG-dci-refstack-15_director-rhel-virthost-1cont_1comp-ipv4-geneve/infrared/plugins/ansible-role-collect-logs/tasks/publish.yml:12\nWednesday 22 April 2020  09:38:29 +0000 (0:00:00.666)       0:14:53.423 ******* \nfatal: [localhost]: FAILED! \u003d\u003e {}\n\nMSG:\n\nThe conditional check \u0027artcl_build_url\u0027 failed. The error was: Invalid conditional detected: invalid syntax (\u003cunknown\u003e, line 1)\n\nThe error appears to have been in \u0027/home/rhos-ci/staging/workspace/DFG-dci-refstack-15_director-rhel-virthost-1cont_1comp-ipv4-geneve/infrared/plugins/ansible-role-collect-logs/tasks/publish.yml\u0027: line 12, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Fetch console log\n  ^ here","commit_id":"d22b4dc24420a32df10457a216b727cd3963c20d"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"5ffc0f02f7e245d98a9777d5dbfb877350dd0d8b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    \u003e {{ artcl_collect_dir }}/console.log"},{"line_number":17,"context_line":"  args:"},{"line_number":18,"context_line":"    executable: /bin/bash"},{"line_number":19,"context_line":"  when: artcl_build_url"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- include: sova.yml"},{"line_number":22,"context_line":"  ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f493fa4_41218d4d","line":19,"range":{"start_line":19,"start_character":2,"end_line":19,"end_character":23},"in_reply_to":"1f493fa4_4869b2bc","updated":"2020-04-22 12:31:12.000000000","message":"Thanks! You really found a serious bug, i am uploading fix now.","commit_id":"d22b4dc24420a32df10457a216b727cd3963c20d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e4cbf272e4476a1b2c2daeb87de588cfb3ed4d8f","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"- name: upload to the artifact server using password auth"},{"line_number":112,"context_line":"  environment:"},{"line_number":113,"context_line":"    RSYNC_PASSWORD: \"{{ artcl_rsync_password | default(omit) }}\""},{"line_number":114,"context_line":"  shell: rsync -av --quiet {{ artcl_collect_dir }}/ {{ artcl_rsync_path }}/{{ artcl_build_tag }}  # noqa 305"},{"line_number":115,"context_line":"  async: \"{{ artcl_publish_timeout }}\""},{"line_number":116,"context_line":"  poll: 15"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f493fa4_8e5bde2c","line":113,"range":{"start_line":113,"start_character":24,"end_line":113,"end_character":44},"updated":"2020-04-21 07:40:17.000000000","message":"so if this *is* a zuul env where are we setting that one ie. not loaded from unsecure... does it come in via job vars or secrets?","commit_id":"d22b4dc24420a32df10457a216b727cd3963c20d"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"316e89fb8924eee1b12c796e2762ad2f7d73cab2","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"- name: upload to the artifact server using password auth"},{"line_number":112,"context_line":"  environment:"},{"line_number":113,"context_line":"    RSYNC_PASSWORD: \"{{ artcl_rsync_password | default(omit) }}\""},{"line_number":114,"context_line":"  shell: rsync -av --quiet {{ artcl_collect_dir }}/ {{ artcl_rsync_path }}/{{ artcl_build_tag }}  # noqa 305"},{"line_number":115,"context_line":"  async: \"{{ artcl_publish_timeout }}\""},{"line_number":116,"context_line":"  poll: 15"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f493fa4_0ebcee03","line":113,"range":{"start_line":113,"start_character":24,"end_line":113,"end_character":44},"in_reply_to":"1f493fa4_8e5bde2c","updated":"2020-04-21 08:01:27.000000000","message":"At this moment this feature is not used under zuul as use of rsync password is something of downstream-legacy. Yep, using secrets when under zuul could be a better way but it would be outside the scope of current change.\n\nTo reiterate: \"publish\" does not run when tested via zuul, only collect runs ATM. This change does not change behaviour or running code, only assures we do not accidentaly perform a lookup outside the unsecure.yml file.\n\nTBH, I do not support the use of RSYNC_PASSWORD in any way but changing this, is outside this CR scope.","commit_id":"d22b4dc24420a32df10457a216b727cd3963c20d"}],"test-playbooks/zuul-ansible-role-collect-logs.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"79b57de298b975694923818fadc968bcf7e705b2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  tasks:"},{"line_number":4,"context_line":"    - name: include ansible-role-collect-logs role"},{"line_number":5,"context_line":"      include_role:"},{"line_number":6,"context_line":"        name: collect-logs"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f493fa4_36513cda","line":6,"updated":"2020-04-21 12:55:23.000000000","message":"If vars are added here, the role can run as-is by implementing override vars.\n\nFor example:\n\n---\n- hosts: all\n  tasks:\n    - name: include ansible-role-collect-logs role\n      include_role:\n        name: collect-logs\n      vars:\n        influxdb_data_file_path: \"{{ zuul_work_dir | default(\u0027~\u0027) }}/.quickstart/influxdb_data\"","commit_id":"d22b4dc24420a32df10457a216b727cd3963c20d"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"f3456d61cbc82a0d3680871bbf853b4da2d081f3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  tasks:"},{"line_number":4,"context_line":"    - name: include ansible-role-collect-logs role"},{"line_number":5,"context_line":"      include_role:"},{"line_number":6,"context_line":"        name: collect-logs"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f493fa4_9619308a","line":6,"in_reply_to":"1f493fa4_36513cda","updated":"2020-04-21 13:24:02.000000000","message":"This is likely true but the scope is not to make the role work under Zuul when called with extra variables, is to make it work without extra-hacks.\n\nIn fact, I plan to add extra tests here (in the future) to provide a better coverage. The rule is simple: whatever bug we find and fix, we need to add a minimal test to avoid regression.","commit_id":"d22b4dc24420a32df10457a216b727cd3963c20d"}],"zuul.d/layout.yaml":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"05cbfce71b12f5f4a6295e9a2eaaf451493e909b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      jobs:"},{"line_number":16,"context_line":"        - openstack-tox-linters"},{"line_number":17,"context_line":"        - openstack-tox-molecule"},{"line_number":18,"context_line":"        - zuul-ansible-role-collect-logs"},{"line_number":19,"context_line":"    gate:"},{"line_number":20,"context_line":"      jobs:"},{"line_number":21,"context_line":"        - openstack-tox-linters"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4c43b2_c3910f9c","line":18,"updated":"2020-04-17 11:41:05.000000000","message":"h","commit_id":"0204eba8a3741ccf6e599a2cbcd9d49bcf8fdb1c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"08981b0e51db37ac367f902a1a6aba9f048cf78d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"        - openstack-tox-linters"},{"line_number":19,"context_line":"        - openstack-tox-molecule"},{"line_number":20,"context_line":"        - zuul-ansible-role-collect-logs"},{"line_number":21,"context_line":"    gate:"},{"line_number":22,"context_line":"      jobs:"},{"line_number":23,"context_line":"        - openstack-tox-linters"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f493fa4_558b901d","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":40},"updated":"2020-04-28 07:21:13.000000000","message":"its voting so why not in gate too","commit_id":"75de37a73becbe89f9c40905365bd9541fdf0476"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"223e74e22cba1d77be6b615cabfd93b942a01292","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"        - openstack-tox-linters"},{"line_number":19,"context_line":"        - openstack-tox-molecule"},{"line_number":20,"context_line":"        - zuul-ansible-role-collect-logs"},{"line_number":21,"context_line":"    gate:"},{"line_number":22,"context_line":"      jobs:"},{"line_number":23,"context_line":"        - openstack-tox-linters"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f493fa4_370b312a","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":40},"in_reply_to":"1f493fa4_17dc3544","updated":"2020-04-30 07:56:57.000000000","message":"I fixed that on rebase, now is included in the gate.","commit_id":"75de37a73becbe89f9c40905365bd9541fdf0476"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"f7db487e7217baaf2e571b8a463363b9c53dd809","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"        - openstack-tox-linters"},{"line_number":19,"context_line":"        - openstack-tox-molecule"},{"line_number":20,"context_line":"        - zuul-ansible-role-collect-logs"},{"line_number":21,"context_line":"    gate:"},{"line_number":22,"context_line":"      jobs:"},{"line_number":23,"context_line":"        - openstack-tox-linters"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f493fa4_5786d4ba","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":40},"in_reply_to":"1f493fa4_558b901d","updated":"2020-04-29 11:31:01.000000000","message":"Because is too new, we better run it in check for a while before using in gate.","commit_id":"75de37a73becbe89f9c40905365bd9541fdf0476"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"57071be20c040df3a60312cd9ad1503779d945be","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"        - openstack-tox-linters"},{"line_number":19,"context_line":"        - openstack-tox-molecule"},{"line_number":20,"context_line":"        - zuul-ansible-role-collect-logs"},{"line_number":21,"context_line":"    gate:"},{"line_number":22,"context_line":"      jobs:"},{"line_number":23,"context_line":"        - openstack-tox-linters"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f493fa4_17dc3544","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":40},"in_reply_to":"1f493fa4_5786d4ba","updated":"2020-04-30 07:44:56.000000000","message":"as long as we don\u0027t forget/do it asap maybe 1/2 days is enough... so we don\u0027t break the gate","commit_id":"75de37a73becbe89f9c40905365bd9541fdf0476"}]}