)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"eae131cad8d00449b7698d229da3337d27ed83b9","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix extra/podman/containers sometimes missing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is bug that sometimes /var/log/extra/podman/containers"},{"line_number":10,"context_line":"is completely missing for some nodes (while it may be there for others)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It\u0027s caused by timing of parallel-container-log-generation+sync"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9edc7e7f_1b056abd","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":12},"updated":"2020-11-26 15:47:18.000000000","message":"if we have an actual bug can you please add a link to it in the commit message thanks","commit_id":"21bd993e196883b26152caeec0c36595d07435d7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b6dad78b0b10625fd44d3d0b6fade871b49a55bf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix extra/podman/containers sometimes missing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is bug that sometimes /var/log/extra/podman/containers"},{"line_number":10,"context_line":"is completely missing for some nodes (while it may be there for others)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It\u0027s caused by timing of parallel-container-log-generation+sync"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"294ad500_aa9f8d91","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":12},"in_reply_to":"9edc7e7f_1b056abd","updated":"2020-11-27 17:04:41.000000000","message":"Sure, it happens only downstream, but I created a bug upstream too for future reference.","commit_id":"21bd993e196883b26152caeec0c36595d07435d7"}],"tasks/collect.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"eae131cad8d00449b7698d229da3337d27ed83b9","unresolved":true,"context_lines":[{"line_number":100,"context_line":"  retries: 60"},{"line_number":101,"context_line":"  when: \"\u0027container\u0027 in collect_log_types\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# All log-generating/dumping steps need to finish before this step"},{"line_number":104,"context_line":"# or those files will not be found and so ignored during collection step"},{"line_number":105,"context_line":"- name: Create find list file"},{"line_number":106,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9c9f1f47_ac9030f4","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":2},"updated":"2020-11-26 15:47:18.000000000","message":"just minor note . this comment might be confusing ... would be better to put something above the wait for container logs task like \"make sure all logs are done before generating find list\" or something...","commit_id":"21bd993e196883b26152caeec0c36595d07435d7"},{"author":{"_account_id":6683,"name":"Pavel Sedlák","email":"psedlak@redhat.com","username":"psedlak"},"change_message_id":"91df4bd971691692d3591ad870a13b75f9f67656","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  retries: 60"},{"line_number":101,"context_line":"  when: \"\u0027container\u0027 in collect_log_types\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# All log-generating/dumping steps need to finish before this step"},{"line_number":104,"context_line":"# or those files will not be found and so ignored during collection step"},{"line_number":105,"context_line":"- name: Create find list file"},{"line_number":106,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f22cc2ae_7329ba54","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":2},"in_reply_to":"58d8b712_17533b94","updated":"2020-11-30 13:19:26.000000000","message":"\u0027wait for container logs collection if not finished yet\u0027 already says that in the task name, i do not think there is additional comment there saying the same needed.\n\nconfusing how - it just highlights that \u0027this is the point when all desired logs are expected to exist already\u0027 - as that may not be obvious (one could expect rsync step is where the files should exist - hence we got this bug), maybe it should be reworded ... to shorter version like\n\n# ALL LOG FILES EXPECT TO EXIST BEFORE THIS POINT\n?","commit_id":"21bd993e196883b26152caeec0c36595d07435d7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b6dad78b0b10625fd44d3d0b6fade871b49a55bf","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  retries: 60"},{"line_number":101,"context_line":"  when: \"\u0027container\u0027 in collect_log_types\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# All log-generating/dumping steps need to finish before this step"},{"line_number":104,"context_line":"# or those files will not be found and so ignored during collection step"},{"line_number":105,"context_line":"- name: Create find list file"},{"line_number":106,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"58d8b712_17533b94","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":2},"in_reply_to":"9c9f1f47_ac9030f4","updated":"2020-11-27 17:04:41.000000000","message":"makes sense, thanks","commit_id":"21bd993e196883b26152caeec0c36595d07435d7"}]}