)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"233728255f4526621964d3ee29e3d8d9d9ad2f03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"765d5ba2_103a0f69","updated":"2022-05-24 12:25:17.000000000","message":"A testproject is here: https://review.rdoproject.org/r/c/testproject/+/43106\n\nit\u0027s a small one, but it should allow to spot any weird things.","commit_id":"2d5055cb50954b6fe5a3695d0bcf259dfe93b442"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"67d2221ea57f3c0623796bbee61c0e1b85c5dd89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3151c9d2_be127d2c","updated":"2022-05-24 12:29:53.000000000","message":"check-rdo","commit_id":"2d5055cb50954b6fe5a3695d0bcf259dfe93b442"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"08a3aa6b1a63780f3df26a975f3966364075befd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"08d720e9_8b2d68cc","updated":"2022-05-31 08:45:53.000000000","message":"for context revoted because 3rd party looks good @ 11:44 \u003c marios|ruck\u003e https://logserver.rdoproject.org/35/843135/3/openstack-check/tripleo-ci-centos-9-ovb-1ctlr_1comp-featureset001/9c0e8e8/logs/undercloud/var/log/extra/nftables.txt.gz \n","commit_id":"ea02074571b11039a3a369086889d6743df3403e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3ea52641fb1ff2bb40df2f31bcddd49e97edb130","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7a54b640_066e7441","updated":"2022-05-31 07:12:43.000000000","message":"looks fine - waiting on sanity check/3rd party zuul to report","commit_id":"ea02074571b11039a3a369086889d6743df3403e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"90def3928ab4bfeea0437fce06bdb7bf13f96f0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"323d9af3_67702ac2","in_reply_to":"08d720e9_8b2d68cc","updated":"2022-05-31 09:05:01.000000000","message":"Thanks Marios for adding the links.","commit_id":"ea02074571b11039a3a369086889d6743df3403e"}],"roles/collect_logs/tasks/collect/network.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"408f5514b313dd553fb378c854da2f96e5790576","unresolved":true,"context_lines":[{"line_number":23,"context_line":"            test $ipv -eq 6 \u0026\u0026 ip6tables -vnL \u0026\u003e\u003e /var/log/extra/network.txt;"},{"line_number":24,"context_line":"          fi"},{"line_number":25,"context_line":"        done;"},{"line_number":26,"context_line":"        command -v nft \u0026\u0026 nft list ruleset \u0026\u003e/var/log/extra/nftables.txt"},{"line_number":27,"context_line":"        (for NS in $(ip netns list | cut -f 1 -d \" \"); do"},{"line_number":28,"context_line":"          for ipv in 4 6; do"},{"line_number":29,"context_line":"            echo \"\u003d\u003d\u003d\u003d $NS (${ipv})\u003d\u003d\u003d\u003d\";"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1cd1d776_9f68bb58","line":26,"range":{"start_line":26,"start_character":69,"end_line":26,"end_character":72},"updated":"2022-05-31 06:12:13.000000000","message":"It should be like this.\ncommand -v nft \u0026\u0026 nft list ruleset \u0026\u003e/var/log/extra/nftables.txt;","commit_id":"6e5d610f983a3ad5f1c0058dbdfbf0e0161d531e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"408f5514b313dd553fb378c854da2f96e5790576","unresolved":true,"context_lines":[{"line_number":23,"context_line":"            test $ipv -eq 6 \u0026\u0026 ip6tables -vnL \u0026\u003e\u003e /var/log/extra/network.txt;"},{"line_number":24,"context_line":"          fi"},{"line_number":25,"context_line":"        done;"},{"line_number":26,"context_line":"        command -v nft \u0026\u0026 nft list ruleset \u0026\u003e/var/log/extra/nftables.txt"},{"line_number":27,"context_line":"        (for NS in $(ip netns list | cut -f 1 -d \" \"); do"},{"line_number":28,"context_line":"          for ipv in 4 6; do"},{"line_number":29,"context_line":"            echo \"\u003d\u003d\u003d\u003d $NS (${ipv})\u003d\u003d\u003d\u003d\";"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7d7b2907_dd36dd3e","line":26,"updated":"2022-05-31 06:12:13.000000000","message":"https://logserver.rdoproject.org/35/843135/2/openstack-check/tripleo-ci-centos-9-ovb-1ctlr_1comp-featureset001/1b2f0e0/logs/undercloud/home/zuul/workspace/logs/quickstart_collect_logs.log.txt.gz\n\n```\n \"stderr\": \"/bin/sh: -c: line 14: syntax error near unexpected token `(\u0027\\n/bin/sh: -c: line 14: `done; command -v nft \u0026\u0026 nft list ruleset \u0026\u003e/var/log/extra/nftables.txt (for NS in $(ip netns list | cut -f 1 -d \\\" \\\"); do\u0027\",\n    \"stderr_lines\": [\n        \"/bin/sh: -c: line 14: syntax error near unexpected token `(\u0027\",\n        \"/bin/sh: -c: line 14: `done; command -v nft \u0026\u0026 nft list ruleset \u0026\u003e/var/log/extra/nftables.txt (for NS in $(ip netns list | cut -f 1 -d \\\" \\\"); do\u0027\"\n    ],\n    \"stdout\": \"\",\n```","commit_id":"6e5d610f983a3ad5f1c0058dbdfbf0e0161d531e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"a5b3f0726cf1bcae53f994eceb9089d0ff9f8058","unresolved":false,"context_lines":[{"line_number":23,"context_line":"            test $ipv -eq 6 \u0026\u0026 ip6tables -vnL \u0026\u003e\u003e /var/log/extra/network.txt;"},{"line_number":24,"context_line":"          fi"},{"line_number":25,"context_line":"        done;"},{"line_number":26,"context_line":"        command -v nft \u0026\u0026 nft list ruleset \u0026\u003e/var/log/extra/nftables.txt"},{"line_number":27,"context_line":"        (for NS in $(ip netns list | cut -f 1 -d \" \"); do"},{"line_number":28,"context_line":"          for ipv in 4 6; do"},{"line_number":29,"context_line":"            echo \"\u003d\u003d\u003d\u003d $NS (${ipv})\u003d\u003d\u003d\u003d\";"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"edd0369c_847c323b","line":26,"range":{"start_line":26,"start_character":69,"end_line":26,"end_character":72},"in_reply_to":"1cd1d776_9f68bb58","updated":"2022-05-31 06:13:50.000000000","message":"Aw dang... thanks!","commit_id":"6e5d610f983a3ad5f1c0058dbdfbf0e0161d531e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"a5b3f0726cf1bcae53f994eceb9089d0ff9f8058","unresolved":false,"context_lines":[{"line_number":23,"context_line":"            test $ipv -eq 6 \u0026\u0026 ip6tables -vnL \u0026\u003e\u003e /var/log/extra/network.txt;"},{"line_number":24,"context_line":"          fi"},{"line_number":25,"context_line":"        done;"},{"line_number":26,"context_line":"        command -v nft \u0026\u0026 nft list ruleset \u0026\u003e/var/log/extra/nftables.txt"},{"line_number":27,"context_line":"        (for NS in $(ip netns list | cut -f 1 -d \" \"); do"},{"line_number":28,"context_line":"          for ipv in 4 6; do"},{"line_number":29,"context_line":"            echo \"\u003d\u003d\u003d\u003d $NS (${ipv})\u003d\u003d\u003d\u003d\";"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a2973de7_625faeca","line":26,"in_reply_to":"7d7b2907_dd36dd3e","updated":"2022-05-31 06:13:50.000000000","message":"Done","commit_id":"6e5d610f983a3ad5f1c0058dbdfbf0e0161d531e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3ea52641fb1ff2bb40df2f31bcddd49e97edb130","unresolved":false,"context_lines":[{"line_number":14,"context_line":"          ip -${ipv} a \u0026\u003e\u003e /var/log/extra/network.txt;"},{"line_number":15,"context_line":"          echo \"### IPv${ipv} routing\" \u003e\u003e /var/log/extra/network.txt;"},{"line_number":16,"context_line":"          ip -${ipv} r \u0026\u003e\u003e /var/log/extra/network.txt;"},{"line_number":17,"context_line":"          if [[ ! $(command -v nft) ]]; then"},{"line_number":18,"context_line":"            echo \"### IPTables (IPv${ipv})\" \u0026\u003e\u003e /var/log/extra/network.txt;"},{"line_number":19,"context_line":"            test $ipv -eq 4 \u0026\u0026 iptables-save \u0026\u003e\u003e /var/log/extra/network.txt;"},{"line_number":20,"context_line":"            test $ipv -eq 6 \u0026\u0026 ip6tables-save \u0026\u003e\u003e /var/log/extra/network.txt;"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"81f05297_c5ac92fe","line":17,"updated":"2022-05-31 07:12:43.000000000","message":"k would be nice if we could move this conditional outside the loop so it is only evaluated once but cant quickly sort it in my head ;)","commit_id":"ea02074571b11039a3a369086889d6743df3403e"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"29b50d37826c2cd07c869efa38f8d78b4dad2f5a","unresolved":true,"context_lines":[{"line_number":14,"context_line":"          ip -${ipv} a \u0026\u003e\u003e /var/log/extra/network.txt;"},{"line_number":15,"context_line":"          echo \"### IPv${ipv} routing\" \u003e\u003e /var/log/extra/network.txt;"},{"line_number":16,"context_line":"          ip -${ipv} r \u0026\u003e\u003e /var/log/extra/network.txt;"},{"line_number":17,"context_line":"          if [[ ! $(command -v nft) ]]; then"},{"line_number":18,"context_line":"            echo \"### IPTables (IPv${ipv})\" \u0026\u003e\u003e /var/log/extra/network.txt;"},{"line_number":19,"context_line":"            test $ipv -eq 4 \u0026\u0026 iptables-save \u0026\u003e\u003e /var/log/extra/network.txt;"},{"line_number":20,"context_line":"            test $ipv -eq 6 \u0026\u0026 ip6tables-save \u0026\u003e\u003e /var/log/extra/network.txt;"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fc2b21d_c0dd31f1","line":17,"in_reply_to":"81f05297_c5ac92fe","updated":"2022-05-31 08:40:14.000000000","message":"We can\u0027t, unless we split the loop in 2 in order to get the \"ip -4|-6\" data in a dedicated one, and a second one, if we don\u0027t have iptables.\n\nHere, we have a 2-elements loop, I\u0027m not 100% sure about any actual improvements.. ?","commit_id":"ea02074571b11039a3a369086889d6743df3403e"}]}