)]}'
{"tasks/docker-login.yml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5ffcf38ec4289cfa11011c470cc8b2747d0435fb","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: perform docker login"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  shell: docker login --username\u003d$DOCKER_USER --password\u003d$DOCKER_PASSWORD $DOCKER_REGISTRY"},{"line_number":6,"context_line":"  environment:"},{"line_number":7,"context_line":"    DOCKER_USER: \"{{ item.username }}\""},{"line_number":8,"context_line":"    DOCKER_PASSWORD: \"{{ item.password }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_ea7c9521","line":5,"updated":"2019-06-20 16:59:33.000000000","message":"why not using https://docs.ansible.com/ansible/latest/modules/docker_login_module.html ?","commit_id":"6272bf12b942db4b0faed0d0e42ef48cf72e7c02"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a692e06906b1bd2be332f3df7a3ea76682140ec1","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: perform docker login"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  shell: docker login --username\u003d$DOCKER_USER --password\u003d$DOCKER_PASSWORD $DOCKER_REGISTRY"},{"line_number":6,"context_line":"  environment:"},{"line_number":7,"context_line":"    DOCKER_USER: \"{{ item.username }}\""},{"line_number":8,"context_line":"    DOCKER_PASSWORD: \"{{ item.password }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_ba557952","line":5,"in_reply_to":"9fb8cfa7_50055079","updated":"2019-06-21 15:28:01.000000000","message":"Yes you\u0027re right: https://review.opendev.org/#/c/651005/2/tripleo_common/image/image_uploader.py\n\nI was more talking of any user of this role outside of TripleO. I won\u0027t block it, I was just wondering if we consider them as well for this feature.","commit_id":"6272bf12b942db4b0faed0d0e42ef48cf72e7c02"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b5bf1d3a4991ee54d6b483b9f58b87800d4f278c","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: perform docker login"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  shell: docker login --username\u003d$DOCKER_USER --password\u003d$DOCKER_PASSWORD $DOCKER_REGISTRY"},{"line_number":6,"context_line":"  environment:"},{"line_number":7,"context_line":"    DOCKER_USER: \"{{ item.username }}\""},{"line_number":8,"context_line":"    DOCKER_PASSWORD: \"{{ item.password }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_50055079","line":5,"in_reply_to":"9fb8cfa7_aad9bd22","updated":"2019-06-20 19:17:02.000000000","message":"I thought auth was already handled elsewhere for skopeo and the tripleo bits.  Guess we should ask steve what he actually implemented","commit_id":"6272bf12b942db4b0faed0d0e42ef48cf72e7c02"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"24fb7c795aaafc5a5baad8e6f78c8b34c379fb3f","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: perform docker login"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  shell: docker login --username\u003d$DOCKER_USER --password\u003d$DOCKER_PASSWORD $DOCKER_REGISTRY"},{"line_number":6,"context_line":"  environment:"},{"line_number":7,"context_line":"    DOCKER_USER: \"{{ item.username }}\""},{"line_number":8,"context_line":"    DOCKER_PASSWORD: \"{{ item.password }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_aad9bd22","line":5,"in_reply_to":"9fb8cfa7_cabf51a8","updated":"2019-06-20 17:06:11.000000000","message":"actually... we would need some podman login support as well, but there is no module yet I think so shell might be ok if we use {{ container_cli }}","commit_id":"6272bf12b942db4b0faed0d0e42ef48cf72e7c02"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7ab168b459513e3d6564f214ff447bab0dd5dc8e","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: perform docker login"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  shell: docker login --username\u003d$DOCKER_USER --password\u003d$DOCKER_PASSWORD $DOCKER_REGISTRY"},{"line_number":6,"context_line":"  environment:"},{"line_number":7,"context_line":"    DOCKER_USER: \"{{ item.username }}\""},{"line_number":8,"context_line":"    DOCKER_PASSWORD: \"{{ item.password }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_cabf51a8","line":5,"in_reply_to":"9fb8cfa7_ea7c9521","updated":"2019-06-20 17:03:31.000000000","message":"where\u0027s the fun in that.","commit_id":"6272bf12b942db4b0faed0d0e42ef48cf72e7c02"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"303bc840e97ec7668ba7a7b857a8f51007dcfcb0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    DOCKER_USER: \"{{ item.username }}\""},{"line_number":8,"context_line":"    DOCKER_PASSWORD: \"{{ item.password }}\""},{"line_number":9,"context_line":"    DOCKER_REGISTRY: \"{{ item.registry }}\""},{"line_number":10,"context_line":"  loop: container_registry_logins"},{"line_number":11,"context_line":"  when: container_registry_logins | list | length \u003e 0"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_6a898524","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":33},"updated":"2019-06-20 16:59:10.000000000","message":"I think this needs to be quoted \n\n  \"{{ container_registry_logins }}\"","commit_id":"6272bf12b942db4b0faed0d0e42ef48cf72e7c02"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"94b39a49e15376498eb9d6e66ac1745b11c74163","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# tasks file for ansible-role-container-registry"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: perform docker login"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  docker_login:"},{"line_number":6,"context_line":"    username: \"{{ lookup(\u0027dict\u0027, item.value).key }}\""},{"line_number":7,"context_line":"    password: \"{{ lookup(\u0027dict\u0027, item.value).value }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_d4284b98","line":4,"updated":"2019-06-21 07:57:11.000000000","message":"I would add no_log: true. Password is generally not shown by the module, but in certain error coniditions, it can be (e.g. a syntax error in the paramaters)","commit_id":"9bf5868d028638e4b265a740e272eb9fedc12489"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"94b39a49e15376498eb9d6e66ac1745b11c74163","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  docker_login:"},{"line_number":6,"context_line":"    username: \"{{ lookup(\u0027dict\u0027, item.value).key }}\""},{"line_number":7,"context_line":"    password: \"{{ lookup(\u0027dict\u0027, item.value).value }}\""},{"line_number":8,"context_line":"    registry: \"{{ item.key }}\""},{"line_number":9,"context_line":"  loop: \"{{ lookup(\u0027dict\u0027, container_registry_logins) }}\""},{"line_number":10,"context_line":"  when: container_registry_logins | length \u003e 0"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_74195f86","line":8,"updated":"2019-06-21 07:57:11.000000000","message":"For dockerhub, the email parameter is mandatory, not specifying the email will return an error, and no login.","commit_id":"9bf5868d028638e4b265a740e272eb9fedc12489"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"f1ffe6877d87c1ce451ee50ece3a198cbb3ac48c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  docker_login:"},{"line_number":6,"context_line":"    username: \"{{ lookup(\u0027dict\u0027, item.value).key }}\""},{"line_number":7,"context_line":"    password: \"{{ lookup(\u0027dict\u0027, item.value).value }}\""},{"line_number":8,"context_line":"    registry: \"{{ item.key }}\""},{"line_number":9,"context_line":"  loop: \"{{ lookup(\u0027dict\u0027, container_registry_logins) }}\""},{"line_number":10,"context_line":"  when: container_registry_logins | length \u003e 0"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_1fd4b7bc","line":8,"updated":"2019-06-21 14:38:02.000000000","message":"No, I mean if you test the actual module docker_login, trying to authenticate to dockerhub using only username and password, it will return an error saying it requires the email, even if the credentials are correct. This is probably an additional option in the dockerhub registry enforced in the API. Docker_login ansible module uses python-docker library which interacts directly using REST with the docker deamon API for everything, including authentication. the POST /auth method includes in the request body the email parameters, and if not sent, dockerhub complains. In our tripleo repositories in dockerhub username and email are completely different.","commit_id":"9bf5868d028638e4b265a740e272eb9fedc12489"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"ebfd78afcd2ef7d9e4a2854f9a35f080ef5deb35","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  docker_login:"},{"line_number":6,"context_line":"    username: \"{{ lookup(\u0027dict\u0027, item.value).key }}\""},{"line_number":7,"context_line":"    password: \"{{ lookup(\u0027dict\u0027, item.value).value }}\""},{"line_number":8,"context_line":"    registry: \"{{ item.key }}\""},{"line_number":9,"context_line":"  loop: \"{{ lookup(\u0027dict\u0027, container_registry_logins) }}\""},{"line_number":10,"context_line":"  when: container_registry_logins | length \u003e 0"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_3aff4902","line":8,"updated":"2019-06-21 14:51:36.000000000","message":"Oddly enough, whatever value of email parameter you pass, as long it\u0027s a valid email, will be accepted, and included in the auth config file. But this may have other side effects when the token is being used.","commit_id":"9bf5868d028638e4b265a740e272eb9fedc12489"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d159b007a63c57e244a921898bc65782d60c685d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  docker_login:"},{"line_number":6,"context_line":"    username: \"{{ lookup(\u0027dict\u0027, item.value).key }}\""},{"line_number":7,"context_line":"    password: \"{{ lookup(\u0027dict\u0027, item.value).value }}\""},{"line_number":8,"context_line":"    registry: \"{{ item.key }}\""},{"line_number":9,"context_line":"  loop: \"{{ lookup(\u0027dict\u0027, container_registry_logins) }}\""},{"line_number":10,"context_line":"  when: container_registry_logins | length \u003e 0"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_5a08fdd7","line":8,"in_reply_to":"9fb8cfa7_3aff4902","updated":"2019-06-21 15:11:20.000000000","message":"Honestly I don\u0027t think we can handle that at the moment given the structure of the container registry credentials in THT.  I wanted to do something that would allow like .username and .email but we already had something in place.  I really don\u0027t want to make this more complicated at the moment as i\u0027m just trying to handle the existing username/password config","commit_id":"9bf5868d028638e4b265a740e272eb9fedc12489"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bea3a3745d57d2654917607c33760af5cbcfa163","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  docker_login:"},{"line_number":6,"context_line":"    username: \"{{ lookup(\u0027dict\u0027, item.value).key }}\""},{"line_number":7,"context_line":"    password: \"{{ lookup(\u0027dict\u0027, item.value).value }}\""},{"line_number":8,"context_line":"    registry: \"{{ item.key }}\""},{"line_number":9,"context_line":"  loop: \"{{ lookup(\u0027dict\u0027, container_registry_logins) }}\""},{"line_number":10,"context_line":"  when: container_registry_logins | length \u003e 0"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_f4e6aae8","line":8,"in_reply_to":"9fb8cfa7_74195f86","updated":"2019-06-21 13:32:24.000000000","message":"Are we assuming username \u003d\u003d email always?  otherwise we don\u0027t actually have a way of differentiating it with the current credentials structure","commit_id":"9bf5868d028638e4b265a740e272eb9fedc12489"}]}