)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"76eac1a6c41900d84856a2e3d1bba7c8c77238a3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable docker iptables support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes: https://bugs.launchpad.net/tripleo/+bug/1845166/"},{"line_number":10,"context_line":"Change-Id: Ib8a28d84d7363f060170c134ea291e84c3231357"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_964e5836","line":9,"updated":"2019-10-24 07:18:16.000000000","message":"The correct syntax is:\nCloses-Bug: #1845166","commit_id":"230373ece3820e93d4a9d3e22586c77bed2c6c14"}],"defaults/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7e5e3f5c6f6554641d12d8a3c77edd1d3c3ac6ac","unresolved":false,"context_lines":[{"line_number":5,"context_line":"container_registry_deploy_docker_distribution: true"},{"line_number":6,"context_line":"container_registry_deployment_user: centos"},{"line_number":7,"context_line":"container_registry_docker_options: \u0027--log-driver\u003djournald --signature-verification\u003dfalse --iptables\u003dfalse --live-restore\u0027"},{"line_number":8,"context_line":"container_registry_docker_disable_iptables: false"},{"line_number":9,"context_line":"container_registry_insecure_registries: []"},{"line_number":10,"context_line":"container_registry_network_options: \u0027\u0027"},{"line_number":11,"context_line":"container_registry_host: localhost"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_2f4c1775","line":8,"updated":"2019-10-04 06:59:36.000000000","message":"where will we set it to true then ... needs to go into all the jobs ? (why not default true)","commit_id":"230373ece3820e93d4a9d3e22586c77bed2c6c14"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"9c1f7ea8ed553a05ea56fc5b0b26ccdb1543ab8d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"container_registry_deploy_docker_distribution: true"},{"line_number":6,"context_line":"container_registry_deployment_user: centos"},{"line_number":7,"context_line":"container_registry_docker_options: \u0027--log-driver\u003djournald --signature-verification\u003dfalse --iptables\u003dfalse --live-restore\u0027"},{"line_number":8,"context_line":"container_registry_docker_disable_iptables: false"},{"line_number":9,"context_line":"container_registry_insecure_registries: []"},{"line_number":10,"context_line":"container_registry_network_options: \u0027\u0027"},{"line_number":11,"context_line":"container_registry_host: localhost"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_cff54385","line":8,"in_reply_to":"3fa7e38b_2f4c1775","updated":"2019-10-04 07:54:15.000000000","message":"We need this only for queens because there we use it differently. This also keeps behavior backwards compatible.","commit_id":"230373ece3820e93d4a9d3e22586c77bed2c6c14"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"36d8660e33c05f6a33a5b7de0f9b8beba8e12bec","unresolved":false,"context_lines":[{"line_number":5,"context_line":"container_registry_deploy_docker_distribution: true"},{"line_number":6,"context_line":"container_registry_deployment_user: centos"},{"line_number":7,"context_line":"container_registry_docker_options: \u0027--log-driver\u003djournald --signature-verification\u003dfalse --iptables\u003dfalse --live-restore\u0027"},{"line_number":8,"context_line":"container_registry_docker_disable_iptables: false"},{"line_number":9,"context_line":"container_registry_insecure_registries: []"},{"line_number":10,"context_line":"container_registry_network_options: \u0027\u0027"},{"line_number":11,"context_line":"container_registry_host: localhost"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_9075f5ce","line":8,"in_reply_to":"3fa7e38b_cff54385","updated":"2019-10-24 13:59:07.000000000","message":"The issue was that CI uses this for queens (the deployment used puppet)","commit_id":"230373ece3820e93d4a9d3e22586c77bed2c6c14"}],"tasks/install-engine.yml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"44acf12cd07955a5a4a21b49ebcb91f278871272","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  block:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    - name: Disable docker iptables for https://bugs.launchpad.net/tripleo/+bug/1845166/"},{"line_number":10,"context_line":"      ini_file:"},{"line_number":11,"context_line":"        path: /etc/sysconfig/docker-network"},{"line_number":12,"context_line":"        section: null"},{"line_number":13,"context_line":"        option: DOCKER_NETWORK_OPTIONS"},{"line_number":14,"context_line":"        value: --iptables\u003dfalse"},{"line_number":15,"context_line":"        no_extra_spaces: true"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - name: Install Docker"},{"line_number":18,"context_line":"      package:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_d0f18297","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":29},"updated":"2019-10-02 14:24:16.000000000","message":"This likely should come after the installation of the docker package but before the start of the service","commit_id":"55be42a9ed83faa212eb61e100ddcc18813ef7da"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1133d83105a0c9f703d124e6f704eca196ec8908","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  block:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    - name: Disable docker iptables for https://bugs.launchpad.net/tripleo/+bug/1845166/"},{"line_number":10,"context_line":"      ini_file:"},{"line_number":11,"context_line":"        path: /etc/sysconfig/docker-network"},{"line_number":12,"context_line":"        section: null"},{"line_number":13,"context_line":"        option: DOCKER_NETWORK_OPTIONS"},{"line_number":14,"context_line":"        value: --iptables\u003dfalse"},{"line_number":15,"context_line":"        no_extra_spaces: true"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - name: Install Docker"},{"line_number":18,"context_line":"      package:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_4b3f2787","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":29},"in_reply_to":"3fa7e38b_30681620","updated":"2019-10-02 14:50:35.000000000","message":"centos is historically not one of those distributions. Additionally if you create the file before installing, then the rpm won\u0027t output the defaults.  If we\u0027re going to support multiple distros this needs to be wrapped in a redhat check as well.","commit_id":"55be42a9ed83faa212eb61e100ddcc18813ef7da"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"da24e4579ca97326ab314492f70247a243b52419","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  block:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    - name: Disable docker iptables for https://bugs.launchpad.net/tripleo/+bug/1845166/"},{"line_number":10,"context_line":"      ini_file:"},{"line_number":11,"context_line":"        path: /etc/sysconfig/docker-network"},{"line_number":12,"context_line":"        section: null"},{"line_number":13,"context_line":"        option: DOCKER_NETWORK_OPTIONS"},{"line_number":14,"context_line":"        value: --iptables\u003dfalse"},{"line_number":15,"context_line":"        no_extra_spaces: true"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - name: Install Docker"},{"line_number":18,"context_line":"      package:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_30681620","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":29},"in_reply_to":"3fa7e38b_d0f18297","updated":"2019-10-02 14:27:40.000000000","message":"If I remember well, some distributions do start the service right away *on install*, not sure but i got the impression that this is default behavior even with docker-ce only the old docker engine did not start right away.\n\nI am inclined to believe doing it before is safer, especially as we ask for \"started\" and not \"restarted\".","commit_id":"55be42a9ed83faa212eb61e100ddcc18813ef7da"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"db5eb40f9eedf112fb4db73ea1c43e820c035bae","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      register: container_registry_docker_install"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    - name: Disable docker iptables for https://bugs.launchpad.net/tripleo/+bug/1845166/"},{"line_number":16,"context_line":"      ini_file:"},{"line_number":17,"context_line":"        path: /etc/sysconfig/docker-network"},{"line_number":18,"context_line":"        section: null"},{"line_number":19,"context_line":"        option: DOCKER_NETWORK_OPTIONS"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_dced118c","line":16,"updated":"2019-10-03 07:01:21.000000000","message":"will you also add a when: per mwhahaha comment - this is rhel/centos specific?","commit_id":"a850729a542116c54548451b93ad34e8980afe80"}]}