)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"bbf401ff6f80aa3ffb9f25182b52d594d10ad45c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e2a8b51e_a54f3d6a","updated":"2025-06-26 13:02:19.000000000","message":"LGTM","commit_id":"9b94a7ab37bf2ed78466204b5158e4ce0ebe0037"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"5344f41fb57203019671c450d5523389c64f058a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3103a3a0_e03d7ebd","updated":"2025-06-30 16:57:31.000000000","message":"`pki_default_backend` is not a great name, because it suggests that it has the value of the default backend, particularly as it is defined in defaults/. But actually it is the value of whatever the user has overidden it to, or the default.\n\nI\u0027m not sure that I see either where this can be overridden per certificate, as suggested by the commit message?","commit_id":"9b94a7ab37bf2ed78466204b5158e4ce0ebe0037"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2d5a60a77054c6572274a1aeb6bc20838f0193fb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"207b822a_b9b63b77","in_reply_to":"224a0176_82bb21be","updated":"2025-07-03 09:49:27.000000000","message":"The possibility to override per cert comes in the next patch in a tree. So given that context - I personally don\u0027t mind renaming it.\n\nI don\u0027t see it as required thing to do either though, as it;s kinda only about `method` vs `backend` which is a really subtle difference, but still.","commit_id":"9b94a7ab37bf2ed78466204b5158e4ce0ebe0037"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"5f7405c181466892fd590795122982fc1cd32631","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"224a0176_82bb21be","in_reply_to":"3103a3a0_e03d7ebd","updated":"2025-06-30 17:40:38.000000000","message":"My intention was to define a variable containing a default backend for all certificates unless `backend` parameter is explicitly defined for a specific certificate.\n\nThis change should explain how it works: https://review.opendev.org/c/openstack/ansible-role-pki/+/948878/3/tasks/main_certs.yml\n\n\n```\n- name: Sign server certificates\n  ansible.builtin.include_tasks: \"{{ cert.backend | default(pki_default_backend) }}/sign_cert.yml\"\n  loop: \"{{ _pki_certificates_defs }}\"\n  loop_control:\n    loop_var: cert\n    label: \"{{ cert.name }}\"\n  when:\n    - pki_create_certificates | default(true)\n```\n\nThat\u0027s why I thought `pki_default_backend` would be appropriate. It defines the default PKI backend for all certificates, unless a specific certificate overrides it.","commit_id":"9b94a7ab37bf2ed78466204b5158e4ce0ebe0037"}]}