)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"26978e0b80c56a9eaf4133bbc0dad349864ba354","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99900abc_1ad4e747","updated":"2025-08-26 15:58:31.000000000","message":"This is a bug fix without adding test coverage - i expect we don\u0027t have enough test cases covering ownca and selfsigned separately at the moment","commit_id":"c8de8c06f203bc206e2f59fbd40ba78c70b4ded7"}],"tasks/standalone/create_cert.yml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5dc1d8992893b79f41fe0620541cf9bfa937fa0c","unresolved":true,"context_lines":[{"line_number":81,"context_line":"        dest: \"{{ cert_dir ~ \u0027/certs/\u0027 ~ cert.name ~ \u0027.info\u0027 }}\""},{"line_number":82,"context_line":"      when: cert_crt is changed"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    - name: Check if _ca_bundle_file exists"},{"line_number":85,"context_line":"      ansible.builtin.stat:"},{"line_number":86,"context_line":"        path: \"{{ _ca_bundle_file }}\""},{"line_number":87,"context_line":"      register: ca_bundle_stat"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    - name: Create certificate ca bundle for {{ cert.name }}"},{"line_number":90,"context_line":"      ansible.builtin.copy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"41a0cbeb_cbda6205","line":87,"range":{"start_line":84,"start_character":0,"end_line":87,"end_character":30},"updated":"2025-08-26 15:51:59.000000000","message":"just as a thought - maybe we should just always produce `_ca_bundle_file` when creating root?","commit_id":"c8de8c06f203bc206e2f59fbd40ba78c70b4ded7"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"26978e0b80c56a9eaf4133bbc0dad349864ba354","unresolved":true,"context_lines":[{"line_number":81,"context_line":"        dest: \"{{ cert_dir ~ \u0027/certs/\u0027 ~ cert.name ~ \u0027.info\u0027 }}\""},{"line_number":82,"context_line":"      when: cert_crt is changed"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    - name: Check if _ca_bundle_file exists"},{"line_number":85,"context_line":"      ansible.builtin.stat:"},{"line_number":86,"context_line":"        path: \"{{ _ca_bundle_file }}\""},{"line_number":87,"context_line":"      register: ca_bundle_stat"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    - name: Create certificate ca bundle for {{ cert.name }}"},{"line_number":90,"context_line":"      ansible.builtin.copy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f9439e86_fce91ad6","line":87,"range":{"start_line":84,"start_character":0,"end_line":87,"end_character":30},"in_reply_to":"41a0cbeb_cbda6205","updated":"2025-08-26 15:58:31.000000000","message":"This does make the code more complex to understand in the future why this task exists - its not very obvious.\n\nIf there is another solution that is more readable, like creating the required file up front with the CA under some condition, then that would be good","commit_id":"c8de8c06f203bc206e2f59fbd40ba78c70b4ded7"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d97ae497e741889fa0c7fcab6e7978ed3edc62e4","unresolved":true,"context_lines":[{"line_number":81,"context_line":"        dest: \"{{ cert_dir ~ \u0027/certs/\u0027 ~ cert.name ~ \u0027.info\u0027 }}\""},{"line_number":82,"context_line":"      when: cert_crt is changed"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    - name: Check if _ca_bundle_file exists"},{"line_number":85,"context_line":"      ansible.builtin.stat:"},{"line_number":86,"context_line":"        path: \"{{ _ca_bundle_file }}\""},{"line_number":87,"context_line":"      register: ca_bundle_stat"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    - name: Create certificate ca bundle for {{ cert.name }}"},{"line_number":90,"context_line":"      ansible.builtin.copy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"302363d9_fffd777f","line":87,"range":{"start_line":84,"start_character":0,"end_line":87,"end_character":30},"in_reply_to":"f9439e86_fce91ad6","updated":"2025-08-26 16:14:29.000000000","message":"Eventually when we\u0027re creating CA we know provider there as well, so likely should be able to have some logic around.","commit_id":"c8de8c06f203bc206e2f59fbd40ba78c70b4ded7"}]}