)]}'
{"defaults/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"bc1465081e2142b94c6b47b94d56afc37ee14bfc","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Distribution packages which must be installed"},{"line_number":29,"context_line":"# on all hosts when building python wheels."},{"line_number":30,"context_line":"venv_build_base_distro_package_list: \"{{ _venv_build_base_distro_package_list[ansible_os_family] }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Distribution packages which must be installed"},{"line_number":33,"context_line":"# on the host for the purpose of building the"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_7ec8d74b","line":30,"range":{"start_line":30,"start_character":78,"end_line":30,"end_character":95},"updated":"2018-10-26 15:02:54.000000000","message":"I think we should normalize this by using the `lower` filter. While it\u0027s not happened in quite some time, ansible and distros have changed system level variables that modify facts. By normalizing the data we\u0027re guarding ourselves from these types of issues.","commit_id":"c1b5ae2959e6b63dd50e68901f3cd9a4a227d62d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"979e6b2fcf4e9137caa27c22953d11da4c2d3c49","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Distribution packages which must be installed"},{"line_number":29,"context_line":"# on all hosts when building python wheels."},{"line_number":30,"context_line":"venv_build_base_distro_package_list: \"{{ _venv_build_base_distro_package_list[ansible_os_family] }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Distribution packages which must be installed"},{"line_number":33,"context_line":"# on the host for the purpose of building the"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_5e85dbac","line":30,"range":{"start_line":30,"start_character":78,"end_line":30,"end_character":95},"in_reply_to":"3f79a3b5_7ec8d74b","updated":"2018-10-26 15:25:38.000000000","message":"Good suggestion. Done.","commit_id":"c1b5ae2959e6b63dd50e68901f3cd9a4a227d62d"}],"tasks/python_venv_install.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"bc1465081e2142b94c6b47b94d56afc37ee14bfc","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Install distro packages for venv build"},{"line_number":22,"context_line":"  package:"},{"line_number":23,"context_line":"    name: \"{{ (venv_build_host !\u003d inventory_hostname) | ternary(venv_install_distro_package_list, venv_build_base_distro_package_list + venv_build_distro_package_list + venv_install_distro_package_list) }}\""},{"line_number":24,"context_line":"    state: \"{{ venv_distro_package_state }}\""},{"line_number":25,"context_line":"    update_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027]) | ternary(\u0027yes\u0027, omit) }}\""},{"line_number":26,"context_line":"    cache_valid_time: \"{{ (ansible_pkg_mgr \u003d\u003d \u0027apt\u0027) | ternary(venv_distro_cache_valid_time, omit) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_9e913348","line":23,"updated":"2018-10-26 15:02:54.000000000","message":"It\u0027s a nit but instead of concatenating the lists, which may contain duplicate packages, I\u0027d prefer we use the union filter. The union filter results in a unique set.","commit_id":"c1b5ae2959e6b63dd50e68901f3cd9a4a227d62d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"979e6b2fcf4e9137caa27c22953d11da4c2d3c49","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Install distro packages for venv build"},{"line_number":22,"context_line":"  package:"},{"line_number":23,"context_line":"    name: \"{{ (venv_build_host !\u003d inventory_hostname) | ternary(venv_install_distro_package_list, venv_build_base_distro_package_list + venv_build_distro_package_list + venv_install_distro_package_list) }}\""},{"line_number":24,"context_line":"    state: \"{{ venv_distro_package_state }}\""},{"line_number":25,"context_line":"    update_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027]) | ternary(\u0027yes\u0027, omit) }}\""},{"line_number":26,"context_line":"    cache_valid_time: \"{{ (ansible_pkg_mgr \u003d\u003d \u0027apt\u0027) | ternary(venv_distro_cache_valid_time, omit) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_a13972a2","line":23,"in_reply_to":"3f79a3b5_9e913348","updated":"2018-10-26 15:25:38.000000000","message":"Heh, I hadn\u0027t realised that list1 + list2 may contain duplicates. Great feedback, will implement something for that too!","commit_id":"c1b5ae2959e6b63dd50e68901f3cd9a4a227d62d"}],"tasks/python_venv_wheel_build.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"bc1465081e2142b94c6b47b94d56afc37ee14bfc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  block:"},{"line_number":22,"context_line":"    - name: Install distro packages for wheel build"},{"line_number":23,"context_line":"      package:"},{"line_number":24,"context_line":"        name: \"{{ venv_build_base_distro_package_list + venv_build_distro_package_list }}\""},{"line_number":25,"context_line":"        state: \"{{ venv_distro_package_state }}\""},{"line_number":26,"context_line":"        update_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027]) | ternary(\u0027yes\u0027, omit) }}\""},{"line_number":27,"context_line":"        cache_valid_time: \"{{ (ansible_pkg_mgr \u003d\u003d \u0027apt\u0027) | ternary(venv_distro_cache_valid_time, omit) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_be30af55","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":85},"updated":"2018-10-26 15:02:54.000000000","message":"I\u0027d prefer this uses the union filter to guard against having the same package listed more than once. For some package managers naming the same package twice may just be a cosmetic mistake while in others it may introduce breakage.","commit_id":"c1b5ae2959e6b63dd50e68901f3cd9a4a227d62d"}],"vars/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"bc1465081e2142b94c6b47b94d56afc37ee14bfc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"_venv_build_base_distro_package_list:"},{"line_number":17,"context_line":"  Debian:"},{"line_number":18,"context_line":"    - cmake"},{"line_number":19,"context_line":"    - gcc"},{"line_number":20,"context_line":"    - \"{{ (venv_python_executable \u003d\u003d python2) | ternary(\u0027pkg-config\u0027, \u0027python3-pkgconfig\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_7e369751","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":8},"updated":"2018-10-26 15:02:54.000000000","message":"see comment on normalizing data.","commit_id":"c1b5ae2959e6b63dd50e68901f3cd9a4a227d62d"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"b63ddd1284315aa03ac679a56efd9aa84435715a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  Debian:"},{"line_number":18,"context_line":"    - cmake"},{"line_number":19,"context_line":"    - gcc"},{"line_number":20,"context_line":"    - \"{{ (venv_python_executable \u003d\u003d python2) | ternary(\u0027pkg-config\u0027, \u0027python3-pkgconfig\u0027) }}\""},{"line_number":21,"context_line":"    - \"{{ (venv_python_executable \u003d\u003d python2) | ternary(\u0027python-dev\u0027, \u0027python3-dev\u0027) }}\""},{"line_number":22,"context_line":"  RedHat:"},{"line_number":23,"context_line":"    - autoconf"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_a1c41295","line":20,"range":{"start_line":20,"start_character":57,"end_line":20,"end_character":67},"updated":"2018-10-26 15:23:10.000000000","message":"watch out for pkg-config vs. pkgconf too (see https://packages.ubuntu.com/bionic/pkgconf) systemd-python building uses pkgconf which i didn\u0027t know existed.","commit_id":"c1b5ae2959e6b63dd50e68901f3cd9a4a227d62d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"979e6b2fcf4e9137caa27c22953d11da4c2d3c49","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  Debian:"},{"line_number":18,"context_line":"    - cmake"},{"line_number":19,"context_line":"    - gcc"},{"line_number":20,"context_line":"    - \"{{ (venv_python_executable \u003d\u003d python2) | ternary(\u0027pkg-config\u0027, \u0027python3-pkgconfig\u0027) }}\""},{"line_number":21,"context_line":"    - \"{{ (venv_python_executable \u003d\u003d python2) | ternary(\u0027python-dev\u0027, \u0027python3-dev\u0027) }}\""},{"line_number":22,"context_line":"  RedHat:"},{"line_number":23,"context_line":"    - autoconf"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_41617ea1","line":20,"range":{"start_line":20,"start_character":57,"end_line":20,"end_character":67},"in_reply_to":"3f79a3b5_a1c41295","updated":"2018-10-26 15:25:38.000000000","message":"I\u0027m a bit torn about adding wheel-specific packages to this list - but I guess it\u0027s going to become inevitable that it happens. I would rather have those in the roles, even if they are duplicated all over the place - because package requirements change, and they likely will too.","commit_id":"c1b5ae2959e6b63dd50e68901f3cd9a4a227d62d"}]}